upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
86905 commits 985 branches 1211 tags 9.7 GiB
Commit graph

6383 commits

Author SHA1 Message Date
Stephan Orbaugh
8ce133e89f
Merge pull request #60565 from nextcloud/backport/60546/stable33 
[stable33] fix: handle NAT64 addresses in isLocalAddress
 2026-05-20 16:13:45 +02:00
Anna
9c5a5e7245
Merge pull request #60595 from nextcloud/backport/60286/stable33 
[stable33] fix(AppStore/Fetcher): catch GenericFileException when reading cache file in Fetcher
 2026-05-20 12:37:57 +02:00
Benjamin Gaussorgues
eeb9f931e3
Merge pull request #60345 from nextcloud/backport/59753/stable33 
[stable33] perf(share): Remove useless order by id
 2026-05-20 10:19:07 +02:00
Anna Larch
b723c94246 fix(appstore): address review comments on GenericFileException handling 
- Attempt delete before logging the warning, so the warning only fires
  when we know recovery will succeed
- Log an error (not silently return) when delete itself fails
- Use catch (\Exception) without variable (PHP 8)
- Replace willReturnArgument(1) with explicit willReturn(true) in test
- Add blank lines between logical blocks in test for readability

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-20 10:00:39 +02:00
Anna Larch
52ca11addd fix(appstore): catch GenericFileException when reading cache file in Fetcher 
When the appstore cache file exists but getContent() throws a
GenericFileException (I/O error or OS-level permission failure), explicitly
delete the file and recreate it before writing fresh data — mirroring the
NotFoundException recovery path. If deletion itself fails, return [] cleanly.

Previously, the unhandled exception caused the entire apps settings page to
crash. The new test covers both the recovery path and deletion failure.

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-20 10:00:39 +02:00
Robin Appelman
3059cb4a30 fix: handle NAT64 addresses in isLocalAddress 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-05-19 15:37:36 +00:00
John Molakvoæ
5397f147ff
Merge pull request #60322 from nextcloud/backport/60195/stable33
Some checks failed
CodeQL Advanced / Analyze (actions) (push) Waiting to run
Details
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Details
Integration sqlite / changes (push) Waiting to run
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, --tags ~@large files_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, capabilities_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, collaboration_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, comments_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, dav_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, federation_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, file_conversions) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, files_reminders) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, filesdrop_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, ldap_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, openldap_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, openldap_numerical_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, remoteapi_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, routing_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, setup_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, sharees_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, sharing_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, theming_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, videoverification_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Details
Psalm static code analysis / static-code-analysis (push) Has been cancelled
Details
Psalm static code analysis / static-code-analysis-security (push) Has been cancelled
Details
Psalm static code analysis / static-code-analysis-ocp (push) Has been cancelled
Details
Psalm static code analysis / static-code-analysis-ncu (push) Has been cancelled
Details 
[stable33] fix(s3): Add Content-MD5 header for DeleteObjects to fix AWS SDK v3.339.0+ compatibility
 2026-05-15 16:26:17 +02:00
Robin Appelman
cfd63b8e41 test: adjust tests to unsorted folder listing 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-05-13 14:49:34 +00:00
Robin Appelman
d098916b95 test: adjust tests to unsorted share listing 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-05-13 10:22:12 +00:00
Benjamin Gaussorgues
822d1bbf67
Merge pull request #60328 from nextcloud/backport/60317/stable33 
[stable33] fix(snowflake): fix wrong documentation about serverId
 2026-05-13 09:04:10 +02:00
Benjamin Gaussorgues
b826809256
fix(snowflake): fix wrong documentation about serverId 
Maximum value of a server ID is 511 (9 bits) and not 1023.
Also adjust SetupCheck

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2026-05-12 14:25:04 +02:00
John Molakvoæ (skjnldsv)
22cba0f06a fix(s3): add Content-MD5 header for DeleteObjects to fix AWS SDK v3.339.0+ compatibility 
AWS SDK PHP v3.339.0+ introduced a breaking change requiring the Content-MD5
header for DeleteObjects operations. This causes 'MissingContentMD5' errors when
using S3-compatible services like MinIO.

Add middleware to automatically calculate and inject the Content-MD5 header on
all DeleteObjects requests. This is applied universally at the S3ConnectionTrait
level, fixing both external storage (AmazonS3) and core ObjectStore (S3) classes.

Fixes: https://github.com/aws/aws-sdk-php/issues/3068
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2026-05-12 09:36:38 +00:00
ernolf
78cb8c3de5
style(http-client): use explicit bitmask comparison for CURL_VERSION_BROTLI 
Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
 2026-05-12 11:18:13 +02:00
ernolf
35dd600e47 fix(http-client): detect brotli support via libcurl, not PHP extension 
- Fixes a regression introduced in #55433.

Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
 2026-05-11 18:34:20 +00:00
Robin Appelman
23547109f1
fix: only update share for the user who moved the share 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-04-28 15:49:41 +02:00
Louis
48e3e15c9f
Revert "[stable33] Revert "Stable33 authoritative share"" 
Signed-off-by: Louis <louis@chmn.me>
 2026-04-28 15:49:33 +02:00
Christoph Wurst
4783cc87b2 fix(dav): unify content disposition header escaping 
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
 2026-04-22 15:37:24 +00:00
Benjamin Gaussorgues
ef5757ee11
Merge pull request #59234 from nextcloud/fix/noid/backport-58229-stable33-recreate
Some checks are pending
CodeQL Advanced / Analyze (actions) (push) Waiting to run
Details
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Details
Integration sqlite / changes (push) Waiting to run
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, --tags ~@large files_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, capabilities_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, collaboration_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, comments_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, dav_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, federation_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, file_conversions) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, files_reminders) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, filesdrop_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, ldap_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, openldap_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, openldap_numerical_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, remoteapi_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, routing_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, setup_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, sharees_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, sharing_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, theming_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, videoverification_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Details
Psalm static code analysis / static-code-analysis (push) Waiting to run
Details
Psalm static code analysis / static-code-analysis-security (push) Waiting to run
Details
Psalm static code analysis / static-code-analysis-ocp (push) Waiting to run
Details
Psalm static code analysis / static-code-analysis-ncu (push) Waiting to run
Details
2026-04-21 09:24:37 +02:00
Julien Veyssier
da1cda0b72 fix(upgrade): restore missing apps on upgrade 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
 2026-04-17 11:17:54 +00:00
Joas Schilling
9b9806707d fix(notifications): Require absolute links for support of desktop and mobile clients 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2026-04-13 15:34:11 +00:00
Joas Schilling
f71bfe554e fix(sharing): Don't give a reason when share from disabled user is no longer working 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2026-04-13 14:11:41 +00:00
Côme Chilliet
83e7ec6fa7 fix: Fix user in Tags class, do not depend upon session 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-04-07 14:43:25 +02:00
Anna Larch
69d0a0609e perf(preview): bulk process preview regeneration 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2026-04-07 12:21:48 +02:00
John Molakvoæ
cbebc8214f
Revert "[stable33] perf(preview): bulk process preview regeneration" 2026-03-26 15:41:10 +01:00
Anna
90f621bdec
Merge pull request #58796 from nextcloud/backport/58229/stable33 
[stable33] perf(preview): bulk process preview regeneration
 2026-03-26 15:12:18 +01:00
Tobias Kaminsky
1d176c03c3 Revert "[stable33] Stable33 authoritative share" 2026-03-24 16:41:26 +01:00
Benjamin Gaussorgues
e3a4a01993
Merge pull request #59057 from nextcloud/backport/58863/stable33 2026-03-20 10:51:21 +01:00
Robin Appelman
15cef14219 test: adjust tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-03-19 18:39:36 +01:00
Robin Appelman
7b3702baf7 test: add reusable mock implementation for IUserConfig 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-03-19 18:39:36 +01:00
Robin Appelman
ca87da8cd9 test: add reusable mock implementation for IAppConfig 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-03-19 18:39:36 +01:00
Robin Appelman
ffa6784bba feat: perform share mount validation on share instead of on mount 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-03-19 18:39:35 +01:00
Côme Chilliet
c75c698906
fix(tests): Adapt Middleware tests to API change 
Removed a few tests rendered obsolete by the refactoring.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-03-19 17:17:26 +01:00
Maksim Sukharev
1c5334f890 fix(bg_jobs): store job argument as a text, increase length cap from 4000 to 32000 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
 2026-03-19 11:09:49 +01:00
Andy Scherzinger
b7a6bd9fa4
Merge pull request #58831 from nextcloud/backport/58817/stable33 
[stable33] fix: add fallback to raw path info
 2026-03-19 09:41:54 +01:00
Anna Larch
9e2acf835b perf(preview): bulk process preview regeneration 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2026-03-18 18:14:31 +01:00
Joas Schilling
e305bab73f fix(comments): Correctly treat end of message as end of code block/inline 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2026-03-18 12:08:17 +01:00
Joas Schilling
e700027378
fix(comments): Don't return mentions in markdown code (by default) 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2026-03-16 16:35:21 +01:00
Joas Schilling
7e832305c9
chore: Fix SPDX header 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2026-03-16 09:10:37 +01:00
David Dreschner
2c601fee60
fix: Remove deprecated RFC7231 constant to avoid warnings on PHP 8.5 
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
 2026-03-13 11:37:55 +01:00
Carl Schwan
3220e34bcc
Merge pull request #58878 from nextcloud/backport/58855/stable33
Some checks are pending
CodeQL Advanced / Analyze (actions) (push) Waiting to run
Details
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Details
Integration sqlite / changes (push) Waiting to run
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, --tags ~@large files_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, capabilities_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, collaboration_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, comments_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, dav_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, federation_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, file_conversions) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, files_reminders) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, filesdrop_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, ldap_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, openldap_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, openldap_numerical_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, remoteapi_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, routing_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, setup_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, sharees_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, sharing_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, theming_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite (stable33, 8.4, stable33, videoverification_features) (push) Blocked by required conditions
Details
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Details
Psalm static code analysis / static-code-analysis (push) Waiting to run
Details
Psalm static code analysis / static-code-analysis-security (push) Waiting to run
Details
Psalm static code analysis / static-code-analysis-ocp (push) Waiting to run
Details
Psalm static code analysis / static-code-analysis-ncu (push) Waiting to run
Details 
[stable33] tests - Fix `Implicit conversion from float 500.5 to int loses precision` in ViewTest
 2026-03-12 15:38:31 +01:00
Josh
db6bb7594d test(ViewTest): disable Nextcloud not PHP - drop testTouchFloat() 
Our interface contract (and implementations) in IStorage are:
`public function touch(string $path, ?int $mtime = null): bool {`

This wasn't always the case but it is today, so testTouchFloat() no longer makes sense; it's not testing our code, just PHP.

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-03-11 19:08:10 +00:00
Robin Appelman
65db0acd46
fix: make objectstore copy consistent with changed local storage behavior 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-03-10 18:12:28 +01:00
Anna Larch
349120b43b fix: add fallback to raw path info 
Follow up to https://github.com/nextcloud/server/pull/56843

The raw path info method has no fallback for an empty array parameter

Signed-off-by: Anna Larch <anna@nextcloud.com>
 2026-03-10 12:50:51 +00:00
Robin Appelman
618c57619e
test: add test for updating cached mounts with multiple entries for root id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-03-05 14:26:23 +01:00
Andy Scherzinger
e3d0ead392
Merge pull request #58658 from nextcloud/backport/58057/stable33 
[stable33] perf(sharing): Avoid loading all shares from all users when unsharing
 2026-03-03 07:47:11 +01:00
Carl Schwan
94c4235151
perf: Perform share path validation early 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-03-02 16:07:24 +01:00
Josh
16ffc27537 test(Storage): avoid falsy directory/filename checks (for now) 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-03-02 13:36:55 +00:00
Josh
c4b94641c3 test(Storage): expand file / directory name tests 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-03-02 13:36:55 +00:00
Carl Schwan
c90bf858ec perf(sharing): Avoid loading all shares from all users when unsharing 
First check which users have a shares and for which providers and then
only load these shares.

Avoid doing at most 5 SQL queries for each users a share was shared with if
there are no shares.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-03-02 11:25:49 +00:00
Marcel Müller
b51a4f452b fix: Use configured loglevel even when log.condition matches is set 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2026-02-27 15:01:30 +00:00