Commit graph

315 commits

Author SHA1 Message Date
Maxence Lange
f9cf7d89c3 fix(share): use share owner to confirm reshare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-28 17:11:47 +00:00
Côme Chilliet
1fb72e8277 Remove modern PHP syntax, and apply codesniffer fixes in Share20/Manager.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-26 10:42:52 +01:00
Côme Chilliet
0ee5c61eae Use nullsafe call syntax instead of additionnal check
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-02-26 10:42:52 +01:00
Côme Chilliet
603c0d00e4 Set files_sharing:hide_disabled_user_shares to 'yes' to hide shares from disabled users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-26 10:42:52 +01:00
Arthur Schiwon
706504bce3 hide shared files located in group folder's trash bin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-30 16:13:58 +00:00
Carl Schwan
3750160d9f Allow to disable password policy enforcement for selected groups
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-05 17:05:09 +02:00
Louis Chemineau
768b41ee45 Rename setting name to reduce its length
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-28 08:40:44 +00:00
Louis Chemineau
cb66d11a40 Use email settings in DAV search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-07 11:37:26 +00:00
Louis Chemineau
77f7855892 Use share setting in DAV search
shareapi_restrict_user_enumeration_full_match_ignore_second_display_name was introduced to ignore second display name during search from the share panel. But this setting was not respected by search from the calendar application. This fix it.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-07 11:37:25 +00:00
Robin Appelman
ef5b60e4cb
fix shared mount roots not being returned from getSharesInFolder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-13 21:26:16 +02:00
Carl Schwan
d69531ac8e
Fix psalm not running
The issue was that we were using psalm/phar instead of vimeo/psalm. This
caused issue with the custom psalm plugin in buildd/psalm.

This is using the opportunity to also update the psalm version from 3.8
to 3.17 and the php-cs-fixer too.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-27 17:20:00 +01:00
Joas Schilling
fa036b2001
Move common logic to share manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 10:10:53 +01:00
JanBartels
9068fd4a21 Patch for master-branch 2021-10-18 21:41:01 +02:00
John Molakvoæ
b585cf1ea1
Merge pull request #26688 from nextcloud/enh/better-share-exceptiondebug 2021-10-13 11:40:59 +02:00
Hinrich Mahler
961f8958c0
Let users choose a share_folder 2021-09-06 16:39:11 +02:00
John Molakvoæ (skjnldsv)
18f8fabd5a Add proper message to created share not found
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-08-18 12:47:11 +00:00
szaimen
4570bb4f65 Admin Audit - Sharing: createShare - report the full path
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-22 14:20:05 +00:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 -04:00
Louis Chemineau
be42a13235 Fix share activity dispatch
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-16 10:11:54 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Morris Jobke
dc9bdd4f39
Use noreply@ as email address for share emails
Fixes #26683

Before it used the instance name, which a) doesn't make sense to randomly guess email addresses and b) could contain characters that are not allowed in email addresses like spaces.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-28 11:13:24 +02:00
Morris Jobke
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +02:00
szaimen
35d978c2fc Rename External storages to External storage
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-05-20 12:13:04 +02:00
Valdnet
e7648c2fdd
l10n: Unify spelling
Spelling unification in Nextcloud applications.
2021-05-20 09:26:38 +02:00
Valdnet
11dc65869d
l10n: Unify spelling
Spelling unification in Nextcloud applications.
2021-05-20 09:26:37 +02:00
Robin Appelman
0e6321957d
allow excluding groups from creating link shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:31 +02:00
Joas Schilling
2b8e47dcac
Correclty use plural for share exception
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:40 +02:00
Vincent Petry
af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Vincent Petry
8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
Arthur Schiwon
be3ae9a44b
gracefully handle deleteFromSelf when share is already gone
- handling race conditions

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 12:59:40 +02:00
Morris Jobke
1eb084cfd3
Merge pull request #25498 from Worteks/feat-federatedfilesharing-logging
feat(federatedfilesharing): log errors, as suggested by @maxbes
2021-03-22 21:21:53 +01:00
John Molakvoæ (skjnldsv)
15767643f2
Fix sharebymail tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +01:00
Daniel Calviño Sánchez
f99876997a
Remove duplicated query for email shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +01:00
John Molakvoæ (skjnldsv)
a100186e5e
Sharing link & mail parity
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +01:00
Roeland Jago Douma
1286848731
Merge pull request #23718 from nextcloud/already-shared-error-message
expand 'path is already shared' error message
2021-03-19 13:39:22 +01:00
Vincent Petry
a9e3d2a10f
Update user share must use correct expiration validation
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.

To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-18 17:12:28 +01:00
Vincent Petry
e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
do cachejail search filtering in sql
2021-03-15 17:45:30 +01:00
Robin Appelman
a550649708
expand 'path is already shared' error message
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 15:55:08 +01:00
Joas Schilling
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +01:00
Joas Schilling
236aa194e2
Restrict autocompletion also based on the phonebook known users
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
Robin Appelman
3da33ce3fc send share notification instead of erroring on duplicate share
when creating a share that already exists, instead of erroring, resend the notifications

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-09 19:20:37 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
Samuel
957e287b79 Merge remote-tracking branch 'upstream/master' into feat-federatedfilesharing-logging 2021-02-11 12:06:16 +01:00
Samuel
75fbc66f9b fix(sahre20): missing ILogger param instantiating Notifications
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-09 09:55:39 +01:00
Samuel
3a077a3903 revert(comment)
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 13:27:37 +01:00
Samuel
5f8dfa8e4c revert(exception): keep throwing an exception for now
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:52:59 +01:00
Samuel
59e43b4828 fix(translation): replace static error message
as suggested by @kesselb in nextcloud/server#25490

Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:06:35 +01:00
Robin Appelman
6ecf33bfe7
only use share cacheentry when available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 16:22:00 +01:00
Robin Appelman
e511a539b7
adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:55:38 +01:00
Robin Appelman
5ae0be08b4
fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:54 +01:00