Commit graph

18 commits

Author SHA1 Message Date
Jonas Meurer
50a25748c0
Respect user enumeration settings in user status lists
So far, the functions to find user statuses listed didn't respect user
enumeration settings (`shareapi_allow_share_dialog_user_enumeration`
and `shareapi_restrict_user_enumeration_to_group` core app settings).

Fix this privacy issue by returning an empty list in case
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

In the long run, we might want to return users from common groups if
`shareapi_restrict_user_enumeration_to_group` is set. It's complicated
to implement this in a way that scales, though. See the discussion at
https://github.com/nextcloud/server/pull/27879#pullrequestreview-753655308
for details.

Also, don't register the user_status dashboard widget at all if
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

Fixes: #27122

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-10-25 10:10:14 +02:00
Joas Schilling
924f58c370 Don't update statuses to offline again and again
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-07 10:17:09 +00:00
Joas Schilling
32d7459d8b Make is_user_defined nullable so we can store false on oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 20:46:55 +00:00
Simon Spannagel
9750efe5ab UserStatus: no message means clear status message. This fixes #23332
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-11-03 09:31:05 +00:00
Joas Schilling
57cfed3f3d Some emojis are in CHAR_CATEGORY_GENERAL_OTHER_TYPES
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-19 15:19:50 +00:00
Julius Härtl
7b65eecf72 Only load user status script when needed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-05 19:53:04 +00:00
Roeland Jago Douma
61a0069dd5
Merge pull request #23115 from nextcloud/backport/23108/stable20
[stable20] Reset the user status when clearing the custom message
2020-10-01 19:23:51 +02:00
Joas Schilling
d7d805ef79 Increase the timeout of statuses
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-01 09:45:46 +00:00
Joas Schilling
413a6042f3 Reset the user status when clearing the custom message
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-30 17:27:14 +00:00
Georg Ehrke
d7ccc616e4
Always use IUserStatus consts
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 11:30:18 +02:00
Georg Ehrke
2146950a71
Add MigrationStep to add better Indizes
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 11:30:18 +02:00
Georg Ehrke
5be49491d3
Do not display Offline statuses in the Dashboard widget
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 11:30:15 +02:00
Georg Ehrke
7fedd33825
Better cleanup routine for statuses
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 09:22:38 +02:00
Georg Ehrke
10df7198fe
HeartbeatController: PHPDoc fixes
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 09:22:38 +02:00
Georg Ehrke
a352a7c7f3
Introduce consts for statuses
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 09:22:34 +02:00
Georg Ehrke
bd6a6cf3bf
Add Status Dashboard
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-20 15:43:34 +02:00
Georg Ehrke
0e0e0d19e8
Provide a PHP Api for UserStatus
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-05 13:48:46 +02:00
Georg Ehrke
0fad921840
Add user-status app
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-31 16:45:27 +02:00