Commit graph

8972 commits

Author SHA1 Message Date
Roeland Jago Douma
d115e7f802 Do not keep searching for recent
If userA has a lot of recent files. But only shares 1 file with userB
(that has no files at all). We could keep searching until we run out of
recent files for userA.

Now assume the inactive userB has 20 incomming shares like that from
different users. getRecent then basically keeps consuming huge amounts
of resources and with each iteration the load on the DB increases
(because of the offset).

This makes sure we do not get more than 3 times the limit we search for
or more than 5 queries.

This means we might miss some recent entries but we should fix that
separatly. This is just to make sure the load on the DB stays sane.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-07-17 05:49:34 +00:00
Morris Jobke
e7ee8a2f48
Merge pull request #16216 from nextcloud/backport/16186/stable14
[stable14] Better check reshare permissions part2
2019-07-03 23:27:42 +02:00
Joas Schilling
35dda87384
Unify the permission checking in one place only
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-03 21:33:06 +02:00
Joas Schilling
98c09e0314
Better check reshare permissions when creating a share
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-03 21:33:02 +02:00
Roeland Jago Douma
983d757c04
Fix notification casting
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-07-03 20:35:53 +02:00
Robin Appelman
48a0065d2d verify that paths are valid for recursive local move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-06-27 14:40:13 +00:00
Joas Schilling
7b80635b82 Prevent faulty logs from nested setupFS calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-06-21 10:03:20 +00:00
Daniel Kesselberg
c34bdac5ae
Don't notify admins if no potentially over exposing links found
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-06-03 21:51:19 +02:00
Roeland Jago Douma
66f739d85f
DateTime is not yet in 14
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-05-16 16:20:49 +02:00
Joas Schilling
7b4b2c6186 fix class might be undefined
Co-Authored-By: blizzz <blizzz@arthur-schiwon.de>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-08 13:53:59 +00:00
Arthur Schiwon
c9a0fbef62 remove args from logging of common-spelled methods dependent on class
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-08 13:53:58 +00:00
Arthur Schiwon
21ee2db3be remove setup args from logging
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-08 13:53:58 +00:00
Joas Schilling
0784369790
Use the querybuilder for the queries
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-04-17 15:58:10 +02:00
Joas Schilling
a99a92b673
Allow to use Subqueries in from
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-04-17 15:57:20 +02:00
Roeland Jago Douma
23c422655d
Repair step for link shares
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-17 15:57:16 +02:00
Roeland Jago Douma
9d8099f5f2
Do not allow invalid users to be created
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-15 09:05:52 +02:00
Vlastimil Pecinka
73dbc29f21
Store user object later in the code
Signed-off-by: Vlastimil Pecinka <pecinka@email.cz>
2019-03-26 17:40:31 +01:00
Robin Appelman
d47106cdcc always allow moving mountpoints inside the same mountpoint
even if that mountpoint isn't normally a valid target for moving mounts into

Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-03-20 10:00:03 +00:00
Morris Jobke
9ddff52753 Remove sensitive SMB arguments from exception log
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-13 13:01:48 +00:00
Morris Jobke
c9b87701d0
Merge pull request #14598 from nextcloud/backport/14425/stable14
[stable14] Do not calculate folder size for parent that also needs proper scan, fixes #3524
2019-03-08 17:32:16 +01:00
Ari Selseng
3ff6465cdc Avoid calculating folder size for parent that needs scan.
Signed-off-by: Ari Selseng <ari@selseng.net>
2019-03-08 08:14:33 +00:00
Marius Blüm
b8470f30bd Remove Google+ from Social Sharing Bundle (2)
Signed-off-by: Marius Blüm <marius@lineone.io>
2019-03-08 08:06:52 +00:00
Daniel Kesselberg
3e1f327ac9 Generate id for navigation item
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-27 15:09:36 +00:00
Daniel Kesselberg
70edd2b633 Parse multiple navigation items
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-27 15:09:36 +00:00
Joas Schilling
06769735b7 Correctly determinate the owner in case of shared external storages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-02-19 09:29:54 +00:00
Roeland Jago Douma
5b5108fe49
Merge pull request #14196 from nextcloud/backport/14185/stable14
[stable14] Fix recent files
2019-02-14 21:22:05 +01:00
Roeland Jago Douma
5330739cec
Merge pull request #14086 from nextcloud/backport/14023/stable14
[stable14] Fix: Check if `$this->params['user']` is an array
2019-02-14 19:50:01 +01:00
Roeland Jago Douma
3bc0990749 Filter out versions and trashbin
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-14 10:27:44 +00:00
Roeland Jago Douma
d97adfe4b1 Loop for the recent search
Else it might happen that less entries than requested are returned

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-14 10:27:44 +00:00
Roeland Jago Douma
7dbcddaa2c We need to initialize the storage else the jailed path is always null
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-14 10:27:44 +00:00
Roeland Jago Douma
cb0b6cedd1 Fix the thorrtler whitelist bitmask
Before we actually didn't check each bit of the bitmask. Now we do.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-12 07:56:11 +00:00
William Pain
130c094df0 Fix: Check if $this->params['user'] is an array
Signed-off-by: William Pain <pain.william@gmail.com>
2019-02-07 13:33:21 +00:00
Christoph Wurst
a7c897b445 Fix typos and unused return values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-30 19:11:16 +00:00
Bjoern Schiessle
41de36b5d8 fix typo
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2019-01-30 19:11:15 +00:00
Bjoern Schiessle
849ad5a8bb log full exception
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2019-01-30 19:11:13 +00:00
Bjoern Schiessle
2dcab24f8c handle mail send error gracefully
log the error in case a notification mail of a new share couldn't
be send to the recipient and finish the share operation successfully

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2019-01-30 19:11:12 +00:00
Roeland Jago Douma
931056e711
Clean pending 2FA authentication on password reset
When a password is reste we should make sure that all users are properly
logged in. Pending states should be cleared. For example a session where
the 2FA code is not entered yet should be cleared.

The token is now removed so the session will be killed the next time
this is checked (within 5 minutes).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-30 10:43:15 +01:00
Morris Jobke
de2c5350a9 Show proper default locale
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-01-24 07:33:03 +00:00
Morris Jobke
e5af104517
Merge pull request #13741 from nextcloud/backport/13140/stable14
[stable14] Cache tokens when using swift's v2 authentication
2019-01-23 15:30:12 +01:00
Robin Appelman
0625d2957c cleanup shared lock if changing to exclusive lock failed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-22 15:13:40 +00:00
Robin Appelman
a5c5a77322 Cache tokens when using swift's v2 authentication
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-22 14:37:13 +00:00
John Molakvoæ
4b025649c0
[stable15] Fix colorizeSvg with transformations that contain a comma (,)
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-01-17 16:02:21 +01:00
Roeland Jago Douma
50ed420440
Merge pull request #13035 from nextcloud/objectstore-write-exists-14
[14] upload new files in objectstore to a .part path first
2019-01-14 11:29:52 +01:00
Joas Schilling
96dab990e7 Don't log parameters on user creation in case of error/exception
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-10 11:37:41 +00:00
Roeland Jago Douma
df25c44a2d HttpClient getHeader can return empty string
Fixes #11999

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-08 15:26:32 +00:00
Roeland Jago Douma
17b7a4805a Throttle with correct metadata
Fixes #13202

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-04 21:22:19 +00:00
Roeland Jago Douma
ce2c08da6a
Merge pull request #12617 from nextcloud/backport/10839/stable14
[stable14] adjust Calendar resource / room interfaces to use class implementation
2018-12-22 12:15:05 +01:00
Roeland Jago Douma
73f19a7a4c Use a case insensitive search for email
Fixes #7084
Now entering wrongly cased email (roeland@ instead of Roeland@) for
password reset etc. Will also work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-20 15:19:28 +00:00
Robin Appelman
2c1ab34aca
upload new files in objectstore to a .part path first
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-12-12 15:48:29 +01:00
Robin Appelman
601f35c337
Add objectExists to objectstore interface
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-12-12 15:42:06 +01:00