upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-14 19:20:35 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
80180 commits 1033 branches 1221 tags 8.4 GiB
Commit graph

5911 commits

Author SHA1 Message Date
Ferdinand Thiessen
08d33a9f57
fix: validate account properties as a repair step 
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 15:16:27 +01:00
Johannes Endres
ae2cc23658 fix: Change UserAgent to *cloud 
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
 2025-02-19 18:51:08 +01:00
Côme Chilliet
ed9b47462f
Merge pull request #49648 from nextcloud/fix/clarify-app-manager-methods 
Clarify app manager method names
 2025-02-13 11:33:52 +01:00
Côme Chilliet
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 10:19:20 +01:00
Côme Chilliet
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 10:19:19 +01:00
Côme Chilliet
3289cbcbd3 fix: Fix UserTest to return valid configuration values 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-10 14:52:18 +01:00
John Molakvoæ
93c72f5675
Merge pull request #50660 from nextcloud/fix/mime-int 
fix: make sure we process mime extensions as string
 2025-02-06 16:13:27 +01:00
Ferdinand Thiessen
729cdf6818
fix(FediverseAction): Ensure valid fediverse links are generated 
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-06 11:58:24 +01:00
Ferdinand Thiessen
fbef47a5d7
fix(AccountManager): Sanitize social media handles 
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-06 11:58:24 +01:00
skjnldsv
6baafd82b6 fix: make sure we process mime extensions as string 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-02-05 12:35:41 +01:00
Louis Chemineau
b6c7c28585 fix: Exclude non accepted shares when computing access list 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-01-30 09:57:14 +01:00
Ferdinand Thiessen
b48ee2e924
fix: Harden files scanner for invalid null access 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 20:08:46 +01:00
Ferdinand Thiessen
0a0f56282a
fix(sharing): Move permission validation to share manager 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 16:40:50 +01:00
Andy Scherzinger
b70654aeed
Merge pull request #48581 from hammer065/fix/issue-35936 
fix: Filter for folders in cleanup old preview job
 2025-01-27 16:06:40 +01:00
Joas Schilling
c1655bcde7
fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-01-27 12:46:15 +01:00
Dario Mehlich
8c309130cf
fix(preview): Filter for folders in cleanup old preview job 
Fixes #35936.
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.

Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
 2025-01-27 10:16:08 +01:00
Ferdinand Thiessen
f33e9a96ae
Merge pull request #50273 from nextcloud/artonge/fix/metadata_field_search 
fix: Metadata field search
 2025-01-25 10:43:59 +01:00
Marcel Klehr
b0d1f2c489
Merge pull request #50331 from nextcloud/fix/perf/cache-avilable-taskt-types 
fix(taskprocessing): More caching
 2025-01-25 09:11:05 +01:00
Marcel Klehr
6f94ddc1d5 fix(taskprocessing): Fix tests 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-01-24 16:45:43 +01:00
Ferdinand Thiessen
eea91fa1ba
fix(TemplateLayout): core is not an app but the server itself 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-24 15:10:23 +01:00
Ferdinand Thiessen
31664b3edd
fix: Correctly return app id and app version for core styles and images 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-24 13:08:31 +01:00
provokateurin
dcb370ab62
Revert "fix(Share20\Manager): Ensure node is still accessible when checking share" 
This reverts commit c2ca99e2f6.

Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-24 09:41:14 +01:00
Benjamin Gaussorgues
b4e3eff078 feat(systemtags): add setting to block non admin to create system tags 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2025-01-22 20:07:24 +01:00
Josh
79ca27f6a6
test: fix periodic Test\Group\DatabaseTest::testSearchGroups failure 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2025-01-22 10:53:03 -05:00
Louis Chemineau
a635710117
fix: Metadata field search 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-01-20 14:41:55 +01:00
Ferdinand Thiessen
27ac8e0f78
Merge pull request #50214 from nextcloud/feat/show-time-diff-user 
feat(contacts): Show time difference for users in different timezones
 2025-01-20 14:39:00 +01:00
Ferdinand Thiessen
84f0fc88cc
feat(contacts): Show time difference for users in different timezones 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-16 18:10:04 +01:00
Côme Chilliet
626bc7220b
Merge pull request #50171 from nextcloud/enh/limit-ldap-user-count 
Limit ldap user count
 2025-01-16 17:25:01 +01:00
Christopher Ng
42d997bcd7 test: Update tests 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:50:43 -08:00
Côme Chilliet
db94aeb96e
chore(tests): Adapt tests to the countUsers refactor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-01-14 16:34:15 +01:00
Maxence Lange
bd4a154d64 feat(lexicon): configurable default value 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2025-01-14 10:36:07 -01:00
Robin Appelman
7b2cb2e3bc
test: update test for mountpoint numeric storage id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-13 18:09:29 +01:00
Richard Steinmetz
3dbdf3266c
feat(ocp): add calendar api to retrieve availability of attendees 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-01-13 10:12:31 +01:00
Joas Schilling
dd0f7f0bbf
Merge pull request #49888 from nextcloud/feat/ocp/meetings-api-requirements 
feat(ocp): calendar event builder api
 2025-01-08 11:48:53 +01:00
Côme Chilliet
99e0867f0a chore: Adapt tests to added constructor parameters 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-01-07 10:34:30 +01:00
Richard Steinmetz
80bc1c2d6c
feat(ocp): calendar event builder api 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-01-06 10:16:53 +01:00
Robin Appelman
16d0363937
fix: improve checks for moving shares/storages into other mounts 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-03 15:36:32 +01:00
Andy Scherzinger
a60f71bd93
Merge pull request #49727 from nextcloud/feat/make-tasks-types-toggleable 
Feat: make taskprocessing task types toggleable
 2024-12-18 20:08:28 +01:00
Jana Peper
75e64e2942 fix: egt rid of unused variable 
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
 2024-12-18 18:32:34 +01:00
Jana Peper
b1d1badcf0 test: add explicitly enabled task type unit test 
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
 2024-12-18 18:32:34 +01:00
Jana Peper
129af480ac test: add disabled task type unit test 
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
 2024-12-18 18:32:34 +01:00
Arthur Schiwon
13fefc4612
feat(Navigation): emit dedicated event for loading additional entries 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2024-12-18 12:50:11 +01:00
Maxence Lange
815991741d fix(lexicon): renaming and minor fixes 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-12-13 11:08:20 -01:00
Maxence Lange
96586ba709 feat(config): implementation of lexicon 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-12-13 11:08:20 -01:00
Côme Chilliet
365ff40929 fix(tests): Adapt ManagerTest to change in Exception class used 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-12-12 15:39:48 +01:00
Julius Knorr
cba556d641
Merge pull request #48612 from nextcloud/fix/activity-log-for-favorites-in-dav 
add activity logging for favorites in dav
 2024-12-12 15:18:47 +01:00
John Molakvoæ
3baa91d842
Merge pull request #40394 from nextcloud/updater-change-mimetype-objectstore 2024-12-11 08:40:58 +01:00
skjnldsv
adf8a454dd feat(systemtags): add color support backend 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-12-06 10:19:42 +01:00
Robin Appelman
37199779de
fix: fix mimetype not being updated when changing file extention on object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-12-05 18:05:13 +01:00
grnd-alt
8d953aeb8d refactor(tags): move favorite event dispatching to tags.php 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
 2024-12-03 20:56:36 +01:00
Louis Chemineau
425e0c3660
test(View): Copy preserves content 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-12-03 18:29:32 +01:00
Louis Chemineau
199b0bd4d9
fix(files): Correctly copy the cache information on copy operations 
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-12-03 17:04:44 +01:00
Joas Schilling
dd101dd0f7
Merge pull request #49515 from nextcloud/bugfix/noid/boolean-false-in-multipart-form-data 
fix(controller): Fix false booleans in multipart/form-data
 2024-11-28 14:46:16 +01:00
Joas Schilling
1909b981a4
fix(controller): Fix false booleans in multipart/form-data 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-11-28 12:18:30 +01:00
John Molakvoæ
379f575c25
Merge pull request #49493 from nextcloud/artonge/feat/pwd_confirmation_allow_set_period 2024-11-28 11:58:02 +01:00
Louis Chemineau
512f3caf57
test:(PasswordConfirmationMiddleware): Fix constructor call 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-11-28 11:05:10 +01:00
Christoph Wurst
1323e5bcb1
fix(migration): Decrypt ownCloud secrets v2 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-11-28 09:00:33 +01:00
provokateurin
c2ca99e2f6
fix(Share20\Manager): Ensure node is still accessible when checking share 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
provokateurin
c378e74017
feat(Share20\Manager): Return all shares on IShareOwnerlessMount 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
provokateurin
a978e0a806
fix(Share20\DefaultShareProvider): Return link shares in getSharesByPath() 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
Louis Chemineau
f9cda54cbf
fix: Wrap partial cache entry in CacheEntry 
Because it is returned here: 7b7d07c575/lib/private/Files/Cache/Cache.php (L136-L137)

And some implementation got stricter: df95bf6ba8/lib/Mount/RootEntryCache.php (L23-L28)

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-11-21 17:13:24 +01:00
Thomas Lehmann
e4c013d86d feat(Mailer): add "null" SMTP transport mode 
== Goal

Allow disabling mail delivery altogether.

== Usecase

If mails ought to be send by other means than rendering messages from
templates and sending them via SMTP-like protocols.

Example: listening to specific Nextcloud events and pass parameters to
a centralized (i.e. REST-based) API that sends e-mails.

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
 2024-11-19 11:32:39 +01:00
Thomas Lehmann
46d8a7333b feat(Mailer): implement caching 
Currently $this->instance is never set, so the code is no-op. This
brings back caching of the instance.

Caching broke with

   be7db1573d

   Swift to \Swift_Mailer as abstraction

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
 2024-11-19 11:32:39 +01:00
Maxence Lange
5b4f1904c0 feat(user-prefs): renaming to IUserConfig 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Maxence Lange
6afc8552b7 feat(user-prefs): switching to NCU/ 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Maxence Lange
7c04818c5c feat(user-prefs): iterator instead of array on search 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Maxence Lange
e73513bdd1 fix(user-prefs): adding sensitive and indexed as flags 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Maxence Lange
65e24f7def feat(user-prefs): IUserPreferences 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Côme Chilliet
0718984bdf
Merge pull request #48675 from georglauterbach/master 
DNS: do not query CNAME if A succeeded already
 2024-11-14 11:43:32 +01:00
skjnldsv
158299b3d7 fix(profile): make sure the app cannot be disabled as it was in core 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-14 10:25:10 +01:00
SebastianKrupinski
7ebeed45bd feat: add iMip Request Handling 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-11-07 21:12:37 -05:00
Robin Appelman
b21c0265df
test: add some minimal testing for metadata storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-11-07 16:27:16 +01:00
Joas Schilling
c3c8b7e2a3
fix(richobjectstrings): Add missing placeholder validation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-11-06 21:31:41 +01:00
georglauterbach
387cd8b771
fix: do not query CNAME if A succeeded already 
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
 2024-11-06 20:21:38 +01:00
John Molakvoæ
3c4290631b
Merge pull request #49039 from nextcloud/jtr/fix-ipv6-zone-ids-link-local 2024-11-06 09:17:52 +01:00
John Molakvoæ
8fab143aa4
Merge pull request #48721 from nextcloud/feat/allow-getter-setter-decl-fors 2024-11-06 08:54:40 +01:00
Daniel Calviño Sánchez
5ea5b2de84
fix: Handle exception when clearing previously removed two factor tokens 
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-11-05 11:14:05 +01:00
Daniel Calviño Sánchez
381a2aa627
fix: Clear pending two factor tokens also from configuration 
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-11-05 11:14:04 +01:00
Josh
e885e4f13d
fix(tests): Add IpAddressClassifier v6 zone ID test 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-11-04 09:31:48 -05:00
Josh
97421fb143
fix(tests): Add RemoteAddress v6 zone ID test 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-11-04 09:30:21 -05:00
Côme Chilliet
901496276b
Merge pull request #47425 from nextcloud/fix/avoid-invalid-share-on-transfer-ownership 
fix: promote re-shares when deleting the parent share
 2024-11-04 10:09:58 +01:00
Benjamin Gaussorgues
79db082fe6 fix(users): improve recently active search 
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-10-30 07:53:10 +01:00
John Molakvoæ
e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders 2024-10-29 11:33:12 +01:00
Kate
d25a0a2896
Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password 2024-10-28 13:26:55 +01:00
Ferdinand Thiessen
86006368bf
Merge pull request #48912 from nextcloud/bugfix/exception-appscreenshot-notstring 
fix(apps-store): Fix exception on generating preview url for installed app screenshot
 2024-10-28 11:32:15 +01:00
yemkareems
a74ef8237d
fix: crypto type made not nullable and tests run using ICrypto 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 15:04:11 +05:30
Kate
5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors 2024-10-28 10:19:41 +01:00
Joas Schilling
220bd3422f
fix(appinfo): Make sure screenshot, author and category are always arrays 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-28 08:46:31 +01:00
yemkareems
505dfd65fd
fix: encrypt and store password, decrypt and retrieve the same 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 11:22:36 +05:30
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 13:24:18 +02:00
Joas Schilling
54c3aa3f99
fix(entity): Fix mapping of old/sub-types to actually supported database types 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-23 09:22:05 +02:00
Ferdinand Thiessen
2ef74b9860
Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-support 
feat(AppFramework): Add full support for date / time / datetime columns
 2024-10-18 19:05:08 +02:00
Joas Schilling
882f91605b
fix(comments): Add test for email mention 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-18 07:39:41 +02:00
Ferdinand Thiessen
db94e10af0
fix: Prevent breaking change in IQueryBuilder 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-17 18:31:44 +02:00
Ferdinand Thiessen
ee02e3246d
feat(AppFramework): Add full support for date / time / datetime columns 
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.

Similar the parameter types needed to be added.

`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.

Also added more tests, especially to make sure the mapper really serializes the values correctly.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-17 18:31:42 +02:00
Ferdinand Thiessen
9a7e1bb227
feat(DeclarativeSettings): Allow to implement value getter and setter directly in Form 
Instead of implementing the form class, a setter event listener and a getter event listener,
this allows to simply write a basic class that provides `getSchema`, `setValue` and `getValue` functions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-15 20:33:45 +02:00
Ferdinand Thiessen
b964e05312
Merge pull request #48673 from nextcloud/fix/null-label 
fix(share): Return empty string if no label is set
 2024-10-14 19:10:12 +02:00
Côme Chilliet
d6ba524263
fix: Use getRelativePath method to check if node is inside folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-14 17:23:29 +02:00
Ferdinand Thiessen
980ab1f56b
fix: Shipped apps should include the Nextcloud version in the cache buster 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-14 16:04:13 +02:00
Ferdinand Thiessen
2e4d3e4e75
fix(share): Return empty string if no label is set 
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-14 15:15:51 +02:00