Commit graph

25182 commits

Author SHA1 Message Date
Ferdinand Thiessen
088e5e6e7b
fix(theming): enforce theme also for login
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 19:37:52 +02:00
Ferdinand Thiessen
e659f2ce07
Merge pull request #51870 from nextcloud/artonge/fix/use_loginname_to_check_password
fix: Use login name to check the password
2025-04-02 19:20:39 +02:00
Ferdinand Thiessen
e7859f0dac refactor: add migration for email setting
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 19:06:25 +02:00
provokateurin
eb98e99530 fix(settings): Handle email change restriction separately from display name change restriction
Co-authored-by: provokateurin <kate@provokateurin.de>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 19:06:25 +02:00
Louis Chemineau
3bff9ee3e1
fix: Use login name to check the password
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-02 15:50:05 +02:00
Robin Appelman
fc2cda12b5
fix: use proper migration sorting when checking if a migration needs to be executed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-02 14:29:08 +02:00
Ferdinand Thiessen
97ad171d32
refactor(IMimeTypeDetector): use consistent capitalization
- use consistantly `mimeType` as it is called MIME type
- fix issues where implementation and interface had different parameter
  names (this is an issue since PHP has named parameters).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 13:22:16 +02:00
Nextcloud bot
82b1b4d0c4
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-04-02 00:23:10 +00:00
Joas Schilling
d4b805c88a
Merge pull request #51800 from gavine99/deterministic-notification-manager
notification manager deterministic app call order
2025-04-01 16:52:19 +02:00
Côme Chilliet
e467ea1c6a
chore(legacy): Remove deprecated OC_Util::addScript and functions depending on it
Deprecated since 24, currently unused.
Sadly not all related functions were officially marked as deprecated,
 but all of them were unused.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-01 15:24:24 +02:00
gavine99
ed6d76ec8d
fix(notifications): Change notification app orders
The notification manager always calls notify() of the 'main' notifications app
before other notify apps, and calls other functions for other notifications apps
before the 'main' notification app

Signed-off-by: gavine99 <github@xymail.tk>
2025-04-01 12:27:24 +02:00
Richard Steinmetz
246da73a36
fix(oauth2): retain support for legacy ownCloud clients
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-01 11:25:52 +02:00
Nextcloud bot
c029616ec0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-04-01 00:23:11 +00:00
Christoph Wurst
e655ffeb43
Merge pull request #50768 from nextcloud/perf/cron/delay-timedjob-checking
perf(cron): Delay (re)checking timed jobs
2025-03-31 17:31:44 +02:00
Christoph Wurst
12e66badc4
Merge pull request #51686 from nextcloud/fix/template/implement-itemplate
fix(template): implement ITemplate directly
2025-03-31 17:11:30 +02:00
Robin Appelman
fcde776683
feat: add command to list objects
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-31 14:30:40 +02:00
Robin Appelman
c3bc362f48
feat: add command to get object metadata
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-31 14:30:40 +02:00
Robin Appelman
ccaa463b30
Merge pull request #51399 from nextcloud/share-list-cmd
add command to list shares
2025-03-31 14:29:38 +02:00
Richard Steinmetz
c50c09315a
fix(template): implement ITemplate directly
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-03-31 14:19:17 +02:00
Christoph Wurst
2395526e6c
perf(cron): Delay (re)checking timed jobs
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-03-31 13:21:29 +02:00
Côme Chilliet
d5ad9b86ef
Merge pull request #51676 from nextcloud/fix/add-getappversions-replacement
Add OC_App::getAppVersions replacement in IAppManager
2025-03-31 10:51:00 +02:00
Louis Chemineau
22e02d1c1e chore: Refactor callForSeenUsers to use getSeenUsers
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-30 08:54:41 +02:00
Louis Chemineau
275b32d513 feat: Implement getSeenUsers to iterate over users
This method uses an iterator.
This is lighter on resources and gives more control to the caller

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-30 08:54:41 +02:00
Robin Appelman
2e9222a29a
feat: add getParentId to ICacheEntry
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-28 16:47:07 +01:00
SebastianKrupinski
2de6d6b908 fix: add event status and participant status
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-03-28 03:48:48 -04:00
Nextcloud bot
dd6a0ebd48
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-28 00:23:27 +00:00
Andy Scherzinger
d2773cf992
Merge pull request #51707 from nextcloud/fix/filter-empty-email
fix: filter out contacts with empty email addresses in sharee completion
2025-03-28 00:14:07 +01:00
Nextcloud bot
f7b96ba26e
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-27 00:24:00 +00:00
Julius Knorr
0a251213a3 fix: filter out contacts with invalid email addresses in sharee completion
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-26 11:51:52 +01:00
Jana Peper
5d192150d1
fix: task type translations
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2025-03-26 10:24:24 +01:00
John Molakvoæ
d1713603c5
Merge pull request #51433 from umgfoin/PR-umgfoin-fix-image-metadata-generation
fix(GenerateBlurhashMetadata): Suppress imagescale errors
2025-03-26 10:02:11 +01:00
Benjamin Giesinger
3c8198a721
feat(mimetypes): Fixed copy paste error 2025-03-25 19:50:27 +01:00
Benjamin Giesinger
68d45006cd
feat(mimetypes): Added musicxml mimetypes 2025-03-25 19:50:06 +01:00
Côme Chilliet
c7037d7b38
fix: Move getAppInstalledVersions to AppConfig so that it can be used earlier
Call it from OC_App to make sure there is only one request to DB.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 16:20:21 +01:00
Côme Chilliet
49cf5ba318
fix: Put back OC_App::getAppVersions in Server.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 14:23:40 +01:00
Côme Chilliet
8caa1a70e9
fix: Do not try to load IAppManager too soon
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 14:23:40 +01:00
Côme Chilliet
0a027c3906
chore: Cleanup Server.php a bit and remove OC_App usage
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 14:23:40 +01:00
Côme Chilliet
4b099bd532
chore: Replace calls to OC_App::getAppVersions with app manager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 14:23:40 +01:00
Côme Chilliet
32c1e3e677 feat: Add a replacement for OC_App::getAppVersions is IAppManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 14:12:17 +01:00
John Molakvoæ
2f7e72fc50
Merge pull request #51649 from rolandinus/fix/dispatch-events-on-bulk-tagging
fix(systemtags): Dispatch events when bulk assigning system tags
2025-03-25 13:22:44 +01:00
John Molakvoæ
248d21a2b9
Merge pull request #51490 from nextcloud/castUsersCountToInt
fix(database): Cast users count to integer
2025-03-25 12:57:34 +01:00
Kate
eab608f144
Merge pull request #51669 from nextcloud/refactor/use-in-instead-of-or
perf(sharing): Use oc_share.item_type IN instead of OR equals
2025-03-25 11:52:52 +01:00
Marcel Klehr
b464469bc1 perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals
to improve performance by using the db index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-03-25 09:42:06 +01:00
Nextcloud bot
a55519268f
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-25 00:22:39 +00:00
Côme Chilliet
1ce593311b
fix: Go back to soft typing for template function p
Strong typing breaks legacy code in this case.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-24 12:53:27 +01:00
Ferdinand Thiessen
214ac4c4a3
Merge pull request #51611 from nextcloud/fix/file-name-validator-case-sensitivity
fix(IFilenameValidator): correctly handle case insensitivity
2025-03-24 12:46:33 +01:00
Nextcloud bot
91c94f19e0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-24 00:23:02 +00:00
Roland Scheidel
a842d917cf fix(systemtags): Dispatch events when bulk assigning system tags
Signed-off-by: Roland Scheidel <kontakt@scheidel.at>
2025-03-23 22:25:32 +01:00
Kate
519ceee5ab
Merge pull request #51622 from nextcloud/fix/ocm-public-key-is-optional
fix(ocm): `publicKey` can be disabled so capabilities do not match
2025-03-23 19:34:11 +01:00
Nextcloud bot
9ffcdd8cdd
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-23 00:22:47 +00:00
Ferdinand Thiessen
b9f9190894
fix(ocm): publicKey can be disabled so capabilities do not match
When the public key feature is disabled null is returned for
`publicKey`. So in this case we need to adjust the capabilities
and return type of `jsonSerialize()`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-21 09:15:55 +01:00
Nextcloud bot
3d38a4bdde
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-21 00:22:58 +00:00
Ferdinand Thiessen
254dd85664
fix(IFilenameValidator): correctly handle case insensitivity
- forbidden names and forbidden base names are case **insensitive**
  so we need to check all lowercase here.
- add test that config value is also read case insensitive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-21 01:00:58 +01:00
Git'Fellow
18de9be0e2
fix(database): Cast users count to integer
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-20 12:00:57 +01:00
Côme Chilliet
101b1f0eaf chore: cleanup human_file_size usage
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
897c2d3934 fix: Require functions in lib/public/Template.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
e9046a0f24 fix: Remove obsolete component template function
HTML imports are not a thing anymore, they are not supported by any
 browser.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
13fe0f5612 fix: Clean up typing and remove deprecated calls in template functions
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
aac391d466 chore: Move template functions out of legacy folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
a83cae1a0e fix: Remove multiple require_once calls for template functions
Only require them when include the template file instead

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Nextcloud bot
bc47dfc075
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-20 00:23:22 +00:00
Ferdinand Thiessen
a243e9cfbb
fix(webauthn): do not require bcmath or gmp - not needed anymore
The extensions are not required anymore but only recommended for
performance. See also:
https://github.com/web-auth/webauthn-framework/issues/213

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 11:19:49 +01:00
Ferdinand Thiessen
d5efd17942
fix(IMimeTypeDetector): use correct return type
In PHP array keys that are integers are always kept as integer,
meaning the type of the key of `$a = ["1" => "one"]` will be integer not
string.
While are hacks to circumvent this (case std object with string keys to
an assoc. array) those hacks are performance wise awefull and also not
needed as in PHP you can always access that element with `$a[1]` or
`$a["1"]`.

So TL;DR;: do not lie about return types.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-18 15:34:28 +01:00
Joas Schilling
c9aea8ffdf
fix(auth): Allow 2FA challenges for Ephemeral sessions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-18 09:52:51 +01:00
Nextcloud bot
2d0f50ad7f
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-18 00:23:53 +00:00
Ferdinand Thiessen
4d453d38de
Merge pull request #51480 from nextcloud/fix/deprecation-comment
chore: drop outdated deprecation comment from Mailer
2025-03-17 18:43:44 +01:00
Hamza
bf06b2552b
Merge pull request #51380 from nextcloud/fix/noid/contactsmenu-ab-enabled
fix(cardav): only show users from enabled addressBooks in contacts menu
2025-03-17 17:51:41 +01:00
Git'Fellow
dda2148f6f
Merge pull request #51333 from nextcloud/filePointerCheck
fix(files): Make sure file pointer exists
2025-03-17 17:04:24 +01:00
Hamza Mahjoubi
c9d9abd46e fix(cardav): only show useres from enabled addressBooks in contacts menu
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-17 11:56:34 +01:00
Côme Chilliet
ac4d805cb9
Merge pull request #51389 from nextcloud/bug/noid/skip-quote-cache-for-remote-shares
fix: skip caching lastSeenQuotaUsage for remote shares
2025-03-17 11:54:45 +01:00
Nextcloud bot
e6b45a68ad
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-16 00:23:40 +00:00
Nextcloud bot
f1dc8c75db
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-15 00:23:31 +00:00
Daniel Kesselberg
db86cf8db1 fix: skip caching lastSeenQuotaUsage for remote shares
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-03-14 10:24:34 +01:00
Ferdinand Thiessen
4717f5cbc9
chore: drop outdated deprecation comment from Mailer
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-14 09:09:53 +01:00
Nextcloud bot
1f99521df1
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-14 00:23:17 +00:00
skjnldsv
0179cb4d8d feat(core): add setup cypress tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-13 20:51:00 +01:00
Nextcloud bot
9dea6185ad
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-13 00:22:59 +00:00
umgfoin
b3b2c68937 fix(GenerateBlurhashMetadata): Suppress imagescale errors
Suppress errors in imagescale during file-scans:
Most of these errors are caused by out of range x/y-dims.

Triggering un unhandled exception, metadata-generation aborts at this point  (e.g. occ files:scan --generate-metadata), effectively preventing these images from being added to photos or maps.

This problem might be the root cause for an issue described here:
https://github.com/nextcloud/photos/issues/2768

Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
2025-03-12 15:41:07 +01:00
provokateurin
3c698c6553
fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-12 14:52:32 +01:00
Nextcloud bot
5741d587ff
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-12 00:23:18 +00:00
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
34251c4375
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Nextcloud bot
e6ed401818
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-11 00:22:59 +00:00
Robin Appelman
8edca98e8e
fix: fix getNodeFromCacheEntryAndMount using relative path
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-10 18:19:20 +01:00
Côme Chilliet
eb597917f6
Merge pull request #51029 from nextcloud/fix/deprecate-oc-template-and-cleanup
fix: Deprecate OC_Template, add proper template manager instead
2025-03-10 16:20:45 +01:00
Côme Chilliet
e8b90c83da
Merge pull request #51108 from nextcloud/fix/fix-disabled-user-list-for-saml-subadmin
Fix disabled user list for SAML group subadmin
2025-03-10 14:21:48 +01:00
Côme Chilliet
30382a5d8d chore: Remove now unused methods from User manager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-10 11:30:18 +01:00
Côme Chilliet
0b449f302b fix: Correctly count disabled users for SAML groups subadmins
If too many users return -1 as for LDAP so that link is shown

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-10 11:30:18 +01:00
Joas Schilling
34bcc53fb9
fix(base.php): Correct order for booting \OC\Server
A recent change had broken authentication with an older
FastCGI Apache2 module, because the IRequest object got
initialised before the fix from self::handleAuthHeaders()
copied the authentication headers into the correct $_SERVER
variables.
Since this part is completely independent from any Nextcloud
code it is now done as a first thing within the init() call.

Additionally similar issues could happen when another class
would boot too early and read other global PHP settings like
ini values and default timezone, so those are now also moved
to the beginning.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-10 06:59:49 +01:00
Nextcloud bot
016519c5b0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-09 00:23:12 +00:00
Nextcloud bot
f45d98bf00
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-08 00:22:17 +00:00
Git'Fellow
4d52b185af
fix(files): Make sure file pointer exists
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-07 19:16:30 +01:00
Edward Ly
dd181f4b2a
feat(dav): add webhook compatibility for calendar object events
Signed-off-by: Edward Ly <contact@edward.ly>
2025-03-07 08:09:53 -08:00
Julius Knorr
bb6b462690
Merge pull request #51130 from nextcloud/fix/credential-passwordless-auth
fix: Do not build encrypted password if there is none
2025-03-07 16:49:18 +01:00
Côme Chilliet
b086f10028 fix: Use a dedicated Exception class for when a template is not found
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
f033ef7c18 fix: Migrate all uses of OCP\Template to OCP\Template\ITemplateManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
558f4c854d fix: Cleanup of internal class TemplateLayout
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
1725d63820 fix: Fix signatures and types in template related classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
2cd90f8281 fix: Replace all usage of OC_Template by the new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
253628ad5a fix: Fix psalm issues and add missing methods to ITemplate interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00