upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-12 02:00:51 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 33
69654 commits 1035 branches 1221 tags 8.3 GiB
Commit graph

5316 commits

Author SHA1 Message Date
Andy Scherzinger
5fbb3bb7f0
Merge pull request #39522 from nextcloud/backport/39264/stable27 
[stable27] Add instance category while checking new updates
 2023-07-27 12:04:52 +02:00
Ferdinand Thiessen
ad2727aef8 fix: Correctly add module content type to script tags when scripts with versions are used 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-07-23 00:38:53 +02:00
Benjamin Gaussorgues
46b462285d Add instance category while checking new updates 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-07-21 10:02:58 +00:00
Arthur Schiwon
d3f50f28e1
Merge pull request #38953 from nextcloud/backport/38917/stable27 
[stable27] fix(l10n): Fix plural issue with different locale and language
 2023-07-10 18:29:58 +02:00
Arthur Schiwon
dd2dfc89fd
Merge pull request #38976 from nextcloud/backport/38625/stable27 
[stable27] fix: expect interface, not a specific implementation
 2023-07-04 22:07:29 +02:00
Joas Schilling
81f9d9a690
fix(l10n): Fix plural issue with different locale and language 
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-06-27 14:13:00 +02:00
Simon L
9c2bd71ad4 try to fix tests 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-06-26 08:32:52 +00:00
Arthur Schiwon
f724760f67 chore: ugly type juggling 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:44 +00:00
Varun Patil
24875c02db redis: move lua scripts to class and add type hints 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
 2023-05-31 07:13:21 +00:00
Robin Appelman
5b137a2498 add test to verify redis lua script hashes 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-31 07:13:20 +00:00
Simon L
48521d67e1
Merge pull request #38143 from nextcloud/fix/generated-avatars-cache 
Fix generated avatars cache
 2023-05-16 11:37:49 +02:00
jld3103
2a19753cf7
Clear generated avatar caches 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-05-15 18:18:21 +02:00
Joas Schilling
3a6bc7aba2
fix(middleware): Also abort the request when reaching max delay in afterController 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-15 16:20:19 +02:00
Ferdinand Thiessen
31c01fa3da fix(JSResourceLocator): Handle missing translations silently 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-05-11 18:22:24 +02:00
John Molakvoæ
db02684008
Merge pull request #37691 from nextcloud/object-store-background-scan 2023-05-11 08:15:41 +02:00
Robin Appelman
2ea41dab93
repair -1 folder sizes for object store background scan 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-10 19:33:26 +02:00
Robin Appelman
904fdf3aa3
Merge pull request #37838 from nextcloud/event-logger-http 
log performance events for http requests
 2023-05-09 17:15:27 +02:00
Joas Schilling
b91957e3df
fix(dav): Abort requests with 429 instead of waiting 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-03 22:43:36 +02:00
Arthur Schiwon
7fcf42ad3f
Merge pull request #38024 from nextcloud/fix/fix-32bits-ci 
Fix 32bits ci
 2023-05-03 10:34:04 +02:00
Arthur Schiwon
ef87dfc478
Merge pull request #33106 from nextcloud/feature/update-expire-date 
Update expire_date column of table comments
 2023-05-03 10:26:28 +02:00
Côme Chilliet
e252182d80
Put back file cleanups, and remove dead code in tests/lib/Template/JSResourceLocatorTest.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-02 16:24:28 +02:00
Côme Chilliet
adf743b141
Remove the array_pop failing tests on 32bit CI 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-02 16:09:37 +02:00
Côme Chilliet
10296ba7e5
Fix tests, and fix Group::searchUsers to avoid duplicates 
Also went back to searchUsers indexing the array by uid as it was the
 previous behavior and the IGroup phpdoc does not say anything about the
 keys.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-02 11:35:41 +02:00
Robin Appelman
e7ab30f5d8
log performance events for http requests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-28 15:37:57 +02:00
Côme Chilliet
b6c17c6ce7
Clear up return types 
usersInGroup index by int for BC, searchInGroup index by uid (string).

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 12:00:45 +02:00
Carl Schwan
35dc223500
Optimize retrieving display name when searching for users in a group 
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-04-27 11:57:45 +02:00
Vitor Mattos
5ed6722dd2 Cover expire_date with unit tests 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2023-04-26 13:21:08 -03:00
Joas Schilling
75f17b6094
Merge pull request #37905 from nextcloud/techdebt/noid/add-attributes-for-remaining-security-annotations 
feat(security): Add PHP \Attribute for remaining security annotations
 2023-04-25 17:13:53 +02:00
Joas Schilling
ecb8b55c5c
feat(security): Add PHP \Attribute for remaining security annotations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-25 14:50:32 +02:00
Côme Chilliet
7250f54ca3
Merge pull request #37835 from nextcloud/feat/background-allow-parallel-runs 
feat(BackgroundJobs): Allow preventing parallel runs for a job class
 2023-04-25 12:10:43 +02:00
Marcel Klehr
06d6cf4ebc JobListTest: Fix JobList constructor call 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-24 19:07:13 +02:00
Marcel Klehr
6148c5e0a1
Update tests/lib/BackgroundJob/DummyJobList.php 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-24 12:35:52 +02:00
Joas Schilling
89c3c31402
feat(ratelimit): Add Attributes support to rate limit middleware 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-24 12:24:48 +02:00
Marcel Klehr
a0c722ad69 Run cs:Fix 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
5608b50778 Fix BackgroundJob tests 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
281c8047b6 JobListTest: clearJobsList before testHasReservedJobs 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
56cb5d1d13 fix(tests): Remove duplicated method 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
1296f3612e test(BackgroundJobs): Add tests for allowParallelRuns and hasReservedJobs 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Côme Chilliet
b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2023-04-20 16:52:38 +02:00
Christoph Wurst
2c0cfd3772
feat(app-framework): Add native argument types for middleware 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-04-18 17:15:05 +02:00
Simon L
8fe22ebf60
Merge pull request #36617 from nextcloud/update/psr-container 
chore: Update PSR container to 2.0.2
 2023-04-18 11:40:12 +02:00
Julius Härtl
d9c81f56ad tests: Adapt node related unit tests mocks to required root view 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-04-17 23:46:52 +02:00
Julius Härtl
160bd75d0a fix: Use proper path when creating node instances 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-04-17 23:46:52 +02:00
Ferdinand Thiessen
dc9d8c42bb fix: Adjust console formatter code to match with Symfony type hints 
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-04-17 18:35:10 +02:00
Glandos
384a1d34a8 adapt test to new workflow 
getDirectoryListing should return all files
getFile is not called anymore

Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
jld3103
b153340b62
Add type hints for mappers 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-07 09:49:42 +02:00
Côme Chilliet
8d5165e8dc
Adapt tests to config value typing 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 17:42:14 +02:00
Côme Chilliet
8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup 
Tidy up typing in OC\Files\View
 2023-04-05 10:14:55 +02:00
jld3103
d9f8522003
Fix types for reading and writing config values 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-05 09:08:56 +02:00
Joas Schilling
131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-04 10:54:12 +02:00
Louis
7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value 
Migrate metadata JSON column to new value TEXT column
 2023-04-04 10:23:54 +02:00
Joas Schilling
c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing 
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
 2023-04-03 14:19:41 +02:00
Louis Chemineau
1a6709cf43 Migrate metadata as JSON to value as STRING 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-04-03 14:06:28 +02:00
Côme Chilliet
4393b96542
Remove unused method getLocalFolder 
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:33 +02:00
Joas Schilling
454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-03 09:06:45 +02:00
Arthur Schiwon
997c2a2a79
fix DBAL exception handling in setValues 
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-03-31 17:01:17 +02:00
Christopher Ng
4f8e916585 Add label for logo link 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-03-29 13:36:45 -07:00
Julius Härtl
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts 2023-03-22 09:17:28 +01:00
Côme Chilliet
633ea018af
Fix BackgroundCleanupJobTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:21:44 +01:00
Joas Schilling
bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute 
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
 2023-03-16 19:33:13 +01:00
Arthur Schiwon
a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection 
chore: use local variable for remote address
 2023-03-15 15:11:53 +01:00
Artur Neumann
37cfccabc1
unit tests for Manager::invalidateTokensOfUser 
Signed-off-by: Artur Neumann <artur@jankaritech.com>
 2023-03-14 17:13:30 +01:00
Côme Chilliet
71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper 
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
 2023-03-13 22:10:47 +01:00
Côme Chilliet
9b1d7794a8 Add chunking in SystemTagObjectMapper::getTagIdsForObjects 
This avoids crashing on Oracle with more than 1000 objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-13 17:36:10 +00:00
Thomas Citharel
f1751c4428
Introduced app enable/disable/update typed events 
OCP\App\ManagerEvent is depreciated since 22 without a replacement

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-03-13 11:52:57 +01:00
Daniel Kesselberg
39c1b6f49f
chore(tests): add tests for handleLoginFailed 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-03-10 18:04:39 +01:00
Joas Schilling
2b49861679
Add a debug message when throttling without defining 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-08 12:09:22 +01:00
Joas Schilling
e839eb9b5c
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-08 12:09:22 +01:00
Joas Schilling
c297f8ee96
feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-03 15:37:13 +01:00
Joas Schilling
de64c96a67
Merge pull request #36941 from nextcloud/bugfix/prevent-error-with-oracle-database 
Split the comments ids by chunks
 2023-03-03 12:37:15 +01:00
blizzz
289fadfd50
Merge pull request #36803 from nextcloud/fix/sqlite-comments 
[db]: Remove not supported column comments for SQLite
 2023-03-02 12:10:19 +01:00
Vitor Mattos
e9295f739e Split the comments ids by chunks 
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.

https://github.com/nextcloud/spreed/issues/8287

Signed-off-by: Vitor Mattos <vitor@php.rio>
 2023-03-01 13:08:17 -03:00
Ferdinand Thiessen
1785a80754 tests(db): Add test case to ensure column comments work 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-28 10:39:13 +01:00
Marcel Klehr
4f7d77406d Fix SystemTagManagerTest#createTag test 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 14:40:33 +01:00
Marcel Klehr
889caf4632
Update tests/lib/SystemTag/SystemTagManagerTest.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 14:22:41 +01:00
Marcel Klehr
8151b1b8b0 fix(SystemTagManager): Truncate overlong tag names 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 12:55:10 +01:00
Ferdinand Thiessen
b642137c65 feat(OC/Template): Add type="module" for ES6 scripts 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-22 21:19:37 +01:00
Ferdinand Thiessen
00e041b907 feat(template): Allow JSResourceLocator to find ES6 scripts 
Enable module js (ES6) support on the `JSResourceLocator`.
This changes `JSResourceLocator` to look for `.mjs` files first
to allow applications to provide a fallback `.js` for older Nextcloud versions.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-22 21:19:37 +01:00
Joas Schilling
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call" 2023-02-21 07:36:43 +01:00
Julius Härtl
614981ae9a
feat(directediting): Allow opening by file id 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-20 12:16:34 +01:00
Anna Larch
5d4efb4d5f
Do not set up filesystem on every call 
Also remove old Oc_FileChunking logis that produced GC- collectable chunks

Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-02-17 19:18:37 +01:00
Julius Härtl
47bc024885
Revert the token scope to not end up with storing the user used in the session 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-17 10:18:18 +01:00
Julius Härtl
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors 2023-02-17 09:42:08 +01:00
Ferdinand Thiessen
f655f83c84 fix(CORS): CORS should only be bypassed on PublicPage if not logged in to prevent CSRF attack vectors 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-16 22:55:18 +01:00
Louis
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts 
fix the contacts-menu vcf-contact avatars
 2023-02-16 14:01:19 +01:00
Simon L
b38d2daede fix the contacts-menu vcf-contact avatars 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-02-15 23:16:43 +01:00
MichaIng
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow" 
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
 2023-02-15 20:16:51 +01:00
Julius Härtl
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation 2023-02-14 10:12:19 +01:00
Robin Appelman
b911da3e1e
DI for Router 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-13 22:51:14 +01:00
Robin Appelman
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion 
more filesystem setup performance instrumentation
 2023-02-13 14:37:57 +01:00
Robin Appelman
91d5f6a826 more filesystem setup performance instrumentation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-10 11:11:13 +01:00
Joas Schilling
a81d8ecef5
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-09 16:15:47 +01:00
Julius Härtl
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id 2023-02-08 20:04:57 +01:00
Joas Schilling
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container 
Make the container fully fulfill PSR container interface
 2023-02-07 20:38:19 +01:00
Robin Appelman
9f3dbb699a fix tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-07 15:50:10 +01:00
Côme Chilliet
892e6c642a
Skip buggy tests for 32bits CI 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:33 +01:00
Côme Chilliet
77c8c9c805
Improve error output on failed Router test 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:31 +01:00
Côme Chilliet
94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
0f8c34cdc6
Fix filesize return type error in ViewTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00