upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-14 19:20:35 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
69654 commits 1033 branches 1221 tags 8.4 GiB
Commit graph

13522 commits

Author SHA1 Message Date
Marcel Klehr
91325efa78 Add tasks::last_updated column and vacate tasks after a week 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit cb0f918d21)
 2023-08-09 10:01:10 +02:00
Marcel Klehr
fb9262e864 LLM OCP API: Use OCP\Common\Exception\NotFoundException 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit b00a9a6eae)
 2023-08-09 10:01:02 +02:00
Marcel Klehr
4405027471 Apply suggestions from code review 
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit 8e4aa92167)
 2023-08-09 10:00:52 +02:00
Marcel Klehr
02c78be790 LLM OCP API: Fix static analysis 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit fac83ce4b6)
 2023-08-09 10:00:16 +02:00
Marcel Klehr
76a5db8867 LLM OCP API: cs:fix 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit b6941aa5c3)
 2023-08-09 10:00:03 +02:00
Marcel Klehr
236c32b13f LLM OCP API: Implement ocs API 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

(cherry picked from commit 795b097122)
 2023-08-09 09:59:58 +02:00
Marcel Klehr
ed3672a5c2 LLM OCP API: Add to RegistrationContext 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit 82d3b00ab1)
 2023-08-09 09:55:24 +02:00
Marcel Klehr
7031072717 LLM OCP API: Add db migration 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit 6fc4cb63ef)
 2023-08-09 09:55:21 +02:00
Marcel Klehr
d20ee42580 LLM OCP API: Implement private backend code + add ILanguageModelTask 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit 3413873653)
 2023-08-09 09:55:18 +02:00
Joas Schilling
32bfd43d29
feat(HTTPClient): Provide wrapped access to Guzzle's asyncRequest() 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-08-07 15:38:09 +02:00
John Molakvoæ
0638f58632 fix: simplify sourceData check 
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2023-08-05 10:34:12 +00:00
Josh Richards
d6fe5acbec Catch more invalid cache source storage paths 
OC\Files\Cache\Cache::get can return string|false|null, not just string|false.

- nextcloud/server#26270 added handling of false, but null is needed too.
- Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason

Related: nextcloud/server#19009

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2023-08-05 10:34:11 +00:00
Julius Härtl
6587cf4314
Merge pull request #39642 from nextcloud/backport/39629/stable27 2023-08-03 08:47:22 +02:00
Arthur Schiwon
200b018a2f
Merge pull request #39596 from nextcloud/backport/38667/stable27 
[stable27] fix(SystemTagManager): Use truncated tagName in getTag and updateTag
 2023-08-02 20:59:16 +02:00
Arthur Schiwon
0d96313256
Merge pull request #39499 from nextcloud/backport/38934/stable27 
[stable27] fix(s3): Pass SSE-C parameters for multipart upload
 2023-08-02 20:55:24 +02:00
Arthur Schiwon
83d114b091
Merge pull request #39448 from nextcloud/backport/38907/stable27 
[stable27] Fix: ContactManager search with fullmatch
 2023-08-02 20:54:48 +02:00
Arthur Schiwon
a0750349fa
Merge pull request #39435 from nextcloud/backport/39309/stable27 
[stable27] fix(profile): fix getUID on nullable user variable
 2023-08-02 20:54:09 +02:00
Arthur Schiwon
0c3fe91239
Merge pull request #39369 from nextcloud/backport/39339/stable27 
[stable27] fix(node): non-existing folder is not searchable
 2023-08-02 20:53:37 +02:00
Tobias Zimmerer
46ba7ed60a fix(s3): add SSE-C parameters to headObject call 
Signed-off-by: Tobias Zimmerer <3228193+ir0nhide@users.noreply.github.com>
 2023-07-31 16:36:16 +00:00
Marcel Klehr
2bc56fef1e Fix ParallelAwareJob tests 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-07-28 11:44:39 +00:00
Marcel Klehr
d44a12bb8b fix(SystemTagManager): Use truncated tagName in getTag and updateTag 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-07-27 17:03:02 +00:00
Andy Scherzinger
5fbb3bb7f0
Merge pull request #39522 from nextcloud/backport/39264/stable27 
[stable27] Add instance category while checking new updates
 2023-07-27 12:04:52 +02:00
Ferdinand Thiessen
ad2727aef8 fix: Correctly add module content type to script tags when scripts with versions are used 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-07-23 00:38:53 +02:00
Benjamin Gaussorgues
46b462285d Add instance category while checking new updates 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-07-21 10:02:58 +00:00
Julius Härtl
e25db0e294 fix(s3): Pass SSE-C parameters for multipart upload 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-07-20 09:13:41 +00:00
Joas Schilling
227497705e
fix(apps): Fix loading info.xml file 
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-20 10:45:58 +02:00
Johannes Merkel
7065a5e0e4 fix(mail): ContactManager search with fullmatch 
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
 2023-07-18 08:52:40 +00:00
Thomas Citharel
56899c1a83 fix(profile): fix getUID on nullable user variable 
As per method signature, $visitingUser is nullable, so we can't be sure calling getUid() on it will
work.

Closes #35766

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-07-17 13:24:08 +00:00
Arthur Schiwon
bf00591278 fix(node): non-existing folder is not searchable 
the previosuly introduced searchBySystemTag was not overwritten in
NonExistingFolder and could run the inherited method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-13 14:26:26 +00:00
Arthur Schiwon
8cfe927f93
Merge pull request #38971 from nextcloud/backport/38945/stable27 
[stable27] implement optimized getDirectoryContent for DAV
 2023-07-12 01:05:35 +02:00
Arthur Schiwon
21a8eb1a62
Merge pull request #38816 from nextcloud/backport/38490/stable27 
[stable27] emit an event when a message is logged
 2023-07-12 01:05:14 +02:00
Arthur Schiwon
fe1a2277cb
Merge pull request #38756 from nextcloud/backport/38468/stable27 
[stable27] log failures to read certificates during listing
 2023-07-12 01:03:05 +02:00
Arthur Schiwon
7fd10d5bb7
Merge pull request #39269 from nextcloud/backport/35915/35915-stable27 
[stable27] display displayname on federated shares
 2023-07-11 17:56:58 +02:00
Maxence Lange
3b93a35108 display displayname on federated shares 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-07-11 09:25:09 -01:00
Julien Veyssier
3a45af2e27 shorten oauth2 client names before resizing the column 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
 2023-07-10 21:13:20 +02:00
Julien Veyssier
47a19f2217 drop the oauth2_clients trusted column, delete unsupported clients and their access tokens 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
 2023-07-10 21:13:20 +02:00
Arthur Schiwon
f5a7d40621
Merge pull request #39099 from nextcloud/backport/39093/stable27 
[stable27] Silent `imagecreatefromstring()` errors
 2023-07-10 18:32:15 +02:00
Git'Fellow
61cd250935 Include PR #38965 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-07-10 18:31:45 +02:00
Robin Appelman
98ec2f023f implement optimized getDirectoryContent for DAV 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-07-10 18:31:45 +02:00
Arthur Schiwon
d3f50f28e1
Merge pull request #38953 from nextcloud/backport/38917/stable27 
[stable27] fix(l10n): Fix plural issue with different locale and language
 2023-07-10 18:29:58 +02:00
Robin Appelman
7d17d2517f emit an event when a message is logged 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-07-10 18:29:09 +02:00
Robin Appelman
6d881c10e8 log failures to read certificates during listing 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-07-10 18:27:38 +02:00
Arthur Schiwon
a7b4f502aa
refactor: adjust to unexposed searchBySystemTag 
- in this backport we have to drop the breaking addition in
  \OCP\Files\Folder
- this requires adjustments in check for the existance of the method but
  also in testing
- another change in \OCP\SystemTag\ISystemTagManager can be applied as
  this interface is not implemented elsewhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 12:25:04 +02:00
Arthur Schiwon
b55be6fd8f
fix: cominbation of small fixes 
- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-06 21:52:52 +02:00
Arthur Schiwon
66a7064db3
fix: include invisible tags for admins 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-06 21:52:51 +02:00
Arthur Schiwon
99442b60d5 fix: favorites view and universal search against tags 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-06 17:29:12 +00:00
Arthur Schiwon
7d8d586983 fix: change if with conditionless else to switch; and a parameter value 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-06 17:29:12 +00:00
Arthur Schiwon
7bfe6f2cc0 use efficient tag retrieval on DAV report request 
- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-06 17:29:11 +00:00
Richard Steinmetz
aaa7b41a33 fix(sse): don't update uncached files 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2023-07-04 20:18:17 +00:00
Arthur Schiwon
dd2dfc89fd
Merge pull request #38976 from nextcloud/backport/38625/stable27 
[stable27] fix: expect interface, not a specific implementation
 2023-07-04 22:07:29 +02:00
Robin Appelman
0ff32cadf3 add utility command for object store objects 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-07-04 17:59:21 +02:00
Git'Fellow
ecbeacbdf5 Silent imagecreatefromstring() errors 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-07-01 14:38:30 +00:00
Joas Schilling
81f9d9a690
fix(l10n): Fix plural issue with different locale and language 
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-06-27 14:13:00 +02:00
Robin Appelman
b219a17cc6 file scanner performance improvements 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-06-26 15:44:16 +00:00
Simon L
bb2da7ed5d use getsystemvalue-functions in Mailer.php 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-06-26 08:32:51 +00:00
Arthur Schiwon
29e11a4273 ci: pro forma check of existence of internal method 
createNode() is protected and used by Folder, but being an internal-only
method it shall not be exposed in the Folder or IRootFolder interface.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:45 +00:00
Arthur Schiwon
09c4ba257c refactor: declare getMount() and getMountsIn() at IRootFolder 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:44 +00:00
Arthur Schiwon
f724760f67 chore: ugly type juggling 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:44 +00:00
Arthur Schiwon
faea2440ed fix: add typehine for IRootFolder 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:44 +00:00
Arthur Schiwon
c04b1ed857 fix: expect interface, not a specific implementation 
- fixes a regression when deleting folders while music app was enabled,
  for a LazyRoot was passed to this method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:44 +00:00
Robin Appelman
782736ab54
use source cache when listing folder during recursive copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-06-19 12:32:04 +02:00
Dominik Fuchß
681d2c0402 Fix deprecated method call 
Signed-off-by: Dominik Fuchß <develop@fuchss.org>
 2023-06-14 20:27:39 +00:00
Dominik Fuchß
a6ca1546cc Changes after code review. 
Signed-off-by: Dominik Fuchß <develop@fuchss.org>
 2023-06-14 20:27:39 +00:00
Dominik Fuchß
c64e9f6e93 Add config variable for curl timeout 
Add the config variable for curl calls ("remote_curl_timeout"). E.g., needed for nextcloud federation.

Signed-off-by: Dominik Fuchß <develop@fuchss.org>
 2023-06-14 20:27:38 +00:00
Ferdinand Thiessen
31d5f720fb fix(apache): Serve mjs (module javascript) as static files 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-06-14 16:51:58 +02:00
Arthur Schiwon
a845fc7395
Merge pull request #38449 from nextcloud/backport/38415/stable27 
[stable27] don't always check if we need to setup the object store root
 2023-06-01 17:33:50 +02:00
Andy Scherzinger
f5d5636272
Merge pull request #38538 from nextcloud/backport/37758/stable27 
[stable27] redis: use atomic operations everywhere
 2023-06-01 17:12:05 +02:00
Varun Patil
24875c02db redis: move lua scripts to class and add type hints 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
 2023-05-31 07:13:21 +00:00
Varun Patil
8745f76bd0 redis: use atomic operations everywhere 
This removes a lot of acrobatics in the code and does each operation
atomically using a lua script. This also reduces several round trips
to the server, and the scripts are compiled and cached server-side.

Notably, since all operations work only on a single key (except clear,
which is broken anyway and shouldn't be used), they will continue to
function and be atomic for Redis cluster.

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
 2023-05-31 07:13:20 +00:00
Daniel Kesselberg
5630703061 fix: catch errors in id3parser library 
We use a forked version of getID3 to read embedded images from mp3 files to use them as previews.

If the library is unable to extract a image or fails on something different we should handle it properly.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-05-30 09:06:35 +00:00
Joas Schilling
bbb9437116 fix(dav): Fix avatar size in system address book 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-26 10:28:59 +00:00
Robin Appelman
780a744e07 don't always check if we need to setup the object store root 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-24 21:55:56 +00:00
Julius Härtl
ce8e21d2c5
fix: execute throws docrine exceptions not our wrapped ones 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-05-24 20:45:51 +02:00
Simon L
6608f84a46
Merge pull request #36692 from nextcloud/throw-exception-to-avoid-division-by-zero 
fix(preview-generator): Throw exception before dividing by zero when generating previews
 2023-05-17 00:14:42 +02:00
Simon L
48521d67e1
Merge pull request #38143 from nextcloud/fix/generated-avatars-cache 
Fix generated avatars cache
 2023-05-16 11:37:49 +02:00
Simon L
ab848244fe
Merge pull request #38065 from nextcloud/fix-result-mimetype-loader 
fix(mimetype): Fix returning value when finding existing mimetype in MimeType Loader
 2023-05-16 11:30:13 +02:00
Joas Schilling
5e02def3f4
Merge pull request #38274 from nextcloud/bugfix/noid/reach-max-delay-in-afterController 
fix(middleware): Also abort the request when reaching max delay in af…
 2023-05-16 11:07:04 +02:00
jld3103
2a19753cf7
Clear generated avatar caches 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-05-15 18:18:21 +02:00
jld3103
e294045223
Properly clear cached avatars 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-05-15 18:18:21 +02:00
Côme Chilliet
8362eea14e
Merge pull request #38196 from nextcloud/fix/fix-32bits-freespace-and-sizes 
Get rid of more int casts in file size manipulations
 2023-05-15 17:05:46 +02:00
Joas Schilling
3a6bc7aba2
fix(middleware): Also abort the request when reaching max delay in afterController 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-15 16:20:19 +02:00
Côme Chilliet
ae525e1935
Fix return types in phpdoc 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-15 12:24:42 +02:00
Côme Chilliet
3bf19f76e6
Merge pull request #32961 from nextcloud/more-debug-lazyuserfolder 
Make it easier to debug issue #32304
 2023-05-15 11:42:06 +02:00
Julius Härtl
0ebb00d01d
fix: Do not attempt to use l10n files as sources for combined js files 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-05-15 08:29:05 +02:00
Julius Härtl
e18f97fc95
Merge pull request #37709 from nextcloud/bugfix/deadlock 2023-05-13 13:13:04 +02:00
Julius Härtl
8cab1d73ac
Merge pull request #37621 from nextcloud/enh/lock-readable-path 2023-05-13 13:11:37 +02:00
Robin Appelman
1f4dd62b4e
Merge pull request #36592 from nextcloud/groupmanager-search-typing 
fix default values and type hints for GroupManager::search
 2023-05-12 15:25:32 +02:00
Christoph Wurst
1381c4c157
feat(users): Store and load a user's manager 
Co-Authored-By: hamza221 <hamzamahjoubi221@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-05-12 13:56:48 +02:00
Ferdinand Thiessen
31c01fa3da fix(JSResourceLocator): Handle missing translations silently 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-05-11 18:22:24 +02:00
John Molakvoæ
4a86487859
fix: getGroups limit check syntax 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2023-05-11 17:30:04 +02:00
Robin Appelman
13b06ba4e2
revert public interface back to the original types, just cast them before passing the nulls to the backends 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-11 17:30:03 +02:00
Robin Appelman
7ad3574d71
also update groupinterface and database backend 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-11 17:30:03 +02:00
Robin Appelman
e4b9ecd8f2
fix default values and type hints for GroupManager::search 
ints really are ints

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-11 17:30:01 +02:00
Côme Chilliet
a90581b405
Get rid of more int casts in file size manipulations 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-11 12:46:16 +02:00
John Molakvoæ
979f4033ca
Merge pull request #33381 from luzpaz/fix/lib-public-typos 2023-05-11 10:26:50 +02:00
Arthur Schiwon
b6c034ac57
Merge pull request #37961 from nextcloud/poc/noid/systemtags-perf 
SystemTags endpoint to return tags used by a user with meta data
 2023-05-11 10:16:03 +02:00
John Molakvoæ
db02684008
Merge pull request #37691 from nextcloud/object-store-background-scan 2023-05-11 08:15:41 +02:00
Robin Appelman
2ea41dab93
repair -1 folder sizes for object store background scan 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-10 19:33:26 +02:00
Arthur Schiwon
df662f50bd
refactor: remove where specification from SELECT getter 
- search constraints are now fully in control of
  SystemTagsInFilesDetector::detectAssignedSystemTagsIn(), avoids
  duplication of a WHERE statement

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-05-10 18:48:06 +02:00
Anna
9e53934498
Merge pull request #36118 from nextcloud/fix/caldav/invitation-outlook-compatibilty 
Fix calendar emails to be outlook compatible
 2023-05-10 12:10:42 +02:00
Simon L
d55a7c619d Fix typos in lib/public subdirectory 
Found via `codespell -q 3 -S l10n -L jus ./lib/public`

Signed-off-by: luz paz <luzpaz@github.com>

Update lib/public/Accounts/IAccount.php

Signed-off-by: luz paz <luzpaz@github.com>

Signed-off-by: Simon L <szaimen@e.mail.de>
Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2023-05-10 11:56:34 +02:00
Arthur Schiwon
dbfd2f936a
refactor: remove SystemTag logic from Folder into QuerySearchHelper 
- adds OC\SystemTag\SystemTagsInFilesDetector where the search logic is
  moved to

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-05-09 23:51:52 +02:00
Arthur Schiwon
2489a2d63a
feat: specify media type via url path: systemtags-current/$mediaType 
- only the media part of the mime type can be search, but not the full
  mime type. It can be added, should it become necessary.
- thus fixes previously hardcoded selector for image/ types
- also fixes a return type hint
- adds a return type hint

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-05-09 23:51:51 +02:00
Arthur Schiwon
6bff6a5667
PoC: SystemTags endpoint to return tags used by a user with meta data 
Target case is photos app: when visiting the tags category, all systemtags
of the whole cloud are retrieved. In subequent steps the next tag is
requested until the browser view is filled with tag tiles (i.e. previews
are requested just as well).

With this approach, we incorpoate the dav search and look for user related
tags that are used by them, and already returns the statistics (number of
files tagged with the respective tag) as well as a file id for the purpose
to load the preview. This defaults to the file with the highest id.

Call:
curl -s -u 'user:password' \
  'https://my.nc.srv/remote.php/dav/systemtags-current' \
  -X PROPFIND -H 'Accept: text/plain' \
  -H 'Accept-Language: en-US,en;q=0.5'  -H 'Depth: 1' \
  -H 'Content-Type: text/plain;charset=UTF-8' \
  --data @/home/doe/request-systemtag-props.xml

With request-systemtag-props.xml:
<?xml version="1.0" encoding="UTF-8"?>
<d:propfind xmlns:d="DAV:">
        <d:prop xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns">
                <oc:id/>
                <oc:display-name/>
                <oc:user-visible/>
                <oc:user-assignable/>
                <oc:can-assign/>
                <nc:files-assigned/>
                <nc:reference-fileid/>
        </d:prop>
</d:propfind>

Example output:
  …
  <d:response>
    <d:href>/master/remote.php/dav/systemtags/84</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>84</oc:id>
        <oc:display-name>Computer</oc:display-name>
        <oc:user-visible>true</oc:user-visible>
        <oc:user-assignable>true</oc:user-assignable>
        <oc:can-assign>true</oc:can-assign>
        <nc:files-assigned>42</nc:files-assigned>
        <nc:reference-fileid>924022</nc:reference-fileid>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
  <d:response>
    <d:href>/remote.php/dav/systemtags/97</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>97</oc:id>
        <oc:display-name>Bear</oc:display-name>
        <oc:user-visible>true</oc:user-visible>
        <oc:user-assignable>true</oc:user-assignable>
        <oc:can-assign>true</oc:can-assign>
        <nc:files-assigned>1</nc:files-assigned>
        <nc:reference-fileid>923422</nc:reference-fileid>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
  …

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-05-09 23:51:48 +02:00
Côme Chilliet
185fe5378b
Merge pull request #36893 from nextcloud/fix/avoid-file-events-on-null-path 
Make sure to never trigger files hooks on a null path
 2023-05-09 17:44:14 +02:00
John Molakvoæ
31302c4528
Merge pull request #38095 from nextcloud/artonge/fix/file_metadata_scan 2023-05-09 17:28:47 +02:00
Robin Appelman
904fdf3aa3
Merge pull request #37838 from nextcloud/event-logger-http 
log performance events for http requests
 2023-05-09 17:15:27 +02:00
Arthur Schiwon
d946256ff9
Merge pull request #38088 from nextcloud/fix/38053/change-display-name 
fix(user): Can change display name
 2023-05-09 11:48:10 +02:00
Louis Chemineau
b67e34f78f Restrict EXIF extracting to a subset of formats 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-05-09 11:43:56 +02:00
Louis Chemineau
157be42a83 Prevent error on files scan if metadata exists 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-05-09 11:43:56 +02:00
Côme Chilliet
1cc1866ba3
Add back missing slash in LazyUserFolder path 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2023-05-09 10:59:31 +02:00
Arthur Schiwon
c7bb540d08
Merge pull request #36895 from apasov/patch-1 
Fix json_decode expecting a string
 2023-05-08 21:20:38 +02:00
Joas Schilling
598859d969
Merge pull request #38097 from nextcloud/bugfix/38087/dont-translate-when-from-and-to-are-equal 
fix(translation): Don't use translation providers when from and to ar…
 2023-05-08 09:40:22 +02:00
jld3103
04d840211f
Remove version check for ancient libxml version 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-05-05 19:07:55 +02:00
Joas Schilling
505e467cc4
fix(translation): Don't use translation providers when from and to are the same 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-05 14:03:14 +02:00
John Molakvoæ
46459ae93f
Merge pull request #35092 from Messj1/bugfix/type-error-cert-manager-cache-path 2023-05-04 21:53:49 +02:00
Christopher Ng
4ecae83385 fix(user): Can change display name 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-05-04 11:14:49 -07:00
Côme Chilliet
6034cc6893 Make sure to never trigger files hooks on a null path 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-04 17:55:09 +00:00
Carl Schwan
85770f3b9f Make it easier to debug issue #32304 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-05-04 11:11:52 +00:00
Simon L
527de8ac9d
Merge pull request #37148 from nextcloud/enh/noid/increase-imaginary-timeouts 
increase imaginary timeouts as for big files the processing could take very long
 2023-05-04 12:44:52 +02:00
Thomas Citharel
375466819e
fix(mimetype): Fix returning value when finding existing mimetype in MimeType Loader 
Also, only return the ID from the transaction as the mimetype string is
already used from the function argument value

Fixes https://github.com/nextcloud/server/pull/35744/files#r1184644610

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-05-04 11:15:50 +02:00
Joas Schilling
b91957e3df
fix(dav): Abort requests with 429 instead of waiting 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-03 22:43:36 +02:00
Arthur Schiwon
7a7578cb86
Merge pull request #37937 from nextcloud/artonge/feat/remove_non_existing_jobs 
Remove job from oc_jobs when the file is not findable
 2023-05-03 12:51:11 +02:00
Joas Schilling
9ace8e561d
Merge pull request #38003 from nextcloud/bugfix/noid/improve-translations-api 
Improve translations api with detecting languages
 2023-05-03 11:07:30 +02:00
Louis Chemineau
8ad2f34045 Remove job from oc_jobs when the file is not findable 
When an application is disabled, or when a background jobs is removed by the app developer, then the job won't be found. In those cases, it makes sense to remove those jobs from oc_job.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-05-03 10:39:38 +02:00
Arthur Schiwon
997efe44ff
Merge pull request #37943 from nextcloud/fix/fix-getcontent-return-type 
Fix file_get_content signatures to make it clear it can return false
 2023-05-03 10:34:51 +02:00
Arthur Schiwon
ef87dfc478
Merge pull request #33106 from nextcloud/feature/update-expire-date 
Update expire_date column of table comments
 2023-05-03 10:26:28 +02:00
Julius Härtl
3bdd770129
fix: Check for wrapped retriable exceptions 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-05-02 19:42:11 +02:00
Julius Härtl
11c5bc6a2a
fix: Wrap filesystem LockedExceptions for holding the readable path 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-05-02 19:40:27 +02:00
Côme Chilliet
f7632f2fc4
Merge pull request #32866 from nextcloud/performance/searchInGroup-displayname-cache 
Optimize retrieving display name when searching for users in a group
 2023-05-02 16:42:09 +02:00
Joas Schilling
9d6ec68b59
feat(translation): Return the detected language so clients can show more details 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-02 16:38:33 +02:00
Joas Schilling
dc67b48c28
fix(translation): Detect the language first and then ask all providers for translations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-02 16:38:33 +02:00
Simon L
4dfadcabb9
Merge pull request #38014 from nextcloud/norm-logic 
Normalize logical operators
 2023-05-02 16:27:58 +02:00
Côme Chilliet
10296ba7e5
Fix tests, and fix Group::searchUsers to avoid duplicates 
Also went back to searchUsers indexing the array by uid as it was the
 previous behavior and the IGroup phpdoc does not say anything about the
 keys.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-02 11:35:41 +02:00
Git'Fellow
951c5b973e
Normalize logical operators 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-05-02 10:10:02 +02:00
Robin Appelman
e7ab30f5d8
log performance events for http requests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-28 15:37:57 +02:00
Robin Appelman
f5e2b0b22f
allow storing multiple mounts for the same rootid in the mount cache 
currently `[$userId, $rootId]` is used as the unique key for storing mounts in the mount cache,
however there are cases where the same rootid is mounted in multiple places for a user which currently leads to not all of those mounts being added to the cache.

Previously this didn't matter as the mount cache was only used to list users with access to a specific file, so a user having access to the file multiple times didn' change anything.

With 24 the mount cache is used for more cases and multiple mounts for the same id becomes relevant.
While I think there isn't a real negative effect atm besides missing the optimized path we should ensure that the mounts are properly listed

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-28 15:08:08 +02:00
Côme Chilliet
346344c153
Update version number in since and deprecated annotations 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 12:04:32 +02:00
Côme Chilliet
b6c17c6ce7
Clear up return types 
usersInGroup index by int for BC, searchInGroup index by uid (string).

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 12:00:45 +02:00
Côme Chilliet
3c2b126eba
Make code clearer and bump @ deprecated annotations 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 12:00:07 +02:00
Carl Schwan
a4c599c1c9
Split new method in a new group backend interface 
Better for backward compatibility, also move new interfaces to nc 26

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-04-27 12:00:01 +02:00
Carl Schwan
35dc223500
Optimize retrieving display name when searching for users in a group 
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-04-27 11:57:45 +02:00
Côme Chilliet
546d94c3ec
Fix file_get_content signatures to make it clear it can return false 
In File::getContent, which must return a string, throw an Exception
 instead of returning false.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 09:56:05 +02:00
Vitor Mattos
7ab50ab010 Update expire_date column of table comments 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2023-04-26 11:29:56 -03:00
Daniel
81e4390e32
Merge pull request #37925 from nextcloud/feat-update-maintenance-mode-hint 
fix: change maintenance mode info wording
 2023-04-26 13:55:22 +02:00
Daniel Kesselberg
155ea6a54c
fix: change maintenance mode info wording 
In maintenance mode the database is accessible and it's possible to execute other commands then maintenance:mode

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-04-26 11:58:37 +02:00
Joas Schilling
75f17b6094
Merge pull request #37905 from nextcloud/techdebt/noid/add-attributes-for-remaining-security-annotations 
feat(security): Add PHP \Attribute for remaining security annotations
 2023-04-25 17:13:53 +02:00
Joas Schilling
ecb8b55c5c
feat(security): Add PHP \Attribute for remaining security annotations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-25 14:50:32 +02:00
Robin Appelman
d60172567f
Merge pull request #37818 from nextcloud/dav-ext-storage-log 
debug log requests made by dav external storage/shares
 2023-04-25 14:12:57 +02:00
Côme Chilliet
7250f54ca3
Merge pull request #37835 from nextcloud/feat/background-allow-parallel-runs 
feat(BackgroundJobs): Allow preventing parallel runs for a job class
 2023-04-25 12:10:43 +02:00
Carl Schwan
b1ec7ff51f
Add missing taint analysis docblock comments, and improve escaping in some methods 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-24 17:17:53 +02:00
Marcel Klehr
524d053eb2 JobList: add debug log when hasReservedJob query fails 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-24 17:16:32 +02:00
Robin Appelman
05dc96f60d
debug log requests made by dav external storage/shares 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-24 17:13:20 +02:00
Robin Appelman
4953296b9e
Merge pull request #36857 from nextcloud/scan-repair-unencrypted-size 
fix unencrypted_size for folders when scanning the filesystem with encryption enabled
 2023-04-24 15:24:50 +02:00
Joas Schilling
89c3c31402
feat(ratelimit): Add Attributes support to rate limit middleware 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-24 12:24:48 +02:00
Christoph Wurst
dcde970bd5
Merge pull request #37816 from nextcloud/fix/events/info-to-debug-log-legacy-events 
fix(events): Log deprecated events as debug, not info
 2023-04-24 11:14:41 +02:00
Marcel Klehr
5a7f023bfc JobList#hasReservedJobs: Close cursor 
so Joas doesn't die

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
5608b50778 Fix BackgroundJob tests 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
6f9a3218d0 Update lib/private/BackgroundJob/JobList.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
1296f3612e test(BackgroundJobs): Add tests for allowParallelRuns and hasReservedJobs 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
ef27bd6e55 fix(SpeechToText): Prevent parallel runs of TranscriptionJob 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Marcel Klehr
c01c516323 feat(BackgroundJobs): Allow preventing parallel runs for a job class 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-23 12:36:12 +02:00
Robin Appelman
0ac7230b7f
Merge pull request #37820 from nextcloud/parent-storage-mtime-ignore-error 
ignore errors while trying to update parent storage_mtime
 2023-04-21 19:11:27 +02:00
Arthur Schiwon
bb4b34ff69 Read mtime of version.php only once 
- in most cases it would read again in \OC_Util::loadVersion anyway
- remove some unused use statements

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-04-21 14:10:47 +00:00
Robin Appelman
4cc5885615
Merge pull request #37062 from nextcloud/free-space 
Check free space only if source exists and is dir
 2023-04-21 13:55:42 +02:00
Robin Appelman
ccab101df8
Merge pull request #37596 from nextcloud/enh/type-iconfig-getter-calls 
Use typed version of IConfig::getSystemValue as much as possible
 2023-04-21 13:48:12 +02:00
Robin Appelman
4b52dafbf9
ignore errors while trying to update parent storage_mtime 
in the worst case this should only cause an extra rescan later

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-20 17:16:03 +02:00
Côme Chilliet
b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2023-04-20 16:52:38 +02:00
Côme Chilliet
e91e7bc60f
Fix TypeError in Profiler 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-20 10:43:00 +02:00
Joas Schilling
fd473f89e8
Merge pull request #37674 from nextcloud/feature/speech-to-text 
feat(SpeechToText): Add SpeechToText OCP provider API
 2023-04-19 16:29:44 +02:00
Marcel Klehr
fbcd275acb Context params: Make userId nullable 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-19 12:39:39 +02:00
Marcel Klehr
a2f5421fc3 SpeechToTextManager#scheduleFileTranscription: Take context params and expose them on the Transcription*Events 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-19 12:35:13 +02:00
Christoph Wurst
ce71aa9acb
fix(events): Log deprecated events as debug, not info 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-04-19 11:56:10 +02:00
Marcel Klehr
a8b27c9126 TranscriptionJob: Add owner argument to simplify filesystem setup 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-19 11:26:04 +02:00
Marcel Klehr
eb996cbbb0 TranscriptionJob: Ensure filesystem is setup before trying to retrieve file 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-18 16:24:06 +02:00
Jérôme Herbinet
c343569b3f To be consistent with the list of users 
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
 2023-04-18 15:47:26 +02:00
Marcel Klehr
9649f91892
Update lib/private/SpeechToText/SpeechToTextManager.php 
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-18 15:24:14 +02:00
Simon L
8508865eaf
Merge pull request #37772 from nextcloud/enh/30986/follow-up 
Prevent the OpenDocument preview generator from trying to open empty files
 2023-04-18 12:18:14 +02:00
Simon L
8fe22ebf60
Merge pull request #36617 from nextcloud/update/psr-container 
chore: Update PSR container to 2.0.2
 2023-04-18 11:40:12 +02:00
Simon L
5f879a705b
Merge pull request #37316 from nextcloud/fix/security/strict-cookie-check-status-codes 
fix(security)!: Use consistent HTTP status for strict cookie checks
 2023-04-18 11:39:18 +02:00
Joas Schilling
bef4cf0ad1
Fix missing import 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-18 10:01:00 +02:00
Simon L
855e7a2efb
Merge pull request #36774 from nextcloud/bugfix/noid/sabre-nodes 
fix: always use proper path on node api when calling the view
 2023-04-18 04:11:44 +02:00
Simon L
45a0fe490c
Merge pull request #37534 from Rsplwe/master 
Adjust the value of the "max-parts" parameter of the object storage 'ListPart' interface to 1000
 2023-04-18 00:16:38 +02:00
Simon L
0a763820bc
Merge pull request #37676 from nextcloud/fix/auth/atomic-password-db-statements 
fix(auth): Run token bulk update statements in atomic transaction
 2023-04-17 23:48:24 +02:00
Julius Härtl
160bd75d0a fix: Use proper path when creating node instances 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-04-17 23:46:52 +02:00
Simon L
85c9e75f33
Merge pull request #32314 from nextcloud/object-mkdir-logging 
additional logging when mkdir fails for object storage
 2023-04-17 23:42:08 +02:00
Simon L
5cda8f0f45
Merge pull request #35129 from Glandos/previewperf2 
[Performance] Reuse preview directory listing
 2023-04-17 20:22:39 +02:00
Simon L
d87cc208bb
Merge pull request #31286 from rotdrop/bugfix/dont-start-session-when-session-is-already-open 
Don't call session_start() when PHP session is still or already open.
 2023-04-17 20:14:53 +02:00
Ferdinand Thiessen
dc9d8c42bb fix: Adjust console formatter code to match with Symfony type hints 
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-04-17 18:35:10 +02:00
Christoph Wurst
a06898a2d0 fix(security)!: Use consistent HTTP status for strict cookie checks 
Before: 503/412
Now: 412 + json body explaining the error

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-04-17 16:06:37 +00:00
Simon L
800f40b71c fix php-lint 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-04-17 17:18:09 +02:00
Marcel Klehr
3f57725a7c SpeechToTextManager#transcribeFile: Try next provider if one fails 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-17 16:59:46 +02:00
Glandos
e542e60dbc try to make linters happy 
Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:14 +02:00
Glandos
3440387f0f gather code from small and max preview 
use directory listing in both functions to gain 25% speed on run where
every preview already exist.

Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
Glandos
24c121347a Revert 0e49b40 
Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
Glandos
06a7e90383 improve parameter doc 
Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
Glandos
4954bead1d Ensure max preview image is not null 
Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
Glandos
b6c65fee2a php-cs-fix 
Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
Glandos
9b4d5146d5 List preview directory only once 
getCachedPreview used to call `getFile`, and this calls `getDirectoryListing` (or underlying function that list directory) to find the file. This was done for every preview spec.
Now, this is done only once at the beginning of the loop, and the array is just iterated when needed to find the correct entry.

Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
Claus-Justus Heine
45ec432492 Don't call session_start() when PHP session is still or already open. 
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
 2023-04-17 16:23:02 +02:00
Claus-Justus Heine
456679c6fb Update lib/private/Preview/Bundled.php 
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
 2023-04-17 16:19:02 +02:00
Claus-Justus Heine
b3d8363327 Prevent the OpenDocument preview generator from trying to open empty files. 
Rationale: does not make sense, and triggers a deprecation error in
\ZipArchive.

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
 2023-04-17 16:19:02 +02:00
Marcel Klehr
6e9f260348
Update lib/private/SpeechToText/SpeechToTextManager.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-17 15:49:50 +02:00
Thomas Citharel
036cd47bf4 Put Mimeloader insertion and read in the same transaction 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-04-17 13:32:02 +00:00
Marcel Klehr
3779cc3d88 SpeechToTextManager: Deduplicate transcription jobs 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-17 14:57:19 +02:00
Marcel Klehr
71523b9816 AbstractTranscriptionEvent: Add File param 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-17 14:57:19 +02:00
Julius Härtl
eecd4601ac
Merge pull request #37429 from nextcloud/object-store-rmdir 
improve objectstore rmdir handling
 2023-04-13 18:45:12 +02:00
Marcel Klehr
ad66180c34
Update lib/private/SpeechToText/SpeechToTextManager.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-13 15:17:17 +02:00
Marcel Klehr
865ebfaf72 Add missing strict_types + author + copyright 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-13 12:15:18 +02:00
Marcel Klehr
a8d3fff648 Split TranscriptionFinishedEvent into Successful and Failed events 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-13 12:12:07 +02:00
Marcel Klehr
176f1af26a ISpeechToTextManager: Take File as input, drop $context 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-13 11:57:23 +02:00
Marcel Klehr
ef7ce88cee ISpeechToTextProvider#transcribeFile: Pass \OCP\Files\File instead of path 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-12 16:52:11 +02:00
Christoph Wurst
5eb768ac5e
fix(auth): Run token statements in atomic transaction 
All or nothing

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-04-12 15:55:42 +02:00
Maxence Lange
fc29b0d1b7 app type extended_authentication 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-04-12 09:34:49 -01:00
Arthur Schiwon
ec1acb92c7
Merge pull request #37617 from nextcloud/notify-self-test-error 
handle not being able to write file for notify self-test
 2023-04-11 19:43:41 +02:00
Marcel Klehr
a9b5d1f9da chore(coding style): Run cs:fix 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-11 15:04:30 +02:00
Marcel Klehr
317521b607 feat(SpeechToText): Add SpeechToText provider API 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-04-11 14:59:57 +02:00
jld3103
b153340b62
Add type hints for mappers 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-07 09:49:42 +02:00
Jan Messer
647c65a640 [BUGFIX] throw exception instead of error if unable to create file handler (only exceptions are catch) 
Signed-off-by: Jan Messer <jan@mtec-studios.ch>
 2023-04-06 23:03:49 +02:00
Jan Messer
7a443863fe [BUGFIX] check return value and improve error handling 
With S3 primary storage there was a problem with getting the CA bundle from the storage without having the CA bundle for the connection which causes that the CertificateManager was throwing an Error.
This commit improves the handling in CertificateManager and log unexpected behaviors.

Signed-off-by: Jan Messer <jan@mtec-studios.ch>
 2023-04-06 23:03:33 +02:00
Vincent Petry
9f05eff3ef
Merge pull request #34607 from nextcloud/encryption-size-not-found 
fix encryption wrapper filesize for non existing files
 2023-04-06 18:04:44 +02:00
Robin Appelman
570b64aafc
handle not being able to write file for notify self-test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-06 11:52:22 +02:00
Robin Appelman
03e965a513
Merge pull request #22943 from nextcloud/scanner-no-access-handling 
improve handling of files we can't access in the scanner
 2023-04-05 21:36:21 +02:00
Côme Chilliet
e63a6f5cdb
Merge pull request #27538 from nextcloud/scanner-home-not-writable-better-errors 
better error messages if the users home is not writable during scanning
 2023-04-05 17:53:42 +02:00
Côme Chilliet
8d5165e8dc
Adapt tests to config value typing 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 17:42:14 +02:00
Robin Appelman
63fc83de26
Merge pull request #33292 from nextcloud/no-profiler 
don't hard error when trying to load profiles with no profiler registered
 2023-04-05 15:57:50 +02:00
Robin Appelman
c6be96d04f
additional logging when mkdir fails for object storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-05 14:52:19 +02:00
Robin Appelman
b1f352c614
improve handling of files we can't access in the scanner 
instead of erroring, remove the items from the cache.

this situation can be triggered if a user has access to a file but looses it afterwards

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-05 14:44:55 +02:00
Robin Appelman
54f61352f0
better error messages if the users home is not writable during scanning 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-05 13:21:30 +02:00
Côme Chilliet
426c0341ff
Use typed version of IConfig::getSystemValue as much as possible 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 12:50:08 +02:00
Côme Chilliet
8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup 
Tidy up typing in OC\Files\View
 2023-04-05 10:14:55 +02:00
Côme Chilliet
6633b4ced6
Remove unecessary fully qualified namespaces from phpdoc 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 09:13:39 +02:00
jld3103
d9f8522003
Fix types for reading and writing config values 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-05 09:08:56 +02:00
Robin Appelman
43b61d26e8
don't hard error when trying to load profiles with no profiler registered 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 17:24:29 +02:00
Robin Appelman
9d3c8b7e70
Merge pull request #36360 from nextcloud/new-share-existing-node 
also set the node when re-using existing share on share create
 2023-04-04 17:11:24 +02:00
Robin Appelman
5267a74027
fix type hints 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 17:05:45 +02:00
Robin Appelman
8c9197d65e
fix unencrypted folder size when no children with unencrypted size set are left 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 16:48:11 +02:00
Robin Appelman
649bed5154
fix unencrypted_size for files when scanning 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 16:48:11 +02:00
Robin Appelman
63fb33538c
fix unencrypted_size for folders when scanning the filesystem with encryption enabled 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 16:48:10 +02:00
Robin Appelman
15a6920b07
fix encryption wrapper filesize for non existing files 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 16:21:17 +02:00
Joas Schilling
131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-04 10:54:12 +02:00
Louis
7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value 
Migrate metadata JSON column to new value TEXT column
 2023-04-04 10:23:54 +02:00
Robin Appelman
d63fa2d991
improve objectstore rmdir handling 
remove folder entries as they are cleared instead of in one go afterwards

otherwise they stick around if some of the child entries can't be removed

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-03 18:28:29 +02:00
Robin Appelman
3473fa3187
also set the node when re-using existing share on share create 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-03 16:40:47 +02:00
Robin Appelman
5024f295dc
Merge pull request #36097 from nextcloud/path-prefix-optimize 
extend path-prefix optimizer to remove all cases of path_hash= when encountering a path prefix filter
 2023-04-03 16:39:49 +02:00
Rsplwe
5c6f35832c
Update lib/private/Files/ObjectStore/S3.php 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Rsplwe <i@rsplwe.com>
 2023-04-03 21:59:59 +08:00
Côme Chilliet
dbc0d6a1c2
Merge pull request #37543 from nextcloud/fix/inherited-parameter-names 
Fix inherited parameter names
 2023-04-03 15:08:45 +02:00
Joas Schilling
c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing 
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
 2023-04-03 14:19:41 +02:00
Louis Chemineau
1a6709cf43 Migrate metadata as JSON to value as STRING 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-04-03 14:06:28 +02:00
Arthur Schiwon
84c76a89ec
Merge pull request #37520 from nextcloud/fix/noid/fix-dbal-exception-handling 
fix DBAL exception handling in setValues
 2023-04-03 11:30:14 +02:00
Côme Chilliet
5ad045619c
View needs to return an instance of OC\Files\FileInfo explicitely 
Applications are calling methods from the class which are not from the
 public interface, and which cannot be added easily to public interface
 because Node interface extends FileInfo.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:35 +02:00
Côme Chilliet
0b3dad895f
More type cleanup in View and FileInfo 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:35 +02:00
Côme Chilliet
ea05544213
Fix return type of methods returning false on error 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
f974281ac9
Improve typing for fopen/toTmpFile 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
4393b96542
Remove unused method getLocalFolder 
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:33 +02:00
Julius Härtl
671d2726fa
Merge pull request #36652 from nextcloud/perf/autoloading/theming-authoritative-autoloader 
perf(autoloading): Add authoritative autoloader for theming
 2023-04-03 10:38:00 +02:00
Joas Schilling
454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-03 09:06:45 +02:00
jld3103
dcf6ebebab
Fix inherited parameter names 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-03 08:29:33 +02:00
Robin Appelman
c9e4e30523 clear encrypted flag when moving away from encrypted storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-01 15:36:37 +00:00
Rsplwe
d85e623916
s3: get remaining truncation part 
Signed-off-by: Rsplwe <i@rsplwe.com>
 2023-04-01 22:56:15 +08:00
Rsplwe
ccac296821
Adjust the value of 'maxparts' to 1000 
Signed-off-by: Rsplwe <i@rsplwe.com>
 2023-04-01 21:20:52 +08:00
Côme Chilliet
8104d9f5d8
Remove useless coalescing operator on non-null return value 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-01 14:20:26 +02:00
Côme Chilliet
da618c457a
Fix quota typing for 32bits after forward port from 25 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2023-04-01 14:20:25 +02:00
Côme Chilliet
3f84d41226
Silence a warning from psalm with explanation 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-01 14:20:25 +02:00
Côme Chilliet
1740311283
Adapt types of subclasses 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-01 14:20:24 +02:00
Côme Chilliet
ed863fb47c
Make it clear that file sizes may be float on 32bits 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-01 14:20:24 +02:00
Vincent Petry
c6b683342e
Remove quota value type for 32-bit systems 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2023-04-01 14:20:20 +02:00
Arthur Schiwon
997c2a2a79
fix DBAL exception handling in setValues 
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-03-31 17:01:17 +02:00
Julien Veyssier
636c2415cc
Merge pull request #37452 from nextcloud/fix/missing-interface-methods 
Add missing interface methods
 2023-03-30 14:55:51 +02:00
Simon L
2811532e83
Merge pull request #37378 from nextcloud/enh/noid/fix-avatar-generation 
fix the avatar generation on Alpine Linux
 2023-03-30 14:20:55 +02:00
Julius Härtl
5e7e3eb665
Merge pull request #37425 from nextcloud/fix/fix-since-version-number-for-app-loading 2023-03-30 13:20:11 +01:00
jld3103
02f9c3a06f
Use implementations instead of interfaces for accessing private methods 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-03-30 12:33:46 +02:00
Arthur Schiwon
488dde12cd
Merge pull request #37448 from nextcloud/fix/12281/hide-deleted-shared-groupfolder-files 
hide shared files located in group folder's trash bin
 2023-03-30 10:31:16 +02:00
Christopher Ng
4f8e916585 Add label for logo link 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-03-29 13:36:45 -07:00
Simon L
6a91d105b9 another approach to fixing the avatar generation 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-03-29 12:42:58 +02:00
Arthur Schiwon
28e7235f87
hide shared files located in group folder's trash bin 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-03-28 14:13:12 +02:00
Côme Chilliet
e94a689bca
Fix version number in phpdoc for app loading refactor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-27 14:27:23 +02:00
Joas Schilling
6741b37356
Merge pull request #37198 from nextcloud/bugfix/noid/reference-image-log 
fix(references): Do not log errors on 404 responses of opengraph image fetching
 2023-03-27 13:56:39 +02:00
Christoph Wurst
44dc839f7b
Revert "Dark autoloader magic for ThemingDefaults" 
This reverts commit 4e1d501696.
 2023-03-27 12:56:52 +02:00
Robin Appelman
36835b7fec
Merge pull request #36810 from nextcloud/setup-user-onetime-before-mounts 
do onetime user setup before getting any mount from providers
 2023-03-24 16:45:08 +01:00
Simon L
825f847ef1
Merge pull request #37234 from cob2p/bugfix/typo 
Fix the typo in comments
 2023-03-23 15:00:41 +01:00
Simon L
67614150b5
Merge pull request #36636 from nextcloud/fix/oc-image-getimagesize 
fix OC_Image: Prevent E_WARNING from getimagesize*
 2023-03-23 14:59:57 +01:00
Git'Fellow
c81ea3aa98
Fix RedisCluster 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-03-22 17:19:07 +01:00
Git'Fellow
fab390f884
Move from DEL to UNLINK 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-03-22 17:10:05 +01:00
Joas Schilling
014a634635
Merge pull request #37334 from nextcloud/bugfix/noid/mark-recording-servers-as-sensitive-due-to-secret 
fix(security): Mark recording_servers key appconfig as private as it …
 2023-03-22 10:27:39 +01:00
Julius Härtl
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts 2023-03-22 09:17:28 +01:00
Joas Schilling
381ab5f4cb
fix(security): Mark recording_servers key appconfig as private as it contains a secret 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-22 09:14:37 +01:00
Côme Chilliet
c60182065f
Merge pull request #34773 from nextcloud/artonge/feat/dispatch_entry_removed_event_for_all_entries 
Dispatch event for all removed entries
 2023-03-21 11:42:18 +01:00
Côme Chilliet
13c71ed24a
Small cleanups for AppManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:21:45 +01:00
Côme Chilliet
78c1716818
Move loadApps to the AppManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:21:45 +01:00
Côme Chilliet
8dc5f82189
Move isType to AppManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:21:45 +01:00
Côme Chilliet
a224551132
Avoid calling Server::get more times than necessary in loadApp 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:21:42 +01:00
Côme Chilliet
f0bdf2a4cd
Strong type private properties and methods in AppManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:19:42 +01:00
Côme Chilliet
71ed968e34
Switch away from Server::get for AppManager and logger in loadApp 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:17:28 +01:00
Côme Chilliet
a7c8090dc3
Move loadApp function to the AppManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:01:17 +01:00
Joas Schilling
bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute 
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
 2023-03-16 19:33:13 +01:00
Christoph Wurst
416c824c74 perf(autoloader): Drop legacy class autoloader 
The documentation says apps should use PSR-4 to get their classes
loaded. The legacy PSR-0 is still in place and has a negative impact on
performance.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-03-16 12:02:09 +00:00
Marcel Klehr
4a2accaa27 fix OC_Image: Prevent E_WARNING from getimagesize* 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-03-16 11:10:36 +00:00
Julius Härtl
c7c1133c15
Merge pull request #35561 from nextcloud/create-user-transaction 2023-03-15 15:13:50 +01:00