Commit graph

13522 commits

Author SHA1 Message Date
Maxence Lange
0fdd3d19a6 fix(share): use share owner to confirm reshare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-20 11:13:14 +00:00
Christoph Wurst
112b8bcbfb fix(config): Make sure user keys are strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-19 17:32:57 +00:00
Robin Appelman
406a59ccae
fix: add some recrusive detection/prevention
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-19 15:02:30 +01:00
Robin Appelman
1569469b70 fix: ensure nested mount points are handled in the correct order
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-18 18:01:53 +00:00
John Molakvoæ
0a83448c4b
Merge pull request #44079 from nextcloud/backport/43992/stable27 2024-03-16 13:13:17 +01:00
Benjamin Gaussorgues
63e5b6fb95 fix: avoid scanning a non existing directory
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-03-14 18:45:53 +00:00
hopleus
deeca104f0 Refactoring getName function
Signed-off-by: hopleus <hopleus@gmail.com>
2024-03-14 14:53:43 +00:00
hopleus
591c2cb01a Fixes for getting the file name in the cases when the file name key is received, but it is empty
Signed-off-by: hopleus <hopleus@gmail.com>
2024-03-14 14:53:43 +00:00
Julius Härtl
29511d85f3 fix: Avoid clear cache with prefix
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-08 08:41:02 +00:00
Julius Härtl
0b1fcf0a5c fix: Fetch custom app store url without internet connection
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-04 20:18:32 +00:00
Louis Chemineau
dee1181e3b
Use table prefix in metadata migration
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-03-04 12:21:18 +01:00
John Molakvoæ
3ecaeb6f2b
Merge pull request #43901 from nextcloud/backport/30957/stable27 2024-02-29 12:05:45 +01:00
John Molakvoæ
7b9fed1cb5
Merge pull request #43789 from nextcloud/backport/39607/stable27 2024-02-29 11:36:12 +01:00
John Molakvoæ
9b326c0c6d
Merge pull request #43830 from nextcloud/backport/43787/stable27 2024-02-29 11:26:23 +01:00
Git'Fellow
477c020db8
Fix backport
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-29 10:37:00 +01:00
Claus-Justus Heine
5b35240c67 fix(collaboration): collaboration MailPlugin: Protect access to a potentially missing array component by ??.
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2024-02-29 07:51:24 +00:00
Benjamin Gaussorgues
1b30da153c feat(share): save date and time for expiration
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-26 09:10:26 +00:00
Julius Härtl
d718a2adb1 fix: Throw instead of yielding nothing when listing local directories
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-02-26 07:45:04 +00:00
John Molakvoæ
a891cbc21b
Merge pull request #43580 from nextcloud/artonge/fix/metdata_column_migration 2024-02-22 20:33:42 +01:00
John Molakvoæ
87fc74841e
Merge pull request #41006 from nextcloud/backport/40879/stable27 2024-02-22 18:50:08 +01:00
Louis Chemineau
261efaafd3
Move oc_file_metadata.metadata migration to a background job
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-22 18:12:30 +01:00
Git'Fellow
ebcd8c0a47 Move away from deprecated utf_encode() on PHP 8.2+
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-20 08:37:05 +00:00
Git'Fellow
7f0a4e786c Lower failed movie preview to info
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-10 12:47:07 +00:00
Benjamin Gaussorgues
d3252caeed
Merge pull request #43038 from nextcloud/fix/36463/preview-not-generated-stable27 2024-02-09 11:26:59 +01:00
Christoph Wurst
bcd7d59a20 fix(session): Do not log fresh/empty session as error
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-09 11:10:28 +01:00
Christoph Wurst
db8252e82c fix(session): Log when crypto session data is lost
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-09 11:10:28 +01:00
Benjamin Gaussorgues
92df765457
Merge pull request #43246 from nextcloud/backport/41327/stable27 2024-02-09 10:31:11 +01:00
Git'Fellow
ef786616ec
Merge pull request #43390 from nextcloud/backport/43131/stable27
[stable27] fix(files): Don't attempt to format a partial cache entry
2024-02-09 10:25:03 +01:00
Robin Appelman
00b9002785 continue background scanning different storages if one fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-07 09:07:40 +00:00
Christoph Wurst
d4e01fb0a1 fix(files): Don't attempt to format a partial cache entry
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-06 12:52:45 +00:00
Robin Appelman
226fa9b039 make failure to load app commands non-fatal
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-02 15:00:52 +00:00
Robin Appelman
7c8d71d0a0 also updated parent etags when a changed etag is detected during scanning
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:28:05 +00:00
Robin Appelman
90c57a6700 dont reuse etag for folders marked explicitly unscanned
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:28:05 +00:00
Arthur Schiwon
9ec107ad25
Merge pull request #43182 from nextcloud/backport/42930/stable27
[stable27] Fix: config param 'overwritecondaddr' not working
2024-01-30 16:33:37 +01:00
Ferdinand Thiessen
36a658e987 fix(Request): Catch exceptions in isTrustedProxy
The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw.
But as it is used by `getRemoteAddress` which is used by logging / templating, thrown errors are not reported but silently fail with error 500.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-29 15:24:21 +00:00
Pavel Kryl
6c9f968888 code style: ommited space, reverted [code review] 2024-01-29 09:59:35 +00:00
Pavel Kryl
55991f93c2 fixing bug #6914: Config Param 'overwritecondaddr' not working
- just ignoring/removing extra parameter 'protocol' as suggested by
  blizzz

Signed-off-by: Pavel Kryl <pavel@kryl.eu>
2024-01-29 09:59:35 +00:00
Marcel Müller
f0146b6f4a fix(preview): Check if node id is null before deleting the preview folder
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-01-22 20:55:15 +01:00
Christoph Wurst
fdfd620757 fix(auth): Fix logging in with email, password and login name mismatch
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-22 09:43:25 +00:00
Arthur Schiwon
448dc1530f
Merge pull request #42870 from nextcloud/backport/42607/stable27
[stable27] fix(session): Avoid useless authtoken DB queries for anonymous requests
2024-01-17 20:45:41 +01:00
Joas Schilling
1839d0ca87
Merge pull request #42873 from nextcloud/backport/42658/stable27
[stable27] fix(systemreport): Mark more configs as sensitive
2024-01-17 13:26:24 +01:00
Joas Schilling
fabb330a69
fix(systemreport): Mark more configs as sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-17 10:31:29 +01:00
Git'Fellow
27af03c92d fix(session): Avoid two useless authtoken DB queries for every anonymous request
Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-17 09:27:17 +00:00
Git'Fellow
e958966288 Lower to info
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-17 09:41:33 +01:00
Git'Fellow
00b0a33e50 Lower error to warning
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-17 09:41:33 +01:00
Git'Fellow
a7be838323
Merge pull request #42828 from nextcloud/backport/41272/stable27
[stable27] fix: reduce memory consumption of scans
2024-01-16 19:16:20 +01:00
Joas Schilling
0148dab1e7
fix(appstore): Only send subscription keys to valid appstores
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-16 10:16:38 +01:00
Git'Fellow
6b496ab164
fix: reduce memory consumption of scans
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Fix lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-16 09:29:09 +01:00
Richard Steinmetz
94d7e459bc
fix: handle exif metadata read errors gracefully
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-01-15 11:21:22 +01:00
Julius Härtl
5fc6fb0d20
fix: Only apply cast if needed when searching users for value
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-09 11:56:46 +01:00
Julius Härtl
9112904206
perf: Use more performant way to obtain and check the email as a login name with token login
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-09 11:56:45 +01:00
Robin Appelman
0e8367b100
Merge pull request #42522 from nextcloud/backport/41914/stable27
[stable27] only do a multipart s3 copy when above the regular copy limit
2024-01-02 18:00:31 +01:00
Robin Appelman
4b74d315b6
adjust redis compareSetTTL to use a lua script
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-02 15:40:34 +01:00
Robin Appelman
0e98f1eb8d
restore shared lock ttl when releasing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-02 15:40:32 +01:00
Alexander Piskun
12257ac765
AppAPI: allowed to bypass Two-Factor
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>

fix php-cs

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2023-12-29 14:46:58 +02:00
Julius Härtl
f5fe531665 fix(s3): Add config option to disable multipart copy for certain s3 providers
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-29 10:48:40 +00:00
Robin Appelman
ad5be4f04b only do a multipart s3 copy when above the regular copy limit
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-29 10:48:40 +00:00
Git'Fellow
26068baa4a Read Only FS return false
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-12-19 21:09:31 +00:00
Arthur Schiwon
d3127983bf
Merge pull request #42085 from nextcloud/backport/41999/stable27
[stable27] fix(security): Handle idn_to_utf8 returning false
2023-12-07 10:03:13 +01:00
Arthur Schiwon
41f31f2e1c
Merge pull request #42078 from nextcloud/backport/40071/stable27
[stable27] fix(updatecheck): Don't wait 120s for a response of updater.nextcloud…
2023-12-07 10:00:26 +01:00
Joas Schilling
6b895462ac
fix(security): Handle idn_to_utf8 returning false
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-07 06:39:34 +01:00
Joas Schilling
58072190dd
fix(systemreport): Mask onlyoffice secret as sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-07 06:25:30 +01:00
Joas Schilling
838669242b
fix(updatecheck): Don't wait 120s for a response of updater.nextcloud.com
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-07 06:19:05 +01:00
staticdev
572890defe
Merge branch 'stable27' into backport/39044/stable27 2023-12-05 18:58:46 +01:00
John Molakvoæ
2e9f364aa6
Merge pull request #41970 from nextcloud/fix/login-csrf-check-error-message-stable27 2023-12-05 11:26:05 +01:00
Robin Appelman
15bed77a22 setup filesystem wrappers before we mark the root as setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-05 09:47:03 +01:00
Robin Appelman
fbc0f65711 add more checks to ensure mounts aren't empty
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-05 09:47:03 +01:00
Arthur Schiwon
870f227428
Merge pull request #41626 from nextcloud/backport/41616/stable27
[stable27] fix: Fix linkToOCSRouteAbsolute() without index.php and with subfolder
2023-12-04 21:13:14 +01:00
Arthur Schiwon
c4ede819f7
Merge pull request #41557 from nextcloud/backport/41541/stable27
[stable27] Serve .flac audio files
2023-12-04 21:05:22 +01:00
Christoph Wurst
32a02b0ec7 fix: Show error message when CSRF check fails at login
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-12-04 19:09:01 +00:00
Marcel Klehr
76265de3f1 fix(TemplateManager): Bail early if templatedirectory is empty
fixes #39266

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-04 10:12:53 +00:00
Simon L
c78141cec9
Merge pull request #41608 from nextcloud/backport/41544/stable27
[stable27] do not write htaccess file if disk space is too low
2023-11-28 18:02:50 +01:00
Arthur Schiwon
52eddf8675
Merge pull request #41462 from nextcloud/backport/40996/stable27
[stable27] reuse sharing disabled state when listing folder content
2023-11-28 11:33:04 +01:00
Joas Schilling
5d12f12319 fix: Fix linkToOCSRouteAbsolute() without index.php and subfolder
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-20 16:15:39 +00:00
Simon L
2d2c679931 do not write htaccess file if disk space is too low
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-11-20 07:26:42 +00:00
Marcel Müller
3656eb4b8a Serve .flac audio files
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2023-11-16 19:53:10 +00:00
Arthur Schiwon
ec84b5c4ee
Merge pull request #41539 from nextcloud/backport/37959/stable27
[stable27] Check for open_basedir before reading /proc
2023-11-16 20:29:57 +01:00
Robin Appelman
43ef6da11e
optimize UserMountCache::registerStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-16 16:40:57 +01:00
Benjamin Gaussorgues
902ba76d30
Merge pull request #41502 from nextcloud/backport/40935/stable27
[stable27] add some support for rename on case insensitive local filesystems
2023-11-16 16:34:12 +01:00
Benjamin Gaussorgues
1af4301997
Merge pull request #41363 from nextcloud/optmize-storage-wrappers-27
[27] optimize builtin storage wrappers
2023-11-16 14:21:56 +01:00
Git'Fellow
febc24db13 Us strpos() only
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-16 12:59:56 +00:00
Git'Fellow
4b97e1614b Check for open_basedir before reading /proc
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-16 12:59:55 +00:00
Joas Schilling
335369f3f4
Reverse X-Forwarded-For list to read the correct proxy remote address
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 07:48:09 +01:00
Git'Fellow
26e24dc909
Merge pull request #41482 from nextcloud/backport/41366/stable27
[stable27] fix(s3): support SSE-C headers for the MultipartCopy call
2023-11-16 00:20:32 +01:00
Arthur Schiwon
ef70f798b5
Merge pull request #41383 from nextcloud/backport/41302/stable27
[stable27] Lower log level about invalid session token
2023-11-15 22:41:09 +01:00
Arthur Schiwon
501858dd63
Merge pull request #41238 from nextcloud/backport/40859/stable27
[stable27] fix(session): Log why session renewal failed
2023-11-15 22:35:30 +01:00
Arthur Schiwon
ddf34961a0
Merge pull request #41231 from nextcloud/backport/40819/stable27
[stable27] Catch Imaginary processing errors
2023-11-15 22:34:37 +01:00
Robin Appelman
482deca354
add some support for rename on case insensitive local filesystems
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-15 15:21:14 +01:00
Benjamin Gaussorgues
11764ffec1
Merge pull request #41212 from nextcloud/backport/fix/aborted_pgsql_transaction_on_error/stable27
[stable27] fix(twofactor): avoid DB error on Twofactor (en/dis)abled event #40472
2023-11-15 09:03:02 +01:00
Tobias Zimmerer
8970f96e3b fix(s3): support SSE-C headers for the MultipartCopy call
Signed-off-by: Tobias Zimmerer <3228193+ir0nhide@users.noreply.github.com>
2023-11-15 07:37:09 +00:00
Robin Appelman
0c88d5b303 reuse sharing disabled state when listing folder content
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-14 14:28:16 +00:00
Arthur Schiwon
712a4c8e10
Merge pull request #41429 from nextcloud/backport/41417/stable27
[stable27] fix(workflowengine): use andWhere() not second where()
2023-11-13 20:15:42 +01:00
Arthur Schiwon
bf301df539 fix(workflowengine): use andWhere() not second where()
- an unconditional where() condition is added right before
- fixes also wrongly named methods in the Exception message

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-11-13 14:13:01 +00:00
Joas Schilling
32ada27ed6 fix(log): Log exception class when message is empty
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-13 13:54:59 +00:00
Patrick Fischer
b79f58933b Lower log level about invalid session token 2023-11-10 15:59:14 +00:00
Marcel Klehr
8e29b026aa
Merge pull request #41359 from nextcloud/backport/41295/stable27
[stable27] fix(JobList#hasReservedJob): Break tie when multiple jobs are reserved
2023-11-10 14:33:49 +01:00
Robin Appelman
81d625d44d
optimize isShared and isMounted
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-09 15:42:41 +01:00
Robin Appelman
bdba3f1e2f
optimize builtin storage wrappers
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-09 15:41:01 +01:00
Robin Appelman
6250c7d3a9
Merge pull request #41324 from nextcloud/backport/40995/stable27
[stable27] optimize cache jail creation
2023-11-09 15:30:43 +01:00
Marcel Klehr
4e15a25933 fix(JobList#hasReservedJob): Break tie when multiple jobs are reserved
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-11-09 12:47:35 +00:00