Commit graph

417 commits

Author SHA1 Message Date
John Molakvoæ
ef760e0337
Add admin user customization kill switch
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-19 12:57:35 +02:00
Christopher Ng
3ead19d997 Add a repair step to cleanup old theming cache
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-18 01:19:47 +00:00
Vincent Petry
19f35f42bc
Improve cache buster for user backgrounds
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-10-14 16:18:41 +02:00
John Molakvoæ
ac21c631a6
Fix migration
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-14 16:18:40 +02:00
John Molakvoæ
a8e90a03fc
Properly use user background cachebuster
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-14 16:18:40 +02:00
John Molakvoæ
e4ff84d468
Scope the appdata theming storage for global and users
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-14 16:18:37 +02:00
Vincent Petry
c0c0387b8e
Merge pull request #34461 from nextcloud/fix/migrate-background
Fix missing background on upgrade
2022-10-13 20:10:57 +02:00
Simon L
b28757fddc
Merge pull request #34437 from nextcloud/feat/theming-default-system-value
Use default system primary
2022-10-13 19:57:28 +02:00
Arthur Schiwon
59e07102ed
graceful background image handling
- fallback to background image from old location
- migrate background images to new location as insensitive job

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-10-13 17:51:30 +02:00
John Molakvoæ
2f8601a27e Adjust testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-10-13 14:31:20 +00:00
John Molakvoæ
9d0f529f1b
Merge pull request #34546 from nextcloud/improve-hight-contrast
Add seperator in high contrast mode
2022-10-13 12:17:54 +02:00
John Molakvoæ
9a92fe9b29
Fix primary and debounce to avoid infinite loop
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-13 12:13:39 +02:00
John Molakvoæ (skjnldsv)
db831359d3
Allow to pick custom colour
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-10-13 12:13:39 +02:00
John Molakvoæ (skjnldsv)
4b46c5a5a0
Use default system primary
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-10-13 12:13:39 +02:00
Simon L
cbe228ae3a
Merge pull request #34545 from nextcloud/fix/theming-highcontrast-translucency-off
Disable translucency on high contrast themes
2022-10-13 00:56:57 +02:00
szaimen
f1b38426e2 fix color-main-background-rgb
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-12 11:59:16 +02:00
Christopher Ng
8c4de8f3bc Add color variables for text on blurred background
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-12 01:43:37 +00:00
Carl Schwan
8a8f150ffb Add seperator in high contrast mode
Between navigation and content and between entry in breadcrump

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-11 23:44:35 +02:00
Carl Schwan
0a5d459c99 Disable translucency on high contrast themes
Fix #34514

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-11 23:15:33 +02:00
Christopher Ng
46ee620150 Fix excessive increase of cachebuster value
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-11 16:25:42 +00:00
Christopher Ng
7044191eb6 Use brand color for background only and keep accessible color as color primary
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-05 06:19:08 +00:00
Christopher Ng
e962d3fba4 Use color preset of shipped background as primary color
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-05 06:19:08 +00:00
szaimen
9d4d95a94c fix the tertiary button text
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-30 17:50:48 +02:00
Simon L
fafc1ee807
Merge pull request #34287 from nextcloud/enh/33836/fix-theme
fix highcontrast theme
2022-09-28 20:35:07 +02:00
Christopher Ng
295d03869e Fix various theming bugs
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-28 17:12:56 +00:00
szaimen
c9a372034f fix highcontrast theme icons
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-27 13:52:49 +02:00
Christopher Ng
67742884b7 Add preset primary colors for shipped backgrounds
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-27 00:56:58 +00:00
John Molakvoæ
b8912153db
Merge pull request #34210 from nextcloud/fix/theming
Fixing missing theming variables
2022-09-24 07:35:34 +02:00
John Molakvoæ
7a43559197
Refactor primary computation and fix a few missing theme parity variables
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-09-23 15:48:45 +02:00
John Molakvoæ
0b23ad9256
Disable background blur on highcontrast
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-09-23 15:01:38 +02:00
John Molakvoæ
48f324fcb1
Fixing dark primary element variables
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-09-23 14:58:40 +02:00
Vincent Petry
b8dbbb177d
Fix loading custom background
Fix the route for loading the custom background.
Because the controller is UserThemeController, so the route path is
not "theming" but "userTheme".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-23 11:19:38 +02:00
szaimen
310ccfa14e update theming icon in personal settings
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-21 11:26:08 +00:00
Joas Schilling
7672152579
Add a global setting to disable keyboard shortcuts
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-15 10:52:55 +02:00
greta
02cc42d40a Move background settings from dashboard app to Appearance and accessibility settings
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-14 20:17:01 +00:00
Simon L
2a2cb01696
Merge pull request #33952 from nextcloud/enh/33850/scrollbar-visibility
fix scrollbar visiblity
2022-09-08 10:18:58 +02:00
szaimen
4636524b7e fix scrollbar visiblity
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-07 23:21:35 +02:00
greta
7e5d973e7e Remove non existing lighter colour
Signed-off-by: greta <gretadoci@gmail.com>
2022-09-07 16:01:41 +02:00
szaimen
d9b463c20a fix dark-contrast-theme
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-06 18:03:35 +00:00
szaimen
7dd7d4d63d fix background shadow
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-05 17:47:07 +02:00
Julius Härtl
b6a6802857
Some more fixes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-09-01 14:15:42 +02:00
Julius Härtl
ac134f5f47
Restore dashboard layout
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-09-01 14:15:40 +02:00
Julius Härtl
e4113b1779
Adapt layout to new base css variables
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-09-01 14:15:39 +02:00
Julius Härtl
cc21ea6419
Fix gradient using the wrong target value
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-26 14:48:38 +02:00
Julius Härtl
9fc52ed491
Properly align element variables to the regular ones
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-26 13:31:26 +02:00
Julius Härtl
57233fd99a
Expose core background image
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-19 11:55:10 +02:00
Julius Härtl
4be6280aa9
Add css variables for blurred background
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-19 11:55:04 +02:00
John Molakvoæ
601664bc84
Allow to manually specify a theme to apply to a section of an app
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-08-16 14:43:35 +02:00
John Molakvoæ
5f3229ed67
Automatically enable plain background if primary colour is set
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-08-16 09:39:00 +02:00
John Molakvoæ
0ea23cad0e
Revert "Fix unit tests for the theming app"
This reverts commit 13ca01ee12.
2022-08-16 08:51:43 +02:00
John Molakvoæ
4c6be330ef
Revert "First first run wizzard"
This reverts commit ba3f5337f3.
2022-08-16 08:30:08 +02:00
Carl Schwan
13ca01ee12
Fix unit tests for the theming app
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-11 18:02:23 +02:00
Vincent Petry
684cc097f4
Merge pull request #33452 from nextcloud/fix/firstrunwizzard
Fix first run wizzard
2022-08-10 22:35:55 +02:00
Joas Schilling
05d034a6da
Allow to invert when on bright
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-08 12:56:31 +02:00
Carl Schwan
ba3f5337f3
First first run wizzard
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 15:51:02 +02:00
Julius Härtl
3f63724c2d
Properly set --color-primary-light-hover on dark themes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-07-16 09:47:22 +02:00
Carl Schwan
4e0574e184 Port encryption admin settings to vue
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-13 14:58:55 +02:00
John Molakvoæ
d64a63abc6
Properly calculate primary element based on background luminance
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-20 08:42:32 +02:00
John Molakvoæ
264adf0c3b
Fix profile and add gradient-primary-background
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:13:01 +02:00
John Molakvoæ
73918b8af9
Cleanup and compile
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:13:00 +02:00
John Molakvoæ
4e7989a83e
Fix dark theme description
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-01 10:23:02 +02:00
John Molakvoæ
f577b5dc96
Fix theming setEnabledThemes unique array
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-30 13:40:27 +02:00
John Molakvoæ
24c5d994c7
Allow to override the default theme
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-30 13:40:27 +02:00
John Molakvoæ
5e8a3eb66c
Fix header apps icons
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-28 18:12:29 +02:00
John Molakvoæ
7c5bb555e7
Fix logo colour on bright primary colour
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-28 18:11:30 +02:00
John Molakvoæ
4a646789c3
Add system/light themes
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-28 08:41:58 +02:00
John Molakvoæ
4dc96dd165
Fix mix factor
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-26 09:22:43 +02:00
John Molakvoæ
d9b77bc2eb
Fix dark theme primary mix
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-26 09:00:11 +02:00
John Molakvoæ
f7f4d36a37
Fix dyslexia font loading
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-22 13:04:15 +02:00
John Molakvoæ
850d8ac1cd
Add default theming disabled fallback
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-22 11:24:25 +02:00
John Molakvoæ
d1dfdfe799
Lint and psalm fix
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:29 +02:00
John Molakvoæ
3c75a99267
Phpunit
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:28 +02:00
John Molakvoæ
1dee36c761
Remove accessibility
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:28 +02:00
John Molakvoæ
7b686abe7f
Migrate old accessibility config
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 09:31:07 +02:00
John Molakvoæ
493b20605f
Font fixes and design update for theme picker
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 09:31:07 +02:00
John Molakvoæ
9ea72b1010
Migrating themes to Theming app
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 09:31:07 +02:00
John Molakvoæ
69d1d1a84e
Write body theme selector straight in the template
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 09:31:07 +02:00
John Molakvoæ
fa18a77fa2
Fix twofactor loading and public image
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 09:31:06 +02:00
John Molakvoæ (skjnldsv)
a1aaaaa0c8
Update and fix theming images
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-04-21 09:31:06 +02:00
Joas Schilling
b3cf312edc
Start theming providers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-21 09:29:33 +02:00
Carl Schwan
7dddbd0c35 Improve caching policy
* Cache css with version in url. This makes most js and css requests to
  be cached by the browser

* Force caching previews, the etag is in the url so that if the propfind
  gives a new etag, we will refresh it otherwise it's no use to try to
  fetch the new etag and do tons of DB queries

Tested with firefox and 'debug' => false (important so that the js/css
urls are generated with ?v= parameter)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-16 11:35:57 +01:00
Julius Härtl
3d0b5c1ff9
Avoid file system access on checking if an image exists
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-02 11:26:36 +01:00
Carl Schwan
760db78dba
Add better error handling
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-27 17:03:09 +01:00
Carl Schwan
f778cbe7b9
Fix registerEventListener issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-27 11:12:45 +01:00
Carl Schwan
e3a12b3482
Fix psalm issues in theming app
After this change, we are down to only one psalm warning for this app
and related to the Application.php. This also make composer
psam:update-baseline not silently ignore new errors.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-26 14:26:58 +01:00
John Molakvoæ (skjnldsv)
dd7bf0f902
Fix dynamic loading
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:14:53 +01:00
Carl Schwan
dfb569f097
Follow upstream security recommandation
See https://scssphp.github.io/scssphp/docs/#security-considerations

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-12-02 15:57:53 +01:00
Carl Schwan
324e0dc36c
Add rgb to hsl converter
This ports away from using now internal functions from scssphp.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-12-02 11:53:34 +01:00
Côme Chilliet
113756db30
Fix ArrayAccess and JsonSerializable return types
First round of modifications for PHP 8.1

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:56 +01:00
Joas Schilling
615a8e60ba
App summary is optional
Fixing:
Error: Undefined index: summary at /var/www/html/apps/theming/lib/Controller/ThemingController.php#392

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-19 14:02:03 +01:00
Carl Schwan
a67a12cb96
Merge pull request #29240 from nextcloud/work/admin-delegation-implementation
Add support for Delegation Settings for more apps
2021-10-15 20:59:43 +02:00
Carl Schwan
719dbafd13
Add support for Delegation Settings for more apps
* This adds support for the sharing, groupware, theming and user_ldap
  app
* This adds some code who disapeared during a rebase in the initial
  delegation PR (provisioning_api)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-10-15 18:41:00 +02:00
Joas Schilling
da73990d1c
Don't setup the filesystem to check for a favicon we don't use anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-13 15:45:42 +02:00
Joas Schilling
37f40cdd46
Fix translated app details
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-09-30 09:08:17 +02:00
szaimen
0758e0258d improve webmanifest
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-08-24 11:42:04 +02:00
Julius Härtl
3860dad9ea
Merge pull request #26481 from ghost/fdroid 2021-07-13 08:49:59 +02:00
MichaIng
af61ac6a7a Fix Psalm code scanning alerts
InvalidScalarArgument (apps/theming/lib/IconBuilder.php#L213): https://github.com/nextcloud/server/security/code-scanning/6691
InvalidScalarArgument (apps/theming/lib/IconBuilder.php#L213): https://github.com/nextcloud/server/security/code-scanning/6692
MissingReturnType (apps/theming/lib/IconBuilder.php#L226): https://github.com/nextcloud/server/security/code-scanning/6693
MissingParamType (apps/theming/lib/IconBuilder.php#L226): https://github.com/nextcloud/server/security/code-scanning/6694
MissingParamType (apps/theming/lib/IconBuilder.php#L226): https://github.com/nextcloud/server/security/code-scanning/6695
PossiblyFalseArgument (apps/theming/lib/IconBuilder.php#L232): https://github.com/nextcloud/server/security/code-scanning/6696

Signed-off-by: MichaIng <micha@dietpi.com>
2021-07-12 20:05:44 +02:00
HouraisanNEET
0ba0189260 Add F-Droid
Signed-off-by: HouraisanNEET <HouraisanNEET@users.noreply.github.com>
2021-07-04 21:44:55 +08:00
Joas Schilling
080e26fb80
Validate the theming color also on CLI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-25 16:58:29 +02:00
Morris Jobke
f6108acea4
Fix default product name for old themes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-06-16 15:52:49 +02:00