upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
87736 commits 985 branches 1211 tags 9.7 GiB
Commit graph

563 commits

Author SHA1 Message Date
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 13:24:18 +02:00
Robin Appelman
7cb07bf306 test: add test for nested jail cross-storage move 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-10 15:16:12 +02:00
provokateurin
f28e74b7a8
refactor(Storage): Make all parameter types strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:05 +02:00
provokateurin
4412b2b8a8
refactor(Wrapper\Encryption): Migrate to strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 14:11:56 +02:00
provokateurin
d1977b8d25
refactor(Stream\Encryption): Migrate to strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 14:02:27 +02:00
provokateurin
256a8d8903
test: Fix IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:48 +02:00
Côme Chilliet
4adf5fd5b0
fix(tests): Pause trashbin for lock tests in ViewTest using rmdir and unlink 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-24 10:37:38 +02:00
Côme Chilliet
40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface 
fix: Move storage constructor to specific interface
 2024-09-23 15:57:38 +02:00
Côme Chilliet
b8ab560bdd
fix(tests): Fix test to remove call to non-existing constructor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-23 14:50:43 +02:00
Louis Chemineau
22d5d29c01 fix(users): Don't crash if disabled user is missing in the database 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-23 10:40:38 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Robin Appelman
1db3d94e1e test: put parent items into cache in tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 16:10:14 +02:00
Robin Appelman
74adaebf96 test: fix incorrect ltrim usage in test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 14:11:27 +02:00
Côme Chilliet
cfca7e7911
fix(tests): Fix most obvious errors in ObjectStore tests 
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-17 19:20:13 +02:00
Côme Chilliet
2bdc97741c
fix(tests): Fix Folder tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-17 19:19:08 +02:00
Stephan Orbaugh
f25acfb799
Merge pull request #47986 from cfiehe/fix_move_on_same_bucket 
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
 2024-09-17 16:35:19 +02:00
Côme Chilliet
22822d5e9b
fix: Fix other uses of removed Storage interface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:36 +02:00
Côme Chilliet
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:10:48 +02:00
Christoph Fiehe
9597072ada perf(ObjectStoreStorage): Improve (slow) move on same object bucket 
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
 2024-09-16 15:11:09 +02:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Anna Larch
6c36c54dc6 feat(db): switch from settype to casts 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-15 19:26:58 +02:00
Git'Fellow
0308001118 fix(files): Check if the target path is a descendant of the shared folder path 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests
 2024-09-05 23:54:01 +02:00
Anna Larch
8af7ecb257 chore: adjust code to adhere to coding standard 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-05 21:23:38 +02:00
Kate
09fef8f0ec
Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents 2024-09-04 20:00:24 +02:00
Andy Scherzinger
bfb5835750
Merge pull request #47546 from nextcloud/fix/files-view-error-messages 
fix: Adjust filename validation messages
 2024-08-29 23:28:50 +02:00
Ferdinand Thiessen
030c209d22 fix: Renaming does not need update but delete permissions 
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 17:22:20 +02:00
Louis Chemineau
2574cbfa61
chore: Apply php:cs recommendations 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-08-28 10:44:18 +02:00
Robin Appelman
62f8b6517f
feat: implement distributing partitioned queries over multiple shards 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-28 10:21:19 +02:00
Ferdinand Thiessen
81c6c24cd5
fix: Adjust filename validation messages 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-27 23:12:24 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
provokateurin
ebfbe99652
fix(files): Create non-existent parents of mountpoints 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-08-22 12:04:31 +02:00
Joas Schilling
e1caa198e3
ci: Skip flaky test on PHP 8.3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-08-21 13:13:12 +02:00
Ferdinand Thiessen
b9cc7bcec7
fix: FilenameValidator::isForbidden should only check forbidden files 
And not forbidden basenames as this is used for different purposes.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-21 04:16:14 +02:00
John Molakvoæ
d35c4eb911
Merge branch 'master' into jr-readdir-false-false 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-08-16 10:53:50 +02:00
Ferdinand Thiessen
21f558b12b
Merge pull request #46379 from nextcloud/fix/folder-search-owner 
fix: `OCP\Files\Node\Folder::search` was not setting the owner
 2024-07-30 13:04:15 +02:00
Joas Schilling
829f2b9bc7
fix(db): Promote the use of getDatabaseProvider to reduce the impage of removed upstream platforms 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-07-19 11:21:14 +02:00
Robin Appelman
c5b687271b
fix: make batch propagator work with sharding restrictions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 19:16:07 +02:00
Robin Appelman
0931492ff0
fix: make usermountcache compatible with sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 19:16:05 +02:00
Ferdinand Thiessen
322b3946d9
fix(dav): Verify target path in setName instead of source path 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-16 12:57:11 +02:00
Ferdinand Thiessen
69341e4306
refactor: Migrate filename validation logic from Storage to FilenameValidator 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-16 12:49:09 +02:00
Ferdinand Thiessen
bdbeabafa7
feat: Add forbidden_filename_basenames config option 
This allows to configure forbidden filenames (the full filename like `.htaccess`)
and also forbidden basenames like `com0` where `com0`, `com0.txt` and `com0.tar.gz` will match.
We need this as only using basenames was too restrictive and will cause problems on some systems when updating.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-15 19:39:18 +02:00
Ferdinand Thiessen
cf935e33ae
fix: OCP\Files\Node\Folder::search was not setting the owner 
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-11 15:46:44 +02:00
Ferdinand Thiessen
46f1efac41
feat: Add IFilenameValidator to have one consistent place for filename validation 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-09 15:04:34 +02:00
Andy Scherzinger
1f7e2ba599
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-13 17:41:36 +02:00
Robin Appelman
88ccea6d06
test: add test for jail watcher 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-04-08 18:42:44 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
John Molakvoæ
5a1ed2d9ea
Merge pull request #40131 from summersab/refactor/OC-Server-getShareManager 2024-03-15 16:05:59 +01:00
Andrew Summers
45eb4a839d Refactor OC\Server::getLockingProvider 
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
 2024-03-15 13:11:33 +01:00
John Molakvoæ
9338ef36de
Merge branch 'master' into refactor/OC-Server-getShareManager 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-03-15 13:03:34 +01:00
Thomas Citharel
ffeb797ecc
refactor(mimeloader): modernize MimeTypeLoader 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2024-03-14 17:24:36 +01:00
Maxence Lange
467c84ec53 feat(files): copy live photos 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-03-08 13:09:22 -01:00
Robin Appelman
51019fda7a fix: clearify logic around getMountsForFileId filtering 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-06 10:54:00 +01:00
Robin Appelman
fd4ca13867
Merge pull request #43471 from nextcloud/cache-path-by-id 
Cache path by id
 2024-03-05 17:26:25 +01:00
Dariusz Olszewski
277a6fc7ea test: Additional tests for issue #35776 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2024-03-04 14:25:52 +01:00
Robin Appelman
a9ee278ec6 perf: cache path by id to speedup getting nodes by id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-04 13:57:31 +01:00
Ferdinand Thiessen
27642d3e6d fix: Enforce forbidden filename characters on backend 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-02-28 22:19:25 +01:00
Robin Appelman
3890aa54be
add some comments for the distributive operation and add another test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-16 10:59:33 +01:00
Robin Appelman
1c87cee5ad
add extra flatten step to improve "or eq" -> "in" optimization 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-15 17:55:44 +01:00
Robin Appelman
7ca516773f
add a search query step to split IN statements that are to large for oci 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-15 17:55:43 +01:00
Robin Appelman
2e14a7a4a6
optimize query pattern used by storage filter 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-15 17:55:40 +01:00
Robin Appelman
963721330f only get the path for the users cached mount info when we use it 
most of the time we shouldn't need it so we can save joining on the filecache

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-09 09:50:43 +01:00
Robin Appelman
5aea3f4d76 make storage directory test be a bit less strict about mtimes 
sometimes the clock ticks over during the test

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-07 12:13:00 +01:00
Thomas Citharel
30798eb6c2
refactor(objectstorage): cleanup types 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2024-02-02 14:59:21 +01:00
Robin Appelman
7aed19ac98
add test for updating etag with unchanged mtime in child folder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-01-31 18:05:12 +01:00
Robin Appelman
2cf9ed7ca5
add test for updating etag with unchanged mtime 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-01-31 18:05:11 +01:00
Joas Schilling
5850695284
fix(tests): Add messages to assertions to explain what failed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-01-26 20:46:14 +01:00
Ferdinand Thiessen
8e02014b55
chore(tests): Migrate object storage unit tests from drone to GitHub Actions 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-01-26 14:54:23 +01:00
Ferdinand Thiessen
fceb781058
fix(tests): Fix deprecation errors in S3 tests 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-01-26 14:53:33 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Ferdinand Thiessen
5172baaf8b
fix(ObjectStore): Make copying behavior consistent with local storage 
Drop file permissions on copy like we do on local storage.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-11-17 12:54:37 +01:00
Robin Appelman
b942850af9
optimize UserMountCache::registerStorage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-16 16:21:59 +01:00
Robin Appelman
f4fa2fb93c
optimize isShared and isMounted 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-11-08 17:34:58 +01:00
Robin Appelman
b11ca34bbd
Merge pull request #40499 from nextcloud/known-mtime-wrapper 
add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is
 2023-09-21 18:33:15 +02:00
Daniel Kesselberg
18af7cc86b test: add test for cache mount provider 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-09-20 15:42:23 +02:00
Robin Appelman
ccf8843d9f apply known mtime wrapper for external storages 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-19 13:58:35 +02:00
Robin Appelman
5bf34979fe add wrapper to ensure we don't get an mtime that is lower than we know it is 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-19 13:58:15 +02:00
Julius Härtl
7f958e81d3
fix: Pass parent to NonExistingFile instances 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-09-13 10:28:28 +02:00
Robin Appelman
64f62f7cfd
Merge pull request #39863 from nextcloud/sharing-mask-wrapper 
move share permission logic to storage wrapper
 2023-09-04 14:05:14 +02:00
Simon L
489a57e9a3
Merge pull request #39707 from nextcloud/bugfix/39706/local-ext-storage-unavailable-mode 2023-09-04 12:05:36 +02:00
John Molakvoæ (skjnldsv)
f828dce597
Fix sharing creation insert and get 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2023-09-02 10:25:24 +02:00
Robin Appelman
e704470c79
update tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-31 22:37:10 +02:00
Andrew Summers
6b09a79227
Refactor OC\Server::getShareManager 
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
 2023-08-29 21:32:58 -05:00
Vincent Petry
8d1a3daa3f Allow ext storage Local to go unavailable 
Whenever an external storage of type Local points at a non-existing
directory, process this as a StorageNotAvailable instead of returning
404.

This makes desktop clients ignore the folder instead of deleting it when
it becomes unavailable.

The code change was limited to external storages to avoid issues during
setup and with the default home storage.
Signed-off-by: Vincent Petry <pvince81@yahoo.fr>
 2023-08-29 11:04:31 +02:00
Robin Appelman
b6c3507aa0 only determine quota_include_external_storage once for quota wrapper 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-18 14:25:28 +02:00
Robin Appelman
e73889a240 cleanup di for share permissions wrapper 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-16 15:25:05 +02:00
Ferdinand Thiessen
5b37d6d9ff tests: Add test for CacheEntry getters 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-08-16 14:00:21 +02:00
Côme Chilliet
ee756579a7
Fix setting static property in tests on PHP 8.3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-08-14 16:27:56 +02:00
Joas Schilling
ad12a740cb
fix!: Remove symfony EventDispatcherInterface from User 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-27 23:13:37 +02:00
Joas Schilling
44a0a62107
fix: Move Node HookConnecter events to IEventDispatcher 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-27 09:57:53 +02:00
Josh Richards
e7cbaf3ee3 Clean-up some remaining readdir calls with undesirable false evaluation potential 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2023-06-24 15:37:06 +02:00
Arthur Schiwon
f6ac874dbf
chore: ugly type juggling 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 16:53:20 +02:00
Robin Appelman
2ea41dab93
repair -1 folder sizes for object store background scan 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-10 19:33:26 +02:00
Côme Chilliet
b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2023-04-20 16:52:38 +02:00
Julius Härtl
d9c81f56ad tests: Adapt node related unit tests mocks to required root view 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-04-17 23:46:52 +02:00
Julius Härtl
160bd75d0a fix: Use proper path when creating node instances 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-04-17 23:46:52 +02:00
Côme Chilliet
8d5165e8dc
Adapt tests to config value typing 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 17:42:14 +02:00
Côme Chilliet
4393b96542
Remove unused method getLocalFolder 
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:33 +02:00
Robin Appelman
91d5f6a826 more filesystem setup performance instrumentation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-10 11:11:13 +01:00
Julius Härtl
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id 2023-02-08 20:04:57 +01:00
Robin Appelman
9f3dbb699a fix tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-07 15:50:10 +01:00
Côme Chilliet
0f8c34cdc6
Fix filesize return type error in ViewTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Louis Chemineau
d8b479752d Fix hookconnector tests 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-01-26 10:12:23 +00:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Côme Chilliet
b22b6431d2
Fix gzip mimetype mapping 
PHP now detects it as application/gzip and not application/x-gzip anymore

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:11 +01:00
Côme Chilliet
7ebbb6b2ca
Remove workarounds specific to 7.4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:08 +01:00
Julius Härtl
59ae6e9dd6
Also update the unencrypted size of files when creating them with empty content 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-12-07 19:12:06 +01:00
Robin Appelman
3357c8e783 test disabling write check 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-10-26 18:45:59 +00:00
John Molakvoæ
d77e832223
Fix tests 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-10-14 16:18:40 +02:00
Robin Appelman
1de0b10751 add test for trying to fopen a file which no longer exists on disk 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-29 10:27:32 +02:00
Robin Appelman
d8961ed10f
fix using FSEEK_END with SeekableHttpStream to get file size 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-15 17:23:16 +02:00
Carl Schwan
eac54c4660
Merge pull request #33788 from nextcloud/improve-recent 
Improve getting recent files performance
 2022-09-08 16:19:41 +02:00
blizzz
417f46e467
Merge pull request #33600 from nextcloud/lazy-quota 
get quota for user only when needed
 2022-09-07 18:10:33 +02:00
Carl Schwan
67551f379f
Filter out old files when trying to get recent files 
Only do so when asking for less than 100 files and having an offset
equal to 0.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-05 12:53:32 +02:00
Robin Appelman
bd91c56539
get quota for user only when needed 
always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-01 19:32:24 +02:00
Julius Härtl
83b1415906
Only pass parent if paths match 
As the user folder might be initialized by the root from two levels
down the hierarchy, passing this as a parent only works if the path matches

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-08-24 22:20:32 +02:00
Julius Härtl
b2d6435737
Avoid extra query for the parent node if we can pass it along 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-08-24 22:20:32 +02:00
Vincent Petry
312b719acf
Merge pull request #32943 from nextcloud/unencrypted-size-revert-interface-changes 
Revert interface changes from "store unencrypted size in the unencrypted_size column"
 2022-08-17 11:36:16 +02:00
Vincent Petry
2360d880fa
Merge pull request #33540 from nextcloud/mount-provider-migration 
fix updating cached mounts that didn't have their mount provider set previously
 2022-08-17 10:41:31 +02:00
Robin Appelman
1850d0ae96 cleanup scannertest a bit 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 13:56:51 +02:00
Robin Appelman
1374cbee3e store unencrypted size in the unencrypted_size column 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 13:54:26 +02:00
Robin Appelman
887952b4f4 add tests for cached mount provider migration 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 13:47:43 +02:00
Robin Appelman
5e375d9092 Revert "store unencrypted size in the unencrypted_size column" 
This reverts commit 8238582e59.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 12:07:14 +02:00
Carl Schwan
d5c23dbb9f Move CappedMemoryCache to OCP 
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-14 15:54:31 +02:00
Côme Chilliet
6a1510f8ee
Remove some more at matchers in tests/lib 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-06-20 10:53:06 +02:00
Robin Appelman
8238582e59
store unencrypted size in the unencrypted_size column 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-06-02 16:07:00 +02:00
Simon L
18dd460720
Merge pull request #26813 from nextcloud/feature/files-search-tags 
Files: Extend search to also cover tags
 2022-05-18 10:58:02 +02:00
Marcel Klehr
f755ee0868 Files: Extend search to also cover tags 
fixes #326

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2022-05-17 21:05:09 +02:00
Carl Schwan
ec6b83cc18 Add stricter psalm type for CappedMemoryCache 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:06:18 +02:00
Joas Schilling
efb432865f
Fix test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-04-20 13:08:31 +02:00
Robin Appelman
151c800397
allow reusing known folder info when getting directory contents 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-06 14:40:34 +02:00
Robin Appelman
754603a04e
dont needlessly resolve path when getting internalPath/storage from Node 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-04 15:40:24 +02:00
Côme Chilliet
1809386862
Fix codestyle 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:27 +01:00
Côme Chilliet
61f7f13bd8
Migrate from ILogger to LoggerInterface where needed in the tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:26 +01:00
Robin Appelman
917c74e214
type fixes 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:30:16 +01:00
Robin Appelman
d81713e5c1
simplify setup of circular SetupManager<->Manager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:30:09 +01:00
Robin Appelman
22875bf367
move logic to decide what to setup to setupmanager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:30:03 +01:00
Robin Appelman
1c468129af
adjust tests to new fs setup 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:29:59 +01:00
Robin Appelman
8b7c8447a0
move root mount setup to mountproviders 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-02-24 17:21:42 +01:00
Robin Appelman
cfb7923e08
store mountprovider for each mount in the mounts table 
this enabled more fine grained filesystem setup

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-02-23 18:02:33 +01:00
Carl Schwan
6312c0df69
Check style update 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-13 00:19:07 +01:00
Côme Chilliet
e053feb5db
Fix PHP deprecation warning in File/ViewTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-12-16 09:43:32 +01:00
Robin Appelman
e95745c074
fix tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-12-02 17:43:16 +01:00
Côme Chilliet
cd72045433
Make mock config return default value to fix warnings 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:29:00 +01:00
Côme Chilliet
bb9c099e42
Fix FolderTest calls to Mountpoint constructor with wrong type 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:28:59 +01:00
Vincent Petry
c42a890126
Merge pull request #29622 from nextcloud/feat/objectstore_multibucket-shift 
Implement multibucket shift for ObjectStore
 2021-11-19 17:26:44 +01:00
Vincent Petry
c92a0e4152
Normalize directory entries in Encoding wrapper 
Directory entry file names are now normalized in getMetaData(),
getDirectoryContents() and opendir().

This makes the scanner work properly as it assumes pre-normalized names.

In case the names were not normalized, the scanner will now skip the
entries and display a warning when applicable.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-11-17 09:43:25 +01:00
John Molakvoæ
6ab2feaa54
Implement multibucket shift for ObjectStore 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-11-11 15:09:28 +01:00
John Molakvoæ
f4e4a85fcf
Merge pull request #27440 from nextcloud/is-file-handle 2021-10-23 11:18:52 +02:00
acsfer
dae769d082
Update Tests 2021-10-22 12:16:11 +02:00
John Molakvoæ
2be0eda47c
Merge pull request #29220 from nextcloud/s3-external-list 2021-10-22 12:06:05 +02:00
John Molakvoæ
0a35937662
Merge pull request #26347 from J0WI/clean-path-regex 2021-10-22 11:42:30 +02:00
Robin Appelman
294b218895
ci 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-10-15 15:35:12 +02:00
Daniel Kesselberg
e60a829b42
explicitly close source stream on local storage 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-09-21 17:41:59 +02:00
Bernd Rederlechner
3866f388b1
Refactor writeObject to only use MultipartUpload when required 
Signed-off-by: Bernd Rederlechner <Bernd.Rederlechner@t-systems.com>

Co-authored-by: Julius Härtl <jus@bitgrid.net>
 2021-08-20 17:02:25 +02:00
acsfer
11169c86f8 Tests update 2021-08-15 12:23:29 +02:00
John Molakvoæ
67e6468b9e
Merge pull request #28220 from nextcloud/get-by-id-multiple-mounts-single-storage 2021-08-09 19:27:23 +02:00
Robin Appelman
5c2e7c7d28
fix Folder->getById() when a single storage is mounted multiple times 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-07-28 17:21:04 +02:00
Robin Appelman
4d5e8bcb99
add test for searching within a "root jail" 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-07-28 17:11:12 +02:00
Julius Härtl
3f44fd00e2
Run s3 tests again 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-06-30 14:30:04 +02:00
Robin Appelman
66e10718c6
split of query building bits from searchhelper 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:40 +02:00
Robin Appelman
f938daa6e4
update tests and fix some edge cases around new search 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:36 +02:00
Robin Appelman
e198dc1b20
rework search api to allow searching on multiple caches at once 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:22 +02:00
Julius Härtl
35b910cf8e
Merge pull request #26322 from nextcloud/recent-search 
Use file search for recent files and optimize getting share types
 2021-05-18 09:44:08 +02:00
Robin Appelman
effb7dc8ba
set mimetype for objects uploaded to object storages 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-04-21 15:25:58 +02:00
Robin Appelman
0d5f4edc22
adjust tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-04-21 14:09:07 +02:00
Lukas Reschke
4b4971ab52
Merge pull request #24966 from nextcloud/jknockaert-patch-1 
avoid fread on directories and unencrypted files
 2021-04-06 13:45:10 +02:00
J0WI
d58d6199d9 Cleaner normalizePath regex 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-03-27 21:29:28 +01:00
Robin Appelman
e5dc1a8085
Set umask before operations that create local files 
this solves issues where "other php stuff" is messing with the umask

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-23 14:52:31 +01:00
Robin Appelman
bfe3712372
handle ordering in folder search 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 16:07:54 +01:00
Robin Appelman
feed42dd6d
folder filtering in sql 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 13:41:00 +01:00
Robin Appelman
de713967c0
cleanup fileinfo creation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 13:35:37 +01:00
Robin Appelman
bd229e7548
handle limit and offset in folder file search 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-18 17:38:31 +01:00
Robin Appelman
50e374c12f
only require user to be set in a query that handles tags 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-18 17:16:28 +01:00
Vincent Petry
e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter 
do cachejail search filtering in sql
 2021-03-15 17:45:30 +01:00
Robin Appelman
c87b1a50d9 apply object store copy optimization when 'cross storage' copy is within the same object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-09 20:31:27 +01:00
Roeland Jago Douma
7b9ca4f7c2 Add some typing to SharedStorage 
Makes psalm a bit more happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-04 10:49:42 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Joas Schilling
645f83121e
Cache the user backend info for 300s 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-02-15 10:36:08 +01:00
Robin Appelman
5ae0be08b4
fix search in nested jails 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-26 15:30:54 +01:00
Robin Appelman
27f9df2e87
fix cachjail searching for root 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-26 15:30:50 +01:00
Robin Appelman
a44aab11f7
do cachejail search filtering in sql 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-26 15:30:46 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Jasper Knockaert
261966ace5
Update EncryptionTest.php 2021-01-05 21:45:50 +01:00
Jasper Knockaert
664e74a82e
2nd attempt to fix tests 2021-01-05 20:41:02 +01:00
Jasper Knockaert
87c640193b
attemtp to fix test 2021-01-05 19:09:16 +01:00
Julius Härtl
98560c80ea
Properly handle result when copying with failure and throw in tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-01-05 09:20:35 +01:00
Julius Härtl
ee842f1c43
Fix writeStream mocking 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-01-05 09:20:35 +01:00
Morris Jobke
83a75c670b
Replace static call to Share::unshare with ShareManager->deleteShare in tests 
And then cleanup all the code that is dead then...

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-30 09:51:18 +01:00
Robin Appelman
9d4848e863
use in objectstore copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-24 15:16:58 +01:00
Joas Schilling
8027dcbc6f
Don't leave cursors open when tests fail 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-09 12:28:17 +01:00
Joas Schilling
c07720de77
Use query builder instead of OC_DB in OC\Files\* 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-09 09:05:15 +01:00
Morris Jobke
e6fca0a519
Fix code style 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-09 17:36:58 +02:00
Julius Härtl
74747163d6
Make sure tests cover the new mkdir behaviour on 0 quota 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-09-08 11:35:32 +02:00
Morris Jobke
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-12 13:55:19 +02:00
Morris Jobke
45428e4948
Add config option to enable multibucket preview distribution 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-06 22:31:39 +02:00
Morris Jobke
159f28cd52
Mount the old previews in a separate folder for the multi bucket setup and check in them before using the actual locations 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-06 22:19:21 +02:00
Robin Appelman
ad7798f9c9
use exceptions for error signaling in writeStream 
this remove the ambiguity when writing zero length files

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 15:24:52 +02:00
Robin Appelman
fcad692b4a
rollback cache rename if trashbin move fails 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 15:24:48 +02:00
Roeland Jago Douma
d53e005458
Merge pull request #21360 from nextcloud/root-storage-prevent-scanning 
prevent the root storage from accidentally scanning user folders
 2020-07-02 21:07:16 +02:00