6482 commits

Author	SHA1	Message	Date
Anna	f67b908c42	Merge pull request #60742 from nextcloud/test/noid/remove-checkbox-tests ... test: replace checkbox assertions with real assertions or DoesNotPerformAssertions	2026-05-27 19:47:57 +02:00
Micke Nordin	5ffde0370b	Merge pull request #60136 from nextcloud/kano-dual-stack-rfc-9421-http-sig ... feat(http-sig): Dual stack http-sig	2026-05-27 15:59:52 +02:00
Anna Larch	18c5c0711e	test: remove no-op checkbox assertions ... Replace assertTrue(true), addToAssertionCount(1) and delete-without-assert patterns with meaningful assertions or proper test removal. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-27 12:12:44 +02:00
Kate	f1915e0dd4	Merge pull request #60744 from nextcloud/test/noid/phpunit-db-test-isolation ... test(db): call parent::tearDown() in DB test classes that skipped it	2026-05-27 11:37:51 +02:00
Micke Nordin	cc9e0ba582	fix(http-sig): make setSignature public and skip third-party-dependent test ... Two CI failures introduced by the test additions in this PR: 1. testEd25519VerifyAcceptedWhenSodiumLoaded calls setSignature() to inject an externally-produced Ed25519 signature (since Algorithm::sign() rejects Ed25519 by design). setSignature was declared protected, so the test couldn't call it from outside the class hierarchy. Make it public — SignedRequest lives in the OC\ private namespace, so this widens internal-only visibility, not the public API surface. 2. testParseKeyRejectsContradictoryAlg expected firebase/php-jwt's JWK::parseKey() to throw on a kty=OKP/crv=Ed25519/alg=ES256 key. The current firebase/php-jwt version does not validate that coherence at parse time, so the test now fails to see any throwable. The actual security check happens at Algorithm::verify() time and is covered by testVerifyEd25519KeyAgainstES256Alg right above it. Skip the parse-time test with a comment pointing at the verify-time coverage. Signed-off-by: Micke Nordin <kano@sunet.se>	2026-05-27 11:03:55 +02:00
Micke Nordin	1bad4fe238	fix: Make sodium optional ... This commit switches the default signature algorithm to ecdsa-p256-sha256 instead of Ed25519. This allows us to make sodium optional again, and we only pull it in to use it for verifying incomming signatures. If sodium is not installed, we throw on Ed25519 signatures instead. At least it is easy for most people to make their Nextcloud install fully RFC compliant by installing sodium. I also renamed all the Ed25519 function names to be more precis, using Jwks for the JSON Web Keys, and RFC9421 for the http-signature code, where it is needed to distinguish from draft-cavage signatures. Signed-off-by: Micke Nordin <kano@sunet.se>	2026-05-27 11:03:55 +02:00
Micke Nordin	3b5107bc96	feat(http-sig): OCM Ed25519 keys, JWKS endpoint, http-sig capability ... OCM dual-stack integration of RFC 9421 alongside the existing cavage publicKey path: - OCMSignatoryManager: Ed25519 active/pending/retiring slot rotation backed by numbered pool appkeys, getRemoteKey for inbound JWK lookup with per-origin cache + cache-miss refetch, and getLocalEd25519Jwks for the JWKS endpoint. - Rfc9421SignatoryManager: per-call wrapper that swaps in the Ed25519 signatory and toggles `rfc9421.format`. - OCMJwksHandler: serves /.well-known/jwks.json (RFC 7517) when signing is enabled. - OCMDiscoveryService: advertises `http-sig` in capabilities when signing is enabled, and picks the signature scheme on outbound based on the remote's advertised capabilities. - Application.php: register the JWKS well-known handler. Signed-off-by: Micke Nordin <kano@sunet.se>	2026-05-27 11:03:55 +02:00
Micke Nordin	0eb927e617	feat(http-sig): RFC 9421 protocol primitives ... Add the RFC 9421 (HTTP Message Signatures) sign/verify path alongside the existing draft-cavage implementation: - Algorithm: sodium for Ed25519, JWT::sign for RSA / ECDSA, ecdsaRawToDer for the ECDSA wire format. JWK parsing via JWK::parseKey. - SignatureBase: RFC 9421 §2.5 base construction for the derived components OCM uses plus plain HTTP fields. - ContentDigest: RFC 9530 helpers used as a covered component. - Rfc9421IncomingSignedRequest / Rfc9421OutgoingSignedRequest: request models. Parsing of Signature-Input / Signature delegates to gapple\\StructuredFields\\Parser. - IJwkResolvingSignatoryManager: capability bit signatory managers advertise to participate in RFC 9421 verification. - OcmProfile: OCM-mandated dictionary label. - SignatureManager: dispatch to RFC 9421 inbound when Signature-Input is present, outbound when rfc9421.format is set. Plus tests for each primitive and a full round-trip across the model. Signed-off-by: Micke Nordin <kano@sunet.se>	2026-05-27 11:03:55 +02:00
Anna Larch	d30f3c491d	test: replace checkbox assertions with DoesNotPerformAssertions (middleware) ... Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-26 23:18:55 +02:00
Anna Larch	a9f177e743	test(db): call parent::tearDown() in DB test classes that skipped it ... Eight test classes overrode tearDown() for custom DB cleanup but never called parent::tearDown(). TestCase::tearDown() does three things these tests were silently skipping after every test method: - ILockingProvider::releaseAll() — unreleased locks bleed into subsequent tests and can cause deadlocks or unexpected NotFoundException - Storage::getGlobalCache()->clearCache() — stale filecache entries from share/storage tests cause unrelated ObjectStore tests to receive false from fopen() (fseek() then fails with "Argument must be of type resource") - UserMountCache::flush() — stale mount cache causes share lookups in later tests to fail with ShareNotFound AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>	2026-05-26 21:20:57 +02:00
Daniel	c0c03fd37f	Merge pull request #60546 from nextcloud/local-address-nat64 ... fix: handle NAT64 addresses in isLocalAddress	2026-05-20 16:10:25 +02:00
Ferdinand Thiessen	7a62c350b1	Merge pull request #53583 from nextcloud/jtr-remove-always-populate-raw-post-data ... chore: remove `always_populate_raw_post_data`	2026-05-20 14:01:01 +02:00
Anna	afe61fe63d	Merge pull request #60286 from nextcloud/fix/noid/appstore-fetcher-generic-file-exception ... fix(AppStore/Fetcher): catch GenericFileException when reading cache file in Fetcher	2026-05-20 02:51:28 +02:00
Josh	3ee366eb27	chore: remove always_populate_raw_post_data from htaccessWithValidModifiedContent ... Signed-off-by: Josh <josh.t.richards@gmail.com>	2026-05-19 21:39:51 +02:00
Robin Appelman	a472a189bb	fix: handle NAT64 addresses in isLocalAddress ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2026-05-19 17:06:46 +02:00
Anna Larch	c4356e1b25	fix(appstore): address review comments on GenericFileException handling ... - Attempt delete before logging the warning, so the warning only fires when we know recovery will succeed - Log an error (not silently return) when delete itself fails - Use catch (\Exception) without variable (PHP 8) - Replace willReturnArgument(1) with explicit willReturn(true) in test - Add blank lines between logical blocks in test for readability Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-19 16:52:52 +02:00
Anna Larch	5113b18739	fix(appstore): catch GenericFileException when reading cache file in Fetcher ... When the appstore cache file exists but getContent() throws a GenericFileException (I/O error or OS-level permission failure), explicitly delete the file and recreate it before writing fresh data — mirroring the NotFoundException recovery path. If deletion itself fails, return [] cleanly. Previously, the unhandled exception caused the entire apps settings page to crash. The new test covers both the recovery path and deletion failure. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-19 16:34:06 +02:00
Benjamin Gaussorgues	91a4172e35	Merge pull request #60225 from nextcloud/remove-cache-order ... perf: remove unneeded sort in getFolderContentsById	2026-05-13 16:49:24 +02:00
Carl Schwan	fcb956b5ab	Merge pull request #59753 from nextcloud/work/carl/remove-orderById ... perf(share): Remove useless order by id	2026-05-13 12:21:48 +02:00
Ferdinand Thiessen	2b2b9840b8	test(appstore): add test cases for appinfo.xml ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2026-05-12 23:11:24 +02:00
Ferdinand Thiessen	e3783b88e6	fix(AppManager): properly type AppInfo type based on XSD ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2026-05-12 22:52:32 +02:00
Robin Appelman	c91f8b0e2c	test: adjust tests to unsorted folder listing ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2026-05-12 19:30:24 +02:00
Carl Schwan	c5c3525a6e	fix: Allow sanitizeHTML to accept null ... Used like this in many places Signed-off-by: Carl Schwan <carlschwan@kde.org>	2026-05-12 18:24:12 +02:00
Carl Schwan	279bface8e	refactor: Delete deprecated code from OC_Util ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	2026-05-12 18:24:12 +02:00
Carl Schwan	32bc6f54d3	refactor: Replace old Utils::callRegister with new API ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	2026-05-12 18:24:12 +02:00
Benjamin Gaussorgues	b438b345b5	Merge pull request #60317 from nextcloud/fix/snowflake_server_id_doc ... fix(snowflake): fix wrong documentation about serverId	2026-05-12 14:16:31 +02:00
Carl Schwan	3dbefe89fd	Merge branch 'master' into work/carl/remove-orderById	2026-05-12 13:59:15 +02:00
Benjamin Gaussorgues	9e36754429	fix(snowflake): fix wrong documentation about serverId ... Maximum value of a server ID is 511 (9 bits) and not 1023. Also adjust SetupCheck Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2026-05-12 10:47:44 +02:00
John Molakvoæ (skjnldsv)	c26b1e4b07	fix(s3): add Content-MD5 header for DeleteObjects to fix AWS SDK v3.339.0+ compatibility ... AWS SDK PHP v3.339.0+ introduced a breaking change requiring the Content-MD5 header for DeleteObjects operations. This causes 'MissingContentMD5' errors when using S3-compatible services like MinIO. Add middleware to automatically calculate and inject the Content-MD5 header on all DeleteObjects requests. This is applied universally at the S3ConnectionTrait level, fixing both external storage (AmazonS3) and core ObjectStore (S3) classes. Fixes: https://github.com/aws/aws-sdk-php/issues/3068 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	2026-05-12 09:07:20 +02:00
Kate	ac15544703	Merge pull request #60299 from nextcloud/fix/remove-iservercontainer-from-core-apps ... Chore: Remove references to deprecated interface IServerContainer	2026-05-12 07:48:58 +02:00
Kate	94c25e210d	Merge pull request #60262 from nextcloud/ernolf/fix/brotli-detection	2026-05-11 20:34:09 +02:00
Côme Chilliet	9680004b58	chore: Remove almost all uses of deprecated IServerContainer in lib/private ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2026-05-11 16:22:22 +02:00
Côme Chilliet	6664f62a6c	fix: Fix debug mode and tests mocking IAppManager ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2026-05-11 14:53:29 +02:00
Côme Chilliet	bdfe8ed77e	fix: Add proper methods in IAppManager for namespace handling ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2026-05-11 14:53:29 +02:00
ernolf	04bd872fd2	style(http-client): use explicit bitmask comparison for CURL_VERSION_BROTLI ... Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>	2026-05-11 14:06:57 +02:00
ernolf	c1cd4de1cd	fix(http-client): detect brotli support via libcurl, not PHP extension ... - Fixes a regression introduced in #55433. Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>	2026-05-09 03:23:27 +02:00
Robin Appelman	d307557c56	test: adjust tests to unsorted share listing ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2026-05-08 18:05:06 +02:00
Anna Larch	0681ced203	fix(previews): use createParameter/setParameter to reuse query in chunk loop ... AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-06 10:32:54 +02:00
Ferdinand Thiessen	f6a37dc608	refactor(appstore): split controllers and use proper root ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2026-05-05 10:41:04 +02:00
Ferdinand Thiessen	5b756ad8bc	refactor: split appstore from settings ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2026-05-05 10:41:04 +02:00
Anna	57c57d7082	Merge pull request #59918 from nextcloud/feat/check-if-talk-enabled ... feat(ocp): expose whether talk is enabled for user	2026-05-04 11:03:52 +01:00
Robin Appelman	9f5535d01b	fix: apply quota with writeStream ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2026-05-02 14:04:09 +02:00
Robin Appelman	f3a5bc8c17	fix: block writing empty files with 0 quota ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2026-05-02 14:04:09 +02:00
John Molakvoæ	723b441324	Merge pull request #60000 from cuppett/cuppett/test-isolation	2026-04-30 12:38:03 +02:00
Stephen Cuppett	c2e2b5704d	fix(tests): Fix encryption test isolation between test runs ... Add global encryption teardown to TestCase base class so encryption state does not leak between test suites regardless of which tests ran earlier. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	2026-04-29 19:42:38 -04:00
Josh	268cc5f07e	test(TestCase): '.ocdata' -> '.ncdata' in knownEntries ... Signed-off-by: Josh <josh.t.richards@gmail.com>	2026-04-30 01:39:59 +02:00
nextcloud-command	e11e7f1c70	refactor: Apply rector changes ... Signed-off-by: GitHub <noreply@github.com>	2026-04-29 23:54:19 +02:00
Ferdinand Thiessen	be2ac0bd86	Merge pull request #59932 from nextcloud/carl/copySkeleton ... refactor: Move copy skeleton step to a file listener	2026-04-29 23:15:38 +02:00
Ferdinand Thiessen	e5b1799079	chore: add missing Override attribute to test files ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2026-04-28 21:29:28 +02:00
Joas Schilling	109eb0c8a9	fix(talkbackend): Make function names positive and remove talk internals from docs ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2026-04-27 21:27:40 +02:00