upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
87736 commits 985 branches 1211 tags 9.7 GiB
Commit graph

181 commits

Author SHA1 Message Date
Côme Chilliet
10664e9529 Migrate MySQL utf8mb4 check to new SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-23 17:34:04 +01:00
Côme Chilliet
ca3e1a531a
Merge gmp and bcmath module checks with the existing PHP modules setup check 
Also add description for why each module is recommended

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-22 15:07:21 +01:00
Côme Chilliet
a77bab2f95
Migrate set_time_limit setup check to new API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-18 12:36:53 +01:00
Côme Chilliet
5ad549a72f
Migrate memcached PHP module setup check to new API 
Merged it with the other existing memcache setup check as it fits

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-18 09:40:43 +01:00
Côme Chilliet
0e889da4a8
Remove obsolete check of curl SSL version 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-16 16:14:40 +01:00
Côme Chilliet
9bdad442f8 Remove references to removed functions in tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-16 10:49:19 +01:00
Côme Chilliet
b27455b922 Fix Cron setup check tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-16 10:49:19 +01:00
Côme Chilliet
7017b3e675
Fix CheckSetupControllerTest following overwrite.cli.url migration 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-16 09:29:12 +01:00
Côme Chilliet
0483064f07 Migrate overwrite.cli.url setup check to new API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-16 09:05:40 +01:00
Côme Chilliet
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check 2024-01-16 09:04:24 +01:00
Côme Chilliet
c998680348
Fix tests in CheckSetupControllerTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-15 11:50:48 +01:00
Côme Chilliet
f06b8da249
Migrate code integrity to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-15 11:50:38 +01:00
Côme Chilliet
d1aac16a72
Fix AppDirsWithDifferentOwnerTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-15 10:32:26 +01:00
Côme Chilliet
d1f2add10c Migrate PHP imagick module check to new SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-11 11:28:59 +01:00
Côme Chilliet
d2dbe1c50c
Migrate tests for AppDirsWithDifferentOwner setup check 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-09 09:52:13 +01:00
Côme Chilliet
3d4c4f19b4
Migrate app dir owner check to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-08 17:37:14 +01:00
Côme Chilliet
989b5ffbab
Remove unused properties from CheckSetupControllerTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-08 15:09:09 +01:00
Côme Chilliet
3f13a1a47e
Migrate opcache check to new SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-08 15:09:09 +01:00
Côme Chilliet
95ea46c99c Merge SQlite warning to existing SupportedDatabase setup check 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-12-07 15:45:27 +01:00
Côme Chilliet
51758117a7
Migrate database pending bigint conversions check to new API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-28 14:07:47 +01:00
Côme Chilliet
6b0d295307 fix(tests) Fix CheckSetupControllerTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-27 15:23:52 +01:00
Côme Chilliet
1b547c7db8 Migrate missing primary key database check to new API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-27 15:23:52 +01:00
Côme Chilliet
ad88c04f2d Migrate missing index database check to new API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-27 15:23:52 +01:00
Côme Chilliet
2cb1c0f2dc Migrate missing column database check to new API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-27 15:23:52 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Côme Chilliet
0ebd44abb6 Migrate tests of forwarded for headers check 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-20 11:36:42 +01:00
Côme Chilliet
0107c7ea24 Migrate Forwarded For Headers check to new API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-20 11:36:42 +01:00
Côme Chilliet
fe8b5d47ae
Migrate Bruteforce Throttle check to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-13 16:26:59 +01:00
Côme Chilliet
7495236034
Migrate memory_limit check to new SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-13 15:55:46 +01:00
Côme Chilliet
00d3856b92
Revert "Migrate code integrity to SetupCheck API" 
This reverts commit aa2d315d95d37b48752d0e92d0ce79913be1d4f1.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:25:04 +01:00
Côme Chilliet
0fd5ed9854
Migrate 32bit check to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:25:03 +01:00
Côme Chilliet
ac3da13b38
Migrate Freetype check to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:25:03 +01:00
Côme Chilliet
086d3ceecc
Migrate code integrity to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:25:03 +01:00
Côme Chilliet
147b29fca2
Migrate Randomness secure check to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:25:03 +01:00
Côme Chilliet
ddd13a90d8
Migrate memcache check to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:25:02 +01:00
Côme Chilliet
6911dc30e6
Migrated both file locking checks to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:14:03 +01:00
Côme Chilliet
f9770b8ef2
Remove duplicate fileinfo PHP module check 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:14:03 +01:00
Côme Chilliet
3c75075eba
Migrate database transaction level check to SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:14:03 +01:00
Côme Chilliet
5957a2bf6b
Migrate email test to new SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:14:02 +01:00
Côme Chilliet
506f3961ec
Remove duplicated ReadOnlyConfig setup check 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:14:02 +01:00
Côme Chilliet
dec52f6979
Migrate getenv test to new SetupCheck API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-11-07 12:14:02 +01:00
Côme Chilliet
d551a0d886
Adapt CheckSetupControllerTest to the migration to a setup check 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-10-24 15:36:09 +02:00
Côme Chilliet
0c346849f3
Migrate missing PHP modules check to new API and improve it 
Test all modules listed as required in our documentation

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-10-19 15:58:45 +02:00
Côme Chilliet
6bc3e008c7
Fix tests for setup checks 
Had to remove tests for migrated checks, we should add tests for each
 SetupCheck class later on.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-10-19 11:44:02 +02:00
Valdnet
be6c889414 Correct typos and add quotation marks 
Corrects typos and unifies spelling for "occ" commands.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2023-10-11 01:51:39 +02:00
Côme Chilliet
0a9371f99f
Migrate applications away from deprecated ILogger 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-21 11:57:21 +02:00
Anna Larch
7f11ee8c4a fix(CardDAV): only run upgrade sync if 1000 users or less 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-08-26 17:21:50 +02:00
Joas Schilling
bed3ffb312
feat(admin): Show an error when the admin is throttled 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-08-21 16:40:24 +02:00
Joas Schilling
ab70bbd3ff
fix(db)!: Remove private legacy event because we can not keep it 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-24 14:51:35 +02:00
Julius Härtl
925bcebcb6
feat: Add public event for missing indices 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-07-14 13:11:22 +02:00
Daniel Kesselberg
5a23b429dd
feat: remove check for OpenSSL 1.0.1d and 1.0.2b 
OpenSSL 1.0.1d: 2013-02-05
OpenSSL 1.0.2b: 2015-06-11

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-06-04 18:44:47 +02:00
Simon L
e2ab9bf4af address review and fix tests 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-04-18 11:33:53 +02:00
Simon L
80645a591a add an admin check for db file locking 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-04-17 12:51:33 +02:00
julia.kirschenheuter
0cfbe54a5a Create headings for settings pages 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
 2023-03-07 17:51:19 +01:00
Côme Chilliet
dde5c46a3e
Migrate to Symfony Mailer 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-02 10:30:06 +01:00
Côme Chilliet
b843d09810
Fix typing errors in settings tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-02 15:13:00 +01:00
Vincent Petry
f9ea078e27
Add unit test for case insensitive email saving 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-12-16 17:47:42 +01:00
Carl Schwan
e35bcc9381 Fix tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-11-22 10:06:19 +01:00
Côme Chilliet
68363f6944
Fix some more problems with tests under PHP 8.2 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-15 16:02:24 +01:00
szaimen
cf9b1082ed add a setup check for 64 bit 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-07-13 09:33:33 +00:00
Côme Chilliet
c0c54b20d9
Remove deprecated at() matcher from settings tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-06-07 10:05:18 +02:00
szaimen
351357047a fix drone tests on master 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-03-11 20:45:26 +01:00
szaimen
3c8f8bc70a fix tests 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-03-07 18:07:45 +01:00
MichaIng
5ac91f1cb8 Add Nextcloud docs link to OPcache recommends 
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.

Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.

Signed-off-by: MichaIng <micha@dietpi.com>
 2022-03-03 23:00:07 +00:00
Arthur Schiwon
b28aa52b28
Setup warning for invalid LDAP user or group UUIDs. 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-02-10 10:15:01 +01:00
szaimen
fa1ee8f0c7 fix tests 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-02-03 20:41:12 +01:00
MichaIng
82c1beaacb Enhance and complement OPcache setup checks 
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
 2021-12-19 23:38:21 +01:00
Joas Schilling
c6ae53096c
More test fixing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-01 22:17:19 +01:00
Joas Schilling
e8f7a08e52
ArgumentCountError: Too few arguments to function OCA\Settings\Controller\CheckSetupController::__construct() 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-09 15:13:24 +01:00
Joas Schilling
24935666e8
PHPUnit\Framework\MockObject\DuplicateMethodException: Cannot stub or mock using a method list that contains duplicates: 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-09 15:13:24 +01:00
Joas Schilling
19d070850b
Make sure trusted_proxies is an array 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-09 15:13:24 +01:00
Julien Veyssier
facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
 2021-10-18 12:39:43 +02:00
Carl Schwan
6958d8005a
Add admin privilege delegation for admin settings 
This makes it possible for selected groups to access some settings
pages.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-09-29 21:43:31 +02:00
Stefan
ea4b7bac7a Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually 
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
 2021-09-17 13:32:42 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 19:23:05 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
John Molakvoæ (skjnldsv)
b228e8a361
Fix translation phpunit test 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-02 18:00:45 +02:00
Arthur Schiwon
847ed37afc
do not use private AccountManager in UsersController 
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-05-25 14:35:38 +02:00
Daniel Calviño Sánchez
67dd087ce4 Fix deleting properties of user settings when not given explicitly 
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
a7431817b9 Respect additional user settings not covered by the controller 
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.

Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).

This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
c5e3d2e5c2 Add more unit tests for setting user settings 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
190ffd75b7 Change default test data to values less similar to empty values 
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:40 +02:00
Daniel Calviño Sánchez
ef5d538448 Extract default test data to a helper getter 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:40 +02:00
Daniel Calviño Sánchez
8cae515daa Use constants from interface rather than class 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:40 +02:00
Vincent Petry
5d14fd4396
Make extra user profile fields always editable 
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:08 +01:00
Vincent Petry
278a73789e
Map old account scope properties to new names 
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:08 +01:00
Joas Schilling
07095fd122
Also clear the knownUser when changing via the settings endpoint 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 19:37:10 +01:00
Roeland Jago Douma
38f761f25f Move away some ILoggers 
Makes psalm happier

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-02 10:47:25 +01:00
Roeland Jago Douma
7d8e9baa77
Revert "use the configured forwarded headers for the setup check" 2021-02-13 18:03:32 +01:00
Robin Appelman
01118a2218
use the configured forwarded headers for the setup check 
instead of always checking against the same header

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-02-12 14:22:27 +01:00
Morris Jobke
bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-08 13:38:32 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Joas Schilling
46b073d7ce
Add a config for default region of phone numbers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
da9462b482
Make code strict 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
Morris Jobke
1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-03 10:06:33 +01:00
nhirokinet
830348dbee
Add SVG support check to setup check 
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
 2020-11-02 11:29:08 +01:00
Roeland Jago Douma
0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2 
Remove setup check for php mail
 2020-10-08 22:40:37 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00