Commit graph

286 commits

Author SHA1 Message Date
Andy Scherzinger
1d451d44a2 chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-13 14:15:32 +02:00
Arthur Schiwon
98b5cdc43d
Merge pull request #43942 from nextcloud/fix/43612/avoid-pwd-confirm-sso
fix(Session): avoid password confirmation on SSO
2024-06-07 11:25:36 +02:00
Arthur Schiwon
f6d6efef3a
refactor(Token): introduce scope constants
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-05 19:01:14 +02:00
Andy Scherzinger
ec5b60af28
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-03 20:33:31 +02:00
Jake Nabasny
f863290572
feat(ldap): sync additional properties to profile and SAB
Synced from LDAP to profile:
- Date of birth

Synced from LDAP to SAB (via the profile):
- Biography
- Date of birth

Original code by Jake Nabasny (GitHub: @slapcat)

Co-authored-by: Jake Nabasny <jake@nabasny.com>
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-05-30 12:01:13 +02:00
Corentin Damman
0fa9f3049f feat(files_sharing): allow to specify allowed groups to share instead of excluded groups
Relates to #3387

Signed-off-by: Corentin Damman <c.damman@intopix.com>
2024-03-15 16:52:59 +01:00
Ferdinand Thiessen
df502c114d
feat(settings): Cache app discover images to ensure privacy of users
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:25 +01:00
Côme Chilliet
6278cf181e
fix: Improve HSTS warning wording as suggested by reviewer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 11:49:47 +01:00
Côme Chilliet
9f819f311f feat: Migrate HSTS check to Security headers SetupCheck
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
d7193ef65e fix: Migrate security headers check tests and fix the SetupCheck implementation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
1fffdf4763 fix: Fix ocm-provider setup check failure detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Maxence Lange
519e434573 fix(updatenotification): spread the use of new appconfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-13 02:22:11 -01:00
jld3103
4ac2375ca2
feat: Add declarative settings
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-12 13:56:54 +02:00
Côme Chilliet
1ea88a73f6 feat(settings): Migrate .well-known URL setup check to new API
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 14:06:08 +01:00
Côme Chilliet
5794e1c9d6
Merge pull request #43906 from nextcloud/enh/migrate-ssl-url-setupcheck
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
2024-03-04 15:54:47 +01:00
Ferdinand Thiessen
ef2c312b18
feat(settings): Migrate data directory protection check to SetupCheck
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-29 13:54:01 +01:00
Côme Chilliet
ca246dc35c
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-29 12:21:36 +01:00
Ferdinand Thiessen
ad747ab62b
feat(settings): Migrate OCM / OCS provider tests to SetupCheck
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-27 14:52:10 +01:00
Andrii Rublov
a72706f1e6
Merge branch 'master' into fix/pages-titles-apps
Signed-off-by: Andrii Rublov <github.a@rublov.me>
2024-02-25 13:48:38 +01:00
John Molakvoæ
b080113fdd
Merge branch 'master' into fix/42480/user-admin-not-admin
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-02-24 19:31:22 +01:00
Ferdinand Thiessen
00386a5407 fix(settings): Use initial state instead of custom state for server data
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-23 21:59:02 +01:00
Ferdinand Thiessen
dd7fba2c95 fix(settings): Only use id in categories - drop duplicated ident property
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-23 21:59:02 +01:00
Andrii Rublov
8d22d341c8 [Bugfix]: Titles of pages (dashboard, apps-settings, users-settings) #43327
Signed-off-by: Andrii Rublov <airublev@outlook.com>
2024-02-23 18:39:23 +01:00
Arthur Schiwon
c98b0462e3 fix(admin role): fix old and wrong way to determine whether user is admin
- fixes Settings knowing who is an admin of non-local group backend groups
- obsoletes and removes a little old, deprecated code
- double checks proper parameter type on Group\Manager::isAdmin
- also fixes legacy OC_User code to check whether user is an admin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-02-19 18:57:22 +01:00
John Molakvoæ
524ed97d62
fix: replace Account name by Login
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
Baptiste Fotia
449d28e610 test(php): Fix the unit tests
I added our context in the unit tests following the advice of Louis.

Link : https://github.com/nextcloud/server/pull/43186#issuecomment-1916571027

Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +01:00
Baptiste Fotia
9af96d9f9a feat(php,vue): Create a new parameter
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +01:00
Côme Chilliet
67541f21f6
Migrate fair use of free push service check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 13:05:59 +01:00
Côme Chilliet
9add64f30e
Merge writable temporary space check with the s3 one, and improve
It will now show available space and path of both PHP and Nextcloud
 temporary directories if they differ.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:30 +01:00
Côme Chilliet
ccbc5fc273
Remove old version of temporary space setup check and fix tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:29 +01:00
Côme Chilliet
10664e9529 Migrate MySQL utf8mb4 check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-23 17:34:04 +01:00
Côme Chilliet
ca3e1a531a
Merge gmp and bcmath module checks with the existing PHP modules setup check
Also add description for why each module is recommended

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:21 +01:00
Côme Chilliet
a77bab2f95
Migrate set_time_limit setup check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 12:36:53 +01:00
Côme Chilliet
5ad549a72f
Migrate memcached PHP module setup check to new API
Merged it with the other existing memcache setup check as it fits

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 09:40:43 +01:00
Côme Chilliet
0e889da4a8
Remove obsolete check of curl SSL version
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 16:14:40 +01:00
Côme Chilliet
9bdad442f8 Remove references to removed functions in tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 10:49:19 +01:00
Côme Chilliet
b27455b922 Fix Cron setup check tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 10:49:19 +01:00
Côme Chilliet
7017b3e675
Fix CheckSetupControllerTest following overwrite.cli.url migration
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:29:12 +01:00
Côme Chilliet
0483064f07 Migrate overwrite.cli.url setup check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:05:40 +01:00
Côme Chilliet
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check 2024-01-16 09:04:24 +01:00
Côme Chilliet
c998680348
Fix tests in CheckSetupControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +01:00
Côme Chilliet
f06b8da249
Migrate code integrity to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:38 +01:00
Côme Chilliet
d1aac16a72
Fix AppDirsWithDifferentOwnerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 10:32:26 +01:00
Côme Chilliet
d1f2add10c Migrate PHP imagick module check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 11:28:59 +01:00
Côme Chilliet
d2dbe1c50c
Migrate tests for AppDirsWithDifferentOwner setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-09 09:52:13 +01:00
Côme Chilliet
3d4c4f19b4
Migrate app dir owner check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 17:37:14 +01:00
Côme Chilliet
989b5ffbab
Remove unused properties from CheckSetupControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Côme Chilliet
3f13a1a47e
Migrate opcache check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Côme Chilliet
95ea46c99c Merge SQlite warning to existing SupportedDatabase setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-12-07 15:45:27 +01:00
Côme Chilliet
51758117a7
Migrate database pending bigint conversions check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-28 14:07:47 +01:00
Côme Chilliet
6b0d295307 fix(tests) Fix CheckSetupControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
1b547c7db8 Migrate missing primary key database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
ad88c04f2d Migrate missing index database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
2cb1c0f2dc Migrate missing column database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Côme Chilliet
281cbbfa97
Fix tests for apps/settings new section
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-21 17:51:34 +01:00
Louis Chemineau
7984b80a76
Fix sharing settings unit tests
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-11-21 17:32:36 +01:00
Côme Chilliet
ad372869bc
Fix tests for setupchecks
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 18:03:15 +01:00
Côme Chilliet
0ebd44abb6 Migrate tests of forwarded for headers check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +01:00
Côme Chilliet
0107c7ea24 Migrate Forwarded For Headers check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +01:00
Côme Chilliet
fe8b5d47ae
Migrate Bruteforce Throttle check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 16:26:59 +01:00
Côme Chilliet
7495236034
Migrate memory_limit check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 15:55:46 +01:00
Côme Chilliet
00d3856b92
Revert "Migrate code integrity to SetupCheck API"
This reverts commit aa2d315d95d37b48752d0e92d0ce79913be1d4f1.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:04 +01:00
Côme Chilliet
0fd5ed9854
Migrate 32bit check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
ac3da13b38
Migrate Freetype check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
086d3ceecc
Migrate code integrity to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
147b29fca2
Migrate Randomness secure check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
ddd13a90d8
Migrate memcache check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:02 +01:00
Côme Chilliet
6911dc30e6
Migrated both file locking checks to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
f9770b8ef2
Remove duplicate fileinfo PHP module check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
3c75075eba
Migrate database transaction level check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
5957a2bf6b
Migrate email test to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
506f3961ec
Remove duplicated ReadOnlyConfig setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
dec52f6979
Migrate getenv test to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
d551a0d886
Adapt CheckSetupControllerTest to the migration to a setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-24 15:36:09 +02:00
Côme Chilliet
0c346849f3
Migrate missing PHP modules check to new API and improve it
Test all modules listed as required in our documentation

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 15:58:45 +02:00
Côme Chilliet
6bc3e008c7
Fix tests for setup checks
Had to remove tests for migrated checks, we should add tests for each
 SetupCheck class later on.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:02 +02:00
Valdnet
be6c889414 Correct typos and add quotation marks
Corrects typos and unifies spelling for "occ" commands.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-10-11 01:51:39 +02:00
Côme Chilliet
0a9371f99f
Migrate applications away from deprecated ILogger
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-21 11:57:21 +02:00
Anna Larch
7f11ee8c4a fix(CardDAV): only run upgrade sync if 1000 users or less
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-26 17:21:50 +02:00
Joas Schilling
bed3ffb312
feat(admin): Show an error when the admin is throttled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +02:00
Joas Schilling
ab70bbd3ff
fix(db)!: Remove private legacy event because we can not keep it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:35 +02:00
Julius Härtl
925bcebcb6
feat: Add public event for missing indices
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-14 13:11:22 +02:00
Daniel Kesselberg
5a23b429dd
feat: remove check for OpenSSL 1.0.1d and 1.0.2b
OpenSSL 1.0.1d: 2013-02-05
OpenSSL 1.0.2b: 2015-06-11

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-04 18:44:47 +02:00
Simon L
e2ab9bf4af address review and fix tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-18 11:33:53 +02:00
Simon L
80645a591a add an admin check for db file locking
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +02:00
jld3103
d9f8522003
Fix types for reading and writing config values
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +02:00
julia.kirschenheuter
0cfbe54a5a Create headings for settings pages
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-07 17:51:19 +01:00
Côme Chilliet
dde5c46a3e
Migrate to Symfony Mailer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +01:00
Joas Schilling
348454cb91
Merge pull request #35876 from bennet0496/patch-mail-header
Adding option to set Auto-Submitted email header
2023-01-04 09:34:14 +01:00
Bennet Becker
5a1cc8de9b
update usages of AutoSubmittedValue to AutoSubmitted::VALUE_
Signed-off-by: Bennet Becker <dev@bennet.cc>
2023-01-03 15:28:43 +01:00
Côme Chilliet
b843d09810
Fix typing errors in settings tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 15:13:00 +01:00
Bennet Becker
eec1ebb848
Updating unit test for NewUserMailHelper, to test for autosumbitted
header

Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
2022-12-23 19:27:09 +01:00
Vincent Petry
f9ea078e27
Add unit test for case insensitive email saving
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-12-16 17:47:42 +01:00
Carl Schwan
f244406ebd Update composer autoloader
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 13:35:17 +01:00
Carl Schwan
e35bcc9381 Fix tests
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 10:06:19 +01:00
Côme Chilliet
68363f6944
Fix some more problems with tests under PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +01:00
Côme Chilliet
72f4b34ad5
Fix tests depending on a trailing whitespace
Many editors remove trailing whitespaces, so avoid depending on them for
 tests success.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 10:31:58 +01:00
Côme Chilliet
c79a6b3f62
Fix errors from PHP 8.2 testing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 17:08:21 +01:00