Commit graph

165 commits

Author SHA1 Message Date
fenn-cs
c179408a0d Tooltip outside click, should abort share creation
It's unexpected that click outside a tooltip would proceed with the
 action that could be carried out inside the tooltip.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-12-11 21:03:28 +01:00
fenn-cs
9d86a0444d Improve share logic for enforced password & expiry date
* It's possible for the admin to enforce and expiry date after, some
 shares have been created. This commit makes possible to update the
 share with the new admin constraints.

* This commit would users to modify enforced expiry to anything within
 range and less than the enforced limit in the pre-create dialog for public
 shares.

* This commit fixes, unable to update share without updating password.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-11-30 11:58:35 +01:00
julia.kirschenheuter
ff2ef8d0d6 Replace ActionLink with ActionButton on sharing tab
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
So-authored-by: Grigorii K. Shartsev <me@shgk.me>
2023-11-17 16:55:05 +01:00
Christopher Ng
590daccca3 fix: Share select search globally icon
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-23 15:14:49 -07:00
Varun Patil
9bd50a7296
refactor: remove remaining usage of OC::getCapabilities
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-10-20 16:19:43 +02:00
julia.kirschenheuter
bfa7d33912 Reduce width of sharing entry
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-10-19 12:50:14 +00:00
fenn-cs
a092bae720 Updates to sharing flow
- Show enforced expiry date for new shares.
- Improve quick share dropdown visibility in dark mode.
- Prevent expiry date from showing expire for incoming shares.
by updating the check for `share.passwordExpirationTime` to equally
check for `undefined`.
- Move "Download permission/attribute" from custom setting (as it is just
another advanced setting and not an actual permission).
- Show correct text for upload/editing when "allow public uploads" is enabled
or disabled by admin.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-10-02 11:59:10 +01:00
fenn-cs
56771b50c4 Consider share type for enforced share expiry dates
We have three kind of share expiry date enforcements.

- `isDefaultExpireDateEnforced`
- `isDefaultInternalExpireDateEnforced`
- `isDefaultRemoteExpireDateEnforced`

Before these commit, `isExpiryDateEnforced` that is used to
disable/enable the set expiry date checkbox does not take those into consideration
which is problematic as those have different applications.

In addition, this commit now uses `isExpiryDateEnforced` to disable/enable the input for
expiry date that shows up before the creation of link shares.

Here, `hasExpirationDate` is also removed from 'SharingEntryLink` component as it is
not used.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-09-20 16:43:12 +00:00
fenn-cs
27559760d1 Properly align all sharing-entry types
SharingEntryLink and regular ShareEntry were not properly visually aligned
before this commit.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-09-14 16:10:29 +00:00
fenn-cs
2c22e1f86a Ellipsize user status in sharing entry
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-09-13 20:19:12 +00:00
fenn-cs
f596f76af3 Display user status by the side in sharing flow
The quick share drop down now takes the place where the user status
would show in the past, so we have the option of removing it (as it's available
in the profile dropdown) or putting it at the side as such.

It's put on the side without the icon, as the status icon appears on the avatar
when set.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-09-13 15:14:56 +01:00
fenn-cs
766806c35d Enfore allowPublicShares admin setting
Use the the modern intial-state library to pass data about
`allowPublicUploads` to the sharing frontend.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-09-12 20:50:49 +01:00
fenn-cs
faa76b94b8 Add accesibility features to quick share dropdown
- Adds appropriate aria attributes
- Uses button element for dropdown items as it's more semantically correct
- Uses trap-focus lib to trap focus when the drowpdown is active
- Adds custom handling for arrow up and down

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-09-07 10:54:47 +01:00
fenn-cs
f75684ec7e Close quickshare dropdown on outside click
If a user clicks anywhere outside of the quickshare dropdown,
it should be closed.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-09-07 10:54:47 +01:00
Grigorii K. Shartsev
1f6101d8a9 fix(files_sharing): select sharing in sidebar breaks Viewer focus trap
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-09-05 22:15:29 +02:00
julia.kirschenheuter
caf97891ef Replace custom input field with NcTextField
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-08-31 12:33:29 +02:00
fenn-cs
79f62632ea Improve sharing flow
This commit introduces the following changes:

- Does not create new share once user is selected for internal shares
- Adds a `SharingDetails` view for share configurations
- Adds a quick share select to enable fast changes in share permisions.

Resolves: https://github.com/nextcloud/server/issues/26691

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-08-30 17:58:01 +02:00
Ferdinand Thiessen
738c596977 fix(apps): Adjust apps for FilePicker API change
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-26 20:56:09 +02:00
Christopher Ng
8a51d64b09 fix(files_sharing): String translations
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-07-31 23:17:23 +00:00
Richard Steinmetz
270d3a4269
fix(files_sharing): hide download permission for circle shares
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-07-10 08:51:49 +02:00
John Molakvoæ
cd54f7c7f4
chore: upgrade typescript, eslint and fix lint
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-27 16:16:41 +02:00
Louis Chemineau
fbde8f91b6 Don't disable actions when saving share permissions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-06-19 12:13:19 +02:00
Daniel Calviño Sánchez
d4631921b4
Show pending popover menu when password is enabled by default
When "Enforce password protection" is enabled in the sharing settings a
popover menu is shown to set a password before the share is created. On
the other hand, when "Always ask for a password" was enabled in the
sharing settings and a new link share was created the share was
immediately created with a default password; the user was not able to
specify a password (nor create the share without password).

The component template already provided the needed elements to also ask
for the password without enforcing it, but the popover menu was not
shown due to "enableLinkPasswordByDefault" being missing in "if"
conditions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:49:23 +02:00
Daniel Calviño Sánchez
d80f8fc84f
Rename "pendingPassword" to "pendingEnforcedPassword"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:49:15 +02:00
Simon L
f5e8268ced Use the color-primary-element* variables
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-13 10:15:33 +00:00
Louis Chemineau
6faf8b85d6 Do not allow to toggle between password and text in sharing
This does not makes sense as we do not have the clear text value.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-09 17:33:53 +02:00
Christopher Ng
8960df2d6a Fix share input id
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-02 02:22:29 +00:00
rakekniven
f7c115146f fix(l10n): Fixed grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2023-04-18 12:08:38 +02:00
John Molakvoæ
8633f13e0a
chore(eslint): fix missing import extensions
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-03-23 08:14:19 +01:00
Michiel de Jong
c0e84cb512 Add SHARE_TYPE_SCIENCEMESH
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +01:00
Christopher Ng
0c69619d91 Fix share select dropdown not opening when viewer is open
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-01 17:18:39 -08:00
julia.kirschenheuter
76999d1626 Adapt native tooltip for new structure of NcAvatar
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-02-27 15:41:35 +01:00
Christopher Ng
edcf675e6e Drop vue-clipboard2 to fix copy to clipboard
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-01 15:40:13 -08:00
Christopher Ng
0236c9e8cd Port files sharing selector
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-24 17:40:17 -08:00
Christopher Ng
41d7f9dff2 Add visible share label
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-12 22:42:40 +00:00
Christopher Ng
f09300b343 Differentiate share links
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-12 17:23:47 +00:00
Christopher Ng
de7b7d3313 Fix inability to re-enter share password after invalid input
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-10 19:51:14 +00:00
julia.kirschenheuter
1063fbcb10
Replace custom tooltips with native one in vue components and views
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-01-05 08:57:58 +01:00
Christopher Ng
fb2fb0d2d5 Revert "Copy to clipboard with button instead of link"
This reverts commit 4ffc022c8b.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-14 00:57:57 +00:00
Christopher Ng
08e15308cb Add success popup message for copying share links
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-06 01:04:10 +00:00
Christopher Ng
7c943c5ce4 Show success on share actions
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-03 01:09:27 +00:00
Christopher Ng
4ffc022c8b Copy to clipboard with button instead of link
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-24 23:50:54 +00:00
Christopher Ng
20da3d081e Add label to sharing search field
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-23 02:04:18 +00:00
John Molakvoæ
2b4ce7b95d
Fix date handling and saving
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-16 17:19:58 +01:00
Vincent Petry
3bf11dcf60
Fix visibility of internal expire date
Fixed visibility of the expiration date field for internal shares by
aligning the logic with the one from the public link shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-10-28 18:58:52 +02:00
julia.kirschenheuter
1eac730caf Replace moment.js date with Date Object.
Replace vue2-datepicker with native date picker for expiration date.

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-10-06 08:56:06 +00:00
Vincent Petry
42bc63f1a0 Update apps/files_sharing/src/components/SharingEntryInternal.vue
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-27 14:05:46 +00:00
Vincent Petry
64a4abf472
Fix focussing to internal link after copy
Since a recent change to NcActions it's not possible to add a "ref"
attribute on a NcAction* component.

As a workaround, a ref was added on the NcActions parent component
instead.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-27 12:25:22 +02:00
Carl Schwan
3fcb05e900
Port Profile section checbox to NcCheckoxRadioSwitch component
Improve accessibility and unify the design

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-12 15:38:20 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-05 12:59:54 +00:00