Ferdinand Thiessen
1b4243f5a3
fix(NavigationManager): resolve entries only when needed
...
The `init` method previously contained two different logics:
1. It set up the internal state of default apps and app order
2. It resolved the app navigation entries
The 1. is needed before `add` can be called, so it was always called by
the `add` method, but this also resolved all appinfo.xml entries on the
first `add` call even if never used.
The 2. is only needed when the navigations are actually fetched.
This splits the logic into two functions:
- `init` for the bare initialization
- `resolveAppNavigationEntries` for resolving the entries when
requesting to output them.
This should give a small performance improvement for API calls and fixes
a problem when navigations are added before all apps are registered.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-06-07 16:54:21 +02:00
Ferdinand Thiessen
0abaf60352
fix: make sure the core app is loaded
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-06-02 22:51:05 +02:00
Ferdinand Thiessen
b27e4956d1
refactor(NavigationManager): move navigation definitions into apps
...
The manager itself does not need to know what hardcoded-things an app provides,
instead the apps itself should handle this.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-06-02 22:51:05 +02:00
Côme Chilliet
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-01 13:46:39 +02:00
Ferdinand Thiessen
f6a37dc608
refactor(appstore): split controllers and use proper root
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-05-05 10:41:04 +02:00
Ferdinand Thiessen
5b756ad8bc
refactor: split appstore from settings
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-05-05 10:41:04 +02:00
Joas Schilling
f5da0de67e
fix(navigation): Fix default app icon
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2026-04-27 10:51:43 +02:00
Joas Schilling
58619b2a68
fix(apporder): Load custom app order before resolving closures
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2026-03-15 15:31:40 +01:00
Carl Schwan
e56e42e7e7
refactor(navigation-manager): Cleanup implementation and add type hinting
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2026-02-06 13:55:40 +01:00
Carl Schwan
c96ece0bcb
refactor: Add more typing
...
- repairs job
- database
- redis
And remove Helpertest which was unused outside of some tests.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2026-02-06 13:55:39 +01:00
Carl Schwan
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2026-02-06 13:50:18 +01:00
Joda Stößer
16d8cc065a
fix(NavigationManager): Remove break to return all defaultEntryIds
...
Otherwise only the first entry id is returned, breaking loading the value for the "Global Default App" option
Signed-off-by: Joda Stößer <git@simjo.st>
2026-01-06 02:41:37 +01:00
Joas Schilling
553870d30a
fix(navigation): Fix default app entry registered as closure
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-25 14:47:33 +02:00
Robin Appelman
aa34f2f457
fix: reuse default navigation entry when updating navigation entries
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-09 18:39:42 +02:00
Côme Chilliet
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:20 +01:00
Arthur Schiwon
13fefc4612
feat(Navigation): emit dedicated event for loading additional entries
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-12-18 12:50:11 +01:00
skjnldsv
b15fdfd40e
chore(profile): move profile app from core to apps
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:02 +01:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +02:00
provokateurin
d5e98cd190
fix(NavigationManager): Skip invalid default navigation entries
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
b0baaaed9d
feat(NavigationManager): Add default entries handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
0a7fcde906
fix(NavigationManager): Make entry order always an integer
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-05-30 17:00:32 +02:00
Andy Scherzinger
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-24 13:11:22 +02:00
Christopher Ng
a7a8feee51
chore: Rename "Users" menu entry to "Accounts"
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-05-17 10:15:46 -07:00
Christopher Ng
3082bdc788
feat: Update help entry name
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-22 15:19:59 -07:00
Arthur Schiwon
1f2d267443
fix(Navigation): ensure NavManager is inited when adding an entry
...
otherwise custom order cannot be applied
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-03-13 16:05:14 +01:00
Ferdinand Thiessen
876e2d6198
feat(AppManager): Provide getAppIcon function
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 22:40:31 +01:00
Ferdinand Thiessen
b1fffb0d3b
enh(NavigationManager): Use ID as fallback for app property of entries
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-06 15:46:22 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Ferdinand Thiessen
8d0c7cc5fa
fix: Allow to set custom app order on navigation entries added by closures to NavigationManager
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:03:28 +01:00
Ferdinand Thiessen
8bd9858345
fix(NavigationManager): Set default app in add function to allow entries added as closures
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:03:28 +01:00
Ferdinand Thiessen
84acc49932
fix(NavigationManager): Check for appManager before using it
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:03:28 +01:00
Christopher Ng
407b67989d
enh: Register profile nav entry
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-26 10:30:22 -07:00
Ferdinand Thiessen
363d9ebb13
feat(NavigationManager): Always sort the default app first
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-19 22:04:20 +02:00
Hamid Dehnavi
ea06cf2f39
Convert isset ternary to null coalescing operator
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-28 17:44:19 +03:30
Côme Chilliet
6083d32a80
Revert "Support admin default order for applications"
...
This reverts commit a3a42591e2 .
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-26 14:22:57 +02:00
Côme Chilliet
a3a42591e2
Support admin default order for applications
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-25 15:43:04 +02:00
Côme Chilliet
ac19ba9c66
Read apporder from configuration value
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-25 15:02:23 +02:00
Joas Schilling
2abb503e60
fix(API): Fix parameter name to match interface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-01 11:17:06 +02:00
Côme Chilliet
426c0341ff
Use typed version of IConfig::getSystemValue as much as possible
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +02:00
jld3103
02f9c3a06f
Use implementations instead of interfaces for accessing private methods
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-03-30 12:33:46 +02:00
Joas Schilling
bf7fe04c4b
fix(appinfo): navigation type is optional
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-03 09:52:37 +01:00
Christopher Ng
62b7bb7395
Allow settings navigation items with no route entry
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-02 17:11:17 -08:00
John Molakvoæ
5f58660de5
Fix navigation order
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-22 12:11:35 +01:00
Vincent Petry
da01494a37
Add accessibility entry in user menu
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-14 15:05:35 +02:00
Valdnet
d9399e1246
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
l10n: Change to administration
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
l10n: Spelling unification
Spelling unification in Transifex.
Match the menu name to the header name of the settings page.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-09-02 12:42:07 +02:00
szaimen
0c90474296
add a better icon for personal settings
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-08-31 15:37:48 +02:00
szaimen
955b6bb82e
add a way to open the admin settings overview directly
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-08-30 15:46:09 +02:00
Julius Härtl
a94236483e
Let apps toggle an unread counter on app icons
...
Co-authored-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-16 17:12:56 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00