Commit graph

546 commits

Author SHA1 Message Date
fenn-cs
08323ee834 fix(deleteAction): Bump up delete requests concurrency to 5
A concurrency of who is not efficient. Low throughput, underutilization, high latency etc...

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-17 07:17:06 +01:00
Louis Chemineau
938eabd619
fix(files): Ignore right click for default action
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-13 16:16:08 +02:00
skjnldsv
343b690d80 fix(files): fetch nodes if we have multiple of the same fileid in the store
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 17:57:14 +02:00
skjnldsv
1d7893dca8 fix(files): do not rely on unique fileid
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 17:15:51 +02:00
John Molakvoæ (skjnldsv)
a094ac0b6d fix(files): also trigger new tab on file name middle click
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-06-12 11:52:22 +00:00
skjnldsv
a0a36563b6 fix(files_sharing): fix parsing of remote shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 10:27:29 +02:00
Ferdinand Thiessen
7f3cc7502b
fix(files): Use data-cy (data attribute) instead of cy-data
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 21:34:28 +02:00
Ferdinand Thiessen
53324821be
refactor(files): Migrate personal view to @nextcloud/files functions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 15:45:22 +02:00
Ferdinand Thiessen
de2276e6d7
refactor(files): Migrate favorites view to @nextcloud/files functions and make it cancelable
Also this fixes the view being writeable

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 15:45:22 +02:00
Ferdinand Thiessen
b1444e78e2
refactor(files): Migrate recent view to @nextcloud/files functions and make it cancelable
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 15:45:22 +02:00
Ferdinand Thiessen
85e6cb4ccc
refactor(files): Migrate files service to functions from @nextcloud/files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 15:45:21 +02:00
Ferdinand Thiessen
75dcf901ff
fix(files): Ensure that focussed file is always scrolled right
Ensure the correct file is scrolled if the content changes,
this also sets a minimal height to the virtual scrolling area
so that the `scrollTop` can be set.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:58:45 +02:00
Ferdinand Thiessen
fbceac9fe1
fix(files): Keep query when trigger the sidebar action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:58:45 +02:00
Ferdinand Thiessen
423c93087e
fix(files): open-in-files action should also set openfile query
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:58:45 +02:00
Ferdinand Thiessen
13d9a1007b
refactor(files): Fix TypeScript issues in FileEntryActions
* We filter the array in `enabledSubmenuActions` so we can be sure the action does have a parent
* Node attributes must be accessed using the `attributes` getter not the private `_attributes` property
* Cast action ref to correct component interface to make TypeScript happy

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:58:45 +02:00
Ferdinand Thiessen
a6e0f083fb fix(files): Correctly type virtual files list ref type
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-06-07 18:11:03 +00:00
Andy Scherzinger
c1555fc33e
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-06 18:05:37 +02:00
John Molakvoæ (skjnldsv)
af5a29e568 fix(files): reset menu pos when opening in grid mode
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-06-04 13:48:03 +00:00
Ferdinand Thiessen
d33cfdd14b fix(files): Only execute default action if there is an action to perform
Some files do not have a default action (can not be viewed and only downloaded).
If the `openfile` query is set on them the `handleOpenFile` will throw an error.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-04 14:41:08 +02:00
Ferdinand Thiessen
91ac7dfb7c fix(files): Update current fileid in route if that node was deleted
We do not change the view to the trash bin but stay in the current view,
so we need to update the current fileid on the route if that was deleted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-04 12:40:48 +02:00
Ferdinand Thiessen
c1fdd9031c fix(files): Close sidebar if shown node is deleted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-04 12:40:48 +02:00
Ferdinand Thiessen
ceafe43a4c
refactor(files): Make currentView a prop of FilesListTableFooter
We already have this as a required prop in `FilesListVirtual`,
so passing it to the footer is straight forward and removed need of computed
value.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 17:17:31 +02:00
Ferdinand Thiessen
e8adb97098
refactor(files): Properly add type information to FilesListTableFooter
- Add correct type for `nodes` prop.
- Use `defineComponent` to properly infer Typescript information
- Correct usage of nullish coalescing operator

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 17:17:31 +02:00
Ferdinand Thiessen
297f0522b2
refactor(files): Fix Typescript issues in filesListWidth mixin
Use `defineComponent` to properly inherit typings.
Expect TS errors for the `$resizeOberserver` as we attach it directly on the component instance.
`filesListWidth` is now a number which defaults to 0,
making compares like `this.fileListWidth < 768` valid in Typescript.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 17:17:31 +02:00
Ferdinand Thiessen
0cb32880ee
refactor(files): Correctly cast table ref to fix TypeScript errors
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 17:17:31 +02:00
Ferdinand Thiessen
622bf30031
fix(deps): Update @nextcloud/event-bus to version 3.3.1
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 12:46:20 +02:00
Ferdinand Thiessen
67d8277c49
fix: Update @nextcloud/files to 3.4.0 to fix public link shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 12:46:20 +02:00
Ferdinand Thiessen
2c47f24266 refactor(files): Consistently sort imports of FileEntryMixin
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 11:39:39 +02:00
Ferdinand Thiessen
7c4dcf51c4 fix(files): Ensure entry with fileid is marked as active
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 11:39:39 +02:00
Ferdinand Thiessen
14635929e9
fix(files): Keep 'back'-button for not found directories or if user can not upload
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-29 14:47:39 +02:00
Marco
1526a6f7c2
feat(files): Show upload menu in folders' emptycontent
Signed-off-by: Marco <marcoambrosini@icloud.com>
2024-05-29 14:44:57 +02:00
Andy Scherzinger
5b7dcc1427
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-29 08:58:16 +02:00
Ferdinand Thiessen
8ce36085c7
fix(files): Adjust type import and usage for removed dependency
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-27 19:02:13 +02:00
Ferdinand Thiessen
0e7498b917
fix(files): Implement SortingService to fix sorting of files
The previously used library was parsing strings to try to detect dates,
but for filenames it makes no sense to parse them as dates.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-27 13:48:33 +02:00
skjnldsv
3ca3c65b0d feat(files): refresh preview on etag change
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-05-23 11:56:27 +00:00
Ferdinand Thiessen
dfd0fa673d fix(files): Debounce does not return a function so it should be used as computed
This also fixes hacky solution to `this` access

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-23 07:19:06 +02:00
Ferdinand Thiessen
42001984f3 fix(files): Use translation function directly instead of calling the instance method
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-23 07:19:06 +02:00
Ferdinand Thiessen
eacdc4571d fix(files): Fix typing issues with data
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-23 07:19:06 +02:00
Ferdinand Thiessen
85c93b54a4 fix(files): Fix naming issue for reserved Vue property names
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-23 07:19:06 +02:00
Ferdinand Thiessen
a8f4b25ae8
fix(files): Drop xml2js dependency and use browser native DOMParser
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-17 10:03:38 +02:00
fenn-cs
21a22a390d perf(deleteAction): Queue delete requests
When multiple files are deleted at once, all the requests bombard the server
simultaneously, causing performance issues.

This commit adds queuing that limits the concurrency of these requests to 5
at a time.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-15 11:51:07 +01:00
fenn-cs
23c71bd862 fix(deleteAction): Remove unused nc l10n import
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-15 11:51:07 +01:00
Ferdinand Thiessen
5d8133bb18 fix: Do not import styles that are already included in server bundle
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-06 15:36:28 +02:00
Ferdinand Thiessen
7dbe89f921 fix(files): Add missing properties and fix Typescript errors in FileEntryName
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-02 20:03:23 +02:00
Raphaël Jakse
c53e4a8b96 fix(files): apply the renaming when leaving the input field
Refs: #42689

Signed-off-by: Raphaël Jakse <raphael.git@jakse.fr>
2024-05-02 16:30:12 +02:00
Ferdinand Thiessen
c6f3aecef1
fix(files): Use string array instead of string for forbidden characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-29 17:15:00 +02:00
Pytal
8fb6d15142
Merge pull request #44805 from nextcloud/fix/selected-files-count
fix(files): Display selected files count
2024-04-17 16:23:06 -07:00
Ferdinand Thiessen
6c9ca8b025
fix(comments): Fix issues thrown by comments sidebar tab code
When the comments tab is used instead of the merged activity+comments, then some issues are throws due to prop altering and duplicated names (resourceId as prop and data).

This is fixed as well as some other vue related errors in the sidebar

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-17 20:09:14 +02:00
Christopher Ng
a999544ff2 fix(files): Display selected files count
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-17 10:32:03 -07:00
Ferdinand Thiessen
16eebd3743
fix(files): Ensure search query is cleared when changing view or directory
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-17 14:06:29 +02:00