upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-12 10:10:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 20
74245 commits 1040 branches 1221 tags 8.4 GiB
Commit graph

201 commits

Author SHA1 Message Date
Simon L
d25d5d34f7 adjust admin setup check to increase warning to set up https 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-06-20 22:54:48 +02:00
Julius Härtl
a6966c0b2d
feat: Add setup check warning if instance is in debug mode 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-05-09 07:34:03 +02:00
Andy Scherzinger
f5c4f55576
Merge pull request #37451 from Fenn-CS/fix/36437/deprecate-php-8.0 
Deprecate PHP8.0
 2023-04-19 15:28:12 +02:00
Simon L
1a255379e8
Merge pull request #37766 from nextcloud/enh/noid/add-db-file-locking-check 
add an admin check for db file locking
 2023-04-18 13:31:57 +02:00
Simon L
e2ab9bf4af address review and fix tests 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-04-18 11:33:53 +02:00
fenn-cs
60a710c91c Deprecate PHP8.0 
PHP8.0 would stop receiving security support on 26 Nov 2023
 hence this deprecation. Next, is the eventual drop of PHP8.0 before its EOL.

This commit also updates the message type from INFO to WARNING if the php
 on file has reached its EOL.

See: https://www.php.net/supported-versions.php

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2023-04-17 23:45:59 +01:00
Alexander A. Klimov
e3f1fae715 Omit "Accessing site insecurely via HTTP." warning if HTTP is secure enough 
This is the case for localhost and Tor hidden services.

Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
 2023-04-17 23:38:29 +02:00
Simon L
80645a591a add an admin check for db file locking 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-04-17 12:51:33 +02:00
MichaIng
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow" 
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
 2023-02-15 20:16:51 +01:00
Côme Chilliet
d4ed1a13fd
Revert "update 64-bit check wording" 
This reverts commit f5ad282418.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 15:02:54 +01:00
Christoph Wurst
75a1721d7d
Deprecate PHP7.4 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-11-10 09:56:32 +01:00
Valdnet
ea41f21bbe
l10n: Shorten link 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-11-05 18:14:41 +01:00
szaimen
f5ad282418 update 64-bit check wording 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-11-01 13:50:50 +01:00
Valdnet
a9f20b94c9 l10n: Spelling unification 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-19 08:05:50 +00:00
Simon L
4209dc7d66
Merge pull request #33475 from nextcloud/rakekniven-patch-1 
l10n: Changed grammar
 2022-08-31 19:34:29 +02:00
Joas Schilling
85eb3b2920
Fix wording of undeliverable push notifications 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-08-31 12:42:31 +02:00
rakekniven
a3a5ba0474
l10n: Changed grammar 
See https://en.wikipedia.org/wiki/32-bit_computing and related articles.

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-08-06 20:01:38 +02:00
szaimen
c1b88f927e add a link to system requirements for new 64bit setup check 
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
 2022-07-13 22:16:42 +02:00
szaimen
cf9b1082ed add a setup check for 64 bit 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-07-13 09:33:33 +00:00
Valdnet
7cb012d86e Return to quotation marks 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-03-31 16:21:28 +02:00
Valdnet
a3f8f08d50 Correct code 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-03-31 16:21:28 +02:00
Valdnet
d94b19de93 Code ordering for text strings 
Code cleanup for text strings and change quotation marks to apostrophe for 'occ'.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-03-31 16:21:06 +02:00
MichaIng
ea0e45d81e Remove legacy Internet Explorer headers 
X-UA-Compatible and X-Download-Options headers are interpreted or relevant for Internet Explorer only. With the deprecation of Internet Explorer support in Nextcloud 20 and planned support removal already in Nextcloud 22, these became obsolete and are hereby removed, including their removal from setup checks.

Signed-off-by: MichaIng <micha@dietpi.com>
 2022-03-19 18:17:46 +01:00
Simon L
3a0b934f84
Merge pull request #31430 from nextcloud/enh/31429/improve-overwrite-cli-url-check 
Validate `overwrite.cli.url` to be a url in setup check
 2022-03-10 12:40:59 +01:00
szaimen
4191a178dd improve overwrite cli url setup check 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-03-09 22:26:00 +01:00
szaimen
7dca146b58 allow to disable the imagick warning 
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
 2022-03-07 17:35:12 +01:00
MichaIng
5ac91f1cb8 Add Nextcloud docs link to OPcache recommends 
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.

Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.

Signed-off-by: MichaIng <micha@dietpi.com>
 2022-03-03 23:00:07 +00:00
Arthur Schiwon
b28aa52b28
Setup warning for invalid LDAP user or group UUIDs. 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-02-10 10:15:01 +01:00
Valdnet
105169433e
Update core/js/setupchecks.js 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>

Co-authored-by: Simon L. <szaimen@e.mail.de>
 2022-02-04 10:17:08 +01:00
Valdnet
e172eb09e0
l10n: Remove spaces 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-02-04 09:55:36 +01:00
szaimen
84cf39f582 show if the mail server settings are not set or verified 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-02-03 20:16:35 +01:00
MichaIng
82c1beaacb Enhance and complement OPcache setup checks 
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
 2021-12-19 23:38:21 +01:00
Vitor Mattos
e55ceb2bb1
Show warning on admin settings page 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2021-10-23 00:54:50 +02:00
Christoph Wurst
4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23 
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-10-18 09:15:54 +02:00
Carl Schwan
a01917510d
Merge pull request #28863 from nextcloud/Valdnet-patch-2 
l10n: Correct spelling
 2021-09-22 14:08:25 +02:00
Stefan
8758b36ebb Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable 
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
 2021-09-17 13:32:42 +02:00
Valdnet
d0558a6188
l10n: Spelling unification 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-09-16 16:16:27 +02:00
Valdnet
4fa170b918
l10n: Correct spelling 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-09-16 15:57:53 +02:00
Guillaume Virlet
ec38cf3b53 [Fix #26726] wrong warning when running HTTP instance 
Signed-off-by: Guillaume Virlet <github@virlet.org>
 2021-04-23 22:23:23 +02:00
Valdnet
2b6cda99d3
l10n: Correct text strings 2021-03-02 11:41:45 +01:00
Joas Schilling
96ae83c529
Remove HTML from setup check translations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-01 20:24:02 +01:00
Joas Schilling
9569df7405
Add target black and noref rules to doc links 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-01 19:42:34 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Christoph Wurst
f37e150d1c
Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api 
Add well known handlers API
 2020-12-18 13:34:04 +01:00
Julius Härtl
b9330887ca
Merge pull request #24740 from nextcloud/bugfix/24738/improve-phone-region-help 
Improve hints for default_phone_region
 2020-12-17 15:29:54 +01:00
Joas Schilling
15956c20c3
Improve hints for default_phone_region 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-17 09:14:21 +01:00
Christoph Wurst
6995223b1e
Add well known handlers API 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 13:13:05 +01:00
Arthur Schiwon
1995097cb8
promoted bad memory_limit setting to error as it may break updater 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-12-15 23:50:26 +01:00
Joas Schilling
46b073d7ce
Add a config for default region of phone numbers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
John Molakvoæ
0e1c9af98d
Merge pull request #23869 from nextcloud/rakekniven-patch-1 2020-11-04 12:12:53 +01:00
rakekniven
bb04df16c1
Update core/js/setupchecks.js 
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2020-11-03 21:27:52 +01:00
rakekniven
9d32ca1884
Update setupchecks.js 
Changed wording of setup check.
Reported at Transifex.

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-11-03 15:55:18 +01:00
Morris Jobke
1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-03 10:06:33 +01:00
nhirokinet
830348dbee
Add SVG support check to setup check 
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
 2020-11-02 11:29:08 +01:00
Daniel Kesselberg
9c8e8007f9
Remove setup check for php mail 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-10-03 21:58:55 +02:00
Morris Jobke
f5efd18b07
Clarify PHP warning in admin settings 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-10 11:08:25 +02:00
Morris Jobke
603d7dab5e
Add setup check that links to the migration documentation 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-19 15:45:45 +02:00
Daniel Kesselberg
c1831f1902
Change const/let to var for PhantomJS 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-08-07 17:34:03 +02:00
Daniel Kesselberg
89c6a2bc1f
Add setup checks for php default charset and output buffering. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-07-26 00:54:16 +02:00
Joas Schilling
720dc4e93d
Add optional column oc_comments.reference_id 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-31 10:51:15 +02:00
Roeland Jago Douma
b0ea022a3e
Add basic reverseproxy misconfig detection to setupchecks 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-23 10:37:08 +01:00
Roeland Jago Douma
c8a360cd7a
Merge pull request #19580 from nextcloud/debt/noid/outdated-check 
Update check for outdated php version.
 2020-03-10 20:10:54 +01:00
Daniel Kesselberg
6eb466776b
Don't show referrer policy warning if fallback policy set. 
Test-Set:

no-referrer-when-downgrade
no-referrer
strict-origin-when-cross-origin
same-origin
no-referrer, strict-origin-when-cross-origin
strict-origin-
unsafe-raw, same-origin
strict-origin-when-downgrade

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-02-26 23:51:02 +01:00
Daniel Kesselberg
f228d73b38
Update check for outdated php version. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-02-24 20:14:13 +01:00
Daniel Kesselberg
bfc956fc88
Set content type for propfind request 
Without the request is sent as application/x-www-form-urlencoded; charset=UTF-8 and might be blocked by some application firewalls because content and content type do not match.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-02-21 22:13:49 +01:00
Victor Goff
2663fc442c adviced should be advised 
Signed-off-by: Victor Goff <keeperotphones@gmail.com>
 2019-08-23 07:01:45 -04:00
Christoph Wurst
20afe94297 Do not show a internet connectivity warning if internet access is disabled 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-06-27 10:51:59 +02:00
Christoph Wurst
0f3e438f7c
Move OC.theme to the bundle and deprecate oc_defaults 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-05-14 11:14:29 +02:00
Morris Jobke
c8f2198aa0
Remove recommendation for opcache on CLI 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-05-09 12:25:53 +02:00
Morris Jobke
25d700ef30
Fix unneeded doc link to unrelated resource 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-03-11 11:00:21 +01:00
Morris Jobke
060b637b70
Show a setup warning in case S3 object storage is used as primary storage 
* checks for at least 50 GB of free space

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-03-08 13:38:39 +01:00
Morris Jobke
6c7ccbecbf
Add setup check for missing UTF8MB4 on mysql 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-02-28 16:46:23 +01:00
Morris Jobke
faef05730a
Add unit tests and provide better message 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-02-20 10:54:39 +01:00
Bjoern Schiessle
7c31c9a748
add setup check for ocm-provider route 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2019-02-20 10:38:16 +01:00
Morris Jobke
0aa30b76de
Merge pull request #13134 from nextcloud/bugfix/13088/404-instead-of-exception 
returns a 404 instead of exception if app is not installed - #13088
 2019-01-04 17:08:04 +01:00
Daniel Kesselberg
248e824f48
Remove check for outdated caches 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2019-01-02 10:46:14 +01:00
Julius Härtl
a3be286273
Make setup check also pass with a 501 status 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-12-19 07:41:25 +01:00
Morris Jobke
17b2827bbf
Add setup check for pending bigint conversion 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-12-05 13:42:31 +01:00
Morris Jobke
5b22225351
Update casing of PHP inside method name 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-12-05 00:03:05 +01:00
Morris Jobke
f5ad80fc57
Add setup check for recommended PHP modules (i.e. Imagick, intl) 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-12-05 00:03:05 +01:00
Morris Jobke
f5894b653d
Add check for missing .woff2 rule in Nginx via setup check 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-29 17:01:43 +01:00
Morris Jobke
df6e9109c8
Merge pull request #11396 from nextcloud/wellknown-webfinger 
adding .well-known/webfinger
 2018-10-24 14:51:15 +02:00
Daniel Peukert
2da4f96bd6 Remove arrow function 
Signed-off-by: Daniel Peukert <dan.peukert@gmail.com>
 2018-10-17 18:10:37 +02:00
Daniel Peukert
b2dfcb5a18 Check if the X-XSS-Protection header contains the required fields 
Signed-off-by: Daniel Peukert <dan.peukert@gmail.com>
 2018-10-17 14:28:51 +02:00
Moritz Beck
b68661ed6e
Allow "same-origin" as "Referrer-Policy" 
Fixes #11531

Although "same-origin" is more strict than e.g. strict-origin it showed up a warning in setupcheck
Based on https://scotthelme.co.uk/a-new-security-header-referrer-policy/

Signed-off-by: Moritz Beck <git@birkenstab.de>
 2018-10-11 13:17:26 +02:00
Daniel Calviño Sánchez
d143b43a04 Make possible to set the expected status of the well known URL check 
The check is based on the HTTP status returned by the URL, and different
URLs may return different status (for example, DAV returns 207, while
a service like WebFinger would return 200), so the expected status needs
to be set depending on the URL.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-10-10 13:48:56 +02:00
Timo Förster
006e150c87 Change check if secure randomness is possible. 
Signed-off-by: Timo Förster <tfoerster@webfoersterei.de>
 2018-08-24 23:12:02 +02:00
Michael Weimann
2bab916c53
Adds license to files. Updates the branch. 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
 2018-08-20 20:46:23 +02:00
Michael Weimann
c164409ee7
Adds a memory limit warning for console commands if the limit is below the recommended value 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
 2018-08-20 15:24:10 +02:00
Michael Weimann
c2fced4463
Adds a setup check for the memory limit 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
 2018-08-20 15:24:10 +02:00
Michael Weimann
b2e60e365d
Adds a setup check for app directory permissions. 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
 2018-08-09 19:47:55 +02:00
Cthulhux
f6f49c77f7
opcache module check 
Improved the speed of isOpcacheProperlySetup() (instant return instead of continuing when we're already failed), added a check for the opcache extension itself. Potentially fixes #9410

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-07-11 16:08:40 +02:00
Roeland Jago Douma
6a0c54d5bf
Add warning to setup checks if the default mailer is still php 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-07-04 08:28:33 +02:00
Morris Jobke
9c4aecb539
Merge all setup checks into one controller 
* renamed hasMissingIndexes to missingIndexes

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-06-13 15:25:08 +02:00
Morris Jobke
cd87a40eb3
Merge pull request #9836 from nextcloud/feature/noid/merge-tips-and-tricks-into-setup-checks 
Merge tips & tricks section into setup checks
 2018-06-13 13:18:40 +02:00
Morris Jobke
4a0b7aaf6c
Merge tips & tricks section into setup checks 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-06-13 12:05:38 +02:00
Morris Jobke
624d191ef6
Fix wrong hint about missing indexes 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-06-13 11:56:43 +02:00
Morris Jobke
393d9aae74
Add a hint that some indexes are not added yet 
* gives the admin a chance to discover the missing indexes and improve the performance of the instance without digging through the manual
* nicely integrated in the setup checks where this kind of hints belong to
* also adds an option to integrate this from an app based on events
* fix style of setting warnings

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-06-06 16:55:01 +02:00
Roeland Jago Douma
4b70c9f89d
Add referrer policy setup check 
Fixes #9122

Based on https://www.w3.org/TR/referrer-policy/ and
https://scotthelme.co.uk/a-new-security-header-referrer-policy/

Setting a sane Referrer-Policy will tell the browser if/when to send
referrer headers when accessing a link from Nextcloud. When configured
properly this results in less tracking and less leaking of (possibly)
sensitive urls

* Fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-06-04 09:21:35 +02:00