Commit graph

6196 commits

Author SHA1 Message Date
Maxence Lange
7c04818c5c feat(user-prefs): iterator instead of array on search
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 -01:00
Maxence Lange
e73513bdd1 fix(user-prefs): adding sensitive and indexed as flags
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 -01:00
Maxence Lange
65e24f7def feat(user-prefs): IUserPreferences
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 -01:00
Côme Chilliet
0718984bdf
Merge pull request #48675 from georglauterbach/master
DNS: do not query CNAME if A succeeded already
2024-11-14 11:43:32 +01:00
skjnldsv
158299b3d7 fix(profile): make sure the app cannot be disabled as it was in core
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:10 +01:00
SebastianKrupinski
7ebeed45bd feat: add iMip Request Handling
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-11-07 21:12:37 -05:00
Robin Appelman
b21c0265df
test: add some minimal testing for metadata storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-07 16:27:16 +01:00
Joas Schilling
c3c8b7e2a3
fix(richobjectstrings): Add missing placeholder validation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-06 21:31:41 +01:00
georglauterbach
387cd8b771
fix: do not query CNAME if A succeeded already
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-06 20:21:38 +01:00
John Molakvoæ
3c4290631b
Merge pull request #49039 from nextcloud/jtr/fix-ipv6-zone-ids-link-local 2024-11-06 09:17:52 +01:00
John Molakvoæ
8fab143aa4
Merge pull request #48721 from nextcloud/feat/allow-getter-setter-decl-fors 2024-11-06 08:54:40 +01:00
Daniel Calviño Sánchez
5ea5b2de84
fix: Handle exception when clearing previously removed two factor tokens
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 11:14:05 +01:00
Daniel Calviño Sánchez
381a2aa627
fix: Clear pending two factor tokens also from configuration
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 11:14:04 +01:00
Josh
e885e4f13d
fix(tests): Add IpAddressClassifier v6 zone ID test
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-04 09:31:48 -05:00
Josh
97421fb143
fix(tests): Add RemoteAddress v6 zone ID test
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-04 09:30:21 -05:00
Côme Chilliet
901496276b
Merge pull request #47425 from nextcloud/fix/avoid-invalid-share-on-transfer-ownership
fix: promote re-shares when deleting the parent share
2024-11-04 10:09:58 +01:00
Benjamin Gaussorgues
79db082fe6 fix(users): improve recently active search
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +01:00
John Molakvoæ
e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders 2024-10-29 11:33:12 +01:00
Kate
d25a0a2896
Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password 2024-10-28 13:26:55 +01:00
Ferdinand Thiessen
86006368bf
Merge pull request #48912 from nextcloud/bugfix/exception-appscreenshot-notstring
fix(apps-store): Fix exception on generating preview url for installed app screenshot
2024-10-28 11:32:15 +01:00
yemkareems
a74ef8237d
fix: crypto type made not nullable and tests run using ICrypto
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 15:04:11 +05:30
Kate
5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors 2024-10-28 10:19:41 +01:00
Joas Schilling
220bd3422f
fix(appinfo): Make sure screenshot, author and category are always arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-28 08:46:31 +01:00
yemkareems
505dfd65fd
fix: encrypt and store password, decrypt and retrieve the same
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 11:22:36 +05:30
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 13:24:18 +02:00
Joas Schilling
54c3aa3f99
fix(entity): Fix mapping of old/sub-types to actually supported database types
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-23 09:22:05 +02:00
Ferdinand Thiessen
2ef74b9860
Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-support
feat(AppFramework): Add full support for date / time / datetime columns
2024-10-18 19:05:08 +02:00
Joas Schilling
882f91605b
fix(comments): Add test for email mention
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-18 07:39:41 +02:00
Ferdinand Thiessen
db94e10af0
fix: Prevent breaking change in IQueryBuilder
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:44 +02:00
Ferdinand Thiessen
ee02e3246d
feat(AppFramework): Add full support for date / time / datetime columns
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.

Similar the parameter types needed to be added.

`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.

Also added more tests, especially to make sure the mapper really serializes the values correctly.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:42 +02:00
Ferdinand Thiessen
9a7e1bb227
feat(DeclarativeSettings): Allow to implement value getter and setter directly in Form
Instead of implementing the form class, a setter event listener and a getter event listener,
this allows to simply write a basic class that provides `getSchema`, `setValue` and `getValue` functions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-15 20:33:45 +02:00
Ferdinand Thiessen
b964e05312
Merge pull request #48673 from nextcloud/fix/null-label
fix(share): Return empty string if no label is set
2024-10-14 19:10:12 +02:00
Côme Chilliet
d6ba524263
fix: Use getRelativePath method to check if node is inside folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 17:23:29 +02:00
Ferdinand Thiessen
980ab1f56b
fix: Shipped apps should include the Nextcloud version in the cache buster
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 16:04:13 +02:00
Ferdinand Thiessen
2e4d3e4e75
fix(share): Return empty string if no label is set
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 15:15:51 +02:00
Côme Chilliet
e584e9baf7 fix: Fix promotion of reshares from subsubfolders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +02:00
Côme Chilliet
3ee5bf6af1 fix(tests): Fix share tests to test new reshare promotion system
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +02:00
Côme Chilliet
7e9bc7c8cf fix: Tidy up code for reshare deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +02:00
Luka Trovic
42181c2f49 fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +02:00
Robin Appelman
7cb07bf306 test: add test for nested jail cross-storage move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-10 15:16:12 +02:00
Kate
356f3ded52
Merge pull request #48610 from nextcloud/fix/usertrait/backend-initialization 2024-10-08 16:53:26 +02:00
provokateurin
902fb8f9fc
fix(UserTrait): Fix backend initialization
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 11:12:01 +02:00
provokateurin
f28e74b7a8
refactor(Storage): Make all parameter types strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 15:00:05 +02:00
provokateurin
4412b2b8a8
refactor(Wrapper\Encryption): Migrate to strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 14:11:56 +02:00
provokateurin
d1977b8d25
refactor(Stream\Encryption): Migrate to strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 14:02:27 +02:00
Joas Schilling
e6cd1051da
fix(message): Fix logic of Mail test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:38 +02:00
Ferdinand Thiessen
3095a92551
Merge pull request #47896 from nextcloud/fix/resiliant-user-removal
fix: Make user removal more resilient
2024-10-07 11:33:07 +02:00
Daniel Kesselberg
6be00432b7
chore: always execute parse_url in preventLocalAddress
This change should make it easier to spot wrong uses of the HTTP client on development setups where allow_local_remote_servers is usually true.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-10-01 18:00:47 +02:00
Ferdinand Thiessen
eb69e89fa5
chore: Drop unused legacy OC_Files
It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:40 +02:00
Ferdinand Thiessen
0f6760c810
feat(files): Make the files download action use WebDAV zip download
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:29 +02:00
Ferdinand Thiessen
16833aff86
fix: Make user removal more resilient
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-26 20:48:37 +02:00
provokateurin
256a8d8903
test: Fix IStorage return types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 17:29:48 +02:00
Côme Chilliet
280f6df66c
Merge pull request #32018 from nextcloud/cleanup/event/trashbin
Port files trashbin events to IEventDispatcher/IEventListener
2024-09-24 17:15:39 +02:00
Richard Steinmetz
19ad13571c
fix: gracefully parse non-standard trusted certificates
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-24 12:36:09 +02:00
Côme Chilliet
4adf5fd5b0
fix(tests): Pause trashbin for lock tests in ViewTest using rmdir and unlink
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-24 10:37:38 +02:00
Côme Chilliet
af0b8fbd17
fix(tests): Fix tests now that trashbin listens to events properly
Hooks are cleared in test bootstrap so switching to events activates
 them in tests.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 18:13:29 +02:00
Joas Schilling
82566c5479
fix(rtl): Make clear that the direction is based on language
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 17:00:07 +02:00
Mostafa Ahangarha
d94745201b
fix(rtl): Add unittest for language direction
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-09-23 16:59:21 +02:00
Côme Chilliet
40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface
fix: Move storage constructor to specific interface
2024-09-23 15:57:38 +02:00
Côme Chilliet
b8ab560bdd
fix(tests): Fix test to remove call to non-existing constructor
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 14:50:43 +02:00
Louis Chemineau
22d5d29c01 fix(users): Don't crash if disabled user is missing in the database
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 10:40:38 +02:00
Andy Scherzinger
3009da3722
Merge pull request #43968 from exi/custom-binary-search-paths
feat: make search path for BinaryFinder customizable.
2024-09-20 19:14:17 +02:00
Git'Fellow
2ba3f7ed5c
Merge pull request #47782 from nextcloud/reworkShareExceptions
fix(l10n): Rephrasing some exceptions to be translated
2024-09-20 18:53:40 +02:00
Git'Fellow
dcbe8da2a6 fix(l10n): Rephrasing some exceptions to be translated
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-20 18:35:11 +02:00
Reno Reckling
ef7e857881
feat: make search path for BinaryFinder customizable.
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue #43922

Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Reno Reckling <e-github@wthack.de>
2024-09-20 17:00:06 +02:00
Julius Knorr
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +02:00
Ferdinand Thiessen
2a59f4fc95
Merge pull request #48220 from nextcloud/chore/remove-travis
chore: Remove old travis related stuff
2024-09-19 23:26:39 +02:00
Ferdinand Thiessen
9813cbf616
Merge pull request #48217 from nextcloud/chore/prepare-oc_repair-unit10
chore: Cleanup and prepare `\OC\Repair\RepairMimeTypes` tests for PHPUnit 10
2024-09-19 20:50:35 +02:00
Ferdinand Thiessen
7ae7f7fd12
chore: Remove old travis related stuff
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 20:16:29 +02:00
Ferdinand Thiessen
349a9fc5f6
chore: Cleanup and prepare \OC\Repair\RepairMimeTypes tests for PHPUnit 10
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 19:25:42 +02:00
Joas Schilling
4ccf62a224
chore: Cleanup and prepare some app tests for PHPUnit 10
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-19 18:19:32 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +02:00
Ferdinand Thiessen
44c7248749
refactor(Collaboration): Use non-deprecated methods
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:20 +02:00
Côme Chilliet
989d708bd8
Merge pull request #48137 from nextcloud/enh/add-rich-object-formatter
feat: Add OCP interface to format richtext into string
2024-09-18 18:59:56 +02:00
Robin Appelman
1db3d94e1e test: put parent items into cache in tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 16:10:14 +02:00
Robin Appelman
74adaebf96 test: fix incorrect ltrim usage in test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 14:11:27 +02:00
John Molakvoæ (skjnldsv)
8fb64b886a
fix(settings): pronouns UsersControllerTest
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 13:30:33 +02:00
Côme Chilliet
b124f19777
fix(tests): Adapt tests to changes in RepairMimeTypes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 19:34:44 +02:00
Côme Chilliet
cfca7e7911
fix(tests): Fix most obvious errors in ObjectStore tests
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 19:20:13 +02:00
Côme Chilliet
2bdc97741c
fix(tests): Fix Folder tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 19:19:08 +02:00
Côme Chilliet
9a9dd10c0c
fix(tests): Remove deprecated tests for ServerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 17:48:01 +02:00
Stephan Orbaugh
f25acfb799
Merge pull request #47986 from cfiehe/fix_move_on_same_bucket
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
2024-09-17 16:35:19 +02:00
Côme Chilliet
b926df4730
fix: Adapt notifications and activity tests to new DI dependency
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 15:28:09 +02:00
provokateurin
8ca6fcace7
fix(Storage): Document getOwner() can return false
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +02:00
Côme Chilliet
b9fb1db0f8
Merge pull request #48009 from nextcloud/fix/remove-references-to-deprected-storage-interface
fix: Remove OCP\Files\Storage interface deprecated since version 9
2024-09-16 20:50:38 +02:00
Robin Appelman
ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback
fix(Mailer): Fix sendmail binary fallback
2024-09-16 18:18:14 +02:00
Côme Chilliet
a165d8f978
chore: Fix encryption test use statement
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +02:00
Côme Chilliet
22822d5e9b
fix: Fix other uses of removed Storage interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:36 +02:00
Côme Chilliet
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:10:48 +02:00
Robin Appelman
d9c5512878
Merge pull request #46140 from nextcloud/fix-nc-env-inclusion
fix(config): Add missing handling for `envCache` in `getKeys()`
2024-09-16 16:55:13 +02:00
Josh
87aa1267a8 fix(Mailer): Fix sendmail binary fallback
feat: add debug logging to sendmail binary finder

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-16 15:20:29 +02:00
Robin Appelman
13088b745a
Merge branch 'master' into fix-nc-env-inclusion
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-16 15:13:29 +02:00
Christoph Fiehe
9597072ada perf(ObjectStoreStorage): Improve (slow) move on same object bucket
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-09-16 15:11:09 +02:00
Ferdinand Thiessen
7fbd518452
feat: Make CheckServerResponseTrait public and provide as OCP\SetupCheck\CheckServerResponseTrait
This trait is used by other apps for creating setup checks,
so we should provide it instead apps using private API.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-16 14:58:21 +02:00
John Molakvoæ
ff0cab5956
Merge pull request #47852 from nextcloud/sharding-code-fixes 2024-09-16 11:39:58 +02:00
Kate
8a32881633
Merge pull request #48008 from nextcloud/fix/entity/strict-types 2024-09-16 11:08:35 +02:00
Anna
d46f271b1f
Merge pull request #48049 from nextcloud/refactor/void-tests
refactor: Add void return type to PHPUnit test methods
2024-09-16 00:11:41 +02:00
Anna
6892500405
Merge pull request #48046 from nextcloud/refactor/self-class-reference
refactor: Replace __CLASS__ with ::class references
2024-09-15 23:01:22 +02:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 22:32:31 +02:00
Christoph Wurst
1ee833efab
refactor: Replace __CLASS__ with ::class references
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:40:55 +02:00
Anna Larch
6c36c54dc6 feat(db): switch from settype to casts
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 19:26:58 +02:00
provokateurin
247b1dd70e
fix(Entity): Fix magic setter call for custom strong typed setters
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:14:54 +02:00
Ferdinand Thiessen
81df2d2c12
feat(PsrLoggerAdapter): Allow to use Psr\Log\LogLevel for log method
There is the `Psr\Log\LogLevel` class defining loglevel constants,
to be fully compatible we should at least support those logging levels.
Moreover this is the last part that was still required from `ILogger` interface,
as we did not have alternatives for the loglevel constants.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-14 17:35:11 +02:00
Côme Chilliet
bcb4e781a4
Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app
Migrate away from OC_App to IAppManager
2024-09-13 17:44:38 +02:00
Côme Chilliet
dfa994ef28
Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2
Move admin_audit to proper event listeners v2
2024-09-13 16:21:44 +02:00
Côme Chilliet
7a16d01ea7
chore(tests): Fix Router test by mocking AppManager methods correctly
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:26:36 +02:00
Côme Chilliet
76f2bc0bfc
fix: Replace OC_App::getAllApps with a method in AppManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:44 +02:00
Côme Chilliet
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:43 +02:00
Joas Schilling
dcd97e1234
fix(config): Throw PreconditionException always when it didn't match
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-13 09:20:08 +02:00
Côme Chilliet
b6c286640f
Merge pull request #47685 from nextcloud/fix/move-apihelper-to-oc-namespace
fix: Move OC_API into \OC\ApiHelper in standard namespace
2024-09-12 14:34:07 +02:00
Julius Knorr
38e0a89972
fix: Add whiteboard to education and public sector bundle
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-12 09:13:42 +02:00
provokateurin
d0a827a684
fix(RichObjectStrings/Validator): Validate key value types of rich object parameters
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:36:33 +02:00
Thomas Citharel
c2150bd079
feat: Add mimetype into BeforePreviewFetchedEvent event
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:05:06 +02:00
Robin Appelman
da59fd4389
fix: misc code fixes around db sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-09 16:59:59 +02:00
provokateurin
d5e98cd190
fix(NavigationManager): Skip invalid default navigation entries
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
70ed08daf1
refactor(AppManager): Deprecated default apps handling
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
b0baaaed9d
feat(NavigationManager): Add default entries handling
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
Côme Chilliet
359bbce3af chore: Adapt tests to OC_API refactoring
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +02:00
Git'Fellow
0308001118 fix(files): Check if the target path is a descendant of the shared folder path
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests
2024-09-05 23:54:01 +02:00
Anna Larch
8af7ecb257 chore: adjust code to adhere to coding standard
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +02:00
Kate
09fef8f0ec
Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents 2024-09-04 20:00:24 +02:00
John Molakvoæ
78e09b5a0a fix: share manager tests translation string
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-04 09:03:45 +02:00
Ferdinand Thiessen
4d2556d4cf
refactor(IMenuAction): Make public menu actions use the new Vue UI
This removes custom rendering code an replaces it with the declarative menu actions.
Also adjust the template to allow the Vue UI to mount.
Custom entries still are possible.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-03 16:07:49 +02:00
Ferdinand Thiessen
92f3f7e2d2
chore: Remove unused CsrfTokenManager from CSPMiddleware
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 00:34:41 +02:00
Marcel Klehr
41e3bde40c
fix(TaskProcessing): Fix namespace of TaskProcessingTest.php
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +02:00
Julien Veyssier
03b3d03b46
fix(taskprocessing): fix tests
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +02:00
Andy Scherzinger
bfb5835750
Merge pull request #47546 from nextcloud/fix/files-view-error-messages
fix: Adjust filename validation messages
2024-08-29 23:28:50 +02:00
Arthur Schiwon
b71c539b5c
test(phpunit): skip sharding tests on 32bit
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-08-29 20:18:35 +02:00
Côme Chilliet
80d7d867bd fix(tests): Fix ImageTest test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +02:00
Côme Chilliet
e8c671fa8b fix: Remove all references to OC_Image
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +02:00
Ferdinand Thiessen
030c209d22 fix: Renaming does not need update but delete permissions
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +02:00
Louis Chemineau
2574cbfa61
chore: Apply php:cs recommendations
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-28 10:44:18 +02:00
Robin Appelman
b21a399d1a
fix: implement sharding compatible cleanup for various bits
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:27:14 +02:00
Robin Appelman
382d102d22
test: fix share provider tests for sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +02:00
Robin Appelman
ddbeb4cac9
test: mark share test cleanup as running across all shards
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +02:00
Robin Appelman
62f8b6517f
feat: implement distributing partitioned queries over multiple shards
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +02:00
Robin Appelman
f5b3486744
feat: add option to automatically partition queries by specific tables
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:53 +02:00
Robin Appelman
c58bdbf378
fix: delay calculating global cache prefix untill a cache is created
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:52 +02:00
Ferdinand Thiessen
81c6c24cd5
fix: Adjust filename validation messages
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 23:12:24 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +02:00
Robin Appelman
8b60df1600
perf: delay getting (sub)admin status for user in the security middleware untill we need it
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-23 15:26:40 +02:00
Ferdinand Thiessen
127cacdd19
feat(Security): Allow setting password context for validation and generation
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-22 19:16:50 +02:00
provokateurin
ebfbe99652
fix(files): Create non-existent parents of mountpoints
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-22 12:04:31 +02:00
Robin Appelman
c3ad469750
Merge pull request #47259 from nextcloud/memcache-ncad
feat: add negative compare-and-delete to imemcache
2024-08-21 17:19:04 +02:00
Joas Schilling
e1caa198e3
ci: Skip flaky test on PHP 8.3
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-21 13:13:12 +02:00
Ferdinand Thiessen
b9cc7bcec7
fix: FilenameValidator::isForbidden should only check forbidden files
And not forbidden basenames as this is used for different purposes.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 04:16:14 +02:00
Robin Appelman
20dbb6c7e8 feat: add negative compare-and-delete to imemcache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-20 19:34:28 +02:00
Ferdinand Thiessen
2ec68b1eb9
refactor(Log): Use new in initializer instead of constructor body
PHP 8.1 allows us to now move the `new` into the initializer,
this makes the code a bit nicer (and 3 lines shorter).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 18:38:28 +02:00
John Molakvoæ
d35c4eb911
Merge branch 'master' into jr-readdir-false-false
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-08-16 10:53:50 +02:00
Ferdinand Thiessen
3e409fd342
Merge pull request #43573 from nextcloud/HolgerHees-fix-csp-nonce-handling
Fix for ignored `CSP_NONCE` in ContentSecurity Header
2024-08-13 17:53:30 +02:00
Christoph Wurst
5100e3152d
feat(auth): Clean-up unused auth tokens and wipe tokens
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-13 12:39:11 +02:00
Ferdinand Thiessen
2916e5df7e
feat: Provide CSP nonce as <meta> element
This way we use the CSP nonce for dynamically loaded scripts.
Important to notice: The CSP nonce must NOT be injected in `content` as
this can lead to value exfiltration using e.g. side-channel attacts (CSS selectors).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:32:44 +02:00
Ferdinand Thiessen
009761be58
test: Adjust tests for CSP nonce
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:06:32 +02:00
Côme Chilliet
1cfc25d08c
fix(tests): Adapt tests to change of DefaultShareProvider constructor
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-12 15:20:21 +02:00
Ferdinand Thiessen
0563757ea4 fix(SetupCheck): Properly check public access to data directory
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.

For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.

¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +02:00
Christoph Wurst
2b38d6ae7e
fix(session): Log when session_* calls are slow
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-07 09:02:10 +02:00
skjnldsv
db28aa8cd1 fix(files_sharing): show proper share not found error message
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 16:25:10 +02:00
Jérôme Herbinet
c221090c86 fix: unify bundle naming
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-08-06 11:14:07 +02:00
Robin Appelman
9af6184af6 chore: delete repair step for 8y old oc_mounts issue
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-02 17:21:54 +02:00
Julius Härtl
a6d421e767
chore: Remove deprecated legacy search backend
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-01 12:33:18 +02:00
Stephan Orbaugh
18c0bcb2da
Merge pull request #46476 from nextcloud/enh/noid/migration-attributes
Migration Attributes
2024-07-30 15:54:56 +02:00
Joas Schilling
710a69b4b5
feat(log): Allow to combine log.conditions to only log (app&user)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-30 13:18:09 +02:00
Ferdinand Thiessen
21f558b12b
Merge pull request #46379 from nextcloud/fix/folder-search-owner
fix: `OCP\Files\Node\Folder::search` was not setting the owner
2024-07-30 13:04:15 +02:00
Maxence Lange
ad490c963b feat(migration-attributes): tests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-07-29 12:44:52 -01:00
provokateurin
9d1705259c
fix(AppFramework): Allow requests with OCS-APIRequest header to pass CSRF checks
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-25 17:31:49 +02:00
Marcel Klehr
799ee8fd51
feat(TaskProcessing): Implement enums and default values
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-25 10:10:31 +02:00
Ferdinand Thiessen
57ed738af2
Merge pull request #46644 from nextcloud/cast-bigint
fix: cast to bigint on postgresql
2024-07-24 20:39:04 +02:00
Louis
7266a9ef33
Merge pull request #46418 from nextcloud/artonge/feat/user_admin_delegation
feat(users): Add users and group management to admin delegation
2024-07-24 11:15:54 +02:00
SebastianKrupinski
fc0b694d37 feat: mail provider backend
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-23 16:20:36 -04:00
Robin Appelman
16c184e2cb
fix: cast to bigint on postgresql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-23 14:41:13 +02:00
Louis Chemineau
dff8815449
feat(users): Add support for admin delegation for users and groups management
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 17:17:35 +02:00
Julien Veyssier
fffc784769
feat(taskprocessing): add support for webhooks (http or AppAPI) in the task processing API
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-22 11:34:29 +02:00
Stephan Orbaugh
9ed2d3e495
Merge pull request #46571 from nextcloud/chore/migrate-to-filenamevalidator
refactor: Migrate some legacy and core functions to `IFilenameValidator`
2024-07-22 10:40:50 +02:00
Andy Scherzinger
c2a571e435
Merge pull request #46473 from nextcloud/feat/restrict_admin_to_ips
feat(security): restrict admin actions to IP ranges
2024-07-22 10:10:42 +02:00
Ferdinand Thiessen
9716b0d735 refactor: Migrate some legacy and core functions to IFilenameValidator
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-19 19:41:46 +02:00
Joas Schilling
7395211c1a
Merge pull request #46605 from nextcloud/bugfix/noid/test-more-oracle-versions
fix(deps): Deprecate functionality deprecated by doctrine and test on more oracle versions
2024-07-19 16:40:49 +02:00
Joas Schilling
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range"
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +02:00
Benjamin Gaussorgues
202e5b1e95
feat(security): restrict admin actions to IP ranges
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +02:00
Marcel Klehr
a3c3eab09c
Merge pull request #46368 from nextcloud/fix/task-processing
TaskProcessing follow-up
2024-07-19 12:38:30 +02:00
Joas Schilling
f6238d35bd
fix(test): Make the test less flaky
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +02:00
Joas Schilling
eeb6ddb176
fix(db): Deprecate IExpressionBuilder::or() and IExpressionBuilder::and() without parameters
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +02:00
Joas Schilling
829f2b9bc7
fix(db): Promote the use of getDatabaseProvider to reduce the impage of removed upstream platforms
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:14 +02:00
Joas Schilling
a4c1d7291f
fix(db): Use createSchemaManager() method as getSchemaManager() is deprecated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:11 +02:00
Robin Appelman
64ca4b832d
Merge pull request #46583 from nextcloud/filecache-sharding-compat
Make filecache queries compatible with sharding
2024-07-19 09:49:45 +02:00
provokateurin
e5dcdfb9e0
feat(Security): Warn about using annotations instead of attributes
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-18 11:25:32 +02:00
Robin Appelman
c5b687271b
fix: make batch propagator work with sharding restrictions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-17 19:16:07 +02:00
Robin Appelman
0931492ff0
fix: make usermountcache compatible with sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-17 19:16:05 +02:00
Richard Steinmetz
718ef5dea5
Merge pull request #46510 from nextcloud/feat/info-xml-backends
feat: hide caldav server settings if no app uses the caldav backend
2024-07-17 18:57:08 +02:00
Julien Veyssier
d37dd4b9a9
feat(settings/admin/ai): fix tests
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-17 15:24:19 +02:00
Marcel Klehr
969cc52851 fix(TaskProcessing): Run cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +02:00
Marcel Klehr
61ebfad724 fix(TaskProcessing): fix tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +02:00
Marcel Klehr
f1bb43dd55 test(TaskProcessing): Add test for setTaskResult with fileIds
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +02:00
Joas Schilling
05888991d7
Merge pull request #46419 from nextcloud/bugfix/noid/limit-logo-size-for-outlook
fix(mail): Fix big logos in mail templates for Outlook
2024-07-17 11:54:47 +02:00
Joas Schilling
693a81bfa3
fix(mail): Fix big logos in mail templates for Outlook
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-17 09:24:55 +02:00
Ferdinand Thiessen
1b41e8f566
Merge pull request #46538 from nextcloud/fix/use-filename-validator
refactor: Migrate filename validation from `Storage` and `Util` to `FilenameValidator`
2024-07-16 17:42:40 +02:00
Robin Appelman
decae5a45a
Merge pull request #46547 from nextcloud/query-builder-connection
feat: allow running QueryBuilder queries on different connections
2024-07-16 17:38:28 +02:00
Ferdinand Thiessen
322b3946d9
fix(dav): Verify target path in setName instead of source path
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:57:11 +02:00
Ferdinand Thiessen
f4ede27cdb
refactor: Remove deprecated Util function for filename validation to FilenameValidator
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:49:10 +02:00
Ferdinand Thiessen
69341e4306
refactor: Migrate filename validation logic from Storage to FilenameValidator
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:49:09 +02:00
Richard Steinmetz
e42bceac9f
feat: hide caldav server settings if no app uses the caldav backend
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-16 09:18:33 +02:00
Robin Appelman
9de6190ec4
feat: allow running QueryBuilder queries on different connections
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-15 22:41:04 +02:00
Ferdinand Thiessen
bdbeabafa7
feat: Add forbidden_filename_basenames config option
This allows to configure forbidden filenames (the full filename like `.htaccess`)
and also forbidden basenames like `com0` where `com0`, `com0.txt` and `com0.tar.gz` will match.
We need this as only using basenames was too restrictive and will cause problems on some systems when updating.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-15 19:39:18 +02:00
skjnldsv
967b3848e0 fix(files_sharing): phpunit & openapi fixes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +02:00
Ferdinand Thiessen
cf935e33ae
fix: OCP\Files\Node\Folder::search was not setting the owner
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-11 15:46:44 +02:00
Ferdinand Thiessen
46f1efac41
feat: Add IFilenameValidator to have one consistent place for filename validation
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 15:04:34 +02:00
Josh Richards
2ffff51461 fix(config): add envCache tests for getKeys()
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-07-08 16:41:58 -04:00
Christopher Ng
48b69c53dc test: Test hash validation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-04 17:05:50 -07:00
Joas Schilling
a1d3b5f1a3
fix(tests): Remove output when running tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-03 15:51:36 +02:00
Daniel
0f95c6e471
Merge pull request #46185 from nextcloud/debt/noid/migrate-background-commands-to-iappconfig
refactor: simplify background commands
2024-07-02 11:21:55 +02:00
Daniel
92acbb0d39
Merge pull request #45766 from nextcloud/feat/ooo-replacement
Feat: Allow users to select another user as their out-of-office replacement
2024-07-01 23:25:43 +02:00
Hamza Mahjoubi
a9774741e8 Feat: Allow users to select another user as their out-of-office replacement
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-07-01 15:10:16 +02:00
provokateurin
5aefdc399e
feat(AppFramework): Add ExAppRequired attribute
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-01 14:41:20 +02:00
Daniel Kesselberg
a773a8b915
refactor: simplify background commands
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-01 12:52:06 +02:00
Misha M.-Kupriyanov
aceb4d776c feat: reduce available languages per config value "reduce_to_languages"
Example: restrict to en, de, es, fr, it' languages

./occ config:system:set reduce_to_languages 0  --value  en
./occ config:system:set reduce_to_languages 1  --value  de
./occ config:system:set reduce_to_languages 2  --value  es
./occ config:system:set reduce_to_languages 3  --value  fr
./occ config:system:set reduce_to_languages 4  --value  it

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2024-07-01 09:34:11 +02:00
Ferdinand Thiessen
14778811b4
refactor: Use IAppConfig for setting cron type
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-28 18:00:39 +02:00
Joas Schilling
00aa8f5438
Merge pull request #46133 from nextcloud/bugfix/noid/fix-missing-protocol-on-remotes
fix(federation): Fix missing protocol on CloudID remote
2024-06-27 14:59:19 +02:00
Arthur Schiwon
ff499a6baa
Merge pull request #45951 from nextcloud/chore/comments-event-legacy
chore: Move comments event handler to use proper event dispatcher
2024-06-27 12:40:06 +02:00
Joas Schilling
280d70a5f4
fix(federation): Fix missing protocol on CloudID remote
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-27 11:26:08 +02:00
Benjamin Gaussorgues
2482688fa0
Merge pull request #45655 from nextcloud/feat/mysql_ignore_conflics 2024-06-27 11:19:12 +02:00
Julius Härtl
9713dd3fa9
chore: Move comments event handler to use proper event dispatcher
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-26 18:13:07 +02:00
Richard Steinmetz
6121325310
Merge pull request #45532 from nextcloud/feat/publish-resources-room-update
feat: implement public OCP api to update resources and rooms
2024-06-25 16:48:30 +02:00
Benjamin Gaussorgues
b7243681dd
feat(dbal): add proper insert ignore conflict method for SQLite
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-06-25 16:21:01 +02:00
Robin Appelman
957a00b9de chore: remove chunking-v1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 16:57:42 +02:00
Robin Appelman
441dfd6646
Merge pull request #45930 from nextcloud/repair-mimetype-expensive
fix: move repair mimetype repair step to the expensive steps
2024-06-19 11:09:15 +02:00
Andy Scherzinger
c3354e9c84
Merge pull request #45228 from smokris/heartbeat-route
fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root
2024-06-18 17:29:30 +02:00
Côme Chilliet
5d744456f6
fix(tests): Strong type property $router in RouterTest
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-06-18 16:33:31 +02:00
Robin Appelman
e74f71b32e feat: add setup check for needed mimetype migrations
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-18 14:46:19 +02:00
Côme Chilliet
de6bb33d99
fix(tests): Fix tests with new LazyUser usage in DefaultShareProvider
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-06-17 18:09:59 +02:00
Robin Appelman
642cffd4dd
Merge pull request #45582 from nextcloud/joblist-cleanup-by-id
delete background jobs by id when cleaning up
2024-06-17 13:21:21 +02:00
Arthur Schiwon
98b5cdc43d
Merge pull request #43942 from nextcloud/fix/43612/avoid-pwd-confirm-sso
fix(Session): avoid password confirmation on SSO
2024-06-07 11:25:36 +02:00
Arthur Schiwon
f6d6efef3a
refactor(Token): introduce scope constants
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-05 19:01:14 +02:00
Arthur Schiwon
340939e688
fix(Session): avoid password confirmation on SSO
SSO backends like SAML and OIDC tried a trick to suppress password
confirmations as they are not possible by design. At least for SAML it was
not reliable when existing user backends where used as user repositories.

Now we are setting a special scope with the token, and also make sure that
the scope is taken over when tokens are regenerated.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-05 19:01:13 +02:00
Ferdinand Thiessen
c1661b6023
Merge pull request #45570 from nextcloud/fix/strict-email-verification
fix(Mailer): Allow to enforce strict email format
2024-06-04 14:03:54 +02:00
Ferdinand Thiessen
1a27314530
fix(Mailer): Allow to enforce strict email format
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 14:18:06 +02:00
John Molakvoæ
7f745a1ed0
Merge branch 'master' into refactor/OC-Server-getSecureRandom
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 19:13:53 +02:00
John Molakvoæ
4d9199fb88
Merge branch 'master' into refactor/OC-Server-getL10NFactory
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 17:52:14 +02:00
Robin Appelman
85b9552617
test: update DummyJobList
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-05-30 15:07:39 +02:00
John Molakvoæ
258bb03cf5
Merge branch 'master' into refactor/OC-Server-getSecureRandom
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 14:24:22 +02:00
John Molakvoæ
91227c908b
Merge branch 'master' into refactor/OC-Server-getHTTPClientService
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 14:21:45 +02:00
John Molakvoæ
99af78cd66
Merge branch 'master' into refactor/OC-Server-getL10NFactory
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 14:19:51 +02:00
Jake Nabasny
f863290572
feat(ldap): sync additional properties to profile and SAB
Synced from LDAP to profile:
- Date of birth

Synced from LDAP to SAB (via the profile):
- Biography
- Date of birth

Original code by Jake Nabasny (GitHub: @slapcat)

Co-authored-by: Jake Nabasny <jake@nabasny.com>
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-05-30 12:01:13 +02:00
Daniel Kesselberg
3fb0aa40cd
feat(db): add mapping for lock wait timeout
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-05-29 11:10:43 +02:00
Christoph Wurst
3bfba2042c
fix(db): Prevent two connections for single node databases
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-05-28 10:38:36 +02:00
Richard Steinmetz
69e0158030
feat: implement public OCP api to update resources and rooms
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-05-27 18:45:52 +02:00
Andy Scherzinger
0b20dd6755
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-22 19:58:12 +02:00
Benjamin Gaussorgues
e630e4b983
Merge pull request #44763 from nextcloud/fix/group_name_length_db 2024-05-16 14:22:30 +02:00
Joas Schilling
4286660983
fix: Extend SVG reference check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-05-16 10:01:33 +02:00
Marcel Klehr
715245a21a fix: run cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:42 +02:00
Marcel Klehr
9cc1a01ea0 test: Put input files in user storage
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:42 +02:00
Marcel Klehr
19a0aaeb5e fix(TextToImage): Allow leaving the resources open
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:41 +02:00
Marcel Klehr
f6f4965294 fix: fix tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:41 +02:00
Marcel Klehr
5de42a53e2 fix: Don't use dynamic property
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:40 +02:00
Marcel Klehr
a5053d33c2 fix: Run cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:40 +02:00
Marcel Klehr
ef44af1f48 test: Test file authorization check
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:40 +02:00
Marcel Klehr
bd5dfd0b5f test: Add more tests for legacy pass-through
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:40 +02:00
Marcel Klehr
b150d779f3 refactor: rename getTaskType to getTaskTypeId
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:40 +02:00
Marcel Klehr
ee7592ffdd fix: Run cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:39 +02:00
Marcel Klehr
4b2acee64b test: Add OldTasksShouldBeCleanedUp test
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:39 +02:00
Marcel Klehr
8352b27c11 fix: weed out some psalm errors and run cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:39 +02:00
Marcel Klehr
00894e2420 feat: first pass at TaskProcessing API
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-05-14 11:38:39 +02:00
Andy Scherzinger
1f7e2ba599
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-13 17:41:36 +02:00
Robin Appelman
d76de94c5b
Merge pull request #44791 from nextcloud/reshare-permission-logic
fix: consider all paths the user has for a share source when considering max permissions
2024-05-13 16:00:10 +02:00
Steve Mokris
e5ec9d6a7b fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root
Signed-off-by: Steve Mokris <steve@kosada.com>
2024-05-07 20:01:27 -04:00
Robin Appelman
4a72b96532
test: adjust test to new permissions check logic
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-05-03 15:38:48 +02:00
Julien Veyssier
1acc57b5c0
feat(bg-jobs): allow setting a job class list instead of a single class in cron.php and the job worker occ command
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-05-02 16:43:41 +02:00
Julius Härtl
52eb6d8726
feat(bg-jobs): Allow calling cron.php with a background job class
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-05-02 16:43:40 +02:00
Côme Chilliet
147426c3ca
Merge pull request #44968 from nextcloud/fix/drop-workaround-for-obsolete-php
fix: Drop workarounds for unsupported obsolete PHP versions
2024-04-29 15:31:04 +02:00
Christoph Wurst
21ee7f59bd
fix(session): Do not update authtoken last_check for passwordless
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-04-26 16:05:18 +02:00
Côme Chilliet
5d1ca7e25a
fix: Drop workarounds for unsupported obsolete PHP versions
Also improved error handling in Installer.php to be type safe.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 16:55:42 +02:00
Côme Chilliet
ac1d868d18
fix: Lazy load IURLGenerator from AppManager to avoid installation crash
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 15:50:06 +02:00
Benjamin Gaussorgues
7a6b1f8ae8
fix(groups): allows to save group names with more than 64 characters
Mimic behaviour from LDAP users and add a hard limit to 255 characters

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-04-22 15:26:55 +02:00
Côme Chilliet
1b5a0c3e1c
fix: Fix RouterTest by adding IAppManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 12:21:57 +02:00
Côme Chilliet
a0be3ffdf2
fix: Fix tests following OC_App migrations to IAppManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 12:21:55 +02:00
Côme Chilliet
733a818139
fix: Migrate a few more classes away from OC_App::getAppPath
Also fixed AppTest

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 12:19:01 +02:00
Joas Schilling
2161387ac7
Merge pull request #44886 from nextcloud/techdebt/noid/improved-activity-exceptions
fix(activity): Improved activity exceptions
2024-04-18 10:05:49 +02:00
Maxence Lange
a624a2b34f fix(appconfig): returns correct value on details
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-04-17 16:28:02 -01:00
Ferdinand Thiessen
3aa9c53a87
Merge pull request #44644 from nextcloud/enh/noid/returns-formated-app-values
fix(appconfig): format app values
2024-04-17 17:11:36 +02:00
Joas Schilling
8f83953ff1
fix(activity): Add a dedicated exception when not all fields are set while publishing an activity
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-17 15:36:41 +02:00
Pytal
728c46d174
Merge pull request #44736 from nextcloud/fix/avatar-images
fix: Fix avatar images
2024-04-09 10:10:19 -07:00
Christopher Ng
78ed7604ff test: Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-08 17:04:33 -07:00
Robin Appelman
88ccea6d06
test: add test for jail watcher
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-04-08 18:42:44 +02:00
Maxence Lange
cc813fec23 fix(appconfig): format app values
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-04-05 17:49:34 -01:00
Joas Schilling
575e7d8dba
fix(federation): ICloudId->getRemote() should contain the protocol
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-02 17:55:16 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +02:00
Côme Chilliet
fda1c42ab7
fix(tests): Fix tests when daytime saving time change happened recently
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 11:24:14 +02:00
Joas Schilling
dababa5138
fix(federation): Fix creating local cloudIds with http:// protocol
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-25 14:21:52 +01:00
Christoph Wurst
b8868e2652
fix(config): Make sure user keys are strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-19 18:27:53 +01:00
Ferdinand Thiessen
bae133bf4f fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-19 09:36:06 +01:00
Florian Klinger
f3a4abd98c
fix: add check for app_api_system session flag to bypass rate limit
Signed-off-by: Florian Klinger <florian.klinger@nextcloud.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-18 20:09:15 +02:00
John Molakvoæ
eb61f6b065
Merge pull request #40117 from summersab/refactor/OC-Server-getCommentsManager 2024-03-15 17:03:54 +01:00
Corentin Damman
0fa9f3049f feat(files_sharing): allow to specify allowed groups to share instead of excluded groups
Relates to #3387

Signed-off-by: Corentin Damman <c.damman@intopix.com>
2024-03-15 16:52:59 +01:00
John Molakvoæ
5a1ed2d9ea
Merge pull request #40131 from summersab/refactor/OC-Server-getShareManager 2024-03-15 16:05:59 +01:00
John Molakvoæ
f5e3fea285
Merge pull request #40138 from summersab/refactor/OC-Server-getHasher 2024-03-15 15:08:32 +01:00
John Molakvoæ
6b4d918dec
Merge pull request #40123 from summersab/refactor/OC-Server-getRootFolder 2024-03-15 14:49:59 +01:00
John Molakvoæ
490533188b
Merge pull request #40143 from summersab/refactor/OC-Server-getLockdownManager 2024-03-15 14:44:23 +01:00
Andrew Summers
6910832170 Refactor OC\Server::getCommentsManager
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-03-15 13:14:06 +01:00
Andrew Summers
45eb4a839d Refactor OC\Server::getLockingProvider
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-03-15 13:11:33 +01:00
Andrew Summers
cd585885b8 Refactor OC\Server::getLockdownManager
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-03-15 13:05:05 +01:00
Andrew Summers
f9ce6bfdff Refactor OC\Server::getHasher
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-03-15 13:04:27 +01:00
John Molakvoæ
9338ef36de
Merge branch 'master' into refactor/OC-Server-getShareManager
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-03-15 13:03:34 +01:00
John Molakvoæ
3f560ae940
Merge branch 'master' into refactor/OC-Server-getRootFolder
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-03-15 13:01:10 +01:00
Thomas Citharel
ffeb797ecc
refactor(mimeloader): modernize MimeTypeLoader
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-03-14 17:24:36 +01:00
Maxence Lange
519e434573 fix(updatenotification): spread the use of new appconfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-13 02:22:11 -01:00
Christopher Ng
af49278c5f test: Update test for PublicSectorBundle
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-12 10:47:12 -07:00
Andrey Borysenko
865fd3ba08
fix: add missing copyrights and strict types
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-12 18:14:40 +02:00
jld3103
4ac2375ca2
feat: Add declarative settings
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-12 13:56:54 +02:00
Maxence Lange
0a79884abf feat(appconfig): switching integrity check to lazy config values
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-11 10:59:43 -01:00
Joas Schilling
b2b4f34d96
Merge pull request #44073 from nextcloud/fix/provide-correct-icon
fix(AppManager): Allow to query dark **or** bright icon
2024-03-08 17:07:06 +01:00
Maxence Lange
467c84ec53 feat(files): copy live photos
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-08 13:09:22 -01:00
Robin Appelman
47ebc1119a
Merge pull request #44064 from nextcloud/deprecate-getNumberOfUnreadCommentsForFolder
refactor: depricate getNumberOfUnreadCommentsForFolder and redo it's …
2024-03-08 12:28:58 +01:00
Ferdinand Thiessen
c8d7a5acaa fix(AppManager): Allow to query dark **or** bright icon
The navigation needs the bright icon, while the notifications and activity need a dark icon.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-08 09:51:03 +01:00
Ferdinand Thiessen
876e2d6198
feat(AppManager): Provide getAppIcon function
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 22:40:31 +01:00
Robin Appelman
eb5832b8fa refactor: depricate getNumberOfUnreadCommentsForFolder and redo it's implementation based on getNumberOfUnreadCommentsForObjects
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-07 19:19:07 +01:00
Joas Schilling
718c845434
Merge pull request #43114 from nextcloud/bugfix/noid/automatically-encrypt-sensitive-values
feat(appconfig): Automatically store "sensitive" appconfigs encrypted in the database
2024-03-07 09:57:21 +01:00
Ferdinand Thiessen
8d58356dc1
Merge pull request #43917 from nextcloud/fix/jsresourcelocator-apppath
fix(JSResourceLocator): Consider configured app roots for files
2024-03-07 09:01:44 +01:00
Joas Schilling
3a67080a96
fix(appconfig): Make sure sensitive values stay sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-06 22:58:59 +01:00
Joas Schilling
24607a37d8
feat(appconfig): Automatically store "sensitive" appconfigs encrypted in the database
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-06 22:27:14 +01:00
John Molakvoæ
dfae067bbc
Merge pull request #43437 from nextcloud/cleanup-mount-by-id-duplication
use lazy user in UserMountCache for getting user for cached mount instead of duplicating logic
2024-03-06 18:57:54 +01:00
Robin Appelman
702c679cfa
Merge pull request #44000 from nextcloud/more-sharing-cleaup
cleanup: remove long depricated share code
2024-03-06 18:02:03 +01:00
Robin Appelman
a598de627c chore: remove long depricated share code
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 15:24:48 +01:00
Robin Appelman
339702e376 refactor: make share manager buildable
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 14:33:51 +01:00
Robin Appelman
51019fda7a fix: clearify logic around getMountsForFileId filtering
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 10:54:00 +01:00
Robin Appelman
fd4ca13867
Merge pull request #43471 from nextcloud/cache-path-by-id
Cache path by id
2024-03-05 17:26:25 +01:00
Robin Appelman
56c75aa7dc
Merge pull request #43975 from nextcloud/search-optimize-fixes
Handle more cases in the MergeDistributive search query optimizer
2024-03-05 10:26:40 +01:00
Robin Appelman
1ae15967fc
Merge pull request #43791 from nextcloud/share-api-cleanup
Share api cleanup
2024-03-04 15:46:09 +01:00
Dariusz Olszewski
277a6fc7ea test: Additional tests for issue #35776
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2024-03-04 14:25:52 +01:00
Robin Appelman
a9ee278ec6 perf: cache path by id to speedup getting nodes by id
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-04 13:57:31 +01:00
Robin Appelman
e7a7b4a401 perf: switch places that always use the first getById result to getFirstNodeById
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-04 13:57:31 +01:00
Julius Härtl
e13fb468cf
fix: Fetch custom app store url without internet connection
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-04 12:47:14 +01:00
John Molakvoæ
e0705f1015
Merge pull request #43057 from nextcloud/feat/cache-authtoken 2024-03-01 14:47:43 +01:00
Ferdinand Thiessen
51ea3de8a7
fix(JSResourceLocator): Consider configured app roots for files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-29 17:27:20 +01:00
Ferdinand Thiessen
27642d3e6d fix: Enforce forbidden filename characters on backend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-28 22:19:25 +01:00
Benjamin Gaussorgues
d1189f923c
feat(perf): add cache for authtoken lookup
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-28 15:04:04 +01:00
Joas Schilling
e5b0c06b24
feat(comments): Allow mentions of federated users, groups and teams in the future
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-27 17:11:23 +01:00
Robin Appelman
d0ebe36906
fix: remove old test-only methods
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-26 18:46:35 +01:00
Benjamin Gaussorgues
3f269782aa
Merge pull request #43428 from nextcloud/feat/share-expiration-with-time 2024-02-26 10:07:41 +01:00
Robin Kluth
51739ad1ac Adjust tests to match new expected exception
Signed-off-by: Robin Kluth <Commifreak@users.noreply.github.com>
2024-02-24 11:34:34 +01:00
John Molakvoæ
edc35f74c7
Merge pull request #42893 from nextcloud/file-info-key-location 2024-02-23 19:36:25 +01:00
John Molakvoæ
0348ad5e0d
Merge pull request #40111 from summersab/refactor/OC-Server-getAppFetcher 2024-02-23 18:59:43 +01:00
John Molakvoæ
b0b4c7e042
Merge pull request #30417 from nextcloud/sualko-patch-1 2024-02-23 16:16:55 +01:00
John Molakvoæ
6c837fd51e
Merge pull request #39607 from FedericoHeichou/fix-double-dots-with-pipe-sendmail 2024-02-23 15:59:26 +01:00
Andrew Summers
f461c79c58 Refactor OC\Server::getAppFetcher
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-02-23 15:43:46 +01:00
Klaus
747aeded9d fix xml ocs response for serializable objects
Signed-off-by: sualko <klaus@jsxc.org>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-02-23 14:49:22 +01:00
Benjamin Gaussorgues
01983d50d4
feat(share): save date and time for expiration
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-22 11:26:01 +01:00
Robin Appelman
3890aa54be
add some comments for the distributive operation and add another test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-16 10:59:33 +01:00
Robin Appelman
1c87cee5ad
add extra flatten step to improve "or eq" -> "in" optimization
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:55:44 +01:00
Robin Appelman
7ca516773f
add a search query step to split IN statements that are to large for oci
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:55:43 +01:00
Robin Appelman
2e14a7a4a6
optimize query pattern used by storage filter
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:55:40 +01:00
Joas Schilling
9f38aabc06
Merge pull request #43552 from nextcloud/bugfix/noid/rfc7239-compatible-proxy-handling
fix(request): Handle reverse proxy setting a port in Forwarded-For
2024-02-15 15:29:47 +01:00
John Molakvoæ
4a509dfe8e
fix: phpunit
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:06:31 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
Joas Schilling
9ed3ab7d87
test(request): Add tests to strip the port when forwarding requests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-13 16:51:13 +01:00
Anna Larch
6434ce96c9 Add timezone getter to ITimeFactory
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-02-13 13:29:06 +01:00
Maxence Lange
592012034e
Merge pull request #43370 from nextcloud/test-iappconfig
[IAppConfig] new tests
2024-02-12 18:09:13 -01:00
Maxence Lange
52ebb8e4b1 removing deprecated tests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-12 13:23:21 -01:00
Robin Appelman
963721330f only get the path for the users cached mount info when we use it
most of the time we shouldn't need it so we can save joining on the filecache

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-09 09:50:43 +01:00
Côme Chilliet
303e2febc7
Merge pull request #43387 from nextcloud/fix/migrate-away-from-ilogger-in-jobs 2024-02-08 18:27:44 +01:00
Louis Chemineau
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server"
This reverts commit d9d60238c7, reversing
changes made to ba3fdb0cdc.
2024-02-08 15:31:19 +01:00
Côme Chilliet
b105603fd1 chore: Remove last uses of IJob::execute method
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +01:00
Côme Chilliet
65981f99bf chore: Migrate away from internal Job classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +01:00
Maxence Lange
44b76cbe8f new API, new tests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-07 12:32:32 -01:00
Maxence Lange
7891c05224 moving previous test
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-07 12:24:57 -01:00
Robin Appelman
5aea3f4d76 make storage directory test be a bit less strict about mtimes
sometimes the clock ticks over during the test

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-07 12:13:00 +01:00
Côme Chilliet
b2e9e0fa0d chore: Replace OC::$server->getL10N by OCP\Util::getL10N in lib and some apps
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +01:00
Thomas Citharel
30798eb6c2
refactor(objectstorage): cleanup types
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-02-02 14:59:21 +01:00
Maxence Lange
b838237f82
Merge pull request #43132 from nextcloud/enh/41755/update-appframework-api
sync with new OCP\IAppConfig
2024-02-01 19:51:47 -01:00
Maxence Lange
31c1bc1c62 better tests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-01 13:40:27 -01:00
Robin Appelman
edaa436345
add key location to info:file output
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-01 15:32:33 +01:00
Joas Schilling
4993dac98f
Merge pull request #43203 from nextcloud/fix/cleanup-register-command-with-di
Use Dependency Injection in register_commands.php
2024-02-01 14:44:07 +01:00
Côme Chilliet
2bfb6fc731
fix: Make Repair object injectable and fix BackgroundRepair test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-01 09:49:32 +01:00
Maxence Lange
1956be4118 fix lint
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-31 21:13:32 -01:00
Maxence Lange
e1d7328bb2 adding test
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-31 21:13:32 -01:00
Robin Appelman
7aed19ac98
add test for updating etag with unchanged mtime in child folder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:05:12 +01:00
Robin Appelman
2cf9ed7ca5
add test for updating etag with unchanged mtime
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:05:11 +01:00
Baptiste Fotia
449d28e610 test(php): Fix the unit tests
I added our context in the unit tests following the advice of Louis.

Link : https://github.com/nextcloud/server/pull/43186#issuecomment-1916571027

Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +01:00
Baptiste Fotia
9af96d9f9a feat(php,vue): Create a new parameter
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +01:00
Côme Chilliet
0e1931754a
chore: use DI for \OC\Repair
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 16:07:02 +01:00
Côme Chilliet
ccc66e912b
fix: Use DI for Setup class and move away from deprecated methods
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 15:28:00 +01:00
Arthur Schiwon
216b95f8b1 test(unit): fix RequestTest
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-01-27 15:11:26 +01:00
Joas Schilling
5850695284
fix(tests): Add messages to assertions to explain what failed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 20:46:14 +01:00
Ferdinand Thiessen
8e02014b55
chore(tests): Migrate object storage unit tests from drone to GitHub Actions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-26 14:54:23 +01:00
Ferdinand Thiessen
fceb781058
fix(tests): Fix deprecation errors in S3 tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-26 14:53:33 +01:00
Joas Schilling
b04f6d57b4
fix(tests): Make PostgreSQL unit tests less flacky by ordering
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-25 06:47:39 +01:00
FedericoHeichou
609e751667 Add "-i" to MailTest's pipe
Signed-off-by: FedericoHeichou <federicoheichou@gmail.com>
2024-01-19 17:08:01 +01:00
Git'Fellow
72e0618f20
fix(session): Avoid two useless authtoken DB queries for every anonymous request
Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-17 09:17:23 +01:00
Maxence Lange
fdd38b46e3
Merge pull request #41755 from nextcloud/enh/noid/lazyconfig
Lazy grouping within IAppConfig
2024-01-16 08:39:13 -01:00
Maxence Lange
f7d0c74b10 lazy AppConfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 -01:00
Joas Schilling
57a30e9bbe
fix(appstore): Only send subscription keys to valid appstores
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-15 15:39:45 +01:00
Julius Härtl
e50cb0a30f tests(DB): Add test for date time comparisons in query builder
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-29 10:36:59 +01:00
Alexander Piskun
26d343d33a
AppAPI: allowed to bypass Two-Factor
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2023-12-28 20:59:02 +03:00
Robin Appelman
ff62154a79 adjust redis compareSetTTL to use a lua script
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-21 15:14:27 +01:00
Robin Appelman
7394645eb7 restore shared lock ttl when releasing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-21 15:14:27 +01:00
Joas Schilling
6056928dc6
feat(comments): Add a meta data column for comments
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-14 14:32:00 +01:00
Julius Härtl
6c52242fb1
Merge pull request #41927 from nextcloud/perf/login-with-email-token 2023-12-05 11:11:33 +01:00
Joas Schilling
33e1c8b236
fix(security): Handle idn_to_utf8 returning false
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-04 10:38:46 +01:00
Julius Härtl
a3a343ce41
perf: Use more performant way to obtain and check the email as a login name with token login
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-30 20:51:47 +01:00
Anna Larch
f19645adab enh(userstatus): add OOO automation and remove calendar automation
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-11-28 10:28:06 +01:00
Joas Schilling
f6b6776c93
fix(API): Use a distinct exception so apps can react to it and customize the return
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-28 06:11:57 +01:00
Joas Schilling
3ccb301853
Merge pull request #41578 from nextcloud/enh/noid/dispatcher-test-argument-range
Enable AppFramework dispatcher to enforce integer ranges
2023-11-27 10:40:50 +01:00
Arthur Schiwon
3fa43a529b
enh(dispatcher): enforce psalm ranges in the http dispatcher
- allows devs to provide int ranges for API arguments

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-11-24 12:46:38 +01:00
Richard Steinmetz
8191295f66
feat(dav): dispatch out-of-office started and ended events
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-11-23 17:18:49 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Ferdinand Thiessen
9c3321c524
Merge pull request #41565 from nextcloud/fix/object-storage-inconsitent-behavior
fix(ObjectStore): Make copying behavior consistent with local storage
2023-11-22 13:54:01 +01:00
Joas Schilling
572ea18ac7
fix: Fix linkToOCSRouteAbsolute() without index.php and subfolder
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-20 11:18:47 +01:00
Ferdinand Thiessen
ecf9f0a872
fix(CSP): Only add strict-dynamic when using nonces
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-17 22:01:02 +01:00
Ferdinand Thiessen
e231abd9bf
fix!(ContentSecurityPolicy): Make strict-dynamic enabled by default on script-src-elem
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-17 14:42:36 +01:00
Ferdinand Thiessen
5172baaf8b
fix(ObjectStore): Make copying behavior consistent with local storage
Drop file permissions on copy like we do on local storage.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-17 12:54:37 +01:00
Ferdinand Thiessen
7df9eb3351 feat(ContentSecurityPolicy): Allow to set strict-dynamic on script-src-elem only
This adds the possibility to set `strict-dynamic` on `script-src-elem` only while keep the default rules for `script-src`.
The idea is to allow loading module js which imports other files and thus does not allow nonces on import but on the initial script tag.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-17 11:12:57 +01:00
Robin Appelman
b942850af9
optimize UserMountCache::registerStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-16 16:21:59 +01:00
Joas Schilling
2fa78f6245
Reverse X-Forwarded-For list to read the correct proxy remote address
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 07:45:19 +01:00
Christoph Wurst
45541eb685
feat(dav): Enable OOO UI and expose enabled via OCP
Makes the feature opt-out now that we have meaningful integrations based
on OOO data. Allows instances still to turn the feature off.

For apps like Mail that build on top of this feature we need to know if
the instance has the feature turned on or off. This is exposed as OCP
API, too.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-15 15:53:38 +01:00
Ferdinand Thiessen
927e7fcf67
fix(AppManager): Ensure that app manager can handle empty app keys on the navigation entries
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:04:48 +01:00
Ferdinand Thiessen
8d0c7cc5fa
fix: Allow to set custom app order on navigation entries added by closures to NavigationManager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:03:28 +01:00
Andrew Summers
40edb426a3 Refactor OC\Server::getRootFolder
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2023-11-10 16:51:05 +01:00
Christoph Wurst
5183ba2a5b
Merge pull request #40653 from nextcloud/feat/ooo-api
feat: Add out-of-office message API
2023-11-09 18:35:20 +01:00
Christoph Wurst
ab1a1d688d
feat: Add out-of-office message API
[skipci]

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-11-09 10:36:11 +01:00
Christoph Wurst
734b11dc86
Merge pull request #41266 from nextcloud/feat/contactsmenu/user-status-sorting
feat(contactsmenu): Sort by user status
2023-11-08 22:21:18 +01:00
Robin Appelman
b29bc59e8b
Merge pull request #41119 from nextcloud/optmize-storage-wrappers
optimize builtin storage wrappers
2023-11-08 22:14:19 +01:00
Christoph Wurst
71080a8d20
feat(contactsmenu): Sort by user status
If user_status is not enabled, fall back to sorting by contact name.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-08 21:53:35 +01:00
Robin Appelman
f4fa2fb93c
optimize isShared and isMounted
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-08 17:34:58 +01:00
Louis Chemineau
d3a313f192
Support getting and setting metadata in DAV requests
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-11-08 16:23:53 +01:00
Christoph Wurst
78842348b2
feat(dependencyinjection): Allow optional (nullable) services
Allows working with classes that might or might not be available.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-03 11:53:43 +01:00
Christoph Wurst
ac168cf9ff feat(contactsmenu): Show user status
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-10-31 11:52:46 -07:00
Christopher Ng
ce5e290d58 fix(tests): Test profile entry
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-26 10:30:22 -07:00
Ferdinand Thiessen
e9d4036389
feat(theming): Allow to configure default apps and app order in frontend settings
* Also add API for setting the value using ajax.
* Add cypress tests for app order and defaul apps

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-20 00:24:17 +02:00
Ferdinand Thiessen
363d9ebb13
feat(NavigationManager): Always sort the default app first
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-19 22:04:20 +02:00
Ferdinand Thiessen
154a9989a7
Merge pull request #39852 from nextcloud/pragmaHeader
Stop sending deprecated Pragma header
2023-10-18 03:30:21 +02:00
Christoph Wurst
ff672b11e2
feat: Add factory method for in-memory caches
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-10-11 13:37:22 +02:00
Joas Schilling
ccb01b19a0
fix(sqlite): Remove some old SQLite cheats
- Doctrine correctly forces integer for autoincrement by now
- Doctrine correctly maintains integer types by now

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:27 +02:00
Joas Schilling
160298c556
fix(mysql): Remove custom MySQL workaround from 2015
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +02:00
Joas Schilling
b202b139dd
fix(postgres): Remove old Postgres 9.4 workaround
Postgres 10 is the minimum in the meantime
and doctrine/dbal fixed this in 2.6.0 already
ref https://github.com/doctrine/dbal/pull/2614

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +02:00
Joas Schilling
ad839dbb0a
fix(sqlite): Remove no longer required autoincrement fix
- I installed current master and exported the schema as SQL
- Then I went to this branch, removed the content of the run() method (so made it no-op)
- I installed again and exported the schema as SQL
- The files are exactly the same, so whatever we tried to fix was fixed since 2015 in doctrine dbal

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +02:00
Christoph Wurst
04ecc2a6a9
feat(backgroundjob): Schedule job after <timestamp>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-09-29 10:29:40 +02:00
Côme Chilliet
c9ed1e981b
Merge pull request #40617 from nextcloud/enh/allow-user-to-set-apporder
Read apporder from configuration value
2023-09-28 10:55:52 +02:00
Côme Chilliet
b11eb9e6d6
Fix and extend NavigationManagerTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-26 16:21:22 +02:00
Côme Chilliet
2d28e8110f
Fix and extend tests for AppManager::getDefaultAppForUser
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-26 14:59:05 +02:00
Joas Schilling
0956b493b6
fix(phonenumber): Use the newly introduced API to limit 3rdparty lib usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-25 15:54:21 +02:00
Daniel Kesselberg
97a024f035 chore(3rdparty): remove opis/closure
- We are using laravel/serializable-closure for a while now.
- The package was there for compatibility reasons but does not play nice with PHP 8.1.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-22 17:16:20 +02:00
Joas Schilling
5e7b41086d
feat(CI): Allow apps to test with PHPUnit10
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-21 21:32:15 +02:00
Robin Appelman
b11ca34bbd
Merge pull request #40499 from nextcloud/known-mtime-wrapper
add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is
2023-09-21 18:33:15 +02:00
Daniel Kesselberg
18af7cc86b test: add test for cache mount provider
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-20 15:42:23 +02:00
Robin Appelman
ccf8843d9f apply known mtime wrapper for external storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-19 13:58:35 +02:00
Robin Appelman
5bf34979fe add wrapper to ensure we don't get an mtime that is lower than we know it is
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-19 13:58:15 +02:00
Côme Chilliet
e24007b530
Remove deprecated at matcher in tests/lib/InstallerTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-14 12:52:05 +02:00
Julius Härtl
7f958e81d3
fix: Pass parent to NonExistingFile instances
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-09-13 10:28:28 +02:00
Daniel Kesselberg
f8f985602b
test: add tests for dns pin middleware
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-12 14:04:23 +02:00
Côme Chilliet
4f1e5bc8fd
Merge pull request #32912 from nextcloud/group-backend-batch-method
Add batch methods in user backends
2023-09-11 11:11:00 +02:00
Julius Härtl
938a558078
Merge pull request #39226 from shdehnavi/null_coalescing_conversion_tests 2023-09-09 09:51:17 +02:00
Côme Chilliet
8549ea4025
Merge pull request #40216 from nextcloud/print-log-message-when-version-could-not-be-got-from-updater-server
Print log message when version could not be got from updater server
2023-09-07 09:33:06 +02:00
Daniel Calviño Sánchez
9a179c391e Print log message when version could not be got from updater server
This could help to diagnose why the updater server could not be reached,
as well as other subtler issues like requests taking too long if the
updater server was tried to be connected to as a "side effect" (for
example, when the "updatenotification" app boots).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-09-06 05:43:21 +02:00