upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-16 20:19:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 16
83872 commits 1016 branches 1221 tags 8.7 GiB
Commit graph

461 commits

Author SHA1 Message Date
Ferdinand Thiessen
a9af58fd1a fix(DB): Remove not supported column comments when using SQLite 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-22 01:07:26 +01:00
Robin Appelman
426b3429f7
log start time of queries for profiler 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-14 15:16:15 +01:00
Joas Schilling
ecad09b38a
Merge pull request #36261 from nextcloud/techdebt/noid/warn-devs-about-potential-bugs 
fix(querybuilder): Log a warning if where() is called again on a quer…
 2023-01-23 18:47:25 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Joas Schilling
7f0a54c558
fix(querybuilder): Log a warning if where() is called again on a query builder object 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-20 07:41:19 +01:00
Côme Chilliet
8a16e7e8a1
Fix more psalm issues in OC\DB 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-21 11:30:20 +01:00
Côme Chilliet
378630f8a0
Fix psalm issues following doctrine/dbal bump 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-21 10:56:15 +01:00
Roeland Jago Douma
d151999fc8
typehint migrationservice closures 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2022-10-09 21:31:27 +02:00
Retidurc Silvernight
2269f35842
Change option name again to be more like the other options 
Signed-off-by: Retidurc Silvernight <retidurc@silvernight.social>
 2022-09-23 09:48:02 +02:00
Retidurc Silvernight
0de8729d7b
Change config option to db.persistent 
Signed-off-by: Retidurc Silvernight <retidurc@silvernight.social>
 2022-09-23 09:48:01 +02:00
Retidurc Silvernight
90f3379dfc
Expose Doctrine settings in Netxcloud settings 
Signed-off-by: Retidurc Silvernight <retidurc@silvernight.social>
 2022-09-23 09:47:56 +02:00
Côme Chilliet
4ac81733bd
Declare strict types in all new Event classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-25 16:15:49 +02:00
Côme Chilliet
a2a7150d6d
Migrate Repair events to OCP\EventDispatcher\Event 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-25 16:15:48 +02:00
Côme Chilliet
a83a8f0dde
Migrate Migrator::executeSql to OCP\EventDispatcher\Event 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-25 16:13:47 +02:00
Côme Chilliet
4ba30d40cf
Switch to string keys for argument of GenericEvent for OC\DB\Migrator 
It seems checkTable is actually never dispatched?

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-25 16:13:46 +02:00
Robin Appelman
6e0123a1d0 Revert "add case statement to sql function builder" 
This reverts commit 2a68819a67.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 12:07:13 +02:00
Robin Appelman
9b52663a81 Revert "make expression build return IQueryFunction instead of string" 
This reverts commit 813b50ed42.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-16 12:07:09 +02:00
luz paz
368f83095d Fix typos in lib/private subdirectory 
Found via `codespell -q 3 -S l10n -L jus ./lib/private`

Signed-off-by: luz paz <luzpaz@github.com>
 2022-07-27 08:52:17 -04:00
Côme Chilliet
c598e3cafa
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-06-21 16:36:25 +02:00
Côme Chilliet
1bd5222224
Fix PHP 8.2 warnings about undeclared properties 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-06-21 16:17:52 +02:00
Robin Appelman
2a68819a67
add case statement to sql function builder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-06-02 15:52:12 +02:00
Robin Appelman
813b50ed42
make expression build return IQueryFunction instead of string 
this allows passing the expressions to further expressions without them being escaped as column names

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-06-02 15:52:08 +02:00
Carl Schwan
9ec0cb0a90 Fix psalm issues related to the user backend 
- Reflect the actual return value returned by the implementation in the
  the interface. E.g. IUser|bool -> IUser|false
- Remove $hasLoggedIn parameter from private countUser implementation.
  Replace the two call with the equivalent countSeenUser
- getBackend is nuallable, add this to the interface
- Use backend interface to make psalm happy about call to undefined
  methods. Also helps with getting rid at some point of the old
  implementActions

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-20 17:14:58 +02:00
Robin Appelman
a4e120c203
tell mysql to ignore the sort index for search queries 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-22 13:42:33 +02:00
Joas Schilling
df36ed4d1a
Log missing primary key until we make it a requirement 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-04-08 10:47:24 +02:00
Joas Schilling
10b2319aa0
Add missing doc changes 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-04-07 15:50:33 +02:00
Joas Schilling
82c33be744
Fix typos and empty tabs 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-04-07 12:42:52 +02:00
John Molakvoæ
0257315c34
Improve error logging on migration failure 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-04-07 11:49:20 +02:00
John Molakvoæ
e20d5fa7fc
Ensure schema change before checking OracleConstraints 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-04-07 11:18:14 +02:00
Robin Appelman
1537c3d23b
record backtrace when profiling db requests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-04 18:12:30 +02:00
Carl Schwan
135bdb3d58
Merge pull request #30823 from nextcloud/work/profiler 
Built-in profiler

This adds the required API for collecting information about requests. This information
can then be displayed with the new 'profiler' app.
 2022-04-04 12:56:37 +02:00
Carl Schwan
7d272c54d0 Add a built-in profiler inside Nextcloud 
The webui is provided by a seperate application named profiler

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-04-04 10:28:26 +02:00
Côme Chilliet
dd357d7f9b
Merge pull request #31679 from nextcloud/bugfix/noid/ensure-string-columns-to-be-maximum-of-4000 
Ensure string column limit of 4.000 characters
 2022-03-31 11:37:43 +02:00
Côme Chilliet
765999f454
Merge pull request #31609 from nextcloud/fix/migrate-away-from-ilogger 
Migrate from ILogger to LoggerInterface in lib/private
 2022-03-29 09:39:38 +02:00
Côme Chilliet
7407a324d9
Fix LENGTH function name across databases 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-28 00:01:17 +02:00
Joas Schilling
129bae62d4
Ensure string column limit of 4.000 characters 
https://docs.oracle.com/en/database/oracle/oracle-database/19/refrn/datatype-limits.html#GUID-963C79C9-9303-49FE-8F2D-C8AAF04D3095

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-03-25 12:44:51 +01:00
Côme Chilliet
25af856ed2 Use OCTET_LENGTH which is more common than LENGTHB 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 20:35:02 +00:00
Côme Chilliet
efebbacca4 Add octetLength and charLength to function builder, and tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 20:35:02 +00:00
Côme Chilliet
f1febfe696
Fix log level for exception in QueryBuilder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:28 +01:00
Côme Chilliet
ea23523c70
Adapt more code to migration to LoggerInterface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:25 +01:00
Côme Chilliet
6be7aa112f
Migrate from ILogger to LoggerInterface in lib/private 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:25 +01:00
Joas Schilling
0acd4b5f82
Merge pull request #31235 from nextcloud/techdebt/noid/extract-request-id 
Extract request id handling to dedicated class so it can be injected without DB dependency
 2022-03-22 12:08:45 +01:00
Joas Schilling
3bed983a9c
Disable for now again until more apps are fixed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-03-21 12:14:19 +01:00
Joas Schilling
32ede5489e
Limit missing primary key fail to new tables 
This will work on CI so devs notice it when they install the app for testing,
and at the same time existing faulty tables don't break the upgrade to 24

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-03-21 12:14:19 +01:00
Joas Schilling
b35253a4c3
Enforce primary keys as they are required to be performant in MySQL clusters 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-03-10 10:24:05 +01:00
Julius Härtl
83717a7800
Add event logging for db and redis connection 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-02-28 11:24:41 +01:00
Louis Chemineau
405c5eb813 Add --dry-run option for db:add-missing-* cmd 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-02-24 16:42:08 +01:00
Joas Schilling
1c138d3ae2
Allow to prefix the Query log with the request id 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-02-23 11:01:58 +01:00
Joas Schilling
76541170bb
Allow specify a config prefix for another database connection 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-02-03 17:16:03 +01:00
Joas Schilling
fccb98c8b6
Merge pull request #30379 from nextcloud/feature/add-comments-reactions 
Add comments reactions
 2022-01-21 15:08:12 +01:00
Joas Schilling
d850dc0220
Remove order from groupConcat as it is not working everywhere 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-21 08:39:39 -03:00
Vitor Mattos
f071b4dfbb
Fix groupConcat and ordering on Oracle 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-01-21 08:39:39 -03:00
Vitor Mattos
afe5b6dd8a
Prevent query error when use subquery 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-01-21 08:37:06 -03:00
Joas Schilling
de9fe8fcc1
Merge pull request #30471 from nextcloud/enh/cast-char-mysql 
Explicitly cast char in the query builder
 2022-01-20 14:32:56 +01:00
John Molakvoæ
eb3cf6c5ec
Merge pull request #30129 from nextcloud/mdb10.6-pipeline 2022-01-19 09:25:46 +01:00
Carl Schwan
89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin 
Fix psalm not running
 2022-01-13 09:51:04 +01:00
Carl Schwan
6312c0df69
Check style update 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-13 00:19:07 +01:00
Vitor Mattos
f732cf1b04
Unit tests 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-01-07 09:54:41 +01:00
Vitor Mattos
814924a787
Accept multipe args on concat 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-01-06 08:12:10 -03:00
Joas Schilling
eebed2c434
Fix psalm complaint 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-04 17:32:07 +01:00
Julius Härtl
a169ca306e
Explicitly cast char in the query builder 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-01-04 16:53:00 +01:00
Joas Schilling
005e717fe6
Use quote function 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-04 13:59:54 +01:00
Joas Schilling
ecc92067bf
Try escaping Oracle single quotes 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-04 13:36:55 +01:00
Joas Schilling
46ad6fa3c7
Add a test with integer 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-04 09:15:17 +01:00
Joas Schilling
e3e73a12ef
Fix oracle LISTAGG 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-03 21:43:53 -03:00
Vitor Mattos
fb6a9f308d
Add unit test 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-01-03 21:41:38 -03:00
Vitor Mattos
7b9fea85b6
Add unit test and orderBy parameter 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-01-03 12:45:00 -03:00
Vitor Mattos
79b3df00f8
Add group_concat aggregator function 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-01-03 07:48:11 -03:00
Carl Schwan
52760a95d9
Check if directoy is writable instead of possibly missing file 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-12-20 15:36:52 +01:00
acsfer
06b77fd666
Attempt to fix CI 2021-12-07 11:58:30 +01:00
Joas Schilling
168c673755
Allow to log DB, redis and LDAP requests into files 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-01 22:33:41 +01:00
Côme Chilliet
18a91f02fa
Fix default value for $type in OC\DB\QueryBuilder\ExpressionBuilder\ExpressionBuilder::literal 
This fixes PHP errors about passing null to PDO::quote second parameter.
We may want to change IExpressionBuilder as well?

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:29:02 +01:00
Joas Schilling
5bb49feef8
Allow NULL as well for limit, not integer only 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-15 18:51:28 +01:00
Christoph Wurst
130ab63ca1
Bump doctrine/dbal from 3.0.0 to 3.1.3 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-10-22 09:03:45 +02:00
Robin Appelman
695326534c
disable path prefix index on postgresql for now 
having the index work properly for the queries we need it for requires some additional options which dbal does not support at the momement.
to prevent making it harder to add the correct index later on we don't create the index for now on postgresql

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-10-08 18:39:22 +02:00
Arthur Schiwon
ce283c12b6
make it possible to override the default collation 
- allows admins to configure it for edge cases like accent sensitivity

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-01 11:57:47 +02:00
Joas Schilling
aae16c21e6
Allow casting query functions as well 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-07-07 14:20:24 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Christoph Wurst
865661ed75
Rename IQueryBuilder::executeUpdate to IQueryBuilder::executeStatement 
Because executeUpdate wasn't a great name. And in DBAL they also use
executeStatement more consistently now.

Ref https://github.com/doctrine/dbal/issues/4607

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-05-05 10:31:54 +02:00
Christoph Wurst
2ab8268128
Do not check Oracle column constraints in unrelated migrations 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-04-19 13:05:34 +02:00
Joas Schilling
f9d4fa2d38
Rename the method to match what it does 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-31 10:21:18 +02:00
Joas Schilling
3696ef5b96
Don't allow Notnull for boolean columns 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-31 10:21:17 +02:00
Joas Schilling
133a6f4fe4
Document the constraints we test against 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-31 10:21:17 +02:00
Joas Schilling
c98cab137c
Fix exception messages spacing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-31 10:21:10 +02:00
Morris Jobke
ab48d5e8cb
Cleanup unneeded code around database.xml 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-03-24 22:15:44 +01:00
Morris Jobke
37feee4e87
Merge pull request #24384 from nextcloud/cleanup/remove-old-migration-check 
Remove dead code from checking core/apps before upgrades
 2021-03-17 21:29:19 +01:00
Julius Härtl
a2f3077ee8
Skip db migration simulation for core schema changes 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-03-17 21:08:22 +01:00
Morris Jobke
459e0b311b
Merge pull request #25924 from nextcloud/bugfix/noid/only-mark-migrations-as-installed-after-executing-them-in-case-the-developer-broke-them 
Only mark migrations as installed after execution
 2021-03-17 20:29:28 +01:00
Roeland Jago Douma
85e48d796c
Merge pull request #25929 from nextcloud/techdept/psalm/25839/redundantcasts 
Remove Redundantcasts
 2021-03-05 08:42:54 +01:00
Roeland Jago Douma
d7f7d3bc51 Type CompositeExpression and ICompositeExpression 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-04 21:47:44 +01:00
Roeland Jago Douma
c3f1eb4f7f Remove Redundantcasts 
For #25839

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-04 14:44:04 +01:00
Roeland Jago Douma
76a6328d10 Add executeQuery and executeUpdate 
Names shamelessly copied from Doctrine itself.
Internally it is still using the same flow. But I added some checks
around it.

This should make static analysis a bit more happy. Which in turn makes
me more happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-04 14:03:31 +01:00
Joas Schilling
1e5fea0460
Only mark migrations as installed after execution 
The problem is that if a developer creates a structural error in their migration file,
they will already be marked as executed and an not be rerun.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-04 08:49:42 +01:00
Joas Schilling
a6246be34c
Merge pull request #25656 from nextcloud/enh/type/expressionbuilder 
Type the experssionbuilders
 2021-03-03 11:37:16 +01:00
Joas Schilling
11858a3d66
Merge pull request #25816 from nextcloud/iquerybuilder-join-conditions 
allow non string join conditions in query builder
 2021-03-03 11:34:56 +01:00
Roeland Jago Douma
4bdf9f5849 Type the experssionbuilders 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-03 10:44:09 +01:00
Robin Appelman
47dd8e54b5
allow non string join conditions in query builder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-03 10:43:15 +01:00
Daniel Kesselberg
bc91eb7c64
Filter tables with other table prefix 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-03-02 21:09:33 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Joas Schilling
1de3b8b0ec
When it kicks in 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-02-18 10:14:12 +01:00
Robin Appelman
111fa47f10
remove ReconnectWrapper 
dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-02-09 16:40:09 +01:00
Daniel Kesselberg
fe378200fa
Check for generic errors at last. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-02-02 18:28:49 +01:00
Christoph Wurst
b9287f9780
Merge pull request #25091 from nextcloud/enhancement/ocp-db-exception-abstraction 
Add our own DB exception abstraction
 2021-01-14 12:27:23 +01:00
blizzz
f9ab7575e7
Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2 
respect DB restrictions on number of arguments in statements and queries
 2021-01-14 11:36:42 +01:00
Christoph Wurst
2c9cdc1cdb
Add our own DB exception abstraction 
Right now our API exports the Doctrine/dbal exception. As we've seen
with the dbal 3 upgrade, the leakage of 3rdparty types is problematic as
a dependency update means lots of work in apps, due to the direct
dependency of what Nextcloud ships. This breaks this dependency so that
apps only need to depend on our public API. That API can then be vendor
(db lib) agnostic and we can work around future deprecations/removals in
dbal more easily.

Right now the type of exception thrown is transported as "reason". For
the more popular types of errors we can extend the new exception class
and allow apps to catch specific errors only. Right now they have to
catch-check-rethrow. This is not ideal, but better than the dependnecy
on dbal.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-12 16:38:23 +01:00
Arthur Schiwon
f9484d15cb
DB: warn on parameter number constraints 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-11 13:43:34 +01:00
Joas Schilling
3cdfe7b0f4
Don't try a transaction for the migrator on MySQL 
As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
CREATE TABLE statements automatically commit always. The only reason
this worked in the past was that PHPs PDO connection didn't check the
actual state on commit, but only checked their internal state.
But in PHP8 this was fixed:
https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450
So now commit() fails because the internal PDO connection implicitly
commited already.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-01-08 16:25:40 +01:00
Morris Jobke
dc00c8ac31
Remove "primary" option from schema builder argument $options as it is not used anymore and triggers an exception 
See 138eb85234 (diff-300f55366adb50a32a40882ebdc95c163b141f64cba5f45f20bda04a907b3eb3L82)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-08 11:45:19 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Christoph Wurst
9ce3ea3368
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-30 14:07:05 +01:00
Roeland Jago Douma
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net 
Unify links to php.net
 2020-12-22 09:53:31 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Joas Schilling
39bee7948d
Merge pull request #24631 from nextcloud/bugfix/noid/prevent-select-asterix-and-specifics 
Prevent * and other things in the same query for Oracle
 2020-12-14 14:31:15 +01:00
Joas Schilling
5828f3c4f9
Prevent * and other things in the same query for Oracle 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-14 09:35:50 +01:00
Julius Härtl
36ffad5ba7
Make sure the migrations table schema is always checked 
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Revert "Make sure the migrations table schema is always checked"

This reverts commit 258955ef738a52d9da2ac2fe59466e6093d7e9bc.

Set current vendor during upgrade and perform migrations table change if needed

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 15:24:03 +01:00
Joas Schilling
c1f28f8d35
Make debugging migration exceptions easier 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 19:35:01 +01:00
Vincent Petry
a50bcdabcc
Prevent log_query to mess up regular execution flow 
When the "log_query" debug config parameter is set, SQL queries are
logged. However, if an error occurs when converting the values to
string, it will abort the request.

This fix catches the error and continues instead.

Also added handler for DateTime value which is already known to cause
aborts here.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2020-12-02 14:10:35 +01:00
Morris Jobke
691409cdec
Merge pull request #24062 from nextcloud/revert-24060-revert-24039-faster-installation 
Revert "Revert "Installation goes brrrr""
 2020-11-20 15:02:51 +01:00
Morris Jobke
1b613c84e9
Merge pull request #24007 from nextcloud/select-distinct-multiple 
allow selecting multiple columns with SELECT DISTINCT
 2020-11-19 22:39:01 +01:00
Joas Schilling
a8cb8e21c1
Add types to function builder 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-16 19:46:24 +01:00
Joas Schilling
9a3ce2f71f
Don't drop the table anymore when we create it again 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-16 19:34:38 +01:00
Robin Appelman
a61a757b85
allow selecting multiple columns with SELECT DISTINCT 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-16 15:45:17 +01:00
Joas Schilling
d7b5d4cb58
Revert "Revert "Installation goes brrrr"" 2020-11-11 20:12:13 +01:00
Christoph Wurst
d36155620c
Revert "Installation goes brrrr" 2020-11-11 17:40:12 +01:00
Joas Schilling
77713ab454
Don't create a schema to check if the migrations table exists 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-11 11:45:00 +01:00
Joas Schilling
dde0e73c6b
Reduce the number of schemas we generate when we just run all migrations anyway 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-11 11:45:00 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
Joas Schilling
fbda2d1d25
Don't try to update on NotNullConstraintViolationException, only on unique or foreign key 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
Joas Schilling
1aa9c9164d
Fix comparing the empty string for global credentials 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:26 +01:00
Roeland Jago Douma
a5fa9604ba
Merge pull request #23923 from nextcloud/bugfix/oci/fix-greatest-order-for-oracle 
Fix greatest/least order for oracle
 2020-11-07 16:55:13 +01:00
Joas Schilling
d9e471771a
Update parameters 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-07 14:06:03 +01:00
Joas Schilling
cb8bef1f37
Fix iLike() falsely turning escaped % and _ into wildcards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-06 16:22:13 +01:00
Joas Schilling
3aaf2fabb1
Make sure Oracle always casts everything in the best way 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-06 12:13:22 +01:00
Joas Schilling
cfc35fa49a
Fix casting to integer on Oracle 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-06 08:38:08 +01:00
Julius Härtl
f49630f48c
Replace prefix in executeUpdate 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-11-03 11:03:02 +01:00
Roeland Jago Douma
fe46149560
Psalm fixes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-10-30 19:27:53 +01:00
Roeland Jago Douma
28be188fbc
Update internal connection class 
executeUpdate is deprecated in favor of executeStatement.
We overwrote the old one hence the prefix was no longer replaced.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-10-30 19:27:53 +01:00
Morris Jobke
f12e7e0e95
Fetch the logger and system config once for all query builder instances 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-29 22:35:06 +01:00
Morris Jobke
c1fd22b025
Merge pull request #23144 from nextcloud/enh/noid/update-param-for-psalm 
Less psalm warnings
 2020-10-06 22:07:58 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
Daniel Kesselberg
0e3ddf1b27
Add explicit typecast for $value. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-10-03 17:15:14 +02:00
Daniel Kesselberg
64b10f61df
Update signature for set 
also ILiteral and IQueryFunction are valid.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-10-02 19:15:34 +02:00
Daniel Kesselberg
8fdb74bdd5
Update signature for in/notIn 
$y is always passed to quoteColumnName hence ILiteral|IParameter|IQueryFunction are supported.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-10-02 19:09:28 +02:00
Daniel Kesselberg
d14c971ad6
Update signature for like/notLike/in/notIn 
$x is always passed to quoteColumnName hence ILiteral|IParameter|IQueryFunction are supported.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-10-02 18:59:53 +02:00
Joas Schilling
3212c074b9
Log the number of queries built and executed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-09-25 14:55:53 +02:00
J0WI
68ce17e59b Unify links to php.net 
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-09-17 17:40:04 +02:00
Morris Jobke
99c9423766
Remove @suppress SqlInjectionChecker 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-16 15:53:56 +02:00
Joas Schilling
50230847ce
Warn about adding NotNull columns with nullable default 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-09-07 13:14:49 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Morris Jobke
fedf9c69d9
Use matching parameter names form interfaces and implementations 
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-19 18:16:35 +02:00
Morris Jobke
d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements 
Ref #21787

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-17 17:46:57 +02:00
Daniel Kesselberg
10ac844448
Update documentation for QueryBuilder::set 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-08-14 19:55:01 +02:00
Daniel Kesselberg
87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Roeland Jago Douma
cbcf072b23
Revert "Make sure MySQL is not saying 'this' = 'this ' is true" 2020-04-15 23:49:16 +02:00
Joas Schilling
16e9bf2309
Make sure MySQL is not saying 'this' = 'this ' is true 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-15 09:14:12 +02:00
Christoph Wurst
28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst
1584c9ae9c
Add visibility to all methods and position of static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:51:06 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
44577e4345
Remove trailing and in between spaces 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:07:47 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
41b5e5923a
Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 10:16:08 +02:00
Christoph Wurst
85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Joas Schilling
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id 
Add optional comments reference_id
 2020-04-02 11:34:21 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Joas Schilling
720dc4e93d
Add optional column oc_comments.reference_id 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-31 10:51:15 +02:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Christoph Wurst
5fc4c91a76
Fix mismatching doc block parameter types 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-06 16:28:42 +01:00
Daniel Kesselberg
9e699a8d21
Add event subscriber for transaction isolation level 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-02-21 09:59:08 +01:00
Joas Schilling
059968e1c7
Pick a shorter name for the transfer ownership table 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-10 11:01:26 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Roeland Jago Douma
76b78edd40
Merge pull request #17833 from nextcloud/propagator-no-negative-sizes 
dont set folder size to negative values during propagation
 2019-12-04 11:49:26 +01:00
Joas Schilling
19935a6a26
Merge pull request #17949 from nextcloud/debt/deprecated-const 
Connection::TRANSACTION_READ_COMMITTED is deprecated
 2019-12-04 09:49:41 +01:00
Robin Appelman
9e450d727a
add LEAST and GREATER to db function builder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2019-11-26 12:05:30 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
Daniel Kesselberg
9cb7252880
Connection::TRANSACTION_READ_COMMITTED is deprecated 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2019-11-14 20:17:27 +01:00
Robin Appelman
ac209cea52
add count() as shortcut for count('*') in FunctionBuilder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2019-11-13 11:30:32 +01:00
Robin Appelman
0e9feeb090
return from QueryBuilder instead of IQueryBuilder 
this make the type hints work properly with querybuilder subclasses

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2019-11-13 11:30:27 +01:00
Robin Appelman
8ef5a366ec
add MAX and MIN to functionbuilder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2019-09-06 12:28:17 +02:00
Arthur Schiwon
d0409548c6
instead of upsert, fallback to default query on PgSQL <= 9.4 
because there is no upsert yet

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-08-14 09:05:11 +02:00
Christoph Wurst
3174012adf Add event dispatcher to OCP 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-06-25 10:02:27 +02:00
Roeland Jago Douma
d11caf1a3a
No need for platform hacks anymore 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-05-14 12:24:43 +02:00
Joas Schilling
b3e6cbc4c5
Remove the custom prefix from the table name length when checking on the default primary index 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-04-30 12:08:52 +02:00
Joas Schilling
f906913177
Allow to use Subqueries in from 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-04-16 15:42:21 +02:00
Joas Schilling
f557e1e214
Indeces, columns and sequences don't have the table prefix 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-03-28 14:51:11 +01:00
Morris Jobke
f889beae7e
Fix PHPDoc 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-03-21 17:05:57 +01:00
Ole Ostergaard
0d778fcc4e Code cleanup. 
Signed-off-by: Ole Ostergaard <ole.c.ostergaard@gmail.com>
 2019-03-21 11:42:00 +01:00
Ole Ostergaard
d62da82bf9 Add supression of SqlInjectionChecker. 
Signed-off-by: Ole Ostergaard <ole.c.ostergaard@gmail.com>
 2019-03-21 11:42:00 +01:00
Ole Ostergaard
c9b6487393 Add PostgreSQL specific implementation for includeIgnoreConflict. 
Signed-off-by: Ole Ostergaard <ole.c.ostergaard@gmail.com>
 2019-03-21 11:42:00 +01:00
Ole Ostergaard
a48ea8cffa Add insertIgnoreConflict to Adapter and use it for for executing the file locking. 
Signed-off-by: Ole Ostergaard <ole.c.ostergaard@gmail.com>
 2019-03-21 11:42:00 +01:00
Robin Appelman
bfd539017f
add casting to string for postgresql query builder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2019-03-14 14:19:10 +01:00
Joas Schilling
c09fa1ee65
Only check the Oracle schema conditions if the app supports it 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-12-17 13:52:08 +01:00
Joas Schilling
f265657bc6
Only check changed items 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-12-17 13:52:08 +01:00
Morris Jobke
fd8eeccb15
Merge pull request #11942 from nextcloud/techdebt/noid/use-count-function 
Use the defined func()->count() instead of manual counting
 2018-11-12 17:43:56 +01:00
Morris Jobke
5273639d0e
Add deprecation message ofr insertIfNotExist 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-09 12:13:30 +01:00
Morris Jobke
230e93f575
Catch UniqueConstraintViolationException inside insertIfNotExist 
This is the most common case for the usage of this method.

See also https://github.com/nextcloud/server/issues/12369 and the linked tickets.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-09 10:38:20 +01:00