upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-16 20:19:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 16
83872 commits 1016 branches 1221 tags 8.7 GiB
Commit graph

441 commits

Author SHA1 Message Date
Aaron Dewes
d79def553f Fix tests 
Signed-off-by: Aaron Dewes <aaron.dewes@protonmail.com>
 2023-08-13 15:43:04 +02:00
Côme Chilliet
2c19aac9e1
Move UpdateGroups methods to a service 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-08-10 10:57:33 +02:00
Joas Schilling
ad12a740cb
fix!: Remove symfony EventDispatcherInterface from User 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-27 23:13:37 +02:00
Arthur Schiwon
92a082d823
fix(ldap): avatar is not being fetched 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-05 17:13:43 +02:00
Côme Chilliet
b2f01b72fe
Merge pull request #34443 from nextcloud/feat/add-enabled-user-backend 
Add IProvideEnabledStateBackend interface
 2023-07-03 10:19:32 +02:00
Faraz Samapoor
b0938b9083 Refactors "strpos" calls in /apps/user_ldap to improve code readability. 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-06-02 15:26:55 +03:30
Côme Chilliet
367b4fe9f2
Fix User_Proxy tests as well 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-25 15:55:04 +02:00
Côme Chilliet
add59d2309
Use DI for DeletedUsersIndex and fix tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-25 12:18:28 +02:00
Côme Chilliet
802363f0f6
Adapt Sync job tests to the constructor change 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 09:08:57 +02:00
Côme Chilliet
f6ff717b56
Merge pull request #34772 from nextcloud/fix/clean-ldap-access-factory-usage 
Make sure to use AccessFactory to create Access instances and use DI
 2022-12-20 16:48:07 +01:00
Côme Chilliet
6b7ffcd6a8
Fixed backup host logic 
Now forcing backup host applies to both main and background.
And background will fallback to backup if not responding.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-19 14:15:48 +01:00
Côme Chilliet
75e369d306
Merge pull request #35231 from nextcloud/fix/user_ldap-cache-fetched-list-of-groups 
Cache the fetched list of groups
 2022-12-19 12:34:05 +01:00
Côme Chilliet
723c1b8adc
Fix user_ldap tests now that list of groups gets cached 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-19 11:59:45 +01:00
Côme Chilliet
72c7fad1c4
Fix job tests in updatenotification and user_ldap applications 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 11:32:49 +01:00
Côme Chilliet
5e74b1e9ad
Adapt test to User_Proxy constructor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-10-25 16:16:59 +02:00
Simon L
47da08fe85
Merge pull request #33945 from nextcloud/fix/noid/fair-use-ldap 
LDAP to not register new users when outside of fair use or over limits
 2022-10-21 18:53:16 +02:00
Côme Chilliet
746a5fb7e0 Fix LDAP recursive nested group support 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-10-20 13:14:39 +02:00
Carl Schwan
1b12a08ec2 Fix user_ldap tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-20 12:09:06 +02:00
Côme Chilliet
7437673add Add testing of nested group membership 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-10-20 12:09:06 +02:00
Côme Chilliet
6ed0d0b8b1 Refactor group membership listing for nested groups 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-10-20 12:09:06 +02:00
Côme Chilliet
02ccce17f7 Add tests for nested groups 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-10-20 12:09:06 +02:00
Arthur Schiwon
8e8acf2d90
LDAP to no register new users when outside of fair use or over limits 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-10-18 12:57:43 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory 
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-05 12:59:54 +00:00
Carl Schwan
48d9c4d2b0
Port existing server code to new interface 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-08 17:03:19 +02:00
Arthur Schiwon
8185a3d701
adjust tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-06-28 22:46:51 +02:00
Côme Chilliet
113028581c
Remove bogus expects from user_ldap tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-06-14 15:44:51 +02:00
Côme Chilliet
129584c966
Remove deprecated at() matcher from user_ldap tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-06-13 15:19:25 +02:00
Côme Chilliet
d7a291039d Fix user_ldap unit tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-01 12:18:03 +00:00
Côme Chilliet
dab5ea958a
Fix unit tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 16:35:06 +01:00
Arthur Schiwon
45d4c0bf66
add occ command to update UUIDs (incomplete) 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-02-10 10:14:59 +01:00
Côme Chilliet
f3dcbfe146
Fix PHP 8.1 support for user_ldap application 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-12-16 09:43:30 +01:00
blizzz
84e47fb484
Merge pull request #29470 from nextcloud/fix/translit-php8 
Avoid use of iconv to get rid of unicode
 2021-11-29 11:37:19 +01:00
Côme Chilliet
20dd46fcae
Merge pull request #29610 from nextcloud/fix/user_ldap-logger 
Get rid of user_ldap LogWrapper and use LoggerInterface
 2021-11-23 15:26:25 +01:00
Côme Chilliet
480056de88
Fix sanitizing regex and add a test case for uppercase in username 
I did not find any test data that would fail with the previous regex,
 but still added data with uppercase to at least test that.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:10:38 +01:00
Côme Chilliet
26330cb774
Test cache invalidation for AbstractMapping in test suite 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-22 14:57:08 +01:00
Côme Chilliet
6b960de47c
Get rid of LogWrapper calling deprecated logger and use LoggerInterface from PSR instead 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-09 15:11:15 +01:00
Côme Chilliet
158e73242e
Avoid use of iconv to get rid of unicode 
Using iconv for translit depends upon server configuration, locale, and
 PHP version. Using htmlentities instead to have a consistent behavior
 independent of configuration.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-28 10:30:14 +02:00
Côme Chilliet
51398d706a
Use Psr\Log\LoggerInterface in OCA\User_LDAP\Access 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-12 17:19:51 +02:00
blizzz
e8f76b03bb
Merge pull request #28876 from nextcloud/fix/28653/ldap-long-user-group-ids 
ensure that user and group IDs in LDAP's tables are also max 64chars
 2021-09-24 22:53:06 +02:00
Arthur Schiwon
6ab30a669b
ensure that user and group IDs in LDAP's tables are also max 64chars 
- limitation by core tables (e.g. sharing), IDs are always 64chars
- when longer group IDs were requested they are hashed (does not affect
  displaynames)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-24 17:29:29 +02:00
Arthur Schiwon
7178194198
fix caching of objectsid searches 
- store result when no name could be retrieved, too
- cached value is not an array, was treated wrongly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-21 13:32:42 +02:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2021-06-30 15:28:02 -04:00
Daniel Kesselberg
04411df695
Add method to read multi-value attributes from ldap. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-06-16 11:35:27 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Valdnet
77ca79f697
l10n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet 47037905+Valdnet@users.noreply.github.com
 2021-05-21 11:50:12 +02:00
Joas Schilling
39e248d330
Fix LDAP unit tests 
20) OCA\user_ldap\tests\Jobs\UpdateGroupsTest::testHandleKnownGroups
Trying to configure method "fetchAll" which cannot be configured because it does not exist, has not been specified, is final, or is static

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-20 17:22:52 +02:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Joas Schilling
645f83121e
Cache the user backend info for 300s 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-02-15 10:36:08 +01:00
Christoph Wurst
6a3321cefe
Merge pull request #25101 from nextcloud/fix/noid/ldap-known-groups 
LDAP: make actually use of batch read known groups
 2021-01-29 10:57:31 +01:00
Arthur Schiwon
02b703193a
really use known groups 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-12 20:52:52 +01:00
Arthur Schiwon
45e3261ad5
respect DB limits limit per statement and query 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-11 13:43:34 +01:00
Roeland Jago Douma
dc89447f13
Revert "(LDAP) respect DB limits of arguments in an IN statement" 2021-01-08 10:44:32 +01:00
Arthur Schiwon
6eca8d6ae1
respect DB limits of arguments in a IN list 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-07 20:16:40 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
blizzz
f68cab4e39
Merge pull request #24402 from nextcloud/fix/24252/ldap-ingroup-memberid 
LDAP: fix inGroup for memberUid type of group memberships
 2020-12-15 22:33:41 +01:00
Roeland Jago Douma
54ef1a73af
Cancel 1 LDAP test for php8 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:04 +01:00
Arthur Schiwon
af6b0ecec0
php-cs happyness 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-27 19:34:35 +01:00
Arthur Schiwon
e9e61b9537
add unit tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-27 19:24:12 +01:00
Joas Schilling
3f370f3732
Test requires the DB 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-09 08:40:00 +01:00
Joas Schilling
5fba0e562f
Use query builder instead of OC_DB in user_ldap 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-06 11:25:28 +01:00
Arthur Schiwon
fd44087530
adds unit test for updategroups background job 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-30 16:30:00 +01:00
Arthur Schiwon
fd1fd5afa4
user share manager to determine share ownership 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-26 16:05:28 +01:00
Arthur Schiwon
951887e922
fixes determining whether former user is a share owner 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-26 16:05:28 +01:00
Arthur Schiwon
002c56de17
add test for active shares flag 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-26 16:05:23 +01:00
Arthur Schiwon
86e5e7d927
LDAP simplify User_Proxy and Group_Proxy signatures 
- make User_Proxy and Group_Proxy easy to instantiate
- simplify dependent code
- move commands to info.xml
- make UpdateGroups job class non-static

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-23 12:25:31 +02:00
Arthur Schiwon
d741c5ab30
when nesting is not enabled, the group filter can be applied right away 
- helps performance, but skipping unnecessary entries
- reduces reoccuring info-level log output against groups that do not
  qualify ("no or empty name")

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-19 13:44:32 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
Christoph Wurst
1f7f93a695
Update license headers for Nextcloud 20 (again) 
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-09-07 14:37:44 +02:00
Arthur Schiwon
699871dcb0
these code bits were part of old logic that was already refactored out 
- only references were in unit tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-09-04 12:56:43 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Morris Jobke
55e79b8a6a
Merge pull request #22199 from nextcloud/techdebt/noid/PHPUnit_Framework_MockObject_MockObject 
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to …
 2020-08-12 13:55:36 +02:00
Morris Jobke
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-12 13:55:19 +02:00
Arthur Schiwon
7eb6d8df0a
do not flip available state to unavailable, allow empty results 
- the detection relies that the first, requested result is not empty
- it might be empty though – groups without members
- protect switching from available to unavailable
  - switching the other way around was also not envisaged either

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-11 19:03:27 +02:00
Arthur Schiwon
7ea262dba0
LDAP: shortcut in reading nested group members when IN_CHAIN is available 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-11 18:22:11 +02:00
Morris Jobke
3203286f52
Do not use custom DI object names for user_ldap 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-13 17:22:19 +02:00
Morris Jobke
d72d9ff1f4
Merge pull request #21171 from nextcloud/enh/noid/tidy-up-group-ldap 
tidy up Group_LDAP
 2020-07-06 14:00:27 +02:00
Arthur Schiwon
b8bef4ded0
fix strings being passed where arrays where expected 
also brought type hints up to internal API level

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-24 23:34:37 +02:00
Arthur Schiwon
64fe042b0d
tidy up Group_LDAP 
* remove unused method
* resolve code duplication
* remove usage of deprectad Util::writeLog
* phpDoc updates
* signature updates

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-08 13:40:24 +02:00
Ruben Barkow-Kuder
4ad622a720 compress some images with tinypng.com 
Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-05-22 13:07:11 +00:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Arthur Schiwon
4babdc082b
formatting 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-23 21:34:05 +02:00
Arthur Schiwon
32000dd1af
read records from DB for lists at once, not one by one. 
Keep a runtime cache of dn-id-mapping

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-17 12:39:54 +02:00
Roeland Jago Douma
d9990b09b8
PHP-CS-Fixer green 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-16 09:25:17 +02:00
Arthur Schiwon
84619a5b9c
use serverControls directly with LDAP calls, fixes 19127 
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-14 12:58:28 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
a8a06a82d2
Remove trailing whitespaces from comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:09:23 +02:00
Christoph Wurst
44577e4345
Remove trailing and in between spaces 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:07:47 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
41b5e5923a
Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 10:16:08 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
2ee65f177e
Use the shorter phpunit syntax for mocked return values 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:21:27 +01:00
Christoph Wurst
74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Arthur Schiwon
f657ded6ec
remove superfluous tests 
- user_ldap is not exposed to public api, it is always behind ldap_proxy
- this is too much for a unit test
- integration tests cover userExists implicitly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-08 09:21:22 +01:00
Arthur Schiwon
1068b860ff
adjust tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-08 09:21:22 +01:00
Arthur Schiwon
411a47cadb
relax strict getHome behaviour for LDAP users in a shadow state 
* simplifies deletion process
* less strange behaviour when looking up home storage (as long as it is local)
* thus could enable transfer ownerships after user went invisible on ldap

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-08 09:21:21 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00