Commit graph

315 commits

Author SHA1 Message Date
Ferdinand Thiessen
8de89b2103
fix(theming): Apply same logic on capabilities for primary color like on themes
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-23 01:01:42 +01:00
Ferdinand Thiessen
18b91ba2e1 fix(theming): Make sure color-border-maxcontrast fulfills 3:1 contrast
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-17 15:30:39 +01:00
Joas Schilling
2fccd090b3
fix(manifest): Check if app exists instead of accessing null as an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-17 09:25:44 +01:00
Ferdinand Thiessen
a782d6f797 fix(theming): Adjust high contrast theme to fulfill WCAG AAA text contrast
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-22 14:05:42 -06:00
Ferdinand Thiessen
74f6995bdb fix(theming): Adjust dark high contrast to fulfill WCAG 2.1 AAA contrast
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-19 10:20:33 -06:00
Ferdinand Thiessen
ae12a73c85 fix(theming): Make dark theme accessible and add unit test
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-18 10:25:10 -06:00
Ferdinand Thiessen
2e5d435df7 fix(theming): Adjust status colors to be also accessible on blurry background
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-18 10:25:10 -06:00
Ferdinand Thiessen
84123b3910
fix(theming): Adjust primary text color calculation to also work with high contrast themes
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-15 21:09:39 +01:00
Ferdinand Thiessen
61f401da57
fix(theming): Adjust hover color to be accessible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-15 21:09:14 +01:00
Ferdinand Thiessen
141d1e9026
enh(theming): Adjust color utils to work as specified by WCAG (color contrast and luma calculation)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-15 21:09:14 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
jld3103
e69e201af8
fix(theming): Correctly expose user and admin theming
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-11-03 09:36:08 +01:00
Ferdinand Thiessen
3676295f7b
fix(theming): Ensure all text colors have enough contrast for accessibility
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-27 12:56:23 +02:00
Ferdinand Thiessen
615a6846da
feat(theming): Allow to reset the user defined app order to the default value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-21 03:52:25 +02:00
Ferdinand Thiessen
e9d4036389
feat(theming): Allow to configure default apps and app order in frontend settings
* Also add API for setting the value using ajax.
* Add cypress tests for app order and defaul apps

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-20 00:24:17 +02:00
Côme Chilliet
0a9371f99f
Migrate applications away from deprecated ILogger
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-21 11:57:21 +02:00
John Molakvoæ
998b3a2581
feat(f2v): migrate Files
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:56:37 +02:00
Daniel Kesselberg
f21cbfff64 feat: add detected mime type to exception
The mimetype may not match the file extension.
Helps the user to find out why a provided image is not accepted.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-24 22:38:57 +02:00
Robin Appelman
51984dc273
fix loading custom logo image
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-22 15:10:54 +02:00
Simon L
4a89b7ea22 adjust tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-11 14:15:47 +02:00
John Molakvoæ
4c71d8f8a4
fix(theming): replace elementColor dark value with better contrast #8c8c8c
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-05-04 14:41:19 +02:00
Ferdinand Thiessen
7e1152603f feat(theming): Only convert a background image if it benefits from it
* WebP images are generally quite small, converting to pngs would increase
  the filesize a lot.
* Small JPEG and PNG images do not benefit from any conversion, so skip it.
* JPEG images will get quite bigger when converted to PNG so instead convert to progressive JPEG

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-20 13:11:19 +01:00
Vincent Petry
6e75931412
Limit key names when uploading theme images
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-11 16:16:44 +01:00
John Molakvoæ
a869259e41
More theming cypress tests and some fixes
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-29 11:26:27 +01:00
John Molakvoæ
064fa10ecf
Extract colour from custom background
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-29 11:23:05 +01:00
John Molakvoæ
cedae7c6d7
Allow to remove the background and select a custom colour
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-29 11:22:13 +01:00
Côme Chilliet
f171de52b3
Fix theming tests for PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-24 12:20:27 +01:00
Simon L
04b236e320 generate user themed icons
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2022-11-18 15:03:41 +01:00
John Molakvoæ
e6b7fa6cae
Fix logo invert
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-16 09:46:20 +01:00
Côme Chilliet
38440563dd
Fix themings tests and get rid of deprecated at matcher
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:29:26 +01:00
Côme Chilliet
68363f6944
Fix some more problems with tests under PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +01:00
Côme Chilliet
c79a6b3f62
Fix errors from PHP 8.2 testing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 17:08:21 +01:00
Christopher Ng
4a2bbc7af9 Rewrite admin theming in Vue
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-28 00:18:47 +00:00
John Molakvoæ
746710ad5b
Fix tests
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-19 12:57:35 +02:00
John Molakvoæ
d77e832223
Fix tests
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-14 16:18:40 +02:00
John Molakvoæ
9a92fe9b29
Fix primary and debounce to avoid infinite loop
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-13 12:13:39 +02:00
John Molakvoæ (skjnldsv)
db831359d3
Allow to pick custom colour
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-10-13 12:13:39 +02:00
Christopher Ng
46ee620150 Fix excessive increase of cachebuster value
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-11 16:25:42 +00:00
Christopher Ng
e962d3fba4 Use color preset of shipped background as primary color
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-05 06:19:08 +00:00
szaimen
c9a372034f fix highcontrast theme icons
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-27 13:52:49 +02:00
greta
02cc42d40a Move background settings from dashboard app to Appearance and accessibility settings
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-14 20:17:01 +00:00
John Molakvoæ
5e550829c5
Fix theming tests
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-08-19 14:35:00 +02:00
John Molakvoæ
5f3229ed67
Automatically enable plain background if primary colour is set
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-08-16 09:39:00 +02:00
John Molakvoæ
0ea23cad0e
Revert "Fix unit tests for the theming app"
This reverts commit 13ca01ee12.
2022-08-16 08:51:43 +02:00
Carl Schwan
13ca01ee12
Fix unit tests for the theming app
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-11 18:02:23 +02:00
Côme Chilliet
293c1797eb
Remove deprecated expectException from theming tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-20 09:10:11 +02:00
Côme Chilliet
f8a5be6a90
Remove deprecated at matcher from theming tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-16 15:55:05 +02:00
John Molakvoæ
f577b5dc96
Fix theming setEnabledThemes unique array
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-30 13:40:27 +02:00
John Molakvoæ
24c5d994c7
Allow to override the default theme
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-30 13:40:27 +02:00
John Molakvoæ
4a646789c3
Add system/light themes
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-28 08:41:58 +02:00
John Molakvoæ
4dc96dd165
Fix mix factor
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-26 09:22:43 +02:00
John Molakvoæ
f7f4d36a37
Fix dyslexia font loading
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-22 13:04:15 +02:00
John Molakvoæ
850d8ac1cd
Add default theming disabled fallback
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-22 11:24:25 +02:00
John Molakvoæ
3c75a99267
Phpunit
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:28 +02:00
Carl Schwan
7dddbd0c35 Improve caching policy
* Cache css with version in url. This makes most js and css requests to
  be cached by the browser

* Force caching previews, the etag is in the url so that if the propfind
  gives a new etag, we will refresh it otherwise it's no use to try to
  fetch the new etag and do tons of DB queries

Tested with firefox and 'debug' => false (important so that the js/css
urls are generated with ?v= parameter)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-16 11:35:57 +01:00
Julius Härtl
3d0b5c1ff9
Avoid file system access on checking if an image exists
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-02 11:26:36 +01:00
Côme Chilliet
37f8f7a5a1
Fix tests on PHP 8.1 for encryption, files_sharing, files_version,
files_trashbin and theming apps

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:29 +01:00
Côme Chilliet
6b770eb579
Fix theming tests on PHP 8.1
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:29 +01:00
szaimen
0758e0258d improve webmanifest
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-08-24 11:42:04 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
Julius Härtl
22e26a7f5e
Store scss variables under a different prefix for each theming config version
The main issue with using the general theming- prefix is that with APCu caching
the cache is not shared between processes, so when trying to reset the cache
through the CLI, e.g. when updating the theming config the old cache is never
invalidated.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-30 14:15:17 +01:00
Julius Härtl
a0c0918ce2
Optimize chek if background is themed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-23 13:48:05 +01:00
Morris Jobke
c7ff0c71b4
Shortcut to avoid file system setup when generating the logo URL
If an SVG is requested and the app config value for logoMime is set then the logo is there. Otherwise we need to check it and maybe also generate a PNG from the SVG (that's done in getImage() which needs to be called then).

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-09 10:01:34 +01:00
Morris Jobke
b8ed997238
Remove ISection in favor of IIconSection
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-28 23:05:00 +01:00
John Molakvoæ (skjnldsv)
a7c4369941
Fix theming manifest tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 11:03:24 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Julius Härtl
0daf097af3
Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-24 08:22:07 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Morris Jobke
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 13:55:19 +02:00
Joas Schilling
f8641a6e55
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 16:16:06 +02:00
Joas Schilling
be5176076e
Precalculate the primary element color for dark mode too
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 09:58:45 +02:00
Roeland Jago Douma
3f1b6e2ce9
Move theming js to initial state
A bit more elegant. Plus it will allow us to also write a proper
@nextcloud/theming package. To make life easier down the line for all.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-05 11:01:49 +02:00
Ruben Barkow-Kuder
4ad622a720 compress some images with tinypng.com
Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-22 13:07:11 +00:00
Christoph Wurst
cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
Christoph Wurst
41b5e5923a
Use exactly one empty line after the namespace declaration
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
Remove unused imports
2020-03-27 17:14:08 +01:00
Christoph Wurst
2ee65f177e
Use the shorter phpunit syntax for mocked return values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
Christoph Wurst
74936c49ea
Remove unused imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
Christoph Wurst
1b46621cd3
Update license headers for 18
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
Roeland Jago Douma
069b938ab0
Fix the theming tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-12-04 09:07:24 +01:00
Roeland Jago Douma
3a7cf40aaa
Mode to modern phpunit
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +01:00
Roeland Jago Douma
c007ca624f
Make phpunit8 compatible
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +01:00
John Molakvoæ
fe6dc8082c
add var for theming images , advanced options (#16815)
add var for theming images , advanced options
2019-11-26 10:55:20 +01:00
Guillaume COMPAGNON
761f331d1e
fix test for new css vars / logoheader and favicon
Signed-off-by: Guillaume COMPAGNON <gcompagnon@outlook.com>
2019-11-24 21:51:43 +01:00
Guillaume COMPAGNON
ed399a31bd
add var for theming images , advanced options
Signed-off-by: Guillaume COMPAGNON <gcompagnon@outlook.com>
2019-11-24 21:51:43 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
Roeland Jago Douma
80743e1f85
CapabilitiesTests are not DB tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-09-04 20:32:34 +02:00
Julius Härtl
47a0254bb3
Validate urls in theming settings and properly handle error messages
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-07-31 10:20:57 +02:00
Julius Härtl
798b2e87b9
Fix light primary button styling
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-27 18:42:06 +01:00
Roeland Jago Douma
575b3f9ff8
Revert "Where is your data?" 2019-03-20 15:17:31 +01:00
Julius Härtl
a6b579b772
Add guest navigation type
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-02-18 09:12:11 +01:00
Michael Weimann
2cd3fd3dc2
Move server info to theming section
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2019-01-14 00:08:26 +01:00
Michael Weimann
044ab0cbec
Adapts the theming util to the new core logo image path
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-10-04 20:43:27 +02:00
Michael Weimann
065e0c0e49
Fixes the logo test
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-10-03 19:26:47 +02:00