Côme Chilliet
4abfd4871f
chore: Move isAppCompatible and shouldUpgrade to the app manager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 16:18:38 +02:00
Ferdinand Thiessen
0dd8e5e32e
feat(settings): allow to set own timezone in personal settings
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-18 12:35:31 +02:00
Maxence Lange
6076b67696
feat(preset): share link expiration date
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-08-14 16:07:32 -01:00
Maxence Lange
cb84ccc57d
feat(preset): share password protection
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-08-12 14:37:32 -01:00
Lukas Schaefer
1ae4764073
chore(settings): Rename ai settings to assistant
...
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
2025-08-08 13:54:08 -04:00
yemkareems
aa227f1c55
feat: add bluesky to accounts, show the same in profile edit and visibility option, in view profile and also in sharing tab
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2025-08-08 08:06:45 +00:00
Julien Veyssier
be7ef439cf
fix(taskprocessing): move LAZY_CONFIG_KEYS constant to the private namespace
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2025-08-04 10:11:24 +02:00
Julien Veyssier
2e3fa51132
feat(taskprocessing): load and store some config keys lazily
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2025-08-04 10:11:24 +02:00
Joas Schilling
3ccb3160b4
Merge pull request #53898 from nextcloud/ci-mariadb-118
...
ci: test against MariaDB 11.8 (latest LTS)
2025-07-28 08:10:05 +02:00
Ferdinand Thiessen
074b994218
fix(settings): verify source of app-discover media
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-21 14:06:47 +02:00
Ferdinand Thiessen
a18e61a1e5
feat(files_sharing): add config option for extending link-share permissions
...
This allows the admin to control the behavior whether link shares with
READ permissions should be extended to also gain SHARE permissions,
allowing users (public share receivers) to add the share to their cloud.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-17 16:59:36 +02:00
Josh
6b65031a08
feat(settings): add support for MariaDB 11.8 in setup checks
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-07-10 10:18:50 -04:00
Jana Peper
f8886fe27a
feat: add toggle for AI guest restriction
...
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2025-07-03 10:25:19 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
John Molakvoæ
bd00b75b29
Merge pull request #53671 from nextcloud/fix/read-only-share-download
2025-07-01 15:11:06 +02:00
Ferdinand Thiessen
54f55a1a0e
Merge pull request #53429 from nextcloud/enh/opcache-checks
...
feat(settings): simplify OPcache checks
2025-07-01 14:26:04 +02:00
Joas Schilling
60b8384e48
Merge branch 'master' into remove-x-xss-protection
2025-06-30 21:32:22 +02:00
Ferdinand Thiessen
b1282f75fa
fix(settings): use correct scope for translations
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-26 18:26:02 +02:00
skjnldsv
9806a9830c
feat(files_sharing): allow viewing files with download disabled
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-26 11:47:53 +02:00
MichaIng
0d10c4fb33
feat(settings): simplify OPcache checks
...
For the overall OPcache size check, we currently compare used memory with free memory. However, `opcache.memory_consumption` is split into `used_memory`, `free_memory` and `wasted_memory`. When cached files change on disk, old entries are not replaced or removed, but remain as wasted memory, until the cache is actually full, and if their percentage is above `opcache.max_wasted_percentage`, which is 5% by default. When this happens, the engine is restarted, resetting the cache completely, like a `opcache_reset()` call.
As long as we do not consider wasted cache, recommendations based on free memory can be false. To solve this, we could count wasted memory as free memory, if it is above `opcache.max_wasted_percentage`, as the engine will be restarted as soon as needed, freeing up this wasted space. On the other hand, wasted memory below the threshold permanently blocks the OPcache, which supports counting it as used memory. Depending on the situation, instead of raising OPcache size, it could be also advised to reduce `opcache.max_wasted_percentage`. But too frequent cache resets break its purpose as well.
In my opinion, the matter is too complex to consider wasted cache correctly, and do precise recommendations, but we should focus on reducing false positives instead. What we know for sure is: if the cache is full (`$status['cache_full'] === true`), and the limit for cached keys has not been reached, the OPcache was too small to maintain free space, with wasted memory below the configured threshold, where it consumes memory permanently. Recommending to raise the OPcache size in this case, is hence as accurate as it gets. Even if 5% wasted cache could be freed, 95% used memory is still above the previous threshold for the setup check warning. And if `opcache.max_wasted_percentage` is above 5%, then the admin must have decided to change the default, deciding that system memory consumption has lower priority than preventing OPcache engine restarts.
`cache_full` can be true as well if the limit for cached keys has been reached, hence we need to merge both checks. In this case `num_cached_keys` equals `max_cached_keys` exactly, hence it is easy to differentiale whether `opcache.max_accelerated_files` or `opcache.memory_consumption` needs to be raised to address the `cache_full` state.
In practice, this change relaxes the checks: the respective limit needs to be reached 100% instead of 90%, to trigger a warning, eliminating also false alarms if a large share of the cache is consumed by wasted memory, which would be automatically freed once cache is 100% full.
Additionally, the recommendation for raising `opcache.max_accelerated_files` now says "a value higher than `max_cached_keys`", instead of "higher than `opcache.max_accelerated_files`". The actual limit, reflected by `max_cached_keys` from `opcache_get_status()`, [is a next higher value from a set of prime numbers](https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.max-accelerated-files ). E.g. if `opcache.max_accelerated_files` is set to 10,000 (PHP default), the effective limit is 16,229 OPcache keys. Recommending "higher than 10000" could hence lead to a settings change without effect. For an effective change, the new value needs to be "higher than 16229" instead, which is what the setup check will show in this situation, with this change applied.
Signed-off-by: MichaIng <micha@dietpi.com>
2025-06-25 15:12:40 +02:00
invario
2b58f74cc8
Fix: Remove X-XSS-Protection use, check and recommendation
...
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-06-13 16:12:27 -04:00
Andrey Borysenko
7994332338
feat: add support for sensitive Declarative settings values encryption
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2025-05-28 20:43:04 +03:00
rakekniven
4261c9d4fa
chore(18n): More natural english - fix plural typo
...
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-05-25 12:56:15 +02:00
Joas Schilling
e064af3149
fix(l10n): Fix one more plural
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-23 09:56:15 +02:00
Marcel Klehr
1afc1805c4
fix: Correct translation method use
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-05-23 09:38:30 +02:00
rakekniven
8be6518e0c
fix(SetupChecks): Update TaskProcessingPickupSpeed
...
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-05-23 09:38:09 +02:00
rakekniven
cca0a757fe
chore(18n): More natural english
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-05-23 09:36:58 +02:00
Marcel Klehr
f8f26952d1
feat(SetupChecks): Add check for TaskProcessing pickup speed
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-05-22 12:50:00 +02:00
provokateurin
82fb8f8508
refactor: Extend rector to core/
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 00:16:54 +02:00
provokateurin
78a175fc74
refactor: Apply rector refactorings
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-14 15:29:02 +02:00
Ferdinand Thiessen
1ae3fa4003
chore: replace leagcy OC_Helper calls with OCP\Util
...
- Replace legacy calls with OCP\Util
- Add missing deprecation notices
- Inline implementation in OCP\Util and call it from OC_Helper
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 10:18:04 +02:00
Ferdinand Thiessen
1ba88da113
chore: compile assets
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 11:38:42 +02:00
Ferdinand Thiessen
6d8c49f0d4
fix(settings): group admins only can add users to their groups
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 11:35:40 +02:00
Ferdinand Thiessen
8cc0c266d5
feat(settings): provide user groups for accounts list
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 11:35:40 +02:00
provokateurin
eb98e99530
fix(settings): Handle email change restriction separately from display name change restriction
...
Co-authored-by: provokateurin <kate@provokateurin.de>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 19:06:25 +02:00
rakekniven
e43a8b473c
chore(i18n): Aligned grammar
...
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-03-31 16:58:07 +02:00
Christopher Ng
2bd1d16157
perf(settings): Remove computation of all groups
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-03-28 14:12:52 -07:00
Ferdinand Thiessen
a243e9cfbb
fix(webauthn): do not require bcmath or gmp - not needed anymore
...
The extensions are not required anymore but only recommended for
performance. See also:
https://github.com/web-auth/webauthn-framework/issues/213
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 11:19:49 +01:00
Ferdinand Thiessen
38e8f30fb7
Merge pull request #51378 from nextcloud/fix/lookup-server-connector-v2
...
fix(lookup-server): disable when not using global scale
2025-03-11 21:17:11 +01:00
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
5e4910e10e
fix(lookup-server): do not upload data by default
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Git'Fellow
659747e5b1
fix(AppDiscover): Ensure created cache folder is safe-chars only
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-10 19:11:17 +01:00
Côme Chilliet
c59400dea1
chore: Move magic number into a documented const
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-10 11:30:18 +01:00
Côme Chilliet
0b449f302b
fix: Correctly count disabled users for SAML groups subadmins
...
If too many users return -1 as for LDAP so that link is shown
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-10 11:30:18 +01:00
skjnldsv
29405f0964
fix(systemtags): unify restrict_creation_to_admin handling
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-06 11:29:57 +01:00
Johan Bernhardsson
c39741fd65
fix: Change SQL query so that it is ansi safe
...
Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>
2025-02-27 09:00:06 +01:00
Joas Schilling
095ab4419e
fix(l10n): Improve english source strings
...
- No leading/trailing whitespace
- Use asci single quote
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 09:54:32 +01:00
Ferdinand Thiessen
f91db181af
feat(setupcheck): check logging level for validity
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-22 14:08:19 +01:00
Ferdinand Thiessen
082e85f6da
Merge pull request #50779 from nextcloud/chore/mailer-tests
...
test(Mailer): Align tests for mailer with stable30
2025-02-18 17:52:12 +01:00
Côme Chilliet
17fffdbbcb
fix(settings): Inject subadmin manager and adapt tests, resolve a FIXME comment
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 12:48:12 +01:00
Côme Chilliet
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:46:42 +01:00
Côme Chilliet
ed5b7ae161
chore: re-apply current rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:45:33 +01:00
Côme Chilliet
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +01:00
Josh
84293441e8
test(Mailer): Align tests for mailer with stable30
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-12 13:29:58 +01:00
Git'Fellow
a509494107
fix(emailTemplate): use instance Name instead of Url in subject
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-12 11:52:22 +01:00
Joas Schilling
0a6eeb497b
fix(setupcheck): Update setup check for PHP version to be more accurate
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-10 11:50:09 +01:00
Ferdinand Thiessen
2a0f81da53
fix(provisioning_api): Correct limit for editUser
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +01:00
Andy Scherzinger
4a7c0b3267
Merge pull request #50281 from nextcloud/fix/fix-email-setupcheck-with-null-smtpmode
...
fix(settings): Fix setup check when mail_smptmode is set to "null"
2025-01-30 09:33:24 +01:00
Andy Scherzinger
4145dedba0
Merge pull request #50425 from nextcloud/fix/openapi/outdated-specs
...
Fix outdated OpenAPI specs
2025-01-26 22:08:35 +01:00
Josh
8a7b1617d0
fix(settings): Add some context to the PHP memory limit error
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-26 17:54:19 +01:00
Josh
b452dc0697
fix(SetupChecks): Pass webfinger if a handler is there
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-26 13:03:05 +01:00
provokateurin
e473a26676
fix(settings): Add back adminstration scope for LogSettingsController
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-25 17:16:39 +01:00
Joas Schilling
3302f1461f
fix(security): Update .well-known/security.txt expiration date
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-23 08:42:30 +01:00
nfebe
f7c46b6809
feat(systemtags): toggle for system tag creation in admin settings
...
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-22 20:07:25 +01:00
Côme Chilliet
b8de5e0d09
fix(settings): Fix setup check when mail_smptmode is set to "null"
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-20 17:12:19 +01:00
Christopher Ng
1a43fc5718
feat(sharing): Toggle custom tokens setting as admin
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Git'Fellow
cd147cd1a3
fix(setupchecks): Binary data can have problems with serialize
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-09 23:42:07 +01:00
Josh
1304590d6c
Merge pull request #49977 from nextcloud/jtr-perf-checks-connectivity-https-proto
...
perf(settings): Speed up InternetConnectivity setup check
2025-01-09 12:09:33 -05:00
Kate
e7122a6864
Merge pull request #49882 from nextcloud/fix/http/template-valid-status-codes
2025-01-08 11:10:57 +01:00
Josh
35cb5d84ca
perf(settings): Speed up InternetConnectivity setup check
...
Specify default protocol (https://) rather than let default handling test both http:// and https://
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-07 16:49:28 -05:00
John Molakvoæ
cd236c7941
Merge pull request #49891 from nextcloud/refactor/settings/mail-settings-parameters
2025-01-07 16:59:02 +01:00
provokateurin
960168fd96
fix(settings): Fix log file download return type
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-07 15:44:48 +01:00
Joas Schilling
17e8948360
Merge pull request #49988 from nextcloud/jtr-locale-personal-info
...
fix(settings): show the correct initial locale in Personal info
2025-01-07 15:42:43 +01:00
provokateurin
f52aa9ad32
refactor(provisioning_api): Rename AUserData to AUserDataOCSController to allow openapi-extractor to detect it as OCS
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 14:30:40 +01:00
provokateurin
98275fb806
refactor(settings): Use parameters explicitly when setting mail settings
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 08:40:52 +01:00
Josh
5e27d1415a
fix(settings): show the correct initial locale in Personal info
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-12-29 12:33:29 -05:00
Jana Peper
ee31b3bbe5
fix: error handling for wrong json values
...
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +01:00
Jana Peper
d87302c651
feat: add error flags for json_decode
...
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +01:00
Jana Peper
8cac92665d
feat: filter disabled apps in task types requests
...
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +01:00
Jana Peper
32b57e7b41
feat: save state in db
...
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +01:00
Joas Schilling
1cbfe55271
fix(setupcheck): Disable PhpMaxFileSize setupcheck for now
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-04 08:35:20 +01:00
Joas Schilling
1bcc381e28
fix(setupcheck): Make the Memcache setupcheck use the cache
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-02 09:18:07 +01:00
Joas Schilling
d1e17e78b7
fix(activity): Fix activity object type warnings
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-27 10:54:15 +01:00
skjnldsv
52020b5ea6
fix(settings): psalm PhpMaxFileSize setup check warning
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 18:27:35 +00:00
skjnldsv
4a88848109
feat(settings): add big file upload setup checks
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 16:43:41 +01:00
Ferdinand Thiessen
9e327a5890
fix(apps-store): Remove apps from force-enabled state when uninstalled
...
If an app is force-enabled and then uninstalled the force-enabled state was kept.
This is now removed, so when the app should be re-installed the compatibility should be reevaluated.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-18 14:09:54 +01:00
rakekniven
49c7f7dd1c
chore(i18n): Fixed grammar
...
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-11-14 12:59:14 +01:00
Daniel
22e2419b28
Merge pull request #48134 from nextcloud/feat/mail-provider-settings
...
feat: mail provider settings
2024-11-13 14:31:21 +01:00
Ferdinand Thiessen
a3e80e4195
feat: Update supported PostgreSQL versions
...
12 is now EOL but 17 was released and should be supported and tested.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-13 02:50:13 +01:00
SebastianKrupinski
3e870695bc
feat: mail provider settings
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-11-12 13:19:35 -05:00
Benjamin Gaussorgues
46abfc6d50
Merge pull request #48792 from nextcloud/chore/update_mysql_setup_check_i18n
2024-11-05 10:06:29 +01:00
rakekniven
25d1628e30
chore(i18n): Fix grammar
...
Reported at Transifex
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-11-03 16:34:57 +01:00
Benjamin Gaussorgues
a40f21b4db
chore(setupchecks): update translation for MySQL row format check
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 09:56:02 +01:00
Benjamin Gaussorgues
34ade098bd
fix(users): use correct active user count
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +01:00
Andrey Borysenko
a12b4da6af
fix(ci): psalm, suppress undefined for viewApps
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:08 +02:00
Andrey Borysenko
e4d586697c
WIP: address review comments, small fixes
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:08 +02:00
Andrey Borysenko
3a840c102a
fix(ci): suppress UndefinedClass for AppAPI related classes since it's bundled
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:07 +02:00
Andrey Borysenko
95b06309f3
feat(app_api): add initial state data for AppAPI UI part
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
# Conflicts:
# apps/settings/lib/Controller/AppSettingsController.php
# Conflicts:
# apps/settings/lib/Controller/AppSettingsController.php
2024-10-29 20:54:05 +02:00
Kate
e8dbf022c9
Merge pull request #48919 from nextcloud/fix/settings/userid-dependency-injection
2024-10-28 11:44:16 +01:00
Claudio Cambra
5969b4bea8
fix(appsmanagement): Fix exception on generating preview url for screenshots
...
Some installed apps meant for older server versions might unexpectedly
offer up screenshot values in a non-string format (e.g. health). Avoid
an exception by checking first if the first app screenshot is indeed a
string and otherwise we take the value of the parameter
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-10-28 08:29:16 +01:00