upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-19 13:39:40 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54
83872 commits 982 branches 1224 tags 9.6 GiB
Commit graph

1338 commits

Author SHA1 Message Date
provokateurin
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-05 09:58:11 +01:00
Maxence Lange
8360c57189 fix(files-external): set password as sensitive 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-10-31 09:41:20 -01:00
yemkareems
3b6a36fae6
fix: add PasswordConfirmationRequired to saveGlobalCredentials 
Co-authored-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-30 10:54:49 +01:00
John Molakvoæ
ed14f5fee2
Merge pull request #48788 from nextcloud/fix/788/add-password-required-to-external-storages 2024-10-29 11:33:47 +01:00
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 13:24:18 +02:00
provokateurin
e8426996f5
fix(psalm): Fix some newly detected issues 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
yemkareems
08f3e44d4a
fix: cs fix namespace 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-18 14:34:39 +05:30
yemkareems
18c0c28bce
fix: add PasswordConfirmationRequired to the eternal storages mentioned in review 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-18 14:04:34 +05:30
Git'Fellow
c254855222 chore(db): Correctly apply query types 
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
 2024-10-17 09:21:07 +02:00
yemkareems
b86dc076b5
fix: add PasswordConfirmationRequired to update and delete method 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-16 16:49:13 +02:00
yemkareems
d3f1b76ebb
fix: add PasswordConfirmationRequired to create user storages endpoint 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-16 16:49:06 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
Kate
614d8c23a0
Merge pull request #48494 from nextcloud/refactor/storage/strong-param-types 2024-10-08 15:20:17 +02:00
provokateurin
54ec472d9a
fix(BackgroundJobs): Adjust intervals and time sensitivities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-08 11:26:53 +02:00
provokateurin
14e6734547
refactor(files_external): Add Storage parameter strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:07 +02:00
Joas Schilling
4219969c96
fix: Ensure we only pass string to writeln() 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-07 12:11:38 +02:00
Joas Schilling
c109ae9437
ci: Fix psalm by typing the QuestionHelper 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-07 12:11:27 +02:00
Robin Appelman
103b464eea fix: use nc's binary finding logic for smb 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-04 15:56:31 +02:00
Joas Schilling
96f77d7b99
fix(filesexternal): Remove unneeded 3rdparty library use 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-02 23:27:44 +02:00
Côme Chilliet
6ef05bafeb
fix: Fix test of IConstructableStorage implentation by storage classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-30 11:21:42 +02:00
provokateurin
1302b48ca2
fix(files_external): Fix all IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:48 +02:00
Louis
c45ed55f95
Merge pull request #48359 from nextcloud/artonge/feat/compare_hashed_password_when_updating_global_cred_in_files_external 
fix: Use placeholder for external storage password
 2024-09-26 14:56:37 +02:00
Marcel Klehr
c8a90e941a fix(files_external): Catch correct exception 
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-26 09:03:08 +02:00
Louis Chemineau
20eb464835
fix: Use hashed password in files_external settings 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-25 17:50:17 +02:00
Côme Chilliet
40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface 
fix: Move storage constructor to specific interface
 2024-09-23 15:57:38 +02:00
Côme Chilliet
94b0a0e863 fix: Move storage constructor to specific interface 
That allows Wrappers to use DI and not care about the constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-23 09:46:44 +02:00
Côme Chilliet
1a4978c4ea
chore: Apply rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-20 17:51:00 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Côme Chilliet
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:10:48 +02:00
Christoph Wurst
614f9ec0a2
refactor: Use the elvis operator 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 21:01:34 +02:00
Git'Fellow
07a6fd11d0
fix(files_external): Check key exists before accessing it 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-09-14 11:21:17 +02:00
John Molakvoæ (skjnldsv)
0f519f4856 fix(files_external): broken credentials dialog 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2024-09-13 14:32:07 +00:00
Josh
2480567005
Merge pull request #47526 from nextcloud/jtr/fix-ftp-custom-port-ui 
fix(files_external): Handling in FTP UI for custom ports
 2024-09-12 09:34:47 -04:00
Josh
56c744d263
Merge pull request #47527 from nextcloud/fix-sftp-custom-port-ui 
fix(files_external): Handling in SFTP UI for custom ports
 2024-09-12 09:34:32 -04:00
Daniel Calviño Sánchez
bd4de5208d fix: Fix unmodified placeholder replacing the actual value when updating 
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-09-04 09:46:17 +02:00
Josh Richards
2e73932c8e fix: custom port handling in UI for SFTP 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-08-27 09:01:12 -04:00
Josh
6db4099246
fix: custom port handling in UI for FTP External Storage 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-08-27 08:49:24 -04:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
John Molakvoæ
d35c4eb911
Merge branch 'master' into jr-readdir-false-false 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-08-16 10:53:50 +02:00
provokateurin
c102b89cd5
refactor(files_external): Replace security annotations with respective attributes 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-08-14 09:44:57 +02:00
Robin Appelman
c2b1f079b1
feat: add a specialized writeStream implementation for s3 external storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-24 17:37:20 +02:00
Benjamin Gaussorgues
369c552e41
Merge pull request #46073 from nextcloud/fix/save_global_credentials 2024-06-25 09:48:24 +02:00
Benjamin Gaussorgues
e93866f904
fix: allows admin to edit global credentials 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-06-24 15:20:44 +02:00
Daniel Calviño Sánchez
733e3f62fd fix: Do not log an error when connecting to SFTP without a logged in user 
When connecting to a SFTP server from a SFTP storage the host key is
checked against the known host keys stored in a file in the data
directory of the logged in Nextcloud user. The path to the file is
(indirectly) got using "OC_App::getStorage", which logs an error if
called when there is no logged in user; this can happen, for example, if
the storage is used from a background job or a command.

Not being able to read or write the file just causes the host key check
to be skipped, but it has no other consequence. Moreover, even with
logged in users it is likely that the file can not be read either and
the check is also skipped, as the file needs to have been manually
created by an admin.

Due to all that now the path to the file is directly created using a
View rather than relying on "OC_App::getStorage" to prevent the unneeded
error from being logged.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-06-18 07:06:30 +02:00
Andy Scherzinger
c1555fc33e
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-06 18:05:37 +02:00
Côme Chilliet
4d060818d1
fix(files_external): Be extra safe with null handling to please psalm 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-30 09:24:00 +02:00
Côme Chilliet
3ad4bbb096
Merge pull request #44658 from nextcloud/fix/migrate-away-from-resource-type 
fix: Remove obsolete resource typing
 2024-04-16 17:13:07 +02:00
Julius Härtl
4910e7e231
fix: Pass the mountpoint target user to storages without owner 
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.

In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-04-09 09:04:24 +01:00
Côme Chilliet
72a0da6d4e fix: Fix small psalm errors in FTP and LDAP connections 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 10:01:47 +02:00
Côme Chilliet
0f348516d2 fix: Remove obsolete resource typing 
In PHP>=8.1, LDAP and FTP resources are always typed objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 10:01:47 +02:00
Côme Chilliet
81319e78bf chore: Improve phpdoc typing to silence psalm errors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Julius Härtl
e330efe5a0
fix: Implement option to temporarily set the user session 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-03-19 13:48:23 +01:00
Robin Appelman
42e14cc4c7 feat: add command to scan external storages directly 
the main use case of this over simply scanning through is the ability to provide a username and/or password for cases where login credentials are used

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-06 19:11:08 +01:00
Julius Härtl
d576b8eaf9 fix: Allow to disable multipart copy on external s3 storage 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-02-24 17:11:07 +01:00
Maxence Lange
2f41b9c092 mark MOUNT_TYPE_PERSONAl as deprecated 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-02-24 11:33:44 +01:00
Maxence Lange
1a5b545fe8 full uppercase const 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-02-24 11:33:44 +01:00
John Molakvoæ
524ed97d62
fix: replace Account name by Login 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2024-02-13 21:08:10 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person 
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2024-02-13 21:06:30 +01:00
Arthur Schiwon
35d0c63abc
Merge pull request #43349 from nextcloud/fix/case-sensitive-root-smb 
SMB: allow to list root directory when using case-insensitive option
 2024-02-12 11:14:07 +01:00
Josh
2e00184eb4
fix(files_external) Add sensitive S3 values redacted by list command 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-02-07 10:05:46 -05:00
Benjamin Gaussorgues
2cb0bf5437
fix(files_external): list root when using SMB case-insensitive option 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-02-05 11:24:12 +01:00
Côme Chilliet
b2e9e0fa0d chore: Replace OC::$server->getL10N by OCP\Util::getL10N in lib and some apps 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-02-05 11:16:04 +01:00
Côme Chilliet
8bcc2d352e chore: Fix missing template parameter for IEventListener 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-30 10:57:15 +01:00
provokateurin
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-01-18 16:14:17 +01:00
Valdnet
9064171b27 Correct a typo 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2023-11-28 15:48:58 +01:00
Joas Schilling
64f5faf8b5
fix(files_external): Fix "Could not find resource main.js to load" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-11-27 12:35:41 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
jld3103
755de1e0b5 refactor: Rename OpenAPI type aliases to their namespaces 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-11-02 11:37:15 +01:00
Benjamin Gaussorgues
c52d5e418a
Merge pull request #41053 from nextcloud/bug/smb/in-place-case-rename 
fix(files_external): on case insensitive system, block case change
 2023-10-31 16:07:29 +01:00
Joas Schilling
4759e7a22d
fix(external): Get storage before update it 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-10-26 06:46:05 +02:00
Louis Chemineau
e66e8bad1a
Return correct status if touch failed 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-10-23 15:26:43 +02:00
Benjamin Gaussorgues
a45e12abc8
fix(files_external): on case insensitive system, block case change 
When a file/directory is renamed to the same name with only case change,
the rename fail. We block this kind of rename.
The user will have to rename to another name first.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-10-23 10:32:28 +02:00
John Molakvoæ
ae29608e46
fix(files_external): basic auth user storage trigger 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-10-10 12:07:48 +02:00
Louis
45cac16432
Merge pull request #39131 from fsamapoor/refactor_lib_files_external_commands 
Refactors files_external app commands
 2023-09-28 14:39:49 +02:00
Hamid Dehnavi
d64bbc8bd3 Convert isset ternary to null coalescing operator 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
 2023-09-28 12:18:41 +03:30
Faraz Samapoor
eab7818f0e Adds parameter type hints. 
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-09-28 09:02:10 +03:30
Faraz Samapoor
32838d8f0a Refactors files_external app commands. 
To improve code readability.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-09-28 09:02:10 +03:30
jld3103
c2d45cb172
Add single status code descriptions for OpenAPI 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-09-27 08:05:21 +02:00
Robin Appelman
b11ca34bbd
Merge pull request #40499 from nextcloud/known-mtime-wrapper 
add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is
 2023-09-21 18:33:15 +02:00
John Molakvoæ (skjnldsv)
a5a8655beb fix: avoid side-effect imports 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2023-09-21 12:40:42 +02:00
Robin Appelman
eab8dd3ca0 use multipart copy for s3 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-20 17:28:48 +02:00
Robin Appelman
ccf8843d9f apply known mtime wrapper for external storages 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-19 13:58:35 +02:00
Robin Appelman
cf7344082d
Merge pull request #40183 from nextcloud/sftp-fixes 
SFTP improvements
 2023-09-18 19:14:27 +02:00
Robin Appelman
d42d809170 sftp psalm fixes 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-18 16:12:03 +02:00
John Molakvoæ
2018c72eaa
Merge pull request #39895 from nextcloud/fix/noid/revoke-admin-overwrite 2023-09-05 14:52:09 +02:00
Robin Appelman
c264903cb9
psalm suppress 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:12 +02:00
Robin Appelman
aa2a3ae6c8
implement fseek for sftp read stream 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:11 +02:00
Robin Appelman
b41c8e0ef5
more optimized getPermissions/getMetaData 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:10 +02:00
Robin Appelman
1dfef9fccf
sftp optimize file_put_contents, writeStream and copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:10 +02:00
Robin Appelman
9cf732a90b
fix error during sftp stream close 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:09 +02:00
Robin Appelman
19daa70947
clear sftp stat cache when opening a write stream 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:07 +02:00
Maxence Lange
e55087b6b1 admin have no special rights on users' entries 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-09-01 20:14:52 +02:00
Vincent Petry
8d1a3daa3f Allow ext storage Local to go unavailable 
Whenever an external storage of type Local points at a non-existing
directory, process this as a StorageNotAvailable instead of returning
404.

This makes desktop clients ignore the folder instead of deleting it when
it becomes unavailable.

The code change was limited to external storages to avoid issues during
setup and with the default home storage.
Signed-off-by: Vincent Petry <pvince81@yahoo.fr>
 2023-08-29 11:04:31 +02:00
Robin Appelman
fb647e29b1 use fresh builders when deleting storages 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-14 18:03:20 +02:00
jld3103
a7808f0115
files_external: Fix OpenAPI 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-08-07 08:42:19 +02:00
Joas Schilling
44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup 
fix!: Final round of moving to IEventDispatcher
 2023-08-04 10:39:57 +02:00
John Molakvoæ
38480fda3c
feat(files_external): migrate to vue 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-08-01 16:38:06 +02:00
Benjamin Gaussorgues
9b03dc52a4
Migrate files external to PSR LoggerInterface 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-08-01 09:44:57 +02:00