Commit graph

911 commits

Author SHA1 Message Date
skjnldsv
1ece5b975d fix(files): undefined displayname for outdated @nextcloud/files<3.6.0 apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 18:12:34 +00:00
skjnldsv
62878c5ece fix(files): undefined sidebar
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 14:10:37 +02:00
Christopher Ng
930a5141ea fix(files): Fix navigating with breadcrumbs not highlighting navigation entry
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-03 10:34:03 -07:00
Ferdinand Thiessen
f01c8efa38 fix(files): Node loading information should be accessible
The loading icon visually informs that the node is currently loading,
but there is no non-visual information (accessible information).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 18:39:16 +02:00
Ferdinand Thiessen
75a684a8d3
chore(files): Fix remaining TypeScript errors in FileEntryPreview
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 23:08:13 +02:00
Louis Chemineau
56e4859201
feat: Use the blurhash in Files
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-29 23:08:11 +02:00
Louis Chemineau
c42f010167 fix(files): Remove margin and width to not break layout
In grid view, this was messing with the reported available list width which was breaking the computed layout.

Fix https://github.com/nextcloud/server/issues/47599

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-29 11:50:25 +00:00
Ferdinand Thiessen
aea0e8df6a fix: Adjust more places for logical position
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 08:32:48 +00:00
Mostafa Ahangarha
723780d184 feat: Add bidi support in core directory
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-08-29 08:32:47 +00:00
Ferdinand Thiessen
030c209d22 fix: Renaming does not need update but delete permissions
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +02:00
Christopher Ng
a1f43964dc test(files): Adapt favorite views spec
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-27 15:37:27 -07:00
Christopher Ng
9cc1a020a2 feat(files): Allow more than 50 favorite views
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-27 14:33:39 -07:00
Elizabeth Danzberger
79d005e11f
feat(templates): add support for checkboxes in template filler
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-08-27 14:41:58 -04:00
Ferdinand Thiessen
988ea85f48 fix(files): Correctly check for already used names when creating new folder
Also add Cypress tests for the "new"-menu.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 19:40:38 +02:00
Elizabeth Danzberger
99221f2a42 fix(files): fix list gap at bottom
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-27 08:53:57 +00:00
Ferdinand Thiessen
21b997f845
Merge pull request #47490 from nextcloud/chore/adjust-translations
chore(files): Adjust wording for file type filter
2024-08-26 21:40:27 +02:00
Ferdinand Thiessen
3ffdf56c8f
chore(files): Adjust wording for file type filter
* Resolves: https://github.com/nextcloud/server/issues/47440

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 20:42:41 +02:00
Ferdinand Thiessen
f7b7474cd3
fix(files): Reset drop notice on firefox
On firefox there is an old bug where when you move a dragged file outside
the window the `dragleave` event is never emitted.
So we just use a timeout to reset the drag over state.

Also a small change: Use the ID of the main container instead of relying on tag name and class.
(The ID is guranteed as other APIs rely on it, while the class is just used internally).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 20:31:31 +02:00
Ferdinand Thiessen
4fcf4dba02
Merge pull request #47466 from nextcloud/chore/migrate-vitest
test: Migrate from Jest to vitest
2024-08-26 20:30:26 +02:00
Ferdinand Thiessen
a5e58dc45e
test: Migrated all Jest tests to vitest
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 17:27:22 +02:00
Ferdinand Thiessen
b1eecde452
fix(files): Remove huge margin on bottom
Instead make it relative to screen size.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 16:31:25 +02:00
Christopher Ng
fc1edaf4c1 refactor(files): Consolidate node registration
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-22 16:09:10 -07:00
Christopher Ng
3b185b1156 refactor(files): Organize event subscriptions
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-22 16:09:10 -07:00
Christopher Ng
4062883459 fix(files): Respect "Show hidden files" setting in tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-22 16:09:10 -07:00
Elizabeth Danzberger
e53684e1d9
fix: use empty template by default when pressing enter
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-08-21 15:00:26 -04:00
Ferdinand Thiessen
1331ce7e7c
fix(files): Move loading icon before grid toggle
This prevents jumping of that toggle button when the view is loading.
Also adjust the design for Nextcloud 30 (prevent jumping of breadcrumbs when loading due to increased height).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 12:47:21 +02:00
Ferdinand Thiessen
132220a89f
fix: Access node owner by top level owner property
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 17:59:10 +02:00
Ferdinand Thiessen
ee4fb148b3 perf(files): Cache getContents function used for uploader
Instead of trigger a PROPFIND for every new-menu entry clicks,
or conflict handling of uploads, we can just use the cached content from the file store.
If we do not have any cache entry we fetch new, but otherwise this is not needed.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 09:47:56 +02:00
Ferdinand Thiessen
7fec706f68 refactor(files): Drop unneeded initial state
The initial state is no longer used, it was only used in legacy UI and in the f2v rewrite
it was only used for the `id` which can be loaded just from the URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 09:31:27 +02:00
Christopher Ng
0c0ba5f552 fix(files): Fix non-sticky sticky views in files nav
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-14 07:27:49 +00:00
rakekniven
b030449ad1 chore(i18n): Improved grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-14 07:18:27 +00:00
Ferdinand Thiessen
ea021df9fa
chore(deps): Update @nextcloud/auth to v2.4.0 and use getCSPNonce where possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 17:54:47 +02:00
Ferdinand Thiessen
58acf4c608 fix(files): Add messages when "new folder" fails or gets cancelled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:31:07 +02:00
Christopher Ng
a3ad8daed6 perf(files): Prevent extraneous requests when tree children are loading
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-09 15:32:17 -07:00
skjnldsv
e4e12a35f5 fix(files): trim names on new node creation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-09 11:58:37 +00:00
Konstantin Myakshin
81ee1ce8fc fix(files): Disable tags editing for shared files/folders with view only permission
Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
2024-08-09 11:42:28 +02:00
Christopher Ng
44bc57bc57 feat: Load limited depth tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 11:15:52 -07:00
Christopher Ng
cfec6fcb1a feat(files): Add getter for all view configs
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 10:52:20 -07:00
Christopher Ng
86459aa5da perf(files): Remove redundant call to get navigation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 10:52:20 -07:00
skjnldsv
827c6fdda9 fix(files): file name and header sort buttons alignments
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-07 15:12:32 +00:00
skjnldsv
40d9b42c84 fix(files): use files:config:updated to monitor user config change
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-07 10:50:33 +00:00
Ferdinand Thiessen
066bd0a25d
fix(files): openfile is set on the query not as a param
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-03 13:52:12 +02:00
skjnldsv
760c37b52e fix(files): show folder sharing overlay on received shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-02 16:52:12 +00:00
julia.kirschenheuter
ff6ba29475 fix(files): Minimize min-height of dialog form
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-02 07:10:00 +00:00
Ferdinand Thiessen
ff795ee527 fix(files): cancel move-copy action should not be handled as an error
Instead we should just show an information message why the file is not moved / copied.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-01 21:04:22 +00:00
Christopher Ng
0def7fa71c feat(files): Allow toggling folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:56 -07:00
Christopher Ng
5812a3422f fix(files): Fix root crumb not marking navigation entry as active
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:56 -07:00
Christopher Ng
3fabc4f733 feat: Navigate via folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:56 -07:00
Christopher Ng
855a45650e feat(files): Support setting view config for complex ids
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:36 -07:00
Ferdinand Thiessen
270ec122e0
fix(files): Correctly create Nodes from WebDAV result in "recent"-view
The recent search works on a different remote URL so the source of the files were wrong,
because the remote url was included twice in the source.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-01 14:17:48 +02:00
skjnldsv
57ab6e1180 fix(files): empty folder pending size
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-01 09:29:20 +00:00
Ferdinand Thiessen
1b9d6194f3 refactor(files): Resort imports and fix doc comment
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-01 07:14:04 +02:00
Ferdinand Thiessen
172c43351e
refactor(files): Migrate logger util to Typescript
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-01 03:20:56 +02:00
Ferdinand Thiessen
7ec1a7888e
fix(files): Add missing directory variable to error message
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-01 01:54:47 +02:00
Ferdinand Thiessen
a39f13e94e
fix(files): Provide file actions from list entry to make it reactive
This fixes non reactive default action text of the name component.
Also use download action as default action so that only one place
is needed to define how to download a file.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-01 01:54:42 +02:00
Ferdinand Thiessen
f570507156 fix(files): Add missing emptyView handling
The interface provides this option but it was never implemented.
This feature of being able to render a custom empty view message is needed
for public file drops to properly show the terms of service.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-31 20:07:57 +00:00
skjnldsv
e2d49f49a9 fix(files): fix template folder and file request menu order
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-31 18:44:50 +00:00
fenn-cs
efcf98d923 fix: Adjust tests for editLocallyAction
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-31 10:28:05 +01:00
fenn-cs
267ae6f97c feat(editLocallyAction): Handle possible no local client scenario
Resolves: https://github.com/nextcloud/server/issues/46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-31 10:25:26 +01:00
Ferdinand Thiessen
6bd886ef6e
fix(files): Set container for file list actions
This is needed to ensure the actions are rendered below dialogs which will have the body as the container.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-31 10:42:54 +02:00
Elizabeth Danzberger
423730963d
fix: Go back to template picker if template filler closed
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-30 15:30:36 -04:00
Elizabeth Danzberger
6c3a4a9f20
fix: Template filler shows only if template has fields
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-30 15:18:09 -04:00
Ferdinand Thiessen
77cffcb049
fix(files_sharing): Make account file filter consistent have design
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-30 16:40:14 +02:00
skjnldsv
197c35598c chore(files_sharing): refactor Share model to ts
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-30 09:50:46 +00:00
Raimund Schlüßler
6be686dc46
fix(files): correctly shrink breadcrumbs bar
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
2024-07-30 10:26:02 +02:00
withbest
dd08f93202 chore: fix some comments
Signed-off-by: withbest <seekseat@outlook.com>
2024-07-29 14:43:27 +08:00
skjnldsv
e32b335289 fix(files): always ask for confirmation if trashbin app is disabled
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-27 07:13:39 +00:00
Ferdinand Thiessen
7abaee813a fix(files): Ensure scrolled file list does not leak through file filters
1. when scrolling the file list should not be visible behind the filters
2. on mobile we need to remove the padding of the filters to ensure they are accessible

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-26 15:27:29 +02:00
Ferdinand Thiessen
dd88fa03a4 fix(files): Correctly validate new node name
* Resolves https://github.com/nextcloud/server/issues/45409

This includes two fixes:
1. The name in the "new node" dialog is correctly selected (e.g. `file.txt` only `file` is selected by default), to allow quick naming
2. `@nextcloud/files` functions for filename validation are used, this allows to use new Nextcloud 30 capabilities (e.g. reserved names)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-26 08:46:23 +00:00
Ferdinand Thiessen
2c0e2cc09e
test: Add cypress tests for file list filtering
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 19:33:28 +02:00
Ferdinand Thiessen
aad09764cd
refactor: Make route parameters accessible using composables to reuse
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 19:33:28 +02:00
Ferdinand Thiessen
842c21f96b
feat(files): Implement files list filters for name, modified time and type
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 19:33:23 +02:00
Ferdinand Thiessen
968d41241b
feat(files): Allow to add file list filters
This adds sticky file list filters above the file list.
Those filters are used to filter the directory content and thus filter the file list.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 19:15:38 +02:00
Ferdinand Thiessen
523e0d3f2b
fix(files): Use @nextcloud/files filename validation to show more details
This will enable showing more details what exactly is wrong with the filename.
Especially with the new capabilities introduced with Nextcloud 30.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 15:49:33 +02:00
Elizabeth Danzberger
b749a89a33
fix: PHP formatting
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:41 +02:00
Elizabeth Danzberger
6aea44920d
fix: Can close template filler modal
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:40 +02:00
Elizabeth Danzberger
3390fc1b94
fix: Add SPDX header to new file
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:40 +02:00
Elizabeth Danzberger
1b904f1252
feat: Add frontend components for filling out template
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:40 +02:00
Elizabeth Danzberger
a7addcb88f
fix(vue): Begin implementing template filler component
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:40 +02:00
Elizabeth Danzberger
e65f318fdf
feat: TemplateFiller component
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:38 +02:00
Elizabeth Danzberger
d3bfcec7ea
feat: Add template filler component
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:38 +02:00
Ferdinand Thiessen
80d797edf3
fix: Ensure displayname is a string
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 01:24:26 +02:00
Ferdinand Thiessen
5dc8e06014
fix(files): Do not split filename into base and extension for folders
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 01:24:26 +02:00
Ferdinand Thiessen
f95d8263f6
chore(deps): Update @nextcloud/files to v3.6.0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 01:24:26 +02:00
Maksim Sukharev
5709e54b8d fix(files): validate input when creating file/directory
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-07-24 13:14:56 +02:00
Louis Chemineau
1aeb3f328b
fix(files): Grid view virtual scrolling computations
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-24 09:38:51 +02:00
Louis Chemineau
ddad7b48eb
fix(files): Reduce preview size in grid view mode
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-24 09:38:51 +02:00
skjnldsv
08af33b5d9 chore: add file request cypress testing
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-19 12:20:25 +02:00
Ferdinand Thiessen
5cf0224461
fix(files): Typo in import of ShareType
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:20:55 +02:00
grnd-alt
3ebfe9511b fix: stop file actions when conflict dialog skipped
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
2024-07-16 09:41:42 +02:00
Ferdinand Thiessen
841efff3fb
fix(files): Close the sidebar on navigation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-15 11:34:05 +02:00
skjnldsv
df42a10e56 chore(files_sharing): lint & refactor fixes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +02:00
skjnldsv
9b84831c8d fix(files_sharing): adjust IAttributes API and files_versions
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +02:00
Louis Chemineau
5fc79e4002
fix(files): Add rounded corners back in grid view
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-11 14:35:03 +02:00
Ferdinand Thiessen
d0951b48be
chore(files): Fix ESLint issues with files and files_sharing app
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 17:25:41 +02:00
Ferdinand Thiessen
24c01695bb
test: Adjust Typescript definitions for OCP and OC
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 17:13:30 +02:00
Ferdinand Thiessen
691f570237
chore: Enable ESLint for apps and fix all errors
Nevertheless this causes a huge amount of new warnings.
Previously the shell script for directories to lint was wrong it was generating all app names to lint,
but was missing the `apps/` prefix. Causing only `core` to be linted.

Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 17:13:30 +02:00
Louis Chemineau
93cb30fc0c
fix(files): Correctly center the checkbox's background in grid view
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-08 17:34:15 +02:00
Andy Scherzinger
2c11c6ac23 style: unify copy icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-07-07 18:39:10 +02:00
Louis Chemineau
d30d7de56f feat(files): Refresh grid view layout
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-04 18:49:37 +02:00
Louis Chemineau
e8790f0b89 feat(files): Display mtime in grid view
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-04 18:48:29 +02:00
Louis Chemineau
d1b5657b7f
fix(files): Disable buttons in copy/move dialog for non writable folders
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-02 17:50:19 +02:00
Ferdinand Thiessen
362c6238fc
fix: Allow to reset unified search using the nextcloud:unified-search:reset event
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 12:13:14 +02:00
Louis Chemineau
fc359e3097
fix(files): Update favorites navigation list on folder renames
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-26 13:59:43 +02:00
John Molakvoæ
d5b286c9d2
feat(files): increase max copy-move concurrency to 5
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-06-26 08:32:02 +02:00
Ferdinand Thiessen
079d026d39
feat(files): Allow uploading directories
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-24 20:03:09 +02:00
Ferdinand Thiessen
3782142f59
refactor(files): Fix nullish operator usage and add missing code comment
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-24 12:53:53 +02:00
Ferdinand Thiessen
d4352fe2ff
fix(files): Properly handle files in failed state
When files are loaded from API the `fileid` might be set to `-1` indicating
an error on the API.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-24 12:52:11 +02:00
Ferdinand Thiessen
3ed32ffbb4
refactor: Use composable for currentView and views to make it reactive when shared with other Vue apps
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-23 16:53:27 +02:00
Ferdinand Thiessen
81ad28f910
chore(deps): Update debounce to 2.1.0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-23 16:53:10 +02:00
Ferdinand Thiessen
a83f276352
refactor(files): Update @nextcloud/files to v3.5.0
* Removed now duplicated code

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-23 16:53:09 +02:00
Louis Chemineau
8e0be0a238 fix(files): Don't react to clicks when renaming
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-20 16:19:01 +02:00
Ferdinand Thiessen
1d0a65db93
fix: Do not import from axios but only @nextcloud/axios
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-20 12:34:37 +02:00
Louis Chemineau
ae0106ef9e
fix(files): Show non writable folders during move or copy
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-19 17:39:57 +02:00
Louis Chemineau
f7c9ac8b54
fix(files): Rename openFileInfo to fileInfo
And check if openFile is set in the URL before opening a file.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-19 15:38:13 +02:00
fenn-cs
08323ee834 fix(deleteAction): Bump up delete requests concurrency to 5
A concurrency of who is not efficient. Low throughput, underutilization, high latency etc...

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-17 07:17:06 +01:00
Louis Chemineau
938eabd619
fix(files): Ignore right click for default action
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-13 16:16:08 +02:00
skjnldsv
343b690d80 fix(files): fetch nodes if we have multiple of the same fileid in the store
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 17:57:14 +02:00
skjnldsv
1d7893dca8 fix(files): do not rely on unique fileid
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 17:15:51 +02:00
John Molakvoæ (skjnldsv)
a094ac0b6d fix(files): also trigger new tab on file name middle click
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-06-12 11:52:22 +00:00
skjnldsv
a0a36563b6 fix(files_sharing): fix parsing of remote shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 10:27:29 +02:00
Ferdinand Thiessen
7f3cc7502b
fix(files): Use data-cy (data attribute) instead of cy-data
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 21:34:28 +02:00
Ferdinand Thiessen
53324821be
refactor(files): Migrate personal view to @nextcloud/files functions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 15:45:22 +02:00
Ferdinand Thiessen
de2276e6d7
refactor(files): Migrate favorites view to @nextcloud/files functions and make it cancelable
Also this fixes the view being writeable

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 15:45:22 +02:00
Ferdinand Thiessen
b1444e78e2
refactor(files): Migrate recent view to @nextcloud/files functions and make it cancelable
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 15:45:22 +02:00
Ferdinand Thiessen
85e6cb4ccc
refactor(files): Migrate files service to functions from @nextcloud/files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-11 15:45:21 +02:00
Ferdinand Thiessen
75dcf901ff
fix(files): Ensure that focussed file is always scrolled right
Ensure the correct file is scrolled if the content changes,
this also sets a minimal height to the virtual scrolling area
so that the `scrollTop` can be set.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:58:45 +02:00
Ferdinand Thiessen
fbceac9fe1
fix(files): Keep query when trigger the sidebar action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:58:45 +02:00
Ferdinand Thiessen
423c93087e
fix(files): open-in-files action should also set openfile query
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:58:45 +02:00
Ferdinand Thiessen
13d9a1007b
refactor(files): Fix TypeScript issues in FileEntryActions
* We filter the array in `enabledSubmenuActions` so we can be sure the action does have a parent
* Node attributes must be accessed using the `attributes` getter not the private `_attributes` property
* Cast action ref to correct component interface to make TypeScript happy

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:58:45 +02:00
Ferdinand Thiessen
a6e0f083fb fix(files): Correctly type virtual files list ref type
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-06-07 18:11:03 +00:00
Andy Scherzinger
c1555fc33e
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-06 18:05:37 +02:00
John Molakvoæ (skjnldsv)
af5a29e568 fix(files): reset menu pos when opening in grid mode
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-06-04 13:48:03 +00:00
Ferdinand Thiessen
d33cfdd14b fix(files): Only execute default action if there is an action to perform
Some files do not have a default action (can not be viewed and only downloaded).
If the `openfile` query is set on them the `handleOpenFile` will throw an error.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-04 14:41:08 +02:00
Ferdinand Thiessen
91ac7dfb7c fix(files): Update current fileid in route if that node was deleted
We do not change the view to the trash bin but stay in the current view,
so we need to update the current fileid on the route if that was deleted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-04 12:40:48 +02:00
Ferdinand Thiessen
c1fdd9031c fix(files): Close sidebar if shown node is deleted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-04 12:40:48 +02:00
Ferdinand Thiessen
ceafe43a4c
refactor(files): Make currentView a prop of FilesListTableFooter
We already have this as a required prop in `FilesListVirtual`,
so passing it to the footer is straight forward and removed need of computed
value.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 17:17:31 +02:00
Ferdinand Thiessen
e8adb97098
refactor(files): Properly add type information to FilesListTableFooter
- Add correct type for `nodes` prop.
- Use `defineComponent` to properly infer Typescript information
- Correct usage of nullish coalescing operator

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 17:17:31 +02:00
Ferdinand Thiessen
297f0522b2
refactor(files): Fix Typescript issues in filesListWidth mixin
Use `defineComponent` to properly inherit typings.
Expect TS errors for the `$resizeOberserver` as we attach it directly on the component instance.
`filesListWidth` is now a number which defaults to 0,
making compares like `this.fileListWidth < 768` valid in Typescript.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 17:17:31 +02:00
Ferdinand Thiessen
0cb32880ee
refactor(files): Correctly cast table ref to fix TypeScript errors
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 17:17:31 +02:00
Ferdinand Thiessen
622bf30031
fix(deps): Update @nextcloud/event-bus to version 3.3.1
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 12:46:20 +02:00
Ferdinand Thiessen
67d8277c49
fix: Update @nextcloud/files to 3.4.0 to fix public link shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 12:46:20 +02:00
Ferdinand Thiessen
2c47f24266 refactor(files): Consistently sort imports of FileEntryMixin
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 11:39:39 +02:00
Ferdinand Thiessen
7c4dcf51c4 fix(files): Ensure entry with fileid is marked as active
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 11:39:39 +02:00
Ferdinand Thiessen
14635929e9
fix(files): Keep 'back'-button for not found directories or if user can not upload
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-29 14:47:39 +02:00
Marco
1526a6f7c2
feat(files): Show upload menu in folders' emptycontent
Signed-off-by: Marco <marcoambrosini@icloud.com>
2024-05-29 14:44:57 +02:00
Andy Scherzinger
5b7dcc1427
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-29 08:58:16 +02:00
Ferdinand Thiessen
8ce36085c7
fix(files): Adjust type import and usage for removed dependency
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-27 19:02:13 +02:00
Ferdinand Thiessen
0e7498b917
fix(files): Implement SortingService to fix sorting of files
The previously used library was parsing strings to try to detect dates,
but for filenames it makes no sense to parse them as dates.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-27 13:48:33 +02:00
skjnldsv
3ca3c65b0d feat(files): refresh preview on etag change
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-05-23 11:56:27 +00:00
Ferdinand Thiessen
dfd0fa673d fix(files): Debounce does not return a function so it should be used as computed
This also fixes hacky solution to `this` access

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-23 07:19:06 +02:00
Ferdinand Thiessen
42001984f3 fix(files): Use translation function directly instead of calling the instance method
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-23 07:19:06 +02:00
Ferdinand Thiessen
eacdc4571d fix(files): Fix typing issues with data
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-23 07:19:06 +02:00
Ferdinand Thiessen
85c93b54a4 fix(files): Fix naming issue for reserved Vue property names
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-23 07:19:06 +02:00
Ferdinand Thiessen
a8f4b25ae8
fix(files): Drop xml2js dependency and use browser native DOMParser
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-17 10:03:38 +02:00
fenn-cs
21a22a390d perf(deleteAction): Queue delete requests
When multiple files are deleted at once, all the requests bombard the server
simultaneously, causing performance issues.

This commit adds queuing that limits the concurrency of these requests to 5
at a time.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-15 11:51:07 +01:00
fenn-cs
23c71bd862 fix(deleteAction): Remove unused nc l10n import
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-15 11:51:07 +01:00
Ferdinand Thiessen
5d8133bb18 fix: Do not import styles that are already included in server bundle
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-06 15:36:28 +02:00
Ferdinand Thiessen
7dbe89f921 fix(files): Add missing properties and fix Typescript errors in FileEntryName
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-02 20:03:23 +02:00
Raphaël Jakse
c53e4a8b96 fix(files): apply the renaming when leaving the input field
Refs: #42689

Signed-off-by: Raphaël Jakse <raphael.git@jakse.fr>
2024-05-02 16:30:12 +02:00
Ferdinand Thiessen
c6f3aecef1
fix(files): Use string array instead of string for forbidden characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-29 17:15:00 +02:00
Pytal
8fb6d15142
Merge pull request #44805 from nextcloud/fix/selected-files-count
fix(files): Display selected files count
2024-04-17 16:23:06 -07:00
Ferdinand Thiessen
6c9ca8b025
fix(comments): Fix issues thrown by comments sidebar tab code
When the comments tab is used instead of the merged activity+comments, then some issues are throws due to prop altering and duplicated names (resourceId as prop and data).

This is fixed as well as some other vue related errors in the sidebar

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-17 20:09:14 +02:00
Christopher Ng
a999544ff2 fix(files): Display selected files count
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-17 10:32:03 -07:00
Ferdinand Thiessen
16eebd3743
fix(files): Ensure search query is cleared when changing view or directory
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-17 14:06:29 +02:00
Ferdinand Thiessen
e545eee210
fix(files): Do not show files from hidden folders in "Recent"-view if hidden files are disabled by user
Needed to adjust the store creation to be able to inject pinia before the vue app is initialized.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-16 23:52:09 +02:00
Ferdinand Thiessen
dec0d91468
fix(files): Focus filename input in new-node dialog when opened
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-16 12:55:50 +02:00
Pytal
90281375a3
Merge pull request #44806 from nextcloud/chore/widget-primary-color
chore(files): Switch widget to primary color
2024-04-16 03:19:13 -07:00
Ferdinand Thiessen
bbe3f4a880
fix(files): Inherit some node attributes when creating new nodes to preserve shared state
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-16 11:24:57 +02:00
Ferdinand Thiessen
c821f28014
fix(files): Sanitize share-types attribute in download action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-16 11:24:57 +02:00
Christopher Ng
ccede9b2ad chore: Switch widget to primary color
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-15 10:58:51 -07:00
Eduardo Morales
0213fb6b5d
fix(Cypress): Adjust tests for new breadcrumbs
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-04-10 01:17:53 +02:00
Ferdinand Thiessen
f6b1fd41c9
fix(files): Hide full view name on small mobile to prevent overflow
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-04-10 01:17:53 +02:00
Eduardo Morales
de47a9ef11
fix(breadcrumbs): Improved breadcrumb progress bar mobile rendering
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-04-10 01:17:53 +02:00
Louis Chemineau
c4534e8963
fix(files): Call davGetFavoritesReport after the registration of propfind properties
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-04-08 13:38:15 +02:00
skjnldsv
1a3ad804bb fix(files): breadcrumbs native drop event
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-04-04 13:33:10 +02:00
skjnldsv
38c7ca0d4d chore: add drag and drop recursion and FilesystemAPI testing
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-04-04 13:33:10 +02:00
skjnldsv
15bf34dac8 feat(files): unify drag and drop methods
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-04-04 13:33:10 +02:00
skjnldsv
f28157e91b fix(files): breadcrumbs dnd
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-04-04 11:18:53 +02:00
Christopher Ng
6ed1b98264 fix(files): Fix error with numeric filenames
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-28 11:22:58 -07:00
Joas Schilling
1dd6f25032
fix(files): Fix translation of "Delete file"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-28 09:56:39 +01:00
Eduardo Morales
7726b15561 fix(personal-files): correctly filters groupfolders now
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-03-26 10:10:45 -05:00
Ferdinand Thiessen
fef9fb3bc0
fix(tests): Add mock for window._oc_webroot
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-23 20:48:13 +01:00
Ferdinand Thiessen
b0b2811211
fix(files): When copying nodes only add the copy suffix for file before file extension
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-22 19:13:48 +01:00
Ferdinand Thiessen
b9caf24228
fix(files): Do not escape file names for filepicker buttons
The text is already escaped by Vue, so we should not escape or sanitize the filename.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-22 14:20:17 +01:00
Christopher Ng
66e77d41c8 feat: Add iconSvgInline to TemplateFileCreator
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-20 15:50:52 -07:00
Ferdinand Thiessen
3f3955e04b
fix(files): Adjust files drop to work with Blink engine (chrom(ium), edge)
The datatransfer items list is cleared on Blink after the first access to an inner prop due to async handling and GC.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-18 13:05:08 +01:00
Maksim Sukharev
0af93c8f79 fix(files): provide onDestroy callback for interactive widgets
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-03-16 06:18:44 +00:00
Eduardo Morales
ae00ed064f fix(files): fixed breadcrumbs dissapearing on narrow screens
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-03-15 08:37:35 -05:00
Christopher Ng
335cdf04a3 fix: Ensure correct stacking context for right click menu
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-14 16:21:50 -07:00
Louis Chemineau
01fe326df1
test(files): Add e2e tests for live photo sync
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-03-14 11:07:20 +01:00
Christopher Ng
742e5b6329 fix(files): Right click menu positioning
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-12 14:59:46 -07:00
Christopher Ng
26bbb8c0e4 fix(files): Right click menu scroll reset glitch
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-12 12:10:55 -07:00
Julius Härtl
bcfaceb83c
fix: Open viewer on simple file widget
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-11 16:47:08 +01:00
Christopher Ng
810bb64028 fix(files): Close submenu actions after click like top-level actions
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-08 03:46:55 -08:00
John Molakvoæ (skjnldsv)
e453b700b9 fix(files): properly reset preview component
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-03-07 21:47:50 +00:00
fenn-cs
035a2c7062 feat(files): add search plugin to search in specified folder exclusively
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-03-07 21:10:54 +01:00
Julius Härtl
bebf1e1860
fix: Positioning and active state of viewer components
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-07 11:10:08 +01:00
John Molakvoæ (skjnldsv)
3f8a66f25d
feat(files): add Folder Preview ressource handler
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-03-07 11:06:37 +01:00
John Molakvoæ (skjnldsv)
bfa65cf0cb
feat(files): add Viewer Files ressource handler
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-03-07 11:06:36 +01:00
Ferdinand Thiessen
4b8868a7f1
feat(theming): Provide CSS variable for favorite color and adjust for dark mode
Co-authored-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-06 22:28:16 +01:00
Eduardo Morales
b3ec461fe8
feat: reconfigured NcActions to use MDI's
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-03-06 18:41:07 +01:00
John Molakvoæ
e072035e86
Merge pull request #43941 from nextcloud/fix/files-open-text
fix(files): Open new file when created from template
2024-03-05 18:21:57 +01:00
John Molakvoæ
d65e46f313
Merge pull request #43988 from nextcloud/fix/files-favorite
fix(files): Adjust sidebar - remove deprecated function calls and add aria label for favorite icon
2024-03-05 11:51:49 +01:00
Eduardo Morales
e0e51aed5d fix: fixed breadcrumbs not showing due to viewport width
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-03-04 19:13:20 -06:00
Ferdinand Thiessen
b8272cccc4
fix(files): Open new file when created from template
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-05 00:55:27 +01:00
Ferdinand Thiessen
5995606931
fix(files): Remove deprecated function calls from sidebar and add aria-label to favorite icon
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-05 00:38:39 +01:00
fenn-cs
29c37af40c feat(files): restore unified search filtering in files view
The unified search emits, search events that other apps can subscribe to and
 react however they want to search queries, following
 4b55594f55 and prior updates to migrate the Files
app ui to vue.js that feature was broken.

This commit reintroduces the feature using the current `FileList` implementation.

This commit also adds some logging to an empty exception handler.

Resolve : https://github.com/nextcloud/server/issues/43365

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-02-29 19:54:55 +01:00
Eduardo Morales
25eebd31ed fix: changed text alignment and icon logic
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-29 07:01:19 -06:00
Varun Patil
b03fd6e363 fix(dav): multiple fixes in usage of webdav library
1. Refresh token on update
2. Fix some very weird imports
3. Patch fetch instead of request to prevent accessing impl details

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2024-02-28 19:23:47 +01:00
rakekniven
e9daa1cbba
fix(i18n): Corrected grammar
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-02-27 17:05:09 +01:00
Ty Davis
f858a2c3f7 fix: Display "+New" while files page loads instead of "+Add".
Signed-off-by: Ty Davis <noreply@mail.theTyster.dev>
2024-02-26 12:17:37 -08:00
Andrii Rublov
1c316c29f1 Update apps/files/src/components/BreadCrumbs.vue
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Andrii Rublov <39839367+arublov@users.noreply.github.com>
2024-02-25 13:40:13 +01:00
Andrii Rublov
c8b68ce639 feature: [F2V] Hide breadcrumbs when an upload is ongoing on narrow screen #40942
Signed-off-by: Andrii Rublov <airublev@outlook.com>
2024-02-25 13:40:13 +01:00
Eduardo Morales
f168187dc9 feat: files update correctly on destination/current folder
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-23 20:08:58 -06:00
Eduardo Morales
67b0c7ce14 fix: conflict picker moves files correctly to its directory
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-23 20:08:58 -06:00
Eduardo Morales
7e7b086c4e fix: merge conflict dialog added when overwriting files on move-file action
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-23 20:08:58 -06:00
Grigorii K. Shartsev
f12d36b226 fix(files): page h1 heading
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-02-23 14:48:41 +01:00
skjnldsv
571e06a35c chore(files): replace encodeFilePath by encodePath from @nextcloud/paths
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-02-22 23:26:22 +01:00
Josh
aff8b5620c fix(files): Dont't warn re: full storage on either zero or unlimited quotas
Fixes #43535
Fixes #43280

Replaces #43544

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-02-19 22:59:20 +00:00
Eduardo Morales
19619f53c6 enh: breadcrumb icon matches nav view icon
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-16 09:10:34 -06:00
Eduardo Morales
bbf279f546 enh: breadcrumbs icons are now more visually descriptive
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-16 08:33:03 -06:00
John Molakvoæ
0fa226ee7c fix(tests): favorites view order
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-02-15 09:03:11 +01:00
Eduardo Morales
69e866c15d fix: condensed filtering logic
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-15 09:03:11 +01:00
Eduardo Morales
93aebee4f9 enh: added option to render icon and text for breadcrumb
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-15 09:03:11 +01:00
Eduardo Morales
8df8522cce feat: changed filtering logic
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-15 09:03:11 +01:00
Eduardo Morales
de954148be feat: added filtering to filter out files that are shared
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-15 09:03:11 +01:00
Eduardo Morales
7dd4ff5827 feature: personal views
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-02-15 09:03:11 +01:00
Ferdinand Thiessen
b758e0496e
fix: Correctly import types in Typescript files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-13 18:04:45 +01:00
Ferdinand Thiessen
99bc452675
fix(files): Do not scroll if there is no scrolling area
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-09 01:06:42 +01:00
Ferdinand Thiessen
d7d1bb6c80
fix(files): Fix some type errors in TemplatePicker
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-09 01:06:42 +01:00
Ferdinand Thiessen
8be4704e11
enh(files): Add modal to set filename before creating new files in the fileslist
* Reactive `openfile` query

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-09 01:06:42 +01:00
Simon L
f6ed1effbf
Merge pull request #43433 from nextcloud/enh/40202/use-correct-icon
Use AccountPlusIcon in broadcrombs
2024-02-08 18:27:41 +01:00
John Molakvoæ
a4f338c7a0
Merge pull request #42444 from nextcloud/fix/41877/files--move-focus-to-sidebar-on-open 2024-02-08 18:27:34 +01:00
Louis Chemineau
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server"
This reverts commit d9d60238c7, reversing
changes made to ba3fdb0cdc.
2024-02-08 15:31:19 +01:00
Simon L
a183a23e2b
fix(files_sharing): use proper sharing AccountPlus icon in breadcrumbs
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-02-08 11:01:04 +01:00
Grigorii K. Shartsev
a0a13628eb fix(files): focus sidebar tab on tab or file change
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-02-07 23:56:08 +01:00
Grigorii K. Shartsev
eb01e74eaa fix(files): do not disable action on load to keep focus
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-02-07 23:56:08 +01:00
John Molakvoæ
12fe86573f
feat(files): ask for confirm if deleting 5 items or more
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-07 11:08:24 +01:00
John Molakvoæ
d50127f093 fix(files): setup cannot be in mixins
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-07 07:57:23 +00:00
John Molakvoæ
6e0499461d chore(files): move shared FileEntry and FileEntryGrid into a mixin
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-07 07:57:23 +00:00
John Molakvoæ
97cd038cf2 fix(files) selection store typing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-07 07:57:23 +00:00
John Molakvoæ
9e1efe0538 fix(files): drop to folder path and user feedback
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-07 07:57:23 +00:00
John Molakvoæ
6cf4fe19a0
fix(files): add mount root property and adjust delete wording
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-06 17:43:35 +01:00
John Molakvoæ
77f307bafd fix(files): dav owner and mime types
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-02-05 14:48:24 +00:00
John Molakvoæ
9c2dc4adb4 fix(files): better null relatedTarget event detection
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-02-04 20:53:46 +00:00
John Molakvoæ
441651c22a fix(files): drag leave detection on safari
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-04 20:52:06 +00:00
Grigorii K. Shartsev
455d24bcfe fix(files): do not open file by id on load for folders
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-02-02 09:54:55 +01:00
John Molakvoæ
23899de2b5
fix(files): make sure we focus the parent actions submenu entry
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-31 17:07:03 +01:00
Grigorii K. Shartsev
f01e169938 fix(files): selected files actions position on scroll/with readme block
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-01-30 20:28:14 +01:00
Jonas
6c7080b152 fix(files): Improve inaccessible files message in file reference widget
Signed-off-by: Jonas <jonas@freesources.org>
2024-01-30 11:50:33 +01:00
Ferdinand Thiessen
2cea4d7b8d
fix(files): Consistent sorting for folders before files (user configurable)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-27 14:23:47 +01:00
John Molakvoæ
1ffb13cf5d
chore(assets): Recompile assets
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-27 12:54:12 +01:00
John Molakvoæ
d06ed4d7cb
fix(files): disable Unshare until proper fix
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-27 12:49:53 +01:00
Ferdinand Thiessen
c089214a2a
chore: Update @nextcloud/dialogs to 5.1.1
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-27 01:21:00 +01:00
Ferdinand Thiessen
7b71f59bab
fix(files): Ensure the correct dir query is set on folder action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-25 15:07:52 +01:00
Ferdinand Thiessen
4023f1e582
fix(files): Make sure to add the fileid on favorite folders navigation entries
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-25 15:07:52 +01:00
Ferdinand Thiessen
2893d1b926
fix(files): Make sure $navigation is observable to react on changes
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-25 15:07:52 +01:00
Ferdinand Thiessen
a62bb3a581
fix(files): Set default view and match also child routes
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-25 15:07:52 +01:00
Ferdinand Thiessen
f92865e2a2
fix(files): Add declaration for $navigation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-25 15:07:52 +01:00
Grigorii K. Shartsev
b40279e376 fix(files): combine navigation and files list into single Vue app
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-01-25 00:25:54 +01:00
Kate
64ccc1ef87
Merge pull request #43027 from nextcloud/fix/svg-viewbox-attribute
fix: Use viewBox instead of viewbox in SVGs
2024-01-22 18:13:03 +01:00
provokateurin
958f18c37b
fix: Use viewBox instead of viewbox in SVGs
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-22 16:39:06 +01:00
John Molakvoæ
5ee989bfb4 fix(files): do not show View in folder in the Files view
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-22 12:32:44 +01:00
Ferdinand Thiessen
a289fdd2d7
fix(files): Allow to copy or move file to folder with similar name
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-20 15:41:53 +01:00
Ferdinand Thiessen
b29c0cca24
fix(files): Adjust getUniqueName for custom suffix and reuse for copy-move-action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-20 15:41:53 +01:00
Ferdinand Thiessen
eaad30c346
enh(files): Allow to copy files into same directory
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-20 15:41:53 +01:00
Eduardo Morales
81057f6191
fix(files): fixed home aria-label and desc logic
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-01-20 13:04:25 +01:00
Christopher Ng
1b0eb2bebd fix(files): Fix checkbox state semantics
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-01-20 12:23:51 +01:00
John Molakvoæ
3f77b543e3 fix(files): prevent dragging previews and appear as an external files DnD
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-17 16:23:31 +01:00
Simon L
816d5299de use showError in TransferOwnershipDialogue
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-01-16 14:06:24 +01:00
Christopher Ng
fa295625ab fix(l10n): Add context note for table footers
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-01-15 11:26:29 -08:00
John Molakvoæ
90d50323d8
fix(files): use backend error message if provided
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-12 10:10:27 +01:00
John Molakvoæ
14da405f92
fix(files): use getSummaryFor for better files summary translations
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-12 08:39:45 +01:00
Raul Ferreira
cf415bfe70 Include unsubscribe from file changed event
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Raul Ferreira <r.ferreira.fuentes@gmail.com>
2024-01-11 15:56:25 +01:00
Raul Ferreira Fuentes
a977247ae3 Update apps/files/src/views/FilesList.vue
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Raul Ferreira Fuentes <Raudius@users.noreply.github.com>
2024-01-11 15:41:39 +01:00
Raul Ferreira
ef2db702f7 Refresh FileList on current folder update
Signed-off-by: Raul Ferreira <r.ferreira.fuentes@gmail.com>
2024-01-11 15:39:26 +01:00
John Molakvoæ
365bb7ded0
chore(deps): bump @nextcloud/files to 3.1.0
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-11 11:57:49 +01:00
John Molakvoæ
9553718acf
fix(files): group duplicate shares
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-11 11:57:49 +01:00
John Molakvoæ
32071942de
fix(files): fix unshare action
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-11 11:57:48 +01:00
Eduardo Morales
8f77f70b71 fix(files): switched native input to NcButton
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-01-10 12:29:34 -06:00
Grigorii K. Shartsev
ad4923ebd6 refactor(files): remove merged to @nextcloud/vue changes
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-01-10 17:52:25 +01:00
Grigorii K. Shartsev
b1a9017f5f fix(files): move header actions out from the table
Having actions in the table header is no valid for a11y and counts as a column name.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-01-10 17:52:24 +01:00
Louis Chemineau
d6cd3a6b49 Include grid view toggle in accessibility switch
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-01-08 23:15:38 +01:00
Christopher Ng
5e7ba125f0 fix(files): Fix unresponsive file click to download
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-01-05 16:46:39 -08:00
Eduardo Morales
2554419805 fix(files): kept only first and last breadcrumb titles
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-01-05 11:09:59 -06:00
Eduardo Morales
e7129bb0f5 enh(files): made breadcrumb component lang=ts
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-01-04 10:17:55 -06:00
John Molakvoæ
dd0fb2e76b fix(files): open menu on right click position
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-03 08:35:07 +01:00
Grigorii K. Shartsev
d682aa25be fix(files): focus file name on renaming also initially
When new folder is created, new file entry is initially in renaming mode.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-01-02 17:25:14 +01:00
Julius Härtl
2c7f63276e fix(files): Allow Ctrl/Command click on file entries to open in a new tab
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-27 10:15:42 +01:00
John Molakvoæ
e407fb6563
fix(files): allow silent batch actions errors
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-12-26 08:48:07 +01:00
Eduardo Morales
6dd6b7f630 enh(breadcrumbs): removed unnecessary aria label
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2023-12-22 13:39:16 -06:00
Eduardo Morales
e1940ba368 enh(files): added ability to escape out of all selection when focused
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2023-12-21 10:38:09 -06:00
John Molakvoæ
dbfd8f612b
fix(files): drag and drop events chain and cancel
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-12-20 10:51:03 +01:00
John Molakvoæ
820b67a5e2
fix(files): recursive drop path join
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-12-20 10:51:03 +01:00
Louis Chemineau
a39b3a3d84
Add global accessibility switch
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-12-19 10:21:13 +01:00
Ferdinand Thiessen
6a67afff37
fix(files): Use DAV functions from library to fix invalid source links
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-19 09:21:00 +01:00
Joas Schilling
d256206ffe
Fix typo in move or copy dialog
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-18 15:25:44 +01:00
John Molakvoæ
1db6947fcd
Merge pull request #42281 from nextcloud/fix/files/urlencode 2023-12-15 08:41:18 +01:00
Ferdinand Thiessen
2d5d782f7f fix(files): Partly revert 32c1aeb and show correct quota again
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-14 12:56:41 -06:00