upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

Merge pull request #38524 from nextcloud/chore/app/clear-unused-cache-key

Browse source 
chore(app): Do not clear unused cache key
This commit is contained in:
Arthur Schiwon 2023-06-05 17:48:44 +02:00 committed by GitHub
commit ffa30ce89b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/private/App/AppManager.php
View file

@ -673,8 +673,6 @@ class AppManager implements IAppManager {
* Clear the cached list of apps when enabling/disabling an app
*/
public function clearAppsCache() {
$settingsMemCache = $this->memCacheFactory->createDistributed('settings');
$settingsMemCache->clear('listApps');
$this->appInfos = [];
}

10
tests/lib/App/AppManagerTest.php
View file

@ -133,14 +133,7 @@ class AppManagerTest extends TestCase {
);
}
protected function expectClearCache() {
$this->cache->expects($this->once())
->method('clear')
->with('listApps');
}
public function testEnableApp() {
$this->expectClearCache();
// making sure "files_trashbin" is disabled
if ($this->manager->isEnabledForUser('files_trashbin')) {
$this->manager->disableApp('files_trashbin');
@ -151,7 +144,6 @@ class AppManagerTest extends TestCase {
}
public function testDisableApp() {
$this->expectClearCache();
$this->eventDispatcher->expects($this->once())->method('dispatchTyped')->with(new AppDisableEvent('files_trashbin'));
$this->manager->disableApp('files_trashbin');
$this->assertEquals('no', $this->appConfig->getValue('files_trashbin', 'enabled', 'no'));
@ -180,7 +172,6 @@ class AppManagerTest extends TestCase {
->willReturn('group2');
$groups = [$group1, $group2];
$this->expectClearCache();
/** @var AppManager|MockObject $manager */
$manager = $this->getMockBuilder(AppManager::class)
@ -229,7 +220,6 @@ class AppManagerTest extends TestCase {
->willReturn('group2');
$groups = [$group1, $group2];
$this->expectClearCache();
/** @var AppManager|MockObject $manager */
$manager = $this->getMockBuilder(AppManager::class)