upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-20 00:12:30 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 38

fix: only allow pre-defined shards

Browse source 
Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2024-07-18 17:16:01 +02:00 committed by Louis Chemineau
parent ddbeb4cac9
commit fc05a67f19
No known key found for this signature in database
1 changed files with 30 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
lib/private/DB/Connection.php
View file

@ -92,6 +92,21 @@ class Connection extends PrimaryReadReplicaConnection {
protected ShardConnectionManager $shardConnectionManager;
protected AutoIncrementHandler $autoIncrementHandler;
public const SHARD_PRESETS = [
'filecache' => [
'companion_keys' => [
'file_id',
],
'companion_tables' => [
'filecache_extended',
'files_metadata',
],
'primary_key' => 'fileid',
'shard_key' => 'storage',
'table' => 'filecache',
],
];
/**
* Initializes a new instance of the Connection class.
*
@ -141,23 +156,30 @@ class Connection extends PrimaryReadReplicaConnection {
$this->_config->setSQLLogger($debugStack);
}
// todo: only allow specific, pre-defined shard configurations, the current config exists for easy testing setup
$this->shards = array_map(function (array $config) {
/** @var array<string, array{shards: array[], mapper: ?string}> $shardConfig */
$shardConfig = $this->params['sharding'] ?? [];
$shardNames = array_keys($shardConfig);
$this->shards = array_map(function (array $config, string $name) {
if (!isset(self::SHARD_PRESETS[$name])) {
throw new \Exception("Shard preset $name not found");
}
$shardMapperClass = $config['mapper'] ?? RoundRobinShardMapper::class;
$shardMapper = Server::get($shardMapperClass);
if (!$shardMapper instanceof IShardMapper) {
throw new \Exception("Invalid shard mapper: $shardMapperClass");
}
return new ShardDefinition(
$config['table'],
$config['primary_key'],
$config['companion_keys'],
$config['shard_key'],
self::SHARD_PRESETS[$name]['table'],
self::SHARD_PRESETS[$name]['primary_key'],
self::SHARD_PRESETS[$name]['companion_keys'],
self::SHARD_PRESETS[$name]['shard_key'],
$shardMapper,
$config['companion_tables'],
self::SHARD_PRESETS[$name]['companion_tables'],
$config['shards']
);
}, $this->params['sharding']);
}, $shardConfig, $shardNames);
$this->shards = array_combine($shardNames, $this->shards);
$this->partitions = array_map(function (ShardDefinition $shard) {
return array_merge([$shard->table], $shard->companionTables);
}, $this->shards);