upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-21 09:35:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 31

Merge pull request #60581 from nextcloud/backport/60547/stable26
Some checks are pending
Cypress / init (push) Waiting to run
Details
Cypress / runner 1 (push) Blocked by required conditions
Details
Cypress / runner 2 (push) Blocked by required conditions
Details
Cypress / runner component (push) Blocked by required conditions
Details
Cypress / cypress-summary (push) Blocked by required conditions
Details
Lint eslint / eslint (push) Waiting to run
Details
Lint php / php-lint (push) Waiting to run
Details
Lint php / php-lint-summary (push) Blocked by required conditions
Details
Node / versions (push) Waiting to run
Details
Node / test (push) Blocked by required conditions
Details
Node / jsunit (push) Blocked by required conditions
Details
Node / handlebars (push) Blocked by required conditions
Details
Node / node (push) Waiting to run
Details
S3 primary storage integration tests / php8.0-objectstore-minio (push) Waiting to run
Details
S3 primary storage integration tests / php8.0-objectstore_multibucket-minio (push) Waiting to run
Details
S3 primary storage integration tests / s3-primary-integration-summary (push) Blocked by required conditions
Details
S3 primary storage / php8.0-objectstore-minio (push) Waiting to run
Details
S3 primary storage / php8.0-objectstore_multibucket-minio (push) Waiting to run
Details
S3 primary storage / s3-primary-summary (push) Blocked by required conditions
Details
Psalm static code analysis / static-code-analysis (push) Waiting to run
Details
Psalm static code analysis / static-code-analysis-security (push) Waiting to run
Details
Psalm static code analysis / static-code-analysis-ocp (push) Waiting to run
Details

Browse source 
[stable26] fix: don't tell the remote their token is lower
This commit is contained in:
Stephan Orbaugh 2026-05-20 20:27:42 +02:00 committed by GitHub
commit fb712cf650
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/federation/lib/Controller/OCSAuthAPIController.php
View file

@ -126,7 +126,7 @@ class OCSAuthAPIController extends OCSController {
'remote server (' . $url . ') presented lower token. We will initiate the exchange of the shared secret.',
['app' => 'federation']
);
throw new OCSForbiddenException();
return new DataResponse();
}
$this->jobList->add(

5
apps/federation/tests/Controller/OCSAuthAPIControllerTest.php
View file

@ -125,9 +125,9 @@ class OCSAuthAPIControllerTest extends TestCase {
try {
$this->ocsAuthApi->requestSharedSecret($url, $token);
$this->assertTrue($ok);
$this->assertTrue($isTrustedServer);
} catch (OCSForbiddenException $e) {
$this->assertFalse($ok);
$this->assertFalse($isTrustedServer);
}
}
@ -183,7 +183,6 @@ class OCSAuthAPIControllerTest extends TestCase {
try {
$result = $ocsAuthApi->getSharedSecret($url, $token);
$this->assertTrue($ok);
$data = $result->getData();
$this->assertSame('secret', $data['sharedSecret']);
} catch (OCSForbiddenException $e) {