From f89613b5072e2cb3142f7b78631814f31b72a5cb Mon Sep 17 00:00:00 2001 From: Abhinav Ohri Date: Mon, 15 Dec 2025 14:22:20 +0530 Subject: [PATCH] refactor(testing): Rename mock trait classes for clarity Signed-off-by: Abhinav Ohri --- apps/files_external/tests/FrontendDefinitionTraitTest.php | 8 ++++---- .../tests/LegacyDependencyCheckPolyfillTest.php | 4 ++-- apps/settings/tests/SetupChecks/SecurityHeadersTest.php | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/files_external/tests/FrontendDefinitionTraitTest.php b/apps/files_external/tests/FrontendDefinitionTraitTest.php index 5c4c227402d..afab9aa46e8 100644 --- a/apps/files_external/tests/FrontendDefinitionTraitTest.php +++ b/apps/files_external/tests/FrontendDefinitionTraitTest.php @@ -11,7 +11,7 @@ use OCA\Files_External\Lib\DefinitionParameter; use OCA\Files_External\Lib\FrontendDefinitionTrait; use OCA\Files_External\Lib\StorageConfig; -class MockFrontendDefinitionTrait { +class MockFrontendDefinitionTraitClass { use FrontendDefinitionTrait; } @@ -22,7 +22,7 @@ class FrontendDefinitionTraitTest extends \Test\TestCase { ->getMock(); $param->method('getName')->willReturn('foo'); - $trait = new MockFrontendDefinitionTrait(); + $trait = new MockFrontendDefinitionTraitClass(); $trait->setText('test'); $trait->addParameters([$param]); $trait->addCustomJs('foo/bar.js'); @@ -71,7 +71,7 @@ class FrontendDefinitionTraitTest extends \Test\TestCase { $storageConfig->expects($this->any()) ->method('setBackendOption'); - $trait = new MockFrontendDefinitionTrait(); + $trait = new MockFrontendDefinitionTraitClass(); $trait->setText('test'); $trait->addParameters($backendParams); @@ -102,7 +102,7 @@ class FrontendDefinitionTraitTest extends \Test\TestCase { ->method('setBackendOption') ->with('param', 'foobar'); - $trait = new MockFrontendDefinitionTrait(); + $trait = new MockFrontendDefinitionTraitClass(); $trait->setText('test'); $trait->addParameter($param); diff --git a/apps/files_external/tests/LegacyDependencyCheckPolyfillTest.php b/apps/files_external/tests/LegacyDependencyCheckPolyfillTest.php index 98ea03bb88b..3edefe5188b 100644 --- a/apps/files_external/tests/LegacyDependencyCheckPolyfillTest.php +++ b/apps/files_external/tests/LegacyDependencyCheckPolyfillTest.php @@ -11,7 +11,7 @@ namespace OCA\Files_External\Tests; use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill; use OCA\Files_External\Lib\MissingDependency; -class MockLegacyDependencyCheckPolyfill { +class MockLegacyDependencyCheckPolyfillClass { use LegacyDependencyCheckPolyfill; public function getStorageClass(): string { @@ -32,7 +32,7 @@ class LegacyDependencyCheckPolyfillTest extends \Test\TestCase { } public function testCheckDependencies(): void { - $trait = new MockLegacyDependencyCheckPolyfill(); + $trait = new MockLegacyDependencyCheckPolyfillClass(); $dependencies = $trait->checkDependencies(); $this->assertCount(2, $dependencies); diff --git a/apps/settings/tests/SetupChecks/SecurityHeadersTest.php b/apps/settings/tests/SetupChecks/SecurityHeadersTest.php index d596a441a7d..e5d32ef7ecf 100644 --- a/apps/settings/tests/SetupChecks/SecurityHeadersTest.php +++ b/apps/settings/tests/SetupChecks/SecurityHeadersTest.php @@ -182,7 +182,7 @@ class SecurityHeadersTest extends TestCase { $this->setupcheck ->expects($this->atLeastOnce()) ->method('runRequest') - ->willReturn($this->generate([$response])); + ->willReturn($this->generate([$response])); } /**