upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-05 23:06:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 78

fix: filtering tags based on existing tags and doing a transaction around the select and insert

Browse source 
Signed-off-by: yemkareems <yemkareems@gmail.com>
This commit is contained in:
yemkareems 2024-05-30 15:38:06 +05:30 committed by Louis
parent 48ab7fce3b
commit f8700e8add
1 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
lib/private/SystemTag/SystemTagObjectMapper.php
View file

@ -133,6 +133,7 @@ class SystemTagObjectMapper implements ISystemTagObjectMapper {
}
$this->assertTagsExist($tagIds);
$this->connection->beginTransaction();
$query = $this->connection->getQueryBuilder();
$query->select('systemtagid')
@ -142,6 +143,12 @@ class SystemTagObjectMapper implements ISystemTagObjectMapper {
->andWhere($query->expr()->eq('objectid', $query->createNamedParameter($objId)));
$result = $query->executeQuery();
$rows = $result->fetchAll();
$existingTags = [];
foreach ($rows as $k => $row) {
$existingTags[] = $row['systemtagid'];
}
//filter only tags that do not exist in db
$tagIds = array_diff($tagIds, $existingTags);
$query = $this->connection->getQueryBuilder();
$query->insert(self::RELATION_TABLE)
@ -153,20 +160,16 @@ class SystemTagObjectMapper implements ISystemTagObjectMapper {
$tagsAssigned = [];
foreach ($tagIds as $tagId) {
if(!in_array($tagId, array_column($rows, 'systemtagid'))) {
// tag not in db so create new one
try {
$query->setParameter('tagid', $tagId);
$query->execute();
$tagsAssigned[] = $tagId;
} catch (UniqueConstraintViolationException $e) {
// ignore existing relations
}
} else {
//tag exists already don't insert
try {
$query->setParameter('tagid', $tagId);
$query->execute();
$tagsAssigned[] = $tagId;
} catch (UniqueConstraintViolationException $e) {
// ignore existing relations
}
}
$this->connection->commit();
if (empty($tagsAssigned)) {
return;
}