upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-19 02:38:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Merge pull request #58350 from nextcloud/regressionEmptyPort

Browse source 
fix(sftp): Handle empty port parameter to allow host-defined ports
This commit is contained in:
Git'Fellow 2026-02-16 10:13:38 +01:00 committed by GitHub
commit f06133bf13
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
apps/files_external/lib/Lib/Storage/SFTP.php
View file

@ -68,9 +68,12 @@ class SFTP extends Common {
Stream::register();
$parsedHost = $this->splitHost($parameters['host']);
$this->host = $parsedHost[0];
$this->port = $parameters['port'] ?? $parsedHost[1];
// Handle empty port parameter to allow host-defined ports
// and ensure strictly numeric ports
$parsedPort = $parameters['port'] ?? null;
$this->port = (int)(is_numeric($parsedPort) ? $parsedPort : $parsedHost[1]);
if (!isset($parameters['user'])) {
throw new \UnexpectedValueException('no authentication parameters specified');