From ec3c07dfde8a681b4a9994826146dfc19b7c32e6 Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Thu, 26 Feb 2026 14:14:03 +0100 Subject: [PATCH] fix(files_external): boolean comparison of array To check if there are no missing required dependencies we need to check if the required dependencies are **empty** because `!array` is still true. Signed-off-by: Ferdinand Thiessen --- apps/files_external/lib/Lib/DependencyTrait.php | 2 +- apps/files_external/lib/Service/BackendService.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/files_external/lib/Lib/DependencyTrait.php b/apps/files_external/lib/Lib/DependencyTrait.php index 79a9555de2c..ca48864ebab 100644 --- a/apps/files_external/lib/Lib/DependencyTrait.php +++ b/apps/files_external/lib/Lib/DependencyTrait.php @@ -26,7 +26,7 @@ trait DependencyTrait { * * @return MissingDependency[] Unsatisfied required dependencies */ - public function checkRequiredDependencies() { + public function checkRequiredDependencies(): array { return array_filter( $this->checkDependencies(), fn (MissingDependency $dependency) => !$dependency->isOptional() diff --git a/apps/files_external/lib/Service/BackendService.php b/apps/files_external/lib/Service/BackendService.php index 0b3eb7c1646..a577711668a 100644 --- a/apps/files_external/lib/Service/BackendService.php +++ b/apps/files_external/lib/Service/BackendService.php @@ -178,7 +178,7 @@ class BackendService { * @return Backend[] */ public function getAvailableBackends() { - return array_filter($this->getBackends(), fn (Backend $backend) => !$backend->checkRequiredDependencies()); + return array_filter($this->getBackends(), fn (Backend $backend) => empty($backend->checkRequiredDependencies())); } /**