upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54

fix: renameParams named as renamedNodes and code changed accordingly as suggested in review comments

Browse source 
Signed-off-by: yemkareems <yemkareems@gmail.com>
This commit is contained in:
yemkareems 2024-06-14 10:14:44 +05:30
parent 953358fdc8
commit eae23867f2
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
apps/admin_audit/lib/Actions/Files.php
View file

@ -27,7 +27,7 @@ use Psr\Log\LoggerInterface;
*/
class Files extends Action {
private array|null $renameParams = null;
private array $renamedNodes = [];
/**
* Logs file read actions
*
@ -60,17 +60,13 @@ class Files extends Action {
public function beforeRename(BeforeNodeRenamedEvent $event): void {
try {
$source = $event->getSource();
$params = [
'oldid' => $source->getId(),
'oldpath' => mb_substr($source->getInternalPath(), 5),
];
$this->renamedNodes[$source->getId()] = $source;
} catch (InvalidPathException|NotFoundException $e) {
\OCP\Server::get(LoggerInterface::class)->error(
"Exception thrown in file rename: ".$e->getMessage(), ['app' => 'admin_audit', 'exception' => $e]
);
return;
}
$this->renameParams = $params;
}
/**
@ -81,10 +77,10 @@ class Files extends Action {
public function afterRename(NodeRenamedEvent $event): void {
try {
$target = $event->getTarget();
$renameParams = $this->renameParams;
$originalSource = $this->renamedNodes[$target->getId()];
$params = [
'newid' => $target->getId(),
'oldpath' => $renameParams['oldpath'],
'oldpath' => mb_substr($originalSource->getInternalPath(), 5),
'newpath' => mb_substr($target->getInternalPath(), 5),
];
} catch (InvalidPathException|NotFoundException $e) {