upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-29 01:50:33 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 51

Merge pull request #42790 from nextcloud/fix/fix-settings-appdirs-test

Browse source 
Fix AppDirsWithDifferentOwnerTest
This commit is contained in:
Arthur Schiwon 2024-01-15 17:43:18 +01:00 committed by GitHub
commit e5ef58b7b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
apps/settings/tests/Controller/CheckSetupControllerTest.php
View file

@ -86,13 +86,6 @@ class CheckSetupControllerTest extends TestCase {
/** @var ISetupCheckManager|MockObject */
private $setupCheckManager;
/**
* Holds a list of directories created during tests.
*
* @var array
*/
private $dirsToRemove = [];
protected function setUp(): void {
parent::setUp();
@ -145,19 +138,6 @@ class CheckSetupControllerTest extends TestCase {
])->getMock();
}
/**
* Removes directories created during tests.
*
* @after
* @return void
*/
public function removeTestDirectories() {
foreach ($this->dirsToRemove as $dirToRemove) {
rmdir($dirToRemove);
}
$this->dirsToRemove = [];
}
public function testCheck() {
$this->config->expects($this->any())
->method('getAppValue')

20
apps/settings/tests/SetupChecks/AppDirsWithDifferentOwnerTest.php
View file

@ -33,6 +33,13 @@ class AppDirsWithDifferentOwnerTest extends TestCase {
private IL10N $l10n;
private AppDirsWithDifferentOwner $check;
/**
* Holds a list of directories created during tests.
*
* @var array
*/
private $dirsToRemove = [];
protected function setUp(): void {
parent::setUp();
@ -97,4 +104,17 @@ class AppDirsWithDifferentOwnerTest extends TestCase {
$this->invokePrivate($this->check, 'getAppDirsWithDifferentOwner', [posix_getuid()])
);
}
/**
* Removes directories created during tests.
*
* @after
* @return void
*/
public function removeTestDirectories() {
foreach ($this->dirsToRemove as $dirToRemove) {
rmdir($dirToRemove);
}
$this->dirsToRemove = [];
}
}