upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

fix(database): Cast users count to integer

Browse source 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This commit is contained in:
Git'Fellow 2025-03-14 16:08:02 +01:00 committed by backportbot[bot]
parent 760503d73e
commit e5d62aeec7
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/private/User/Database.php
View file

@ -470,9 +470,12 @@ class Database extends ABackend implements
$query = $this->dbConn->getQueryBuilder();
$query->select($query->func()->count('uid'))
->from($this->table);
$result = $query->executeQuery();
$result = $query->executeQuery()->fetchOne();
if ($result === false) {
return false;
}
return $result->fetchOne();
return (int)$result;
}
/**

13
tests/lib/User/DatabaseTest.php
View file

@ -25,6 +25,9 @@ class DatabaseTest extends Backend {
/** @var IEventDispatcher|MockObject */
private $eventDispatcher;
/** @var \OC\User\Database */
protected $backend;
public function getUser() {
$user = parent::getUser();
$this->users[] = $user;
@ -139,4 +142,14 @@ class DatabaseTest extends Backend {
$result = $this->backend->getDisplayNames('@nextcloud.COM');
$this->assertCount(2, $result);
}
public function testUserCount(): void {
$base = $this->backend->countUsers() ?: 0;
$users = $this->backend->getUsers();
self::assertEquals($base, count($users));
$user = $this->getUser();
$this->backend->createUser($user, $user);
self::assertEquals($base + 1, $this->backend->countUsers());
}
}