From e41afea7396412b24077db615016ae55b6b4c404 Mon Sep 17 00:00:00 2001
From: Samuel <faust64@gmail.com>
Date: Fri, 5 Feb 2021 11:55:56 +0100
Subject: [PATCH] feat(federatedfilesharing): log errors, as suggested by
 @maxbes

Signed-off-by: Samuel <faust64@gmail.com>
---
 .../lib/Notifications.php                     | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/apps/federatedfilesharing/lib/Notifications.php b/apps/federatedfilesharing/lib/Notifications.php
index 410c155b072..011842e7981 100644
--- a/apps/federatedfilesharing/lib/Notifications.php
+++ b/apps/federatedfilesharing/lib/Notifications.php
@@ -123,7 +123,15 @@ class Notifications {
 				$event = new FederatedShareAddedEvent($remote);
 				$this->eventDispatcher->dispatchTyped($event);
 				return true;
+			} else {
+				\OC::$server->getLogger()->info(
+					"failed sharing $name with $shareWith",
+					[ 'app' => 'federatedfilesharing' ]);
 			}
+		} else {
+			\OC::$server->getLogger()->info(
+				"could not share $name, invalid contact $shareWith",
+				[ 'app' => 'federatedfilesharing' ]);
 		}
 
 		return false;
@@ -174,6 +182,18 @@ class Notifications {
 				$status['ocs']['data']['token'],
 				$status['ocs']['data']['remoteId']
 			];
+		} else if (! $validToken) {
+		    \OC::$server->getLogger()->info(
+			    "invalid or missing token requesting re-share for $filename to $remote",
+			    [ 'app' => 'federatedfilesharing' ]);
+		} else if (! $validRemoteId) {
+		    \OC::$server->getLogger()->info(
+			    "missing remote id requesting re-share for $filename to $remote",
+			    [ 'app' => 'federatedfilesharing' ]);
+		} else {
+		    \OC::$server->getLogger()->info(
+			    "failed requesting re-share for $filename to $remote",
+			    [ 'app' => 'federatedfilesharing' ]);
 		}
 
 		return false;