upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-17 20:50:05 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 16

chore: Fix CreateSessionTokenCommandTest and add test for ephemeral session

Browse source 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This commit is contained in:
Côme Chilliet 2026-05-21 16:24:48 +02:00
parent e52bd2f50b
commit df2b3bb776
No known key found for this signature in database
GPG key ID: A3E2F658B28C760A
1 changed files with 67 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

77
tests/lib/Authentication/Login/CreateSessionTokenCommandTest.php
View file

@ -1,40 +1,49 @@
<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
declare(strict_types=1);
namespace Test\Authentication\Login;
use OC\Authentication\Login\CreateSessionTokenCommand;
use OC\Authentication\Token\IToken;
use OC\User\Session;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\IConfig;
use OCP\IURLGenerator;
use PHPUnit\Framework\MockObject\MockObject;
class CreateSessionTokenCommandTest extends ALoginCommandTest {
/** @var IConfig|MockObject */
private $config;
/** @var Session|MockObject */
private $userSession;
private IConfig&MockObject $config;
private Session&MockObject $userSession;
private IURLGenerator&MockObject $urlGenerator;
private ITimeFactory&MockObject $timeFactory;
protected function setUp(): void {
parent::setUp();
$this->config = $this->createMock(IConfig::class);
$this->userSession = $this->createMock(Session::class);
$this->urlGenerator = $this->createMock(IURLGenerator::class);
$this->timeFactory = $this->createMock(ITimeFactory::class);
$this->cmd = new CreateSessionTokenCommand(
$this->config,
$this->userSession
$this->userSession,
$this->urlGenerator,
$this->timeFactory,
);
}
public function testProcess() {
// Just return the route name as path to not return an empty string
$this->urlGenerator->expects(self::once())
->method('linkToRoute')
->willReturnArgument(0);
$data = $this->getLoggedInLoginData();
$this->config->expects($this->once())
->method('getSystemValueInt')
@ -53,7 +62,8 @@ class CreateSessionTokenCommandTest extends ALoginCommandTest {
$this->username,
$this->username,
$this->password,
IToken::REMEMBER
IToken::REMEMBER,
null
);
$this->userSession->expects($this->once())
->method('updateTokens')
@ -68,6 +78,10 @@ class CreateSessionTokenCommandTest extends ALoginCommandTest {
}
public function testProcessDoNotRemember() {
// Just return the route name as path to not return an empty string
$this->urlGenerator->expects(self::once())
->method('linkToRoute')
->willReturnArgument(0);
$data = $this->getLoggedInLoginData();
$this->config->expects($this->once())
->method('getSystemValueInt')
@ -86,7 +100,8 @@ class CreateSessionTokenCommandTest extends ALoginCommandTest {
$this->username,
$this->username,
$this->password,
IToken::DO_NOT_REMEMBER
IToken::DO_NOT_REMEMBER,
null
);
$this->userSession->expects($this->once())
->method('updateTokens')
@ -100,4 +115,46 @@ class CreateSessionTokenCommandTest extends ALoginCommandTest {
$this->assertTrue($result->isSuccess());
$this->assertFalse($data->isRememberLogin());
}
public function testLoginFlowEphemeral(): void {
$this->redirectUrl = 'EPHEMERAL_ROUTE';
$this->urlGenerator->expects(self::once())
->method('linkToRoute')
->willReturn($this->redirectUrl);
$this->timeFactory->expects(self::once())
->method('getTime')
->willReturn(1000);
$data = $this->getLoggedInLoginDataWithRedirectUrl();
$this->config->expects($this->once())
->method('getSystemValueInt')
->with(
'remember_login_cookie_lifetime',
60 * 60 * 24 * 15
)
->willReturn(100);
$this->user->expects($this->any())
->method('getUID')
->willReturn($this->username);
$this->userSession->expects($this->once())
->method('createSessionToken')
->with(
$this->request,
$this->username,
$this->username,
$this->password,
IToken::REMEMBER,
1000 + 5 * 60
);
$this->userSession->expects($this->once())
->method('updateTokens')
->with(
$this->username,
$this->password
);
$result = $this->cmd->process($data);
$this->assertTrue($result->isSuccess());
}
}