upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-21 14:23:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

Merge pull request #44362 from nextcloud/artonge/feat/check_permissions_of_all_nodes_for_versions

Browse source 
Check permissions of all accessible file for versions
This commit is contained in:
Louis 2024-03-22 20:35:11 +01:00 committed by GitHub
commit ddb84f9738
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
apps/files_versions/lib/Versions/LegacyVersionsBackend.php
View file

@ -275,15 +275,23 @@ class LegacyVersionsBackend implements IVersionBackend, IDeletableVersionBackend
throw new NotFoundException("No user logged in");
}
if ($sourceFile->getOwner()?->getUID() !== $currentUserId) {
$nodes = $this->rootFolder->getUserFolder($currentUserId)->getById($sourceFile->getId());
$sourceFile = array_pop($nodes);
if (!$sourceFile) {
throw new NotFoundException("Version file not accessible by current user");
if ($sourceFile->getOwner()?->getUID() === $currentUserId) {
return ($sourceFile->getPermissions() & $permissions) === $permissions;
}
$nodes = $this->rootFolder->getUserFolder($currentUserId)->getById($sourceFile->getId());
if (count($nodes) === 0) {
throw new NotFoundException("Version file not accessible by current user");
}
foreach ($nodes as $node) {
if (($node->getPermissions() & $permissions) === $permissions) {
return true;
}
}
return ($sourceFile->getPermissions() & $permissions) === $permissions;
return false;
}
public function setMetadataValue(Node $node, int $revision, string $key, string $value): void {