upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-11 01:30:50 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 79

Merge pull request #53904 from nextcloud/followup/53896/adjust-interface

Browse source 
fix(comments): Adjust interface with implementation
This commit is contained in:
Joas Schilling 2025-07-11 08:13:39 +02:00 committed by GitHub
commit db4450f4db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/public/Comments/ICommentsManager.php
View file

@ -108,6 +108,7 @@ interface ICommentsManager {
* @param int $limit optional, number of maximum comments to be returned. if
* set to 0, all comments are returned.
* @param bool $includeLastKnown
* @param string $topmostParentId Limit the comments to a list of replies and its original root comment
* @return list<IComment>
* @since 14.0.0
* @deprecated 24.0.0 - Use getCommentsWithVerbForObjectSinceComment instead
@ -119,6 +120,7 @@ interface ICommentsManager {
string $sortDirection = 'asc',
int $limit = 30,
bool $includeLastKnown = false,
string $topmostParentId = '',
): array;
/**
@ -130,6 +132,7 @@ interface ICommentsManager {
* @param int $limit optional, number of maximum comments to be returned. if
* set to 0, all comments are returned.
* @param bool $includeLastKnown
* @param string $topmostParentId Limit the comments to a list of replies and its original root comment
* @return list<IComment>
* @since 24.0.0
*/
@ -141,6 +144,7 @@ interface ICommentsManager {
string $sortDirection = 'asc',
int $limit = 30,
bool $includeLastKnown = false,
string $topmostParentId = '',
): array;
/**

2
tests/lib/Comments/FakeManager.php
View file

@ -38,6 +38,7 @@ class FakeManager implements ICommentsManager {
string $sortDirection = 'asc',
int $limit = 30,
bool $includeLastKnown = false,
string $topmostParentId = '',
): array {
return [];
}
@ -50,6 +51,7 @@ class FakeManager implements ICommentsManager {
string $sortDirection = 'asc',
int $limit = 30,
bool $includeLastKnown = false,
string $topmostParentId = '',
): array {
return [];
}