From d669e6ed2bc3bdc81bfaf12a4de34ee85b9d90a9 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Mon, 9 Feb 2026 19:04:15 +0100
Subject: [PATCH] refactor(files): port file list headers to new files registry

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 apps/files/src/components/FilesListHeader.vue |  4 +-
 .../composables/useFileListHeaders.spec.ts    | 60 ++++++++++++-------
 .../src/composables/useFileListHeaders.ts     | 19 ++++--
 3 files changed, 56 insertions(+), 27 deletions(-)

diff --git a/apps/files/src/components/FilesListHeader.vue b/apps/files/src/components/FilesListHeader.vue
index e672510c500..0bde10c9701 100644
--- a/apps/files/src/components/FilesListHeader.vue
+++ b/apps/files/src/components/FilesListHeader.vue
@@ -9,7 +9,7 @@
 </template>
 
 <script lang="ts">
-import type { Folder, Header, View } from '@nextcloud/files'
+import type { Folder, IFileListHeader, View } from '@nextcloud/files'
 import type { PropType } from 'vue'
 
 import PQueue from 'p-queue'
@@ -25,7 +25,7 @@ export default {
 	name: 'FilesListHeader',
 	props: {
 		header: {
-			type: Object as PropType<Header>,
+			type: Object as PropType<IFileListHeader>,
 			required: true,
 		},
 
diff --git a/apps/files/src/composables/useFileListHeaders.spec.ts b/apps/files/src/composables/useFileListHeaders.spec.ts
index c407156412b..4f0c5546931 100644
--- a/apps/files/src/composables/useFileListHeaders.spec.ts
+++ b/apps/files/src/composables/useFileListHeaders.spec.ts
@@ -3,39 +3,59 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { Header } from '@nextcloud/files'
+import type { IFileListHeader } from '@nextcloud/files'
+import type { registerFileListHeader } from '@nextcloud/files'
+import type { ComputedRef } from 'vue'
+
 import { beforeEach, describe, expect, it, vi } from 'vitest'
-import { useFileListHeaders } from './useFileListHeaders.ts'
+import { nextTick } from 'vue'
 
-const getFileListHeaders = vi.hoisted(() => vi.fn())
-
-vi.mock('@nextcloud/files', async (originalModule) => {
-	return {
-		...(await originalModule()),
-		getFileListHeaders,
-	}
-})
+interface Context {
+	useFileListHeaders: () => ComputedRef<IFileListHeader[]>
+	registerFileListHeader: typeof registerFileListHeader
+}
 
 describe('useFileListHeaders', () => {
-	beforeEach(() => vi.resetAllMocks())
+	beforeEach(async (context: Context) => {
+		delete globalThis._nc_files_scope
+		// reset modules to reset internal variables (the headers ref) of the composable and the library (the scoped globals)
+		vi.resetModules()
+		context.useFileListHeaders = (await import('./useFileListHeaders.ts')).useFileListHeaders
+		context.registerFileListHeader = (await import('@nextcloud/files')).registerFileListHeader
+	})
 
-	it('gets the headers', () => {
-		const header = new Header({ id: '1', order: 5, render: vi.fn(), updated: vi.fn() })
-		getFileListHeaders.mockImplementationOnce(() => [header])
+	it<Context>('gets the headers', ({ useFileListHeaders, registerFileListHeader }) => {
+		const header: IFileListHeader = { id: '1', order: 5, render: vi.fn(), updated: vi.fn() }
+		registerFileListHeader(header)
 
 		const headers = useFileListHeaders()
 		expect(headers.value).toEqual([header])
-		expect(getFileListHeaders).toHaveBeenCalledOnce()
 	})
 
-	it('headers are sorted', () => {
-		const header = new Header({ id: '1', order: 10, render: vi.fn(), updated: vi.fn() })
-		const header2 = new Header({ id: '2', order: 5, render: vi.fn(), updated: vi.fn() })
-		getFileListHeaders.mockImplementationOnce(() => [header, header2])
+	it<Context>('headers are sorted', ({ useFileListHeaders, registerFileListHeader }) => {
+		const header: IFileListHeader = { id: '1', order: 10, render: vi.fn(), updated: vi.fn() }
+		const header2: IFileListHeader = { id: '2', order: 5, render: vi.fn(), updated: vi.fn() }
+		registerFileListHeader(header)
+		registerFileListHeader(header2)
 
 		const headers = useFileListHeaders()
 		// lower order first
 		expect(headers.value.map(({ id }) => id)).toStrictEqual(['2', '1'])
-		expect(getFileListHeaders).toHaveBeenCalledOnce()
+	})
+
+	it<Context>('composable is reactive', async ({ useFileListHeaders, registerFileListHeader }) => {
+		const header: IFileListHeader = { id: 'a', order: 10, render: vi.fn(), updated: vi.fn() }
+		registerFileListHeader(header)
+		await nextTick()
+
+		const headers = useFileListHeaders()
+		expect(headers.value.map(({ id }) => id)).toStrictEqual(['a'])
+		// now add a new header
+		const header2: IFileListHeader = { id: 'b', order: 5, render: vi.fn(), updated: vi.fn() }
+		registerFileListHeader(header2)
+
+		// reactive update, lower order first
+		await nextTick()
+		expect(headers.value.map(({ id }) => id)).toStrictEqual(['b', 'a'])
 	})
 })
diff --git a/apps/files/src/composables/useFileListHeaders.ts b/apps/files/src/composables/useFileListHeaders.ts
index b57bcbb1432..ab9f032208b 100644
--- a/apps/files/src/composables/useFileListHeaders.ts
+++ b/apps/files/src/composables/useFileListHeaders.ts
@@ -2,18 +2,27 @@
  * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-import type { Header } from '@nextcloud/files'
+
+import type { IFileListHeader } from '@nextcloud/files'
 import type { ComputedRef } from 'vue'
 
-import { getFileListHeaders } from '@nextcloud/files'
+import { getFileListHeaders, getFilesRegistry } from '@nextcloud/files'
 import { computed, ref } from 'vue'
 
+const headers = ref<IFileListHeader[]>()
+const sorted = computed(() => [...(headers.value ?? [])].sort((a, b) => a.order - b.order) as IFileListHeader[])
+
 /**
  * Get the registered and sorted file list headers.
  */
-export function useFileListHeaders(): ComputedRef<Header[]> {
-	const headers = ref(getFileListHeaders())
-	const sorted = computed(() => [...headers.value].sort((a, b) => a.order - b.order) as Header[])
+export function useFileListHeaders(): ComputedRef<IFileListHeader[]> {
+	if (!headers.value) {
+		// if not initialized by other component yet, initialize and subscribe to registry changes
+		headers.value = getFileListHeaders()
+		getFilesRegistry().addEventListener('register:listHeader', () => {
+			headers.value = getFileListHeaders()
+		})
+	}
 
 	return sorted
 }