Merge pull request #56619 from nextcloud/chore/eslint

chore(eslint): fix linting on CI and resolve issues

REUSE.toml

@@ -400,7 +400,7 @@ SPDX-FileCopyrightText = "2019 Fabian Wiktor <https://www.pexels.com/photo/green
 SPDX-License-Identifier = "CC0-1.0"
 
 [[annotations]]
-path = ["openapi.json", ".envrc", "flake.nix", "flake.lock", "build/eslint-baseline.json"]
+path = ["openapi.json", ".envrc", "flake.nix", "flake.lock", "build/eslint-baseline.json", "build/eslint-baseline-legacy.json"]
 precedence = "aggregate"
 SPDX-FileCopyrightText = "2025 Nextcloud GmbH and Nextcloud contributors"
 SPDX-License-Identifier = "AGPL-3.0-or-later"

apps/files_versions/src/components/VirtualScrolling.vue

@@ -96,6 +96,8 @@ export default defineComponent({
 		},
 	},
 
+	emits: ['need-content'],
+
 	data() {
 		return {
 			scrollPosition: 0,
@@ -312,7 +314,7 @@ export default defineComponent({
 		this.container.addEventListener('scroll', this.updateScrollPosition, { passive: true })
 	},
 
-	beforeDestroy() {
+	beforeUnmount() {
 		if (this.useWindow) {
 			window.removeEventListener('resize', this.updateContainerSize)
 		}

apps/files_versions/src/utils/davClient.ts

@@ -12,10 +12,10 @@ const rootPath = 'dav'
 const remote = generateRemoteUrl(rootPath)
 const client = createClient(remote)
 
-// set CSRF token header
 /**
+ * set CSRF token header
  *
- * @param token
+ * @param token - CSRF token
  */
 function setHeaders(token) {
 	client.setHeaders({

build/demi.sh

@@ -30,7 +30,10 @@ run_sequentially() {
 	echo -e "\e[1;34m>> Running 'npm $COMMAND' for Vue 3 based frontend\e[0m"
 	echo
 	pushd "$FRONTEND"
+	set +e
 	npm $COMMAND
+	STATUS=$?
+	set -e
 	popd
 
 	echo -e "\e[1;34m>> Running 'npm $COMMAND' for Vue 2 based frontend\e[0m"
@@ -38,9 +41,14 @@ run_sequentially() {
 	pushd "$FRONTEND_LEGACY"
 	npm $COMMAND
 	popd
+
+	if [ $STATUS -ne 0 ]; then
+		echo -e "\e[1;31m>> Vue 3 based frontend build failed\e[0m"
+		exit $STATUS
+	fi
 }
 
-
+set -e
 if [ "--parallel" = "$1" ]; then
 	build_command ${@:2}
 	run_parallel

build/eslint-baseline-legacy.json

@@ -0,0 +1,63 @@
+{
+  "apps/files/src/components/TransferOwnershipDialogue.vue": {
+    "@nextcloud/vue/no-deprecated-props": {
+      "count": 1
+    }
+  },
+  "apps/files_sharing/src/components/SharingEntryQuickShareSelect.vue": {
+    "vue/no-mutating-props": {
+      "count": 2
+    }
+  },
+  "apps/files_sharing/src/components/SharingInput.vue": {
+    "@nextcloud/vue/no-deprecated-props": {
+      "count": 1
+    }
+  },
+  "apps/files_sharing/src/views/SharingDetailsTab.vue": {
+    "vue/no-mutating-props": {
+      "count": 23
+    }
+  },
+  "apps/files_sharing/src/views/SharingLinkList.vue": {
+    "vue/no-mutating-props": {
+      "count": 1
+    }
+  },
+  "apps/settings/src/components/Users/NewUserDialog.vue": {
+    "@nextcloud/vue/no-deprecated-props": {
+      "count": 1
+    },
+    "vue/no-mutating-props": {
+      "count": 17
+    }
+  },
+  "apps/workflowengine/src/components/Check.vue": {
+    "vue/no-mutating-props": {
+      "count": 3
+    }
+  },
+  "apps/workflowengine/src/components/Rule.vue": {
+    "vue/no-mutating-props": {
+      "count": 1
+    }
+  },
+  "core/src/OC/dialogs.js": {
+    "camelcase": {
+      "count": 33
+    },
+    "no-undef": {
+      "count": 1
+    }
+  },
+  "core/src/views/Login.vue": {
+    "vue/multi-word-component-names": {
+      "count": 1
+    }
+  },
+  "core/src/views/Setup.vue": {
+    "vue/multi-word-component-names": {
+      "count": 1
+    }
+  }
+}

build/eslint-baseline.json

@@ -1,63 +1,7 @@
 {
-  "apps/files/src/components/TransferOwnershipDialogue.vue": {
+  "apps/dav/src/components/AbsenceForm.vue": {
     "@nextcloud/vue/no-deprecated-props": {
       "count": 1
     }
-  },
-  "apps/files_sharing/src/components/SharingEntryQuickShareSelect.vue": {
-    "vue/no-mutating-props": {
-      "count": 2
-    }
-  },
-  "apps/files_sharing/src/components/SharingInput.vue": {
-    "@nextcloud/vue/no-deprecated-props": {
-      "count": 1
-    }
-  },
-  "apps/files_sharing/src/views/SharingDetailsTab.vue": {
-    "vue/no-mutating-props": {
-      "count": 23
-    }
-  },
-  "apps/files_sharing/src/views/SharingLinkList.vue": {
-    "vue/no-mutating-props": {
-      "count": 1
-    }
-  },
-  "apps/settings/src/components/Users/NewUserDialog.vue": {
-    "@nextcloud/vue/no-deprecated-props": {
-      "count": 1
-    },
-    "vue/no-mutating-props": {
-      "count": 16
-    }
-  },
-  "apps/workflowengine/src/components/Check.vue": {
-    "vue/no-mutating-props": {
-      "count": 3
-    }
-  },
-  "apps/workflowengine/src/components/Rule.vue": {
-    "vue/no-mutating-props": {
-      "count": 1
-    }
-  },
-  "core/src/OC/dialogs.js": {
-    "camelcase": {
-      "count": 33
-    },
-    "no-undef": {
-      "count": 1
-    }
-  },
-  "core/src/views/Login.vue": {
-    "vue/multi-word-component-names": {
-      "count": 1
-    }
-  },
-  "core/src/views/Setup.vue": {
-    "vue/multi-word-component-names": {
-      "count": 1
-    }
   }
 }

build/frontend-legacy/package.json

@@ -8,8 +8,8 @@
   "scripts": {
     "build": "webpack --node-env production --progress",
     "dev": "webpack --node-env development --progress",
-    "lint": "eslint --suppressions-location ../eslint-baseline.json --no-error-on-unmatched-pattern ./apps/*/ ./core/",
-    "lint:fix": "eslint --suppressions-location ../eslint-baseline.json --fix --no-error-on-unmatched-pattern ./apps/*/ ./core/",
+    "lint": "eslint --suppressions-location ../eslint-baseline-legacy.json --no-error-on-unmatched-pattern ./apps/*/ ./core/",
+    "lint:fix": "eslint --suppressions-location ../eslint-baseline-legacy.json --fix --no-error-on-unmatched-pattern ./apps/*/ ./core/",
     "test": "vitest run",
     "test:coverage": "vitest run --coverage --reporter=default",
     "test:update-snapshots": "vitest run --update",

dist/files_versions-files_versions-sidebar-tab-DbvfeGRa.chunk.css

@@ -1 +1 @@
-.version[data-v-e3870fc8]{display:flex;flex-direction:row}.version__info[data-v-e3870fc8]{display:flex;flex-direction:row;align-items:center;gap:.5rem;color:var(--color-main-text);font-weight:500;overflow:hidden}.version__info__label[data-v-e3870fc8]{font-weight:700;overflow:hidden;text-overflow:ellipsis;min-width:110px}.version__info__author_name[data-v-e3870fc8],.version__info__date[data-v-e3870fc8]{overflow:hidden;text-overflow:ellipsis}.version__info__subline[data-v-e3870fc8]{color:var(--color-text-maxcontrast)}.version__image[data-v-e3870fc8]{width:3rem;height:3rem;border:1px solid var(--color-border);border-radius:var(--border-radius-large);display:flex;justify-content:center;color:var(--color-main-text)}.version-label-modal__info[data-v-6a69577b]{color:var(--color-text-maxcontrast);margin-block:calc(3 * var(--default-grid-baseline))}.version-label-modal__input[data-v-6a69577b]{margin-block-start:calc(2 * var(--default-grid-baseline))}.vs-container[data-v-52b628a8]{overflow-y:scroll;height:100%}.vs-rows-container[data-v-52b628a8]{box-sizing:border-box;will-change:scroll-position,padding;contain:layout paint style}.versions-tab__container{height:100%}
+.version[data-v-e3870fc8]{display:flex;flex-direction:row}.version__info[data-v-e3870fc8]{display:flex;flex-direction:row;align-items:center;gap:.5rem;color:var(--color-main-text);font-weight:500;overflow:hidden}.version__info__label[data-v-e3870fc8]{font-weight:700;overflow:hidden;text-overflow:ellipsis;min-width:110px}.version__info__author_name[data-v-e3870fc8],.version__info__date[data-v-e3870fc8]{overflow:hidden;text-overflow:ellipsis}.version__info__subline[data-v-e3870fc8]{color:var(--color-text-maxcontrast)}.version__image[data-v-e3870fc8]{width:3rem;height:3rem;border:1px solid var(--color-border);border-radius:var(--border-radius-large);display:flex;justify-content:center;color:var(--color-main-text)}.version-label-modal__info[data-v-6a69577b]{color:var(--color-text-maxcontrast);margin-block:calc(3 * var(--default-grid-baseline))}.version-label-modal__input[data-v-6a69577b]{margin-block-start:calc(2 * var(--default-grid-baseline))}.vs-container[data-v-b0f92288]{overflow-y:scroll;height:100%}.vs-rows-container[data-v-b0f92288]{box-sizing:border-box;will-change:scroll-position,padding;contain:layout paint style}.versions-tab__container{height:100%}

dist/files_versions-sidebar-tab.css

@@ -1,4 +1,4 @@
 /* extracted by css-entry-points-plugin */
-@import './files_versions-files_versions-sidebar-tab-4BohXFH5.chunk.css';
+@import './files_versions-files_versions-sidebar-tab-DbvfeGRa.chunk.css';
 @import './NcSettingsSection-BfK7eHNT-BFoYkIs3.chunk.css';
 @import './check-BhZ0LWiU.chunk.css';