From 795a48d45c9cb1e568c27b43b837fdc7314ac1dc Mon Sep 17 00:00:00 2001 From: Arthur Schiwon Date: Wed, 6 May 2015 15:25:51 +0200 Subject: [PATCH 1/2] fix broken group presentation in selected groups list --- apps/user_ldap/js/wizard/wizardTabAbstractFilter.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/apps/user_ldap/js/wizard/wizardTabAbstractFilter.js b/apps/user_ldap/js/wizard/wizardTabAbstractFilter.js index 702c30a5a69..16920199dc7 100644 --- a/apps/user_ldap/js/wizard/wizardTabAbstractFilter.js +++ b/apps/user_ldap/js/wizard/wizardTabAbstractFilter.js @@ -158,9 +158,12 @@ OCA = OCA || {}; /** * sets the selected groups * - * @param {Array} groups + * @param {string} groups */ setGroups: function(groups) { + if(typeof groups === 'string') { + groups = groups.split("\n"); + } if(!this.isComplexGroupChooser) { this.setElementValue(this.getGroupsItem().$element, groups); this.getGroupsItem().$element.multiselect('refresh'); @@ -224,10 +227,10 @@ OCA = OCA || {}; $selectedGroups, $(this.tabID).find('.ldapManyGroupsSearch') )); } else { - if(_.isUndefined || only.toLowerCase() === 'available') { + if(only.toLowerCase() === 'available') { this.filterOnType[0].updateOptions(); } - if(_.isUndefined || only.toLowerCase() === 'selected') { + if(only.toLowerCase() === 'selected') { this.filterOnType[1].updateOptions(); } } From 71e6644ec8133e3da216b4641f78067fa02803d9 Mon Sep 17 00:00:00 2001 From: Arthur Schiwon Date: Wed, 6 May 2015 15:34:44 +0200 Subject: [PATCH 2/2] fix filter index on selected groups is updated too early --- apps/user_ldap/js/wizard/wizardTabAbstractFilter.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/user_ldap/js/wizard/wizardTabAbstractFilter.js b/apps/user_ldap/js/wizard/wizardTabAbstractFilter.js index 16920199dc7..b67392a4189 100644 --- a/apps/user_ldap/js/wizard/wizardTabAbstractFilter.js +++ b/apps/user_ldap/js/wizard/wizardTabAbstractFilter.js @@ -170,6 +170,7 @@ OCA = OCA || {}; } else { var $element = $(this.tabID).find('.ldapGroupListSelected'); this.equipMultiSelect($element, groups); + this.updateFilterOnType('selected'); } }, @@ -360,7 +361,7 @@ OCA = OCA || {}; this._saveGroups(selected.concat($available.val())); $available.find('option:selected').prependTo($selected); - this.updateFilterOnType(); + this.updateFilterOnType('available'); // selected groups are not updated yet }, /** @@ -373,7 +374,7 @@ OCA = OCA || {}; this._saveGroups(selected); $selected.find('option:selected').appendTo($available); - this.updateFilterOnType(); + this.updateFilterOnType('available'); // selected groups are not updated yet } });