upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-09 00:32:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

Merge pull request #48356 from nextcloud/bugfix/noid/document-icon-requirements

Browse source 
fix(icons): Document icon requirements for notifications and activities
This commit is contained in:
Joas Schilling 2024-09-25 17:16:11 +02:00 committed by GitHub
commit c98206bd7a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/public/Activity/IEvent.php
View file

@ -310,6 +310,10 @@ interface IEvent {
public function getLink(): string;
/**
* Set the absolute url for the icon (should be colored black or not have a color)
*
* It's automatically color inverted by clients when needed
*
* @param string $icon
* @return $this
* @throws InvalidValueException if the icon is invalid
@ -319,6 +323,10 @@ interface IEvent {
public function setIcon(string $icon): self;
/**
* Get the absolute url for the icon (should be colored black or not have a color)
*
* It's automatically color inverted by clients when needed
*
* @return string
* @since 11.0.0
*/

8
lib/public/Notification/INotification.php
View file

@ -249,6 +249,10 @@ interface INotification {
public function getLink(): string;
/**
* Set the absolute url for the icon (should be colored black or not have a color)
*
* It's automatically color inverted by clients when needed
*
* @param string $icon
* @return $this
* @throws InvalidValueException if the icon is invalid
@ -258,6 +262,10 @@ interface INotification {
public function setIcon(string $icon): INotification;
/**
* Get the absolute url for the icon (should be colored black or not have a color)
*
* It's automatically color inverted by clients when needed
*
* @return string
* @since 11.0.0
*/