upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

Merge pull request #54519 from nextcloud/fix/fix-duplicated-category-migration

Browse source 
fix: Fix unique constraint violation in oc_vcategory migration
This commit is contained in:
Côme Chilliet 2025-08-21 18:01:33 +02:00 committed by GitHub
commit c88a5b451c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 40 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
core/Migrations/Version32000Date20250731062008.php
View file

@ -41,7 +41,7 @@ class Version32000Date20250731062008 extends SimpleMigrationStep {
/**
* Clean up duplicate categories
*/
private function cleanupDuplicateCategories(IOutput $output) {
private function cleanupDuplicateCategories(IOutput $output): void {
$output->info('Starting cleanup of duplicate vcategory records...');
// Find all categories, ordered to identify duplicates
@ -74,6 +74,8 @@ class Version32000Date20250731062008 extends SimpleMigrationStep {
$output->info("Found duplicate: keeping ID $keepId, removing ID $categoryId");
$this->cleanupDuplicateAssignments($output, $categoryId, $keepId);
// Update object references
$updateQb = $this->connection->getQueryBuilder();
$updateQb->update('vcategory_to_object')
@ -103,4 +105,41 @@ class Version32000Date20250731062008 extends SimpleMigrationStep {
$output->info("Duplicate cleanup completed - processed $duplicateCount duplicates");
}
}
/**
* Clean up duplicate assignments
* That will delete rows with $categoryId when there is the same row with $keepId
*/
private function cleanupDuplicateAssignments(IOutput $output, int $categoryId, int $keepId): void {
$selectQb = $this->connection->getQueryBuilder();
$selectQb->select('o1.*')
->from('vcategory_to_object', 'o1')
->join(
'o1', 'vcategory_to_object', 'o2',
$selectQb->expr()->andX(
$selectQb->expr()->eq('o1.type', 'o2.type'),
$selectQb->expr()->eq('o1.objid', 'o2.objid'),
)
)
->where($selectQb->expr()->eq('o1.categoryid', $selectQb->createNamedParameter($categoryId)))
->andWhere($selectQb->expr()->eq('o2.categoryid', $selectQb->createNamedParameter($keepId)));
$deleteQb = $this->connection->getQueryBuilder();
$deleteQb->delete('vcategory_to_object')
->where($deleteQb->expr()->eq('objid', $deleteQb->createParameter('objid')))
->andWhere($deleteQb->expr()->eq('categoryid', $deleteQb->createParameter('categoryid')))
->andWhere($deleteQb->expr()->eq('type', $deleteQb->createParameter('type')));
$duplicatedAssignments = $selectQb->executeQuery();
$count = 0;
while ($row = $duplicatedAssignments->fetch()) {
$deleteQb
->setParameters($row)
->executeStatement();
$count++;
}
if ($count > 0) {
$output->info(" - Deleted $count duplicate category assignments for $categoryId and $keepId");
}
}
}