upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-23 07:08:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54

[user_ldap] Small perf improvements suggestion from review

Browse source 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This commit is contained in:
Côme Chilliet 2023-08-07 10:56:51 +02:00
parent 1026b2131c
commit c33c40f677
No known key found for this signature in database
GPG key ID: A3E2F658B28C760A
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/user_ldap/lib/Db/GroupMembershipMapper.php
View file

@ -47,7 +47,7 @@ class GroupMembershipMapper extends QBMapper {
->from($this->getTableName())
->executeQuery();
$groups = array_map(fn ($row) => $row['groupid'], $result->fetchAll());
$groups = array_column($result->fetchAll(), 'groupid');
$result->closeCursor();
return $groups;
}

2
apps/user_ldap/lib/Service/UpdateGroupsService.php
View file

@ -90,7 +90,7 @@ class UpdateGroupsService {
$this->logger->debug('service "updateGroups" – Dealing with {group}.', ['group' => $group]);
$groupMemberships = $this->groupMembershipMapper->findGroupMemberships($group);
$knownUsers = array_map(
fn (GroupMembership $groupMembership): string => $groupMembership->getUserid(),
static fn (GroupMembership $groupMembership): string => $groupMembership->getUserid(),
$groupMemberships
);
$groupMemberships = array_combine($knownUsers, $groupMemberships);