From c28a4cdb95407e97868bb0befada38fb7a85efe3 Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Mon, 13 Oct 2025 14:32:30 +0200 Subject: [PATCH] fix(settings): Introduce TaskProcessingSuccessRate setup check Signed-off-by: Marcel Klehr --- apps/settings/composer/composer/autoload_classmap.php | 1 + apps/settings/composer/composer/autoload_static.php | 1 + apps/settings/lib/SetupChecks/TaskProcessingSuccessRate.php | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/settings/composer/composer/autoload_classmap.php b/apps/settings/composer/composer/autoload_classmap.php index 8c90376d79c..41cfcd4339d 100644 --- a/apps/settings/composer/composer/autoload_classmap.php +++ b/apps/settings/composer/composer/autoload_classmap.php @@ -135,6 +135,7 @@ return array( 'OCA\\Settings\\SetupChecks\\SupportedDatabase' => $baseDir . '/../lib/SetupChecks/SupportedDatabase.php', 'OCA\\Settings\\SetupChecks\\SystemIs64bit' => $baseDir . '/../lib/SetupChecks/SystemIs64bit.php', 'OCA\\Settings\\SetupChecks\\TaskProcessingPickupSpeed' => $baseDir . '/../lib/SetupChecks/TaskProcessingPickupSpeed.php', + 'OCA\\Settings\\SetupChecks\\TaskProcessingSuccessRate' => $baseDir . '/../lib/SetupChecks/TaskProcessingSuccessRate.php', 'OCA\\Settings\\SetupChecks\\TempSpaceAvailable' => $baseDir . '/../lib/SetupChecks/TempSpaceAvailable.php', 'OCA\\Settings\\SetupChecks\\TransactionIsolation' => $baseDir . '/../lib/SetupChecks/TransactionIsolation.php', 'OCA\\Settings\\SetupChecks\\WellKnownUrls' => $baseDir . '/../lib/SetupChecks/WellKnownUrls.php', diff --git a/apps/settings/composer/composer/autoload_static.php b/apps/settings/composer/composer/autoload_static.php index cf6ebfacba8..edda60d4e82 100644 --- a/apps/settings/composer/composer/autoload_static.php +++ b/apps/settings/composer/composer/autoload_static.php @@ -150,6 +150,7 @@ class ComposerStaticInitSettings 'OCA\\Settings\\SetupChecks\\SupportedDatabase' => __DIR__ . '/..' . '/../lib/SetupChecks/SupportedDatabase.php', 'OCA\\Settings\\SetupChecks\\SystemIs64bit' => __DIR__ . '/..' . '/../lib/SetupChecks/SystemIs64bit.php', 'OCA\\Settings\\SetupChecks\\TaskProcessingPickupSpeed' => __DIR__ . '/..' . '/../lib/SetupChecks/TaskProcessingPickupSpeed.php', + 'OCA\\Settings\\SetupChecks\\TaskProcessingSuccessRate' => __DIR__ . '/..' . '/../lib/SetupChecks/TaskProcessingSuccessRate.php', 'OCA\\Settings\\SetupChecks\\TempSpaceAvailable' => __DIR__ . '/..' . '/../lib/SetupChecks/TempSpaceAvailable.php', 'OCA\\Settings\\SetupChecks\\TransactionIsolation' => __DIR__ . '/..' . '/../lib/SetupChecks/TransactionIsolation.php', 'OCA\\Settings\\SetupChecks\\WellKnownUrls' => __DIR__ . '/..' . '/../lib/SetupChecks/WellKnownUrls.php', diff --git a/apps/settings/lib/SetupChecks/TaskProcessingSuccessRate.php b/apps/settings/lib/SetupChecks/TaskProcessingSuccessRate.php index fc4ed2ac464..fc6b9c425b0 100644 --- a/apps/settings/lib/SetupChecks/TaskProcessingSuccessRate.php +++ b/apps/settings/lib/SetupChecks/TaskProcessingSuccessRate.php @@ -39,7 +39,7 @@ class TaskProcessingSuccessRate implements ISetupCheck { public function run(): SetupResult { $taskCount = 0; $lastNDays = 1; - while($taskCount === 0 && $lastNDays < self::MAX_DAYS) { + while ($taskCount === 0 && $lastNDays < self::MAX_DAYS) { $lastNDays++; $tasks = $this->taskProcessingManager->getTasks(userId: '', scheduleAfter: $this->timeFactory->now()->getTimestamp() - 60 * 60 * 24 * $lastNDays); // userId: '' means no filter, whereas null would mean guest $taskCount = count($tasks);