From c0d2f7ee214023f7aea713b459388342c23883f9 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 1 Jul 2024 12:41:55 +0200 Subject: [PATCH] fix(CI): Operand of type Doctrine\DBAL\Schema\Column is always truthy Signed-off-by: Joas Schilling --- .../lib/Migration/Version1011Date20201120125158.php | 2 +- .../lib/Migration/Version11300Date20201120141438.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/federatedfilesharing/lib/Migration/Version1011Date20201120125158.php b/apps/federatedfilesharing/lib/Migration/Version1011Date20201120125158.php index bd12722801a..8e9c6dbb2bf 100644 --- a/apps/federatedfilesharing/lib/Migration/Version1011Date20201120125158.php +++ b/apps/federatedfilesharing/lib/Migration/Version1011Date20201120125158.php @@ -32,7 +32,7 @@ class Version1011Date20201120125158 extends SimpleMigrationStep { if ($schema->hasTable('federated_reshares')) { $table = $schema->getTable('federated_reshares'); $remoteIdColumn = $table->getColumn('remote_id'); - if ($remoteIdColumn && Types::getType($remoteIdColumn->getType()) !== Types::STRING) { + if (Types::getType($remoteIdColumn->getType()) !== Types::STRING) { $remoteIdColumn->setNotnull(false); $remoteIdColumn->setType(Type::getType(Types::STRING)); $remoteIdColumn->setOptions(['length' => 255]); diff --git a/apps/files_sharing/lib/Migration/Version11300Date20201120141438.php b/apps/files_sharing/lib/Migration/Version11300Date20201120141438.php index 4a0448a7d4f..6c7f323a8f7 100644 --- a/apps/files_sharing/lib/Migration/Version11300Date20201120141438.php +++ b/apps/files_sharing/lib/Migration/Version11300Date20201120141438.php @@ -90,7 +90,7 @@ class Version11300Date20201120141438 extends SimpleMigrationStep { } else { $table = $schema->getTable('share_external'); $remoteIdColumn = $table->getColumn('remote_id'); - if ($remoteIdColumn && Types::getType($remoteIdColumn->getType()) !== Types::STRING) { + if (Types::getType($remoteIdColumn->getType()) !== Types::STRING) { $remoteIdColumn->setNotnull(false); $remoteIdColumn->setType(Type::getType(Types::STRING)); $remoteIdColumn->setOptions(['length' => 255]);