Merge pull request #41473 from nextcloud/fix/41306-Sharing_tab_There_is_no_indicator_that_advanced_settings_are_open

Adapt "advanced settings" button for accordion button

apps/files_sharing/src/views/SharingDetailsTab.vue

@@ -78,15 +78,20 @@
 			</div>
 			<div class="sharingTabDetailsView__advanced-control">
 				<NcButton type="tertiary"
+					id="advancedSectionAccordionAdvancedControl"
 					alignment="end-reverse"
+					aria-controls="advancedSectionAccordionAdvanced"
+					:aria-expanded="advancedControlExpandedValue"
 					@click="advancedSectionAccordionExpanded = !advancedSectionAccordionExpanded">
 					{{ t('files_sharing', 'Advanced settings') }}
 					<template #icon>
-						<MenuDownIcon />
+						<MenuDownIcon v-if="!advancedSectionAccordionExpanded" />
+						<MenuUpIcon v-else />
 					</template>
 				</NcButton>
 			</div>
-			<div v-if="advancedSectionAccordionExpanded" class="sharingTabDetailsView__advanced">
+			<div v-if="advancedSectionAccordionExpanded" id="advancedSectionAccordionAdvanced" class="sharingTabDetailsView__advanced"
+				aria-labelledby="advancedSectionAccordionAdvancedControl" role="region">
 				<section>
 					<NcInputField v-if="isPublicShare"
 						:value.sync="share.label"
@@ -226,6 +231,7 @@ import UserIcon from 'vue-material-design-icons/AccountCircleOutline.vue'
 import ViewIcon from 'vue-material-design-icons/Eye.vue'
 import UploadIcon from 'vue-material-design-icons/Upload.vue'
 import MenuDownIcon from 'vue-material-design-icons/MenuDown.vue'
+import MenuUpIcon from 'vue-material-design-icons/MenuUp.vue'
 import DotsHorizontalIcon from 'vue-material-design-icons/DotsHorizontal.vue'
 
 import GeneratePassword from '../utils/GeneratePassword.js'
@@ -260,6 +266,7 @@ export default {
 		UploadIcon,
 		ViewIcon,
 		MenuDownIcon,
+		MenuUpIcon,
 		DotsHorizontalIcon,
 	},
 	mixins: [ShareTypes, ShareRequests, SharesMixin],
@@ -644,6 +651,9 @@ export default {
 					: translatedPermissions[permission].toLocaleLowerCase(getLanguage()))
 				.join(', ')
 		},
+		advancedControlExpandedValue() {
+			return this.advancedSectionAccordionExpanded ? 'true' : 'false'
+		}
 	},
 	watch: {
 		setCustomPermissions(isChecked) {

dist/files-main.js.LICENSE.txt

@@ -194,6 +194,28 @@
  *
  */
 
+/**
+ * @copyright Copyright (c) 2023 John Molakvoæ <skjnldsv@protonmail.com>
+ *
+ * @author John Molakvoæ <skjnldsv@protonmail.com>
+ *
+ * @license AGPL-3.0-or-later
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
 /**
  * @copyright Copyright (c) 2023 John Molakvoæ <skjnldsv@protonmail.com>
  *