From ba8b55f4d6e670b8d437e27fde8ad9b712b33078 Mon Sep 17 00:00:00 2001
From: Vincent Petry <vincent@nextcloud.com>
Date: Wed, 27 Oct 2021 09:38:26 +0200
Subject: [PATCH] Fix action share icon markup

Expanded the empty span tag to resolve issue with wrong appending done
by either handlebars or jquery.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
---
 apps/files/js/templates.js                             | 2 +-
 apps/files/js/templates/file_action_trigger.handlebars | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/apps/files/js/templates.js b/apps/files/js/templates.js
index d19a22731de..ba612f9e314 100644
--- a/apps/files/js/templates.js
+++ b/apps/files/js/templates.js
@@ -103,7 +103,7 @@ templates['file_action_trigger'] = template({"1":function(container,depth0,helpe
 
   return "			<span class=\"icon "
     + container.escapeExpression(((helper = (helper = lookupProperty(helpers,"iconClass") || (depth0 != null ? lookupProperty(depth0,"iconClass") : depth0)) != null ? helper : container.hooks.helperMissing),(typeof helper === "function" ? helper.call(depth0 != null ? depth0 : (container.nullContext || {}),{"name":"iconClass","hash":{},"data":data,"loc":{"start":{"line":6,"column":21},"end":{"line":6,"column":34}}}) : helper)))
-    + "\" />\n";
+    + "\"></span>\n";
 },"6":function(container,depth0,helpers,partials,data) {
     var helper, lookupProperty = container.lookupProperty || function(parent, propertyName) {
         if (Object.prototype.hasOwnProperty.call(parent, propertyName)) {
diff --git a/apps/files/js/templates/file_action_trigger.handlebars b/apps/files/js/templates/file_action_trigger.handlebars
index d7112ee2b2f..e74b3717c92 100644
--- a/apps/files/js/templates/file_action_trigger.handlebars
+++ b/apps/files/js/templates/file_action_trigger.handlebars
@@ -3,7 +3,7 @@
 		<img class="svg" alt="{{altText}}" src="{{icon}}" />
 	{{else}}
 		{{#if iconClass}}
-			<span class="icon {{iconClass}}" />
+			<span class="icon {{iconClass}}"></span>
 		{{/if}}
 		{{#unless hasDisplayName}}
 			<span class="hidden-visually">{{altText}}</span>