From b8b0ae094432ca093022896e1b57db91400f245a Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 30 Nov 2015 13:32:58 +0100 Subject: [PATCH] Fix phpstorm complains in tests --- ...stemtagmanager.php => systemtagmanagertest.php} | 14 ++++++-------- ...ectmapper.php => systemtagobjectmappertest.php} | 2 +- 2 files changed, 7 insertions(+), 9 deletions(-) rename tests/lib/systemtag/{systemtagmanager.php => systemtagmanagertest.php} (96%) rename tests/lib/systemtag/{systemtagobjectmapper.php => systemtagobjectmappertest.php} (99%) diff --git a/tests/lib/systemtag/systemtagmanager.php b/tests/lib/systemtag/systemtagmanagertest.php similarity index 96% rename from tests/lib/systemtag/systemtagmanager.php rename to tests/lib/systemtag/systemtagmanagertest.php index 52bc33e7b6f..0a192f01f41 100644 --- a/tests/lib/systemtag/systemtagmanager.php +++ b/tests/lib/systemtag/systemtagmanagertest.php @@ -12,9 +12,10 @@ namespace Test\SystemTag; use OC\SystemTag\SystemTagManager; use OC\SystemTag\SystemTagObjectMapper; +use OCP\IDBConnection; use OCP\SystemTag\ISystemTag; -use \OCP\SystemTag\ISystemTagManager; -use \OCP\IDBConnection; +use OCP\SystemTag\ISystemTagManager; +use Test\TestCase; /** * Class TestSystemTagManager @@ -22,7 +23,7 @@ use \OCP\IDBConnection; * @group DB * @package Test\SystemTag */ -class TestSystemTagManager extends \Test\TestCase { +class SystemTagManagerTest extends TestCase { /** * @var ISystemTagManager @@ -188,7 +189,7 @@ class TestSystemTagManager extends \Test\TestCase { */ public function testGetAllTagsFiltered($testTags, $visibilityFilter, $nameSearch, $expectedResults) { foreach ($testTags as $testTag) { - $tag = $this->tagManager->createTag($testTag[0], $testTag[1], $testTag[2]); + $this->tagManager->createTag($testTag[0], $testTag[1], $testTag[2]); } $testTagsById = []; @@ -239,10 +240,7 @@ class TestSystemTagManager extends \Test\TestCase { $this->assertSameTag($tag1, $tag2); } - /** - * @dataProvider oneTagMultipleFlagsProvider - */ - public function testGetExistingTagById($name, $userVisible, $userAssignable) { + public function testGetExistingTagById() { $tag1 = $this->tagManager->createTag('one', true, false); $tag2 = $this->tagManager->createTag('two', false, true); diff --git a/tests/lib/systemtag/systemtagobjectmapper.php b/tests/lib/systemtag/systemtagobjectmappertest.php similarity index 99% rename from tests/lib/systemtag/systemtagobjectmapper.php rename to tests/lib/systemtag/systemtagobjectmappertest.php index c57e61ddabb..a4312fa722d 100644 --- a/tests/lib/systemtag/systemtagobjectmapper.php +++ b/tests/lib/systemtag/systemtagobjectmappertest.php @@ -26,7 +26,7 @@ use Test\TestCase; * @group DB * @package Test\SystemTag */ -class TestSystemTagObjectMapper extends TestCase { +class SystemTagObjectMapperTest extends TestCase { /** * @var ISystemTagManager